- 14 Jan, 2020 40 commits
-
-
sreejakshetty@chromium.org authored
Introduce HideFillingUI method to hide manual filling popup immediately after navigating away. At the moment it is closed due to a mojo message being send from the renderer when the document is shutdown, which has the following problems: - Is not triggered for back-forward cache, - Is not sent when the old renderer is killed during navigation or not responding BUG=1031076,1017693 Change-Id: Ie1b8d74a1008226b852404e864deb2aecb694b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995173 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731627}
-
Stepan Khapugin authored
Updates AppLaunchManager to accept variations, both regular and trigger, alongside features. This is used downstream to test interaction with Google search backend. Bug: none Change-Id: I52d363d9c84018ba3f8a0a41180d8b8c77a0066d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981609 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731626}
-
Abhijeet Singh authored
Removing the redundant fallback HTML card which was displayed when user clicks "What's on my screen?" suggestion chip and nothing is returned in the server response, as a helpful fallback text is already displayed alongside it. Bug: b:139210908 Test: Tested and verified locally on atlas test device. Change-Id: Ifb7ba341e6be655ddeb49600418fc45807b0a618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997717Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#731625}
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/browser_view/browser_view_controller_unittest.mm This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 546640 Change-Id: Ic6e410770cb48e19eb7018153a46e7d9a28b0eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991756Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#731624}
-
Michael Spang authored
This reverts commit 07dd9f6f. Reason for revert: This breaks the sandbox for a number of //content embedders (content_shell, cast_shell) by changing the name to a binary that will not exist. Original change's description: > Derive name of the Linux SUID sandbox executable from the main one. > > Bug: 1037808 > Change-Id: I0319edefde8c7faee772f350d6b183f9dc6e3073 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981751 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Francois Marier <francois@brave.com> > Cr-Commit-Position: refs/heads/master@{#730661} TBR=jorgelo@chromium.org,palmer@chromium.org,thestig@chromium.org,rsesek@chromium.org,thomasanderson@chromium.org,francois@brave.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037808 Change-Id: Ic994fa680ae2ece6f2dba08711c42455de785045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001417 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#731623}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1041419 Change-Id: I0c6d3b7bcb1abb7baac57d501cd12d3fac90fc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994072 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731622}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=shaseley@chromium.org Bug: 1041419 Change-Id: I73d9da6db7cf7347a1f22c13958c5f3723a6c8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998164 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731621}
-
Scott Violet authored
This way WebLayer can use it. ENABLE_SESSION_SERVICE case is handled in chrome side by supplying a null SessionService if ENABLE_SESSION_SERVICE is false. BUG=1033924 TEST=none Change-Id: I334274270d3e06e829d6f67e132467f0f8b9c73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999152 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#731620}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa610e24. With Chromium commits locally applied on WPT: bc899bf6 "DOM Overlay: update API to match current draft spec" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic0550a0f972579decc38e601bb4df1b481c12ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000521Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731619}
-
Saman Sami authored
This CL fixes two issues: - |evdev_bound_| is never set, so we keep rebinding |evdev_cursor_| on every cursor move. - |evdev_cursor_| was initially bound on the UI thread so calling Unbind() on the evdev thread for the first time triggers a DCHECK. Instead keep the pending remote unbound until it's time to bind it on the evdev thread. Bug: 620927,1039834 Change-Id: Iea19d5e32b0cbc9396f7b5e178e8e4ab6001f8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997646 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#731618}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/395b69e99301..d85dc3874aaa git log 395b69e99301..d85dc3874aaa --date=short --first-parent --format='%ad %ae %s' 2020-01-14 aerotwist@chromium.org Migrates object_ui/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Revert "Use typescript-eslint instead of tslint" 2020-01-14 tvanderlippe@chromium.org Migrate snippets/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Fail on changed files before commit 2020-01-14 tvanderlippe@chromium.org Migrate inspector_main/ to ESM internally 2020-01-14 petermarshall@chromium.org [fix-it] Add more unittests for TextUtils.js 2020-01-14 almuthanna@google.com Add Karma tests for Throttler.js 2020-01-14 tvanderlippe@chromium.org Run the linter before the formatter 2020-01-14 mathias@chromium.org Add unescapeCssString tests 2020-01-14 aerotwist@chromium.org Adds PRESUBMIT check for .only calls in Karma tests 2020-01-14 tvanderlippe@chromium.org Migrate network/ to ESM internally 2020-01-14 tvanderlippe@chromium.org Migrate inline_editor/ to ESM internally 2020-01-14 varuncvarada@gmail.com Fix units to be consistent with the SI 2020-01-14 aerotwist@chromium.org Migrates profiler/ to ESM internally 2020-01-14 petermarshall@chromium.org [fix-it] Add unittests for TextUtils.js 2020-01-14 tvanderlippe@chromium.org Use typescript-eslint instead of tslint 2020-01-14 tvanderlippe@chromium.org Update node_modules to include typescript-eslint 2020-01-14 tvanderlippe@chromium.org Add typescript-eslint to node_modules 2020-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d85dc3874aaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561,chromium:1033910,chromium:1041811,chromium:1983391 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I408edb9bf4df45989822283040e4c45d99fddae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731617}
-
Sadrul Habib Chowdhury authored
Avoid unnecessary conversion from enum to int when getting the name of the FrameSequenceTrackerType enum. BUG=none Change-Id: Ib7e8400f9af128575a99446a8e6a4a4caa3d11c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996153 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#731616}
-
Tom Anderson authored
Explanation copied from comment added by this CL: XFlush() flushes all requests and *also* reads events. It's unclear why it does this, but there's no alternative Xlib function that flushes the requests and *doesn't* read any events, so this workaround is necessary. In |event_task_runner_|'s message loop, poll() is called on the underlying XDisplay's fd to dispatch toplevel events. When the fd is readable, poll() exits and we (via Xlib) check for new events by read()ing from the fd. But if the event dispatcher is currently dispatching an event, then our call to XFlush() may read events into the event queue which will make the fd blocking since there's no more data to read, so poll() won't wake up until a new event comes, which may take a long time. Forcing the event loop to wake up with a dummy event fixes the race condition. BUG=1036742 R=msisov Change-Id: I4ce5dd1bbfd9c31a5e1adc992241937251fc3822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999436Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#731615}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 1041419 Change-Id: I2999fd57be53f68bd82b8d431f659d49a4efc436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998507 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731614}
-
Alan Screen authored
The PDF Compositor is being updated to perform composition for both PDF and XPS documents. Rename the service to more accurately reflect this expanded scope of the service. This CL is just to do the rename without any new XPS functionality yet; that will come in later CLs. Bug: 1008222 Change-Id: I2233e1590f5862da8f4bc50025f699e4dc1fbad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981135Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731613}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1041419 Change-Id: I265ecdbd0e4b3524cea50f49592f62540196c490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998355 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731612}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bffadc06..85f423a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icf5f7320e3fcca2a6f11cbb8912f1f7c9bf12412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000522Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731611}
-
Tom Anderson authored
The new X11 codepath also needs to convert gfx::BufferUsage to GBM flags, so move BuferUsageToGbmFlags to a common location to avoid duplicating it in 3 places. BUG=1031269 Change-Id: I23a6438fe6b01479a941dbb0393984494282f61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981051 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#731610}
-
Kurt Horimoto authored
All calls of |-dismissInfobarModal:animated:completion:| from an infobar modal UIViewController passed YES for |animated| and nil for |completion|, so these parameters were removed. Additionally, none of the implementations of any selectors in the delegate protocol used the |sender| argument, so that was removed as well. Several InfobarCoordinator subclasses utilized the dismissal using a completion block, however, so a base implementation was added to a subclassing category for InfobarCoordinator. Bug: 1030357 Change-Id: I7e4b06294a5dce28131f6c2a95430fbae62a97fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996167 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#731609}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 1041419 Change-Id: If21b7c662aec1842884b84302e09c2c0ff79b9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995788 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731608}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: I2a981762ce1d46300488dfdbcfcb1ba87420b557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999324Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#731607}
-
Dan Beam authored
R=dpapad@chromium.org Bug: none Change-Id: I6db701fbabe50ad5acb094c91c5bbba923fa6afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999282 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#731606}
-
Fritz Koenig authored
mmap fails on some platforms when trying to map a dmabuf with a non-zero offset. Instead of passing in the offset to map to, get the base address and add the offset afterwards. BUG: none TEST=./ozone_gl_unittests --gtest_filter=GLImageNativePixmap/GLImageBindTest/5.BindTexImage --gtest_also_run_disabled_tests Change-Id: Ie20e460e4099f937452a96a6e64b39ec56f1cc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979096 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#731605}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rmcelrath@chromium.org Bug: 1041419 Change-Id: I3ed2eccb81e26ef4a1b51fe0eb9e0ec584c8012b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998881 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731604}
-
Mitsuru Oshima authored
On ChromeOS, the panel's physical rotation can be different from logical one. That is, the panel's original orientation can be portrait, but the default orientation is landscape, which leads to wrong cursor rotation. This CL fixes the issue by using panel's orientation to rotate cursor. For other platforms, they're the same and this doesn't change the behavior. Bug: 1027832 Test: covered by unit tests. Also teseted manually. See bug for repro case. Change-Id: If70076a3a8a1b9b0893a31827bc767f2dd512489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995060Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#731603}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=wutao@chromium.org Bug: 1041419 Change-Id: I0ae4ba3bd6daae16e7b81963afa8d5d1726a0d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998738 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#731602}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 1041419 Change-Id: I319d7a1fbb3caa71709cce240011a758a598a38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998798 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731601}
-
Ali Juma authored
SafeBrowsingDataManager::CanCheckResourceType takes an argument of type content::ResourceType but only the Android-specific override in RemoteSafeBrowsingDatabaseManager uses the value of this argument. This CL forward-declares content::Resource type in database_manager.h. With this change, components/safe_browsing/core/db no longer depends on content/public/common. This is a step towards removing content/ dependencies from components/safe_browsing/core. Change-Id: I8b227a2c04594db8965a3ef1db4008a381a0965d Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995333 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#731600}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1041419 Change-Id: I37d869acfd366097bf4c1b2c2fc84d49f82c3bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998349 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#731599}
-
Kartik Hegde authored
Gather display and graphics related metrics in DeviceStatusCollector so that they can be exposed by the CDM API. BUG=chromium:1017893 TEST=Cherry pick https://crrev.com/c/1779132 and ensure that the values reported match that found on chrome://gpu or task manager (for GPU process memory). Change-Id: Idbc88fddf16b52f342cf92d0a0fe6060b4ee0e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933563 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731598}
-
edchin authored
Rapid blocking of javascript popups can cause a crash as simultaneous snapshots are triggered. Do not take snapshots when consecutive infobars are popup blocking infobars. Bug: 1018285 Change-Id: I46bca7fd8cc1f4d3f43ff28800b37c41a247f7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999084 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731597}
-
Becca Hughes authored
Add a basic Web UI at chrome://media-history for viewing Media History data. At the moment it just shows the row count per table but in the future we will add more. BUG=1024353 Change-Id: Ifb4190ba4266806ae6c07b07c77144c71907e87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988733Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#731596}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=manukh@chromium.org Bug: 1041419 Change-Id: I77d816e1495a2d404919fb2d0c83162df088af0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998306 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731595}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/683dd1d6a863..feb3b6cc6f2b git log 683dd1d6a863..feb3b6cc6f2b --date=short --first-parent --format='%ad %ae %s' 2020-01-14 syoussefi@chromium.org Vulkan: Remove row->col major shader transformation 2020-01-14 jie.a.chen@intel.com Add P010 stream test 2020-01-14 jmadill@chromium.org Invoke the standalone test harness runner. 2020-01-14 jmadill@chromium.org Fix test harness running disabled tests. 2020-01-14 jmadill@chromium.org Fix and improve UWP build. 2020-01-14 syoussefi@chromium.org Vulkan: Add test that exposes sampler refactor bug Created with: gclient setdep -r src/third_party/angle@feb3b6cc6f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033416 Tbr: jonahr@google.com Change-Id: I976aa5a885ba380971e3e9696d0934ac4989d81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731594}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1041419 Change-Id: I6f350b5690afb17554d191b71a2e1d51b87734d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998202 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731593}
-
John Budorick authored
Follow-up to crrev.com/c/1994168 Bug: 1039873 Change-Id: I2d86cc07fc2684886313fd454c733a40b9959df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998965Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#731592}
-
Stefan Zager authored
Change-Id: I7a1d9bc15bf04da61bba97f105303639ffd34f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999239 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731591}
-
rajendrant authored
This CL gets the estimated data savings due to SaveData and updates as LiteMode savings. The savings are retrieved from field trial as json. Relanding the revert in https://crrev.com/c/1990989 after renaming the failing test class LazyLoadDisabledBrowserTest, due to some naming clash. TBR=ryansturm@chromium.org Bug: 923551 Change-Id: Idf09151ea69218065b52b83e39eb84a0b7ae6cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996270 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#731590}
-
Alex Newcomer authored
Increase the padding to align the opaque bg with the button. Bug: 1041771 Change-Id: I04c5c89a4694a0d358b2bc5ccf143934ef30242a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001387 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#731589}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kerrnel@chromium.org Bug: 1041419 Change-Id: Ib705be1fc7ef6116a8c385209e07b1d9eb4e2107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998698 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731588}
-