- 18 Oct, 2018 40 commits
-
-
Marc Treib authored
In some circumstances, ProfileSyncService wants to fully reset SyncServiceCrypto's state. Currently, it destroys and recreated the whole object. That works, but it's problematic if we want to pass pointers to the SyncServiceCrypto object elsewhere. Instead, this CL adds a Reset() method to SyncServiceCrypto. For convenient implementation, and to make sure *everything* gets reset, all the mutable state gets wrapped into a new struct. Bug: 884159 Change-Id: Ia2590301a6236461e4df20d7f83fee5599e5483c Reviewed-on: https://chromium-review.googlesource.com/c/1286424 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#600705}
-
Sergio Villar Senin authored
Currently using the SigninManager API to get the primary (authenticated) account. Migrated it to IdentityManager so it could eventually use the identity service. Bug: 890772 Change-Id: I22cadc9256589885c002a0cabe1e3a174b0504ad Reviewed-on: https://chromium-review.googlesource.com/c/1282973Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#600704}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie72fbbaa5ffae8a15fb07356d0e190fd3d140e5c Reviewed-on: https://chromium-review.googlesource.com/c/1288111Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#600703}
-
https://crbug.com/889567Makoto Shimazu authored
I'm suspecting that CHECK(context_) will hit. Bug: 889567 Change-Id: I1e839185dc86f33ed9d8da6fb93c0ecf63a3d2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1288097 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600702}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=yosin@chromium.org Bug: 681136 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6bd5a1a0e8a2050c579cf459e243c5b63185b1f6 Reviewed-on: https://chromium-review.googlesource.com/c/1288515Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600701}
-
Daniel Vogelheim authored
.mjs is apparently being used as an extension for JavaScript ES6 modules. (Example: https://developers.google.com/web/fundamentals/primers/modules) Change-Id: I0cb88cf01cb468214e0ccbd8fab89ea5040c9c84 Reviewed-on: https://chromium-review.googlesource.com/c/1286132Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#600700}
-
Anders Hartvoll Ruud authored
Unfortunately, the existing test for this does too much behind a single green square. If even a single assertion were to fail, it would hide the result of all the other rests. At the same time, adding 40something tests is perhaps a bit excessive, so I've tried to reduce that number somewhat (mostly by only testing one of the initial value cases, which I think is reasonable). The aspect of the deleted test which verified that values were observable from all API entry points (has, get, getAll, size and iterator) is now a separate test as well. R=ikilpatrick@chromium.org Bug: 641877 Change-Id: Ie9316583ccef0ee4ddcaf688b7c1fac422649a39 Reviewed-on: https://chromium-review.googlesource.com/c/1286855Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#600699}
-
Anders Hartvoll Ruud authored
R=ikilpatrick@chromium.org Bug: 641877 Change-Id: Ic0403289f9deaf97369962d6901bafb58dc46931 Reviewed-on: https://chromium-review.googlesource.com/c/1283018Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/48ee86f818fb..dd254486280d git log 48ee86f818fb..dd254486280d --date=short --no-merges --format='%ad %ae %s' 2018-10-18 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-10-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@dd254486280d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ic35e86e6b58e135c21009ff512cd4d26667d3ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1288021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600697}
-
Tatsuhisa Yamaguchi authored
Some third-party archivers generate ZIP files which claim file names are coded in CP437 but actually put file names in other coding system. This change attempts to guess which encoding system they are, and decodes the file and directory names. Not all detected encodings are supported by the TextDecoder. There is also coding name difference between CED and TextDecoder. By this reason the set of encodings to be handled is whitelisted and translated by a mapping. We can simply add mappings to support other encodings. We also assume that all the files are coded in the uniform coding system, so as to stabilize the automated coding system detection. Bug: 846195 Test: browser_tests --gtest_filter='*ZipFiles*FilesAppBrowserTest*' --gtest_also_run_disabled_tests Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I284c189431d4fbac5554fb62507f1646517d279d Reviewed-on: https://chromium-review.googlesource.com/c/1251684 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#600696}
-
Colin Blundell authored
Forgot to do this in the CLs converting away from these utils. TBR=sdefresne@chromium.org Bug: 896180 Change-Id: Ifa1766efc5ec91c5313658d65fdfc0fc48bc9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1288529Reviewed-by:
-
Hirokazu Honda authored
This enables VideoFrameLayout (VFL) to be created always by factory functions. They return base::Optional. With invalid configured values, they should return base::nullopt. However, VFL is often created in VideoFrame's factory functions. Some of VideoFrame factory function's input rule is unclear. It may leads to pass invalid values to VFL and returns nullptr as VideoFrame. Becuase VideoFrame is widely used on Chrome video stack on any platform, it is dangerous to change a logic at one time. In this CL, VFL's factory functions always create VFL. Therefore, a logic in VideoFrame is unchanged. This also changes buffer_sizes is empty if it is not specified. BUG=896135 TEST=media_unittests on Linux TEST=VEA and VDA unittest on eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibf4191f2e8674ccff084ac8fb4d7e48f89594d6c Reviewed-on: https://chromium-review.googlesource.com/c/1250682 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600694}
-
Alexandr Ilin authored
This CL replaces the deprecated base::SharedMemoryHandle in gfx::GpuMemoryBufferHandle with the base::UnsafeSharedMemoryRegion. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I527a84876f8b87ddc652cf2f780a2893cb419c46 Bug: 854594, 863011 Reviewed-on: https://chromium-review.googlesource.com/c/1106340 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600693}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. Bug: 842194 Change-Id: I51591bad6d084f2200fca07deb6b0e90a6e45ba2 Reviewed-on: https://chromium-review.googlesource.com/c/1246841 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600692}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=peria@chromium.org Bug: 681136 Change-Id: I9dce2f01375277b9f471e65d30479ec91689e478 Reviewed-on: https://chromium-review.googlesource.com/c/1288496Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600691}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=jdoerrie@chromium.org Bug: 681136 Change-Id: I948c064bed03c801088e96007b641be2412bc6ee Reviewed-on: https://chromium-review.googlesource.com/c/1288509 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#600690}
-
Kinuko Yasuda authored
Especially on Android. Wasn't able to find a strong culprit, disabling it for now. TBR=ahest@chromium.org Bug: 896466 Change-Id: I3e063094b2fb3888c10a3366d24d6ea9145fddf0 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1288331Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#600689}
-
Matt Falkenhagen authored
I suspect the errors were that we were getting no preload request and two fallback requests, which seems plausible based on the existing comment. Loosen the test expectations accordingly. Bug: 896230 Change-Id: I539b56343d5057975352f74b482b61583174fb13 Reviewed-on: https://chromium-review.googlesource.com/c/1288330 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chrome://flagsMichael Lippautz authored
There should be no reason to override this from the UI anymore. Also fix flag toggle. The toggle was only working from 'default false' -> 'enabled' but could not be used to explicitly disable the feature. Tbr: jochen@chromium.org Bug: 757440 Change-Id: I732c508503692437f9780d745f43d9bc4f09a611 Reviewed-on: https://chromium-review.googlesource.com/c/1286857 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600687}
-
Yoshifumi Inoue authored
This patch renames ContainsOnlyWhitespace() to ContainsOnlyWhitespaceOrEmpty() to avoid ambiguity of return value of empty string for improving readability. This patch is done by global replace and manual changes fro removing |IsEmpty()| from |str.IsEmpty() || str.ContainsOnlyWhitespaceOrEmpty()| in * third_party/blink/renderer/core/css/properties/css_parsing_utils.cc * third_party/blink/renderer/core/editing/selection_controller.cc This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1288176 Make WhitespaceAttacher to ignore empty Text node Bug: 894674 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I144ef97f2b016a1bb39e6c3ef5fc5d850865d009 Reviewed-on: https://chromium-review.googlesource.com/c/1288157Reviewed-by:
-
Christopher Cameron authored
It is no longer the case that a gfx::NativeView/Window refers to an NSView/Window in the same process. Because of RemoteMacViews, they may refer to an NSView/Window that is in another process. Make gfx::NativeView/Window be a pass-by-value struct, and make converting from a gfx::NativeView/Window to an NSView/Window require an explicit conversion function. Mechanically add this conversion as needed. Also define a gfx::kNullNativeView/Window to match other types. Allow some temporary sloppiness to keep the patch size manageable: - Provide a non-explicit constructor that takes a NSView/Window. This will be removed in a follow-on patch (which will mechanically add constructors). - Provide a bool-cast operator to allow if-statements to still compile. These statements can later be changed to comparison with the gfx::kNullNativeView/Window. R=avi, ellyjones TBR=jochen (OWNER of remaining files) Bug: 893719 Change-Id: I39ccac1fd117fe0660fcc21bcb276c8d90dbe550 Reviewed-on: https://chromium-review.googlesource.com/c/1270343 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#600685}
-
Colin Blundell authored
This change is possible now that there is infrastructure for glueing an IdentityTestEnvironment to a Profile. Bug: 896180 Change-Id: I444b847636b4f709c9003ac3047bfc8e848bc049 Reviewed-on: https://chromium-review.googlesource.com/c/1286459 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600684}
-
Maksim Sisov authored
Wayland does not come with mus. Thus, update the doc respectively. What is more, add a note about minigbm usage with Ozone/Wayland. Change-Id: I66194efccfef75d4496a2f74a7d8c3ec9fe53ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1282066 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#600683}
-
chrome://media-internalsHenrik Grunell authored
* Adds capability of showing general audio information on chrome://media-internals in a key-value format. * Shows states of AudioService features (enabled/disabled). * Fixes JS presubmit errors: Use $(id) instead of getElementById(id), and use camelCase for variables. Bug: 895741 Change-Id: I35db3a3ab175586aa7e493ca1acccb1ac7ffa824 Reviewed-on: https://chromium-review.googlesource.com/c/1283020Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Daniel Murphy authored
R=mek@chromium.org Bug: 781870 Change-Id: Ic1b3846812f99520300dbad5e4082921043e673a Reviewed-on: https://chromium-review.googlesource.com/c/1286204 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600681}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f3d2a60105b..48ee86f818fb git log 0f3d2a60105b..48ee86f818fb --date=short --no-merges --format='%ad %ae %s' 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c20ead32ad6d..25843dd65181 (5 commits) 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 54e397425efa..b83d4911baae (1 commits) 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 847fc0b278f8..54e397425efa (1 commits) 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 nigeltao@google.com Have EncodeBench avoid superfluous setup 2018-10-17 nigeltao@google.com Rename EncoderBench.cpp to EncodeBench.cpp 2018-10-17 mtklein@google.com clean up SK_LEGACY_4F_XFERMODES 2018-10-17 fmalita@chromium.org [skottie] Clang-tidy fixes 2018-10-17 halcanary@google.com SkPDF: be smarter about checking to see if a new font is needed. 2018-10-17 jvanverth@google.com Fix NV12 and NV21 images in non-DDL 2018-10-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-17 kjlubick@google.com [canvaskit] Add perf jobs 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms c851ac96663d..f3e50cfac5bc (1 commits) 2018-10-17 mtklein@google.com reject non-3x3 gamut matrices 2018-10-17 caryclark@skia.org fix pathops timeouts 2018-10-17 mtklein@google.com disable legacy shaders in flutter Created with: gclient setdep -r src/third_party/skia@48ee86f818fb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:895763 TBR=egdaniel@chromium.org Change-Id: Ifba7c1e3f72463f9a519d9fb401827ae5aaf08c2 Reviewed-on: https://chromium-review.googlesource.com/c/1288019Reviewed-by:
-
Marina Ciocea authored
This is a reland of https://crrev.com/c/1240280 after fixing #890850 in parent CL. TBR=holte Bug: 832666, 890850 Change-Id: I98cc6918842b8acfe0dae14ed176b29b92eadc4e Reviewed-on: https://chromium-review.googlesource.com/c/1283132 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#600679}
-
Ben Wells authored
A default app has been added that isn't appearing on some devices. This logging will enabled this to be debugged. Bug: 893481 Change-Id: I7be3800c6893841f8627fc6a0aabc56648fea5e6 Reviewed-on: https://chromium-review.googlesource.com/c/1288096Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#600678}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ia60a35c3a34147d84d366fad26e6a75f4859b015 Reviewed-on: https://chromium-review.googlesource.com/c/1286099Reviewed-by:
-
Kinuko Yasuda authored
This reverts commit b90f388e. Reason for revert: After enabling this in main waterfall following tests keep failing in single_process_mash_interactive_ui_tests: TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 LoggedInSpokenFeedbackTest.KeyboardShortcutViewer Original change's description: > Run single_process_mash_interactive_ui_tests in main waterfall > > It seems this is stable recently with the current filter. > Let's run under the main waterfall. > > BUG=883523 > TEST=none > > Change-Id: Ia14281c1e5a276c5057ae7653547086347c3ee0c > Reviewed-on: https://chromium-review.googlesource.com/c/1285055 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600462} TBR=mukai@chromium.org,sky@chromium.org Change-Id: I511a0b6101a5574b154981cd1aaac76c7d5d088f No-Tree-Checks: true No-Try: true Bug: 883523 Reviewed-on: https://chromium-review.googlesource.com/c/1288158 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Lei Zhang authored
BUG=775054 Change-Id: I08746100815d3c7b05f6c181253841942481a629 Reviewed-on: https://chromium-review.googlesource.com/c/1285316 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#600675}
-
Sergey Ulanov authored
Previously the runner script was copying packages to /data when installing them. On some devices (e.g. VIM2) /data is significantly slower than /tmp. On VIM2 This change reduces media_unittests installation delay from more than 45s to less than 5s. Change-Id: Iea4a25abede1f41b28c7194969eb62286f476bbc Reviewed-on: https://chromium-review.googlesource.com/c/1284392Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600674}
-
Kinuko Yasuda authored
Looks like this one's really flaky on multiple bots. TBR=falken@chromium.org Bug: 896230 Change-Id: I2e2ca10912d7a75ed52e1e668110444fb0817f6c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1288159 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
tanvir.rizvi authored
IsConnected checks if the anchor node is connected in DOM/FLAT tree, while IsValidFor check if the position is in the same document. HandleGeneralDelete can cause DOM mutation and hence can move out of the document. Therefore we should use IsValidFor. This CL changes IsConnected to IsValidFor to cover all the scenarios. Bug: 794282 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I72268bfe1e275e40768aaf7f8e875e20b99f6460 Reviewed-on: https://chromium-review.googlesource.com/c/1286242Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#600672}
-
Yoshifumi Inoue authored
This patch changes inline item and block-level replaced handling in Element#innerText for improving interrop with adding test cases to WPT test file. Examples: * abc <img> def => "abc def"; not collapse spaces around <img> * <canvas></canvas> abc => " abc"; not collapse space after <canvas> * abc <img style="display:block"> def => "abc\ndef"; recognize block with style This patch also updates of layout test expectations since existing expectations were produced by Element#innerText with bug fixed by this patch. Bug: 894701 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I72d7eec3436d0cfa0226b5efa3adbc4c990f06c5 Reviewed-on: https://chromium-review.googlesource.com/c/1277802 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Koji Ishii authored
The primary motivation is to save memory usage. It may improve memory locallity, but will make reversed- iteration slower. This is in company with using one-way linked list for NGPhysicalFragment in http://crrev.com/c/1284469. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie17e566d3c66bd4a2f6f1f24e575e7a1494c1639 Reviewed-on: https://chromium-review.googlesource.com/c/1284469 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I5be3ea82fed659cb0fc3ddbe13e308eb9e8c1f38 Reviewed-on: https://chromium-review.googlesource.com/c/1286009 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600669}
-
Darren Shen authored
This reverts commit b03ffb6b. Reason for revert: b117901291 Original change's description: > [VK] Clarify KeyboardUI interface. > > Currently, KeyboardUI has a weird interface where |GetKeyboardWindow| > will start loading the keyboard web page if it is called the first time. > So this resulted in a lot of places where we were calling > GetKeyboardWindow and didn't know whether it would cause a load or not. > > We change the KeyboardUI interface a bit to explicitly state when we > are creating / loading a keyboard window, vs just getting an already > loaded one. > > This removes ChromeKeyboardUIWebContent's dependency on > KeyboardController as well. > > We tried to keep the same behaviour for existing KeyboardUI subclasses. > > Bug: 845780 > Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be > Reviewed-on: https://chromium-review.googlesource.com/c/1264336 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599772} TBR=jamescook@chromium.org,stevenjb@chromium.org,shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 845780 Change-Id: Ifb9f421d12eccfc0f6208a952025b84df087228b Reviewed-on: https://chromium-review.googlesource.com/c/1288094 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#600668}
-
Tetsui Ohkubo authored
This CL fixes the bug that the scroll position is wrong in such cases: 1. Initially there's no notification. 2. Open SystemTray 3. Press CapsLock 4. Bottom position of notification is wrong TEST=NewUnifiedMessageCenterTest.AddAndRemoveNotification BUG=769219 Change-Id: I362b2497da1b89c9decca9cca8e8e2d735d1293d Reviewed-on: https://chromium-review.googlesource.com/c/1286011 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#600667}
-
Dmitry Iljinskiy authored
Change-Id: I276ee26927af91971e8dd54af455ac55c93b8731 Reviewed-on: https://chromium-review.googlesource.com/c/1286131 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#600666}
-
