- 03 Nov, 2020 40 commits
-
-
Zhenyao Mo authored
It seems minidumps fail to include "reason". My guess is it's due to its if-else-clause local scope. Declare these variables at function level, hoping they will be included in minidumps. BUG=1060785,1077725 TEST=bots R=rafael.cintron@microsoft.com Change-Id: I0a81aee1134c4c69c1d444b6b445b07dc99d9ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515223 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823427}
-
Alex Turner authored
Currently, it is a bit confusing that the function is not static, given its render_frame argument. Additionally, it currently violates the rule against virtual methods in constructors. We add an extra layer of indirection: GetInheritedActivationStateForNewDocument(). This can then be overridden by the test harness without affecting the constructor. Bug: 1134747 Change-Id: I0db55c7fdaaf52992dc23ee9a568f82a22d0161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495911Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#823426}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68ff27c5daea..bc186f0ead79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1084659,chromium:1142554,chromium:1142775 Tbr: meredithl@google.com,tommycli@google.com Change-Id: I0882d33c1c7d9b783a799f8d2836163e65de58fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515124Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823425}
-
Minju Kim authored
This CL is a precursor of https://crrev.com/c/2419056. Bug: 1126828 Change-Id: I629123a6eae153825355b6b2820ac6ce924f05f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490913 Commit-Queue: MINJU KIM <mkim@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#823424}
-
Dominik Röttsches authored
Also removes exception for web-tests so will now target Win10-18363. These should go together so that the change is atomic. Generated using the rebaseline script generated from failed results in [1] plus blink-tool.py optimize-baselines with tests copied using "Copy test names" from the same page. [1] https://test-results.appspot.com/data/layout_results/Win10_Tests_x64_1909/907/blink_web_tests/layout-test-results/results.html Bug: 1125612,1124829 Change-Id: I1df907d54b7c7a7645ac4b90f4afdb54b85a8ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396138 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#823423}
-
Demetrios Papadopoulos authored
Specifically: - Pass "More options" label as a <slot> to cr-expand-button. - Change md-select's aria-label to aria-labeledby This results in better screen reader (VoiceOver) behavior where the label is not read twice when navigating with Ctrl+Alt+RightArrow. Bug: 1055829 Change-Id: I31dadd2e13ca8ce50e75050f0f580b06183bcfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510329 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823422}
-
Francois Doray authored
Intensive wake up throttling limits wake ups from Javascript timers to 1 per minute for pages that have been backgrounded for 5 minutes. A side-effect of this change is that pages that used to cause frequent extension messages (e.g. navigation commit) now cause extension messages only once per minute. Because extension processes can be terminated after 15 seconds of inactivity, keeping most pages idle for 1-minute intervals *increases* extension process churn (extensions processes that were kept alive permanently by frequent messages are now recreated every minute). This CL adds a feature param to control the inactivity delay to terminate an extension page. We plan to experiment with a 65 seconds delay (slightly longer than the intensive wake up throttling delay) and assess impact on resource consumption (CPU + memory + power). Bug: 1144166 Change-Id: If7b797f375b4ad37c753b8b43e32898e197a91ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510431 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823421}
-
Nicholas Hollingum authored
Discussed with the DLC team, we're tracking these two FRs from DLCservice, so ive added TODOs in the relevant parts of the code. Bug: b/172284265, b/172279567 Change-Id: If46949016defd403f266d3fb766488089657e7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515804 Auto-Submit: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#823420}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604339911-496ad7cd0b2f151b52bf1dbd6e77aab393c02169.profdata to chrome-mac-master-1604361545-d42c7d02d03a39b634140e180e06bf71d35a67fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib1305525d98c9698275bae07ba98eb90a25428ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823419}
-
Raymond Toy authored
The fix for issue 1125635 and 1115901 causes a deadlock because pulling on the audio graph that has a ScriptProcessorNode calls the main thread to do the processing. If the context goes away, the destructor needs tries to get the lock which is being held by the audio thread, waiting for the ScriptProcessorNode to return so the lock can be released. Hence a deadlock. We revert this fix. Local tests indicate that the repro case from 1125635 no longer triggers for whatever reason when it was very reliable before. While the deadlock is gone, this is also a speculative revert for 1125635 and 1115901. Bug: 1136571, 1125635, 1115901 Change-Id: I7de5cd8e764272a7a320c4b89d2c187663f0ff5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514806Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823418}
-
Evan Stade authored
Bug: 790766 Change-Id: I85fe845d3aa8b2584e7bd4877b7d80f1ee5ca3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511878Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#823417}
-
Yue Zhang authored
This CL hides TabStrip IPH when bottom sheet shows and reshows IPH right after bottom sheet hides. This CL is gated by Finch parameter "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchBugFixEnabled. Bug: 1135926 Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823416}
-
Daniel Libby authored
It is possible for the scrollable area that is targeted for a scrollbar scroll to have a layout box, but the parent hosting iframe does not. In these cases we should just return a null target since we should not attempt to scroll something that will not be visible. This is really hard to repro outside of using eventSender, since getting code to run between the queuing of a GSB targeted at a scrollable area and the GSB executing happens as the stack unwinds, but fixing this will fix the clusterfuzz test case. R=bokan@chromium.org Bug: 1140886 Change-Id: I65675ac565bb5d860d2b1fd7209a58ff835d27bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511860 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823415}
-
Daniele Castagna authored
Canvas can have an "image-rendering: pixelated" css property. In those cases, nearest neighbor filter will be used instead of bilinear. Since we don't do nearest neighbor filter when scanning out buffers via HW overlays, this CL simply rejects the HW overlay path in those cases and always falls back to GPU compositing. Test: SingleOverlayOnTopTest.RejectNearestNeighbor Change-Id: I907998f5a23ed2888ff0b3c53b9d7a938164acdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510649Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#823414}
-
Bo Liu authored
Hook up SkiaRenderer to webview's secondary command buffer skia draw context. Introduce SkiaOutputDeviceSecondaryCB for this case. Still need to refactor SkiaOutputSurfaceImplOnGpu. Eg SecondaryCB does not have access to a SkSurface so anything that uses SkSurface needs to be abstracted by SkiaOutputDevice. Also need to refactor draw context submit and swap buffer calls since webview does not call submit itself, and instead gets a callback after android calls submit. Also add a way to get a SkSurfaceCharacterization from SkiaOutputSurfaceDependency, since the SkDDL has to use the exact characterization from the GrVkSecondaryCBDrawContext. Add a check if there is a readback from the root surface. WebView currently does not use this for any production features so should be ok for now. Bug: 1141683 Change-Id: I3a0ad5b0f3a99070ffe773f35ea69d0ba5eca036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513784Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9396c2b0646a..655afebfcd13 2020-11-02 brucedawson@chromium.org Support autoninja -o/--offline to disable goma If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib0d6b4f15a2386de4554b8c95c1a48eafdcd346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823412}
-
Shik Chen authored
The seek operation is required for non-fragmented mp4 recording. This CL adds the seek support for the underlying file writers, except the Android intent writer. Bug: 1140852 Test: Pass camera.CCAUIRecordVideo and camera.CCAUIIntent Change-Id: I1e111f9776b1c44905a5de203dbe8c95570ce490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513961Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823411}
-
Matthew Denton authored
The Network Service previously used concrete net::CertVerifier implementations, but is now switching to use the CertVerifierService. When creating a NetworkContext, a remote to a CertVerifierService needs to be included in the NetworkContextParams. Some unit tests don't do this, which is fixed in this CL in preparation for enabling the CertVerifierService by default. Since there's no need to test cert verification in most of these unit tests, just add a pipe to a fake CertVerifierService that always passes cert verification. Bug: 1015134, 1111472 Change-Id: I378ff0930148bcc229b774c1bec1f7020ce97082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509429Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#823410}
-
Egor Pasko authored
======================================================================== Overall the tool has two subcommands: ======================================================================== usage: PINPOINT_TRACES [-h] {fetch,extract} ... Tool to download and aggregate traces from a given Pinpoint job. The tool is intended to be used in two steps: Step 1: Fetch all traces from a Pinpoint job. Example: > pinpoint_traces.py fetch \ --job=https://pinpoint-dot-chromeperf.appspot.com/job/1709f5ff920000 Step 2: Extract all events with a matching name into a CSV file. Example: > pinpoint_traces.py extract --event='.*Looper.dispatch.*' --output events.csv NOTE: Currently only supported on Linux. WARNING: Uses multiprocessing with heavy use of memory and CPU resources in each subprocess. This causes problems when handling SIGINT (when ^C is pressed), instead it is recommended to stop by ^Z and using the shell job control to kill or continue the job (like: kill %1). positional arguments: {fetch,extract} fetch Fetches job_results.csv and the traces mentioned in it extract Extracts information about an event from all downloaded tracesinto a CSV file ======================================================================== The 'fetch' command takes a JOB: ======================================================================== usage: PINPOINT_TRACES fetch [-h] --job JOB required named arguments: --job JOB Pinpoint job ID or URL ======================================================================== The 'extract' command takes a regex and an output file name: ======================================================================== usage: PINPOINT_TRACES extract [-h] -e EVENT -o OUTPUT required named arguments: -e EVENT, --event EVENT Regex to match event names against -o OUTPUT, --output OUTPUT CSV output file name Bug: 1119406 Change-Id: Ief2a3d5ab97c54aa6e98c6095c6fcadbe88e4907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461323 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#823409}
-
Darren Shen authored
The API is supposed to return a boolean 'success' value, but we forgot to. Bug: 1141347 Change-Id: I9f06828e5219209972d478becab515c5b7240062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505856 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#823408}
-
Meredith Lane authored
This reverts commit 365f1d94. Reason for revert: Fails deterministically on Webkit Linux Leak bot, first failure here: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/20367 Original change's description: > WPT to check click/auxclick/contextmenu are pointerevents > > Verify that the user agent returns click/auxclick/contextmenu as pointerevents. > > Bug: 989958 > Change-Id: I02757ef704b605471614829177cba24a73b6c8db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823332} TBR=mustaq@chromium.org,liviutinta@chromium.org Change-Id: Idf6e9caf6291aa9a35ddabbb8e8f18c45f004522 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515504Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823407}
-
Meredith Lane authored
This reverts commit 1d6d5027. Reason for revert: Suspected culprit of win-asan failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/15420 Original change's description: > Hooking up buffer_size in EtwTraceController::StartRealtimeSession > > I am working on some ETW stuff for Chrome Remote Desktop and I > noticed that this parameter is unused and a default value of 16KB > is always used. This isn't a big deal as the only caller appears > to be its unit tests but it seemed like the value passed in > should do something. The other approach would be to remove the > param but adjusting the buffer size seems like a reasonable thing > to expose (assuming the param is actually used). > > Change-Id: I453ac2417d68f6c16fecd517cf1cd74c5aa15731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511290 > Commit-Queue: Joe Downing <joedow@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823240} TBR=brucedawson@chromium.org,joedow@chromium.org Change-Id: Iab1337eaf4c762f50074d56d8d7eaa0210fb7d0c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515503Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823406}
-
Kevin McNee authored
We needed to manually reset the frame host AssociatedReceiver after reporting a bad message, since AssociatedReceiver didn't have a ReportBadMessage until recently. Bug: None Change-Id: I49b13134f4dc4202d684248db4d5aa01c8fe5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514466Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823405}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1443e5ac0acf..af6371f32764 2020-11-02 tsepez@chromium.org Consolidate some tests in new fxv8:: functions. 2020-11-02 nigi@chromium.org Fix issue that some characters from the embedded font don't render. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia6f22975aa393d189816ddfd9dc96df61b2d5bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823404}
-
Reilly Grant authored
Due to an error introduced in r678566 the set of configuration descriptors was overwritten after parsing each one so that the device info only contained the last configuration descriptor provided by the device. This change fixes that by waiting for all configuration descriptors to be parsed before moving the list into the device info structure. Bug: 1144532 Change-Id: Ic540986eb9cbc5a01391e581ce7c21ad219a2f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514589 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823403}
-
Erik Chen authored
This reverts commit 68dcf80e. Reason for revert: Breaks copy/paste: https://bugs.chromium.org/p/chromium/issues/detail?id=1144289 Original change's description: > Lacros: Enable IME. > > Bug: 1133732, 1123705 > Test: Ran Lacros locally. > Change-Id: Id74573390f287512a4455636e7b636255df4e025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503528 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821320} TBR=jamescook@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1133732 Bug: 1123705 Change-Id: I087969af40be61dc325325c91f0502fc18e191dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515204Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823402}
-
Joel Hockey authored
FileManager UITests fail when native HTML Imports are disabled. Serve the test files from the embedded test server to make the HTML imports polyfill on the UITest test.html page work. The tests now pass when HTML imports are disabled. All console errors about Polymer not working are gone. The Visual Signals xf* files 404 off the embedded test server but the UITests still PASS. Test: browser_tests --gtest_filter="FileManagerUITest*" Bug: 1111393 Change-Id: Iec0133c61b7296ced6bb01fb740e1667b9aa8d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515379 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823401}
-
Hiroki Nakagawa authored
Reland "NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/" This is a reland of 8436de62 The previous CL was reverted because unluckily conflicting CL that refers to a pre-moved header file was landed before the CL. This reland CL fixes it. Original change's description: > NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/ > > This is mechanical rename other than changes in OWNERS and > flag-metadata.json. > > Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f > Bug: 1144577 > Tbr: fgorski@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486 > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823349} Bug: 1144577 Change-Id: I82417260cfcf0ecda944d31e1901d25e542f4a2f Tbr: fgorski@chromium.org, robertogden@chromium.org, ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515420Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823400}
-
Lan Wei authored
When we are using Chromedriver ExecutePerformActions to simulate three mouse click, it should set the mouse click count to 3, but if we keep clicking, the click count should keep increasing on Windows and Mac, reset to 1 otherwise. It should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. I added three more tests to verify these cases. Bug: 1119679 Change-Id: I6f628e625e680870a77e18495eb0b4fab024fbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508987Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823399}
-
Ian Struiksma authored
Test cc had date of 10/2020, which means it expired. Setting exp year to use test::NextYear() so test can proceed. Bug: 1144598 Change-Id: I018787f8003f3d48a0d56715a613163ae7c3158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515263Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#823398}
-
dpapad authored
- Remove |deps| field from js_modulizer() definition. - Spit js_modulizer() targets with deps to two separate targets, one js_modulizer() and one group() target. - Change js_library() targets to only depend on "modulize_local" targets. Bug: None Change-Id: Ifb0ed2344f3ecc9e6699f88fc0676d339b2d3424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514071 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823397}
-
Clark DuVall authored
This also prints the parent ClassLoaders, to see if there is differences there too. Bug: 1142589 Change-Id: Ib8933bba6ce6bc66883a2bc88bee208383e41dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514591 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823396}
-
Nicolas Ouellet-Payeur authored
Bug: 1144907 Change-Id: I5c66ef7b869ada7603fbc7e15c20007c078bb0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515044 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#823395}
-
Shik Chen authored
The size limit optimization only applies for fragemented MP4. Chrome needs the whole file of a non-fragemented MP4 to be able to play it. Bug: 1140852 Test: Record a video and check the thumbnail manually. Change-Id: I3f4d6d7c317c21203761372265b7283bac4734f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513415 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#823394}
-
Mike Wittman authored
This reverts commit 440bbbe7. Reason for revert: causing crashes seen in https://crbug.com/1144621 Original change's description: > [Sampling profiler] Restore callee-save registers in V8 unwind > > Restore the callee-save registers now provided in the V8 API when > unwinding. This is a necessary condition to support unwinds of > functions that use dynamic stack allocation, which is failure mode > 1 in the corresponding bug. > > Bug: 1122124 > Change-Id: Ifb30bbdd9df343251a7c215e5a5fc140754ac216 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500453 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822204} TBR=wittman@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122124, 1144621 Change-Id: I0e998ab210537a513cfc9a67d5e632b2aa73d9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515202Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823393}
-
Nancy Wang authored
AppServiceAppIconLoader could call LoadIcon multiple times, because the icon image is updated for each scale. Waiting icon update once might cause the AppServiceAppIconLoader is destroyed before the icon loading process is finish, so it might cause below error: [app_service.mojom.cc(1174)] Check failed: !connected. AppService::LoadIconCallback was destroyed... This CL modifies the expected icon update count to wait the icon loading process finish to avoid AppServiceAppIconLoader to be destroyed early. BUG=1124972 Change-Id: Id7efc80d14ac1a0f6e4cfbe77223256922898599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494215 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#823392}
-
David Jacobo authored
Previous CLs got rid of this flag in code as it was expired, this CL only removes said flag from the flag-metadata file that keeps track of flags and their milestones. Bug: None Test: build. Change-Id: I476bf49ad50b189d05c919883052202f80327b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515180 Commit-Queue: David Jacobo <djacobo@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823391}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I68f4d928659f3366732c12dd45fc36200a714130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823390}
-
Will Cassella authored
This CL extends the expiration of the 'turn-off-streaming-media-caching-always' and 'turn-off-streaming-media-caching-on-battery' flags to m89 in order to support the run of the corresponding finch trial. Bug: 984851 Change-Id: Ib2f2e43b292cbf0d333558f8f47ecbb1db4a3928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514804Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#823389}
-
Scott Violet authored
This removes adding the qualifier PageTransition.FROM_API for TabLaunchTypes of FROM_LINK and FROM_RESTORE. I believe this was unintentional, and doesn't make sense to use FROM_API with. This also removes FROM_API for intents that came from chrome and launched chrome. Again, seems like we shouldn't use FROM_API for this scenario either. I came across this while doing the other patches. AFAIK nothing depends upon this, just seems worth cleaning up. BUG=none TEST=none Change-Id: Id89fbc0e70fb52a662ac33a55d269460677ee152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511853 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823388}
-