- 14 Jul, 2017 40 commits
-
-
Sammie Quon authored
This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. This approach of adding a back button expands the current app list button to be modal and have two functionalities depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the meantime. Screenshots: https://screenshot.googleplex.com/ZVNP0aq0cc3 https://screenshot.googleplex.com/fDcGTuoyZg5 https://screenshot.googleplex.com/ZFBzk72LLVt Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" Bug: 721940 Change-Id: I699c6d971aea89ba201536ca8534a14b4d44b0e2 Reviewed-on: https://chromium-review.googlesource.com/555836 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#486830}
-
Jeff Carpenter authored
This reverts commit 1674a85c. Reason for revert: results were unstable upstream: https://github.com/w3c/web-platform-tests/pull/6546 A provisional PR wasn't created for the CL so there's no way this could have been avoided. Original change's description: > Capture from HTMLMediaElement: move LayoutTests to external/wpt > > This CL moves the three standard functionality LayoutTests for > mediacapture-fromelement to the external/wpt folder, adapting > them accordingly and adding the necessary webmfiles. > > Also removes the HTMLMediaElementCapture-*.html expectations. > > Bug: 619625 > Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 > Reviewed-on: https://chromium-review.googlesource.com/566151 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486677} TBR=mcasas@chromium.org,emircan@chromium.org Change-Id: Id0c5e1a45f9d4e65929aede3a6f256eae3850a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 619625 Reviewed-on: https://chromium-review.googlesource.com/572087Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486829}
-
bshe authored
Bug: None Change-Id: I01edfbb7fe6331d78052cf2ee7b3214affb7c425 Reviewed-on: https://chromium-review.googlesource.com/568848Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#486828}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:743085 Change-Id: I4a95ad0f99f84a0884dee37a2eee7abced2a1921 Reviewed-on: https://chromium-review.googlesource.com/572072Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486827}
-
Tom Sepez authored
Bug: 742459 Change-Id: I228bccccb3f094e60a45dc3b9e8267c580f3d750 Reviewed-on: https://chromium-review.googlesource.com/571018Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486826}
-
Weidong Guo authored
Changes: 1. Initializes the search result page view using the same bounds, color and background border corner raidus as the search box view to make it hidden. 2. When there's query in the search box, grows the search result page in the same pace as the search box to make them look like a single growing view. Screenshots of animation: https://screenshot.googleplex.com/FNsJ0bE9s29 https://screenshot.googleplex.com/4ObTEsitpRK https://screenshot.googleplex.com/sHQWVWaqavH https://screenshot.googleplex.com/HVFKUXrYQhO Specs: https://screenshot.googleplex.com/409fBM7pTO2 BUG=741051 Change-Id: I2fc15631e6675169dcb0ab222ce1af4cdc9cf2d2 Reviewed-on: https://chromium-review.googlesource.com/570835 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486825}
-
Ryan Landay authored
Currently, this method uses LinearLayout.LayoutParams to measure the views in the ListView (this code was refactored out of DropdownPopupWindow). However, this causes a crash in certain situations on Android J and K (for example, adding a LinearLayout as a footer view, calling this method, and then later trying to measure a parent of the ListView) because LinearLayout.LayoutParams can't be cast to AbsListView.LayoutParams. This CL changes this code to use AbsListView.LayoutParams to avoid this crash. Bug: Change-Id: I90b68cd812155ac87bc089f95493cdd82de77395 Reviewed-on: https://chromium-review.googlesource.com/571600Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#486824}
-
Donn Denman authored
Updates ukm.xml to have the correct metric names. We originally wrote metrics using all-caps names, and changed the code in CL 2894913003 but we forgot to update ukm.xml at that time. This just updates the ukm.xml names to reflect what's already being written. Also removed one name that's for data that's not actually written. Also removes an include that's not needed. BUG=736158 Change-Id: I31f94553ab188e7001d10a3f2f109e4d7a255233 Reviewed-on: https://chromium-review.googlesource.com/568760Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#486823}
-
Andy Paicu authored
Fixed an issue where multiple policies with different algorithms would deny scripts/styles Fixed an issue where report-only policies could cause hash-based policies to incorrectly deny scripts/styles Fixed an issue where mixing hash based and not hash based policies would deny scripts/styles because the checks were done independently Got rid of the IsAllowedByAll template system and replaced it with for loops Ensured that checks that check hashes are now incorporated in their respective allows function Removed the need for external callers to know to call the hash specific functions checks since now they are integrated Added LayoutTests relevant to the issues above Bug: 617065, 739292, 740688 Change-Id: I1b56afe899eac6358d2ef33fc7030aef568f89ac Reviewed-on: https://chromium-review.googlesource.com/570248Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#486822}
-
yolandyan authored
Since WebView is the only place where parameterization is used for instrumentation tests. This CL simplify the framework by only providing commandline flag parameterization. This is for the sake of listing out tests from Java test runner side in the follow up CL BUG=640116 Review-Url: https://codereview.chromium.org/2963683002 Cr-Commit-Position: refs/heads/master@{#486821}
-
Fady Samuel authored
I forgot to move this file in the last CL. Bug: 722935 Change-Id: Ic7e3872fe876b23b993b9d0a3f53d998e6b43ea6 Reviewed-on: https://chromium-review.googlesource.com/571265Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486820}
-
Peter K. Lee authored
Bug: 721921 Change-Id: Idc58d5076791ea511d0efcd1df944496883de220 Reviewed-on: https://chromium-review.googlesource.com/567393Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#486819}
-
Dirk Pranke authored
This reverts commit 19e9083e. Reason for revert: This might be causing the Linux CFI failures in https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20CFI/26 and following. Original change's description: > Reland of Pass -no-canonical-prefixes to clang by default. > > This is a reland of patchset #1 of https://codereview.chromium.org/2936053003, > except that we do not pass the flag when using the ChromeOS custom > toolchains, either. > > TBR=hans@chromium.org, manojgupta@chromium.org, thakis@chromium.org > BUG=712797 > > Change-Id: I14f56c9b29234dd693719b017828c6250202a9d0 > Reviewed-on: https://chromium-review.googlesource.com/571440 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486793} TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org,manojgupta@chromium.org Change-Id: Iffa28553b78c79fec8daed93658ba755bd17fe1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 712797 Reviewed-on: https://chromium-review.googlesource.com/572004Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486818}
-
oshima authored
The issue was that NativeViewHost fills the background with WHITE (default color) if the clipping window is installed. This was for fast resize scenario (resizing the view without resizing nativ view), but this also appends when native view gets clipped (which happens when you scroll). While it's a bit sounds wrong to set the resize background color even if you're not resizing, this is simplest solution. BUG=None Review-Url: https://codereview.chromium.org/2969523002 Cr-Commit-Position: refs/heads/master@{#486817}
-
Patrick Monette authored
Bug: 717696 Change-Id: I60b57042445f89122db3288983fa3e66bb29d13e Reviewed-on: https://chromium-review.googlesource.com/563697Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#486816}
-
johnchen authored
On Android devices, ChromeDriver used to use shell "echo" command to send Chrome command line to the device. Adb limits the length of the command line that can be sent this way, ranging from less than 1000 characters to about 4000 characters, depending on the Adb version. To allow longer command line to be used, ChromeDriver now uses Adb file transfer protocol to send the command line file to the device. This is the same underlying protocol used by "adb push" command. BUG=727979 Review-Url: https://codereview.chromium.org/2972913002 Cr-Commit-Position: refs/heads/master@{#486815}
-
Lukasz Anforowicz authored
This CL introduces the following helpers for setting field trial params from test code: content/public/test/test_util.h: // Appends command line switches to |command_line| to enable the // |feature| and to set field trial params associated with the feature // as specified by |param_name| and |param_value|. void EnableFeatureWithParam(const base::Feature& feature, const std::string& param_name, const std::string& param_value, base::CommandLine* command_line); components/variations/variations_params_manager.h: // Appends command line switches to |command_line| in a way that // mimics SetVariationParams. static void AppendVariationParams( const std::string& trial_name, const std::string& trial_group_name, const std::map<std::string, std::string>& param_values, base::CommandLine* command_line); Change-Id: Ibdcd7931c2894b9d5d77334d286bf3142034591a Bug: 740701 Tbr: bauerb@chromium.org, bartfab@chromium.org, nparker@chromium.org Reviewed-on: https://chromium-review.googlesource.com/565224 Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Dan Sinclair <dsinclair@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Charlie Reis (OOO until July 19) <creis@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#486814}
-
Quinten Yearsley authored
TBR in order to green up the waterfall TBR: fmalita Bug: 743068 Change-Id: Ic94118d288b7d1a4568e95df2538cef0542cb007 Reviewed-on: https://chromium-review.googlesource.com/572041Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486813}
-
ymalik authored
This CL adds VrFirstRunActivity which has the android:enableVrMode attribute which keeps us in VR mode when starting Chrome. We need this because VrCore doesn't allow non-active VR apps to call DOFF. Starting Chrome with a pure VR activity sets Chrome to be the active VR app in time for us to call DOFF. The new activity can be removed when VrCore allows transitioning activities to call DOFF without being the active VR app. BUG=721885 Review-Url: https://codereview.chromium.org/2980453002 Cr-Commit-Position: refs/heads/master@{#486812}
-
xdai authored
setup dialog. When setting up a printer for CUPS (Settings -> Printers -> Add Printer), the default dialog should be "Add a nearby printer" via auto-discovery. However, we should account for the case where no printers are available via auto-discovery - In this case, if 0 printers are detected, we should present the "Add a printer manually" to avoid presenting a dialog with an empty list of printers. BUG=735244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2979903003 Cr-Commit-Position: refs/heads/master@{#486811}
-
Xida Chen authored
After this change: https://chromium-review.googlesource.com/c/570003/, two layout tests under css-paint-api/ starts failing. I found that the common thing with these two tests is that there is a repeat-x or repeat-y in the css style. Not sure why that causes the failure. Instead, this CL changes it to fill a rect, which will be less sensitive to AA changes. Bug: 742991 Change-Id: I16e4cddbcbd466852d43a07d658460f4e07e6a47 Reviewed-on: https://chromium-review.googlesource.com/571027Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486810}
-
Duc Bui authored
started_in_foreground in PageLoadMetricsObserver::OnStart() is false for foreground tabs in session restore. This patches fixes 2 things: 1. Correct the in_foreground variable in MetricsWebContentsObserver constructor. 2. Pass the correct visibility status of tabs in session_restore.cc. TBR=xiyuan@chromium.org BUG=740252 Change-Id: Ic8ab868bc850b20070813ec659d64c60345cc160 Reviewed-on: https://chromium-review.googlesource.com/569578 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#486809}
-
Jonathan Ross authored
This reverts commit b18491dc. Reason for revert: Viz currently does not support the mash configuration. Due to this the compositor cannot be used in mash_browser_tests. The tests have been disabled on the waterfall. See crbug.com/742966 Original change's description: > Disable Compositor:DidFailToInitializeLayerTreeFrameSink NOTREACHED > > One third of CQ runs of mash_browser_tests are failing when hitting the > NOTREACHED in Compositor:DidFailToInitializeLayerTreeFrameSink so I'm disabling > it while the cause is researched. > > TBR=sadrul@chromium.org > > TEST: mash_browser_tests > Bug: 742966, 743028 > Change-Id: I9363ebfbdeac594d26696b5426004cbafcec9c9b > Reviewed-on: https://chromium-review.googlesource.com/571274 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486771} TBR=sadrul@chromium.org,jonross@chromium.org Change-Id: Ic7eb38c23b6330dc27d5fddb0e546b83ec08b6d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 742966, 743028 Reviewed-on: https://chromium-review.googlesource.com/572003Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#486808}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3921afc2..1115d872 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I7466e0a712700c182dcf7c1109abed839f832c47 Reviewed-on: https://chromium-review.googlesource.com/571276Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#486807}
-
Matt Menke authored
Bug: 734870 Change-Id: I0e2eb546795892c9aef7c24b50e46696c42ff7ed Reviewed-on: https://chromium-review.googlesource.com/570501Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486806}
-
Dirk Pranke authored
It looks like they have several issues. This removes them from both the "Linux ChromiumOS Ozone Tests (1)" builder and the "Linux ChromiumOS Tests (1)" builder, so it should stop breaking the CQ builds. TBR=jonross@chromium.org, kbr@chromium.org, qyearsley@chromium.org NOTRY=true BUG=742966 Change-Id: Ie96885593e40b1ff62e76dc1b09aa01d15e20529 Reviewed-on: https://chromium-review.googlesource.com/572079Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486805}
-
Daniel Bratell authored
The files listed in core_generated jumbo exclusions have since been fixed so the exclusions are no longer necessary. R=fs@opera.com Bug: 713137 Change-Id: Ib9a9216147e9df7d8b196de761556d3f23997448 Reviewed-on: https://chromium-review.googlesource.com/571222 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#486804}
-
Becky Zhou authored
+ Set list item translation value to 0 when app menu is anchored at bottom Before: Bottom AppMenu list items translate y position while fade in Now: List items don't translate y position while fade in when app menu is at bottom, but still translate when at top. BUG=735272 Change-Id: I0f20647807916059c7c81613772f5881c85600da Reviewed-on: https://chromium-review.googlesource.com/566588Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486803}
-
Paul Miller authored
"android update sdk" is deprecated in the O SDK. Switch to "sdkmanager". BUG=742635 Change-Id: Ia8ae4b22ed579ffc097b14d5514a8dcc63bfaf2e Reviewed-on: https://chromium-review.googlesource.com/571441 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#486802}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/477d0efcf2d9..fc4ee229a653 $ git log 477d0efcf..fc4ee229a --date=short --no-merges --format='%ad %ae %s' 2017-07-14 scroggo Fix double delete in SkBmpCodec 2017-07-14 bsalomon Make ProcessorRefTests op be a non-legacy GrMeshDrawOp 2017-07-13 bsalomon Make PrimitiveProcessorTest's op be a non-legacy GrMeshDrawOp 2017-07-14 bsalomon Make convex poly effect GM use a non-legacy GrMeshDrawOp 2017-07-14 update-skps Update SKP version 2017-07-14 csmartdalton Add "findOrMakeStaticBuffer" to GrOnFlushResourceProvider Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I7ea7e215c0dd4d1201de50e9edfcbc6e62bb3744 Reviewed-on: https://chromium-review.googlesource.com/570736Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486801}
-
Sasha Perigo authored
either the Windows or ChromeOS IsEnterpriseManaged() flags are set. As of yet, we don't have similar heuristics for getting this info from other operating systems. Bug: 600840 Change-Id: I9c319d4c24ab74058b84b47e17c1d73b1cd28908 Reviewed-on: https://chromium-review.googlesource.com/565176Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Sasha Perigo <sperigo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486800}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b63abe05c654..ebf00ecf2e83 $ git log b63abe05c..ebf00ecf2 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 etienneb Fix incorrect computation of sections when symbolizing traces Created with: roll-dep src/third_party/catapult BUG=739783 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icd11d46ea973a4069910c3aacd742ed4e228124d Reviewed-on: https://chromium-review.googlesource.com/571173 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486799}
-
Tibor Goldschwendt authored
Bug: 727955 Change-Id: Ib68a97b0ff6a548155b9fa3db1c44a4ba24c7a94 Reviewed-on: https://chromium-review.googlesource.com/566318 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#486798}
-
Josh Karlin authored
Labels frames identified as ads by the SubresourceFilter as ads. Also adds an AdType to each frame tracked by AdsPageLoadMetrics. When it's time to record the metrics, the same logic is applied once to collect stats for each ad type. There is also an additional ad type, "All", which records stats on all of the identified ads, regardless of which detector discovered it. Bug: 708570 Change-Id: Ic0f1f1cfd7176ffdba459b607735a6aa6b4318ff Reviewed-on: https://chromium-review.googlesource.com/567324Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486797}
-
arthursonzogni authored
A bug has been introduced in: https://crrev.com/2834013002. The assumption that Content-ID URLs can't be loaded without an MHTMLArchive doesn't hold. It is possible for instance with the Yahoo Mail app. It embeds chrome as a Webview. The webview load attached image with the Content-ID scheme. This CL allows the load instead of blocking it. BUG=739658 TBR=japhet@chromium.org Review-Url: https://codereview.chromium.org/2975623002 Cr-Commit-Position: refs/heads/master@{#486796}
-
kylechar authored
Make the creation of CompositorFrameSinkSupport go through HostFrameSinkManager. This takes us one step closer to viz architecture without using Mojo anywhere. FrameSinkManager is injected into HostFrameSinkManager if we want this path to be available. Every callsite in the browser process that creates a CompositorFrameSinkSupport goes through HostFrameSinkManager, with the exception of Android webview which doesn't use HostFrameSinkManager at all. This requires adding a dep from //components/viz/host to //components/viz/service again. It also requires adding an interface for DirectLayerTreeFrameSink. Bug: 742374 Change-Id: I22b9fb855b7a16716dccd4d5233c72412f9b2259 Reviewed-on: https://chromium-review.googlesource.com/570504 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486795}
-
Daniel Bratell authored
There are two very small, identical, To16Bit functions in font shaping tests. Since they caused collisions in jumbo builds and I didn't want to exclude the files from jumbo files I've merged them into a utilities file. Bug: Change-Id: I0c7e7d4ee708431a6401de7a01790f78c4e75e08 Reviewed-on: https://chromium-review.googlesource.com/570426 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486794}
-
Dirk Pranke authored
This is a reland of patchset #1 of https://codereview.chromium.org/2936053003, except that we do not pass the flag when using the ChromeOS custom toolchains, either. TBR=hans@chromium.org, manojgupta@chromium.org, thakis@chromium.org BUG=712797 Change-Id: I14f56c9b29234dd693719b017828c6250202a9d0 Reviewed-on: https://chromium-review.googlesource.com/571440Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486793}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/57f228d75275..21dd189fe50d $ git log 57f228d75..21dd189fe --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Use CFX_MaybeOwned in CJBig2_TRDProc Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I372752bccfc8f5b290bf809a9fe3d75b9c835c27 Reviewed-on: https://chromium-review.googlesource.com/571172 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486792}
-
Regan Hsu authored
Allow tether notifications to display blue icons with varing signal strength. Bug: 740686 Change-Id: I2e3477b899ece0a511270c82f48d52d44bfaf608 Reviewed-on: https://chromium-review.googlesource.com/564199 Commit-Queue: Regan Hsu <hsuregan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486791}
-