GitLab

This fixes a bug in QuicTestPacketMaker which was blocking this flag from
being fixed.

Change-Id: I76ffbbe1c87c35dfe94119e694eb787fb6cbf720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864301
Auto-Submit: Nick Harper <nharper@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706434}

Prior to this patch, if OnTrustedVaultKeyRequired() got called during
the sync engine's initialization, the keys would be successfully fetched
from the client, but there was no known engine to feed them to, so they
got dropped and IsTrustedVaultKeyRequired() never became true.

As fixed alternative, the patch proposes to defer the reading of the
keys until SetSyncEngine() gets called.

Bug: 1000146
Change-Id: I058407b157c66e72a3d62354108c5ee151197125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865149
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706433}

https://chromium.googlesource.com/angle/angle.git/+log/14dd70757eb0..bedeb781e8ca

git log 14dd70757eb0..bedeb781e8ca --date=short --no-merges --format='%ad %ae %s'
2019-10-16 tobine@google.com Vulkan: Define VK_USE_PLATFORM_XLIB_KHR

Created with:
  gclient setdep -r src/third_party/angle@bedeb781e8ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Bug: chromium:1011068
Change-Id: Id65c6d366d421ac8aa743dace21e9e161e17b84c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706432}

This reverts commit c40a0262.

Reason for revert: The crash looks unrelated to this CL, crbug.com/1013943

Original change's description:
> Revert "[StartSurface] Add long press behavior for the fake box"
>
> This reverts commit 14f7eff8.
>
> Reason for revert: Crashes on Canary with voice input
>
> Original change's description:
> > [StartSurface] Add long press behavior for the fake box
> >
> > This CL is based on
> > https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3
> >
> > It is the fourth patch of splitting the bigger one
> > https://chromium-review.googlesource.com/c/chromium/src/+/1797069
> >
> > It also unifies the record of the 'Android.OmniboxFocusReason' metrics.
> >
> > Screenshot:
> > https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing
> >
> > Bug: 982018, 1012275
> > Change-Id: I16d045777164d49d72356af474e5c186c8318370
> > Binary-Size: crbug.com/998206
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126
> > Commit-Queue: Ganggui Tang <gogerald@chromium.org>
> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#705264}
>
> TBR=yusufo@chromium.org,gogerald@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 982018, 1012275, 1013943
> Change-Id: I4a48866d15dc65e8f939fe1c86867754eea87604
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860598
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705727}

TBR=yusufo@chromium.org,gogerald@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=yusufo@chromium.org

Bug: 982018, 1012275, 1013943
Change-Id: I2af5453e12de134bb6c75b1c9229bd4644007d40
Binary-Size: crbug.com/998206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864005
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706431}

This CL removes overrides from:

* AppUninstallDialogView, which uses text that is computed during the
  constructor (and used redundant cancel text)
* DataRemovalConfirmationDialog, which uses static text
* DownloadInProgressDialogView, which uses static text
* Various NativeFileSystem dialogs, which use static text or text computed
  during the constructor & then never changed

This change also makes
NativeFileSystemRestrictedDirectoryDialogView::is_directory_ const to make the
code easier to reason about.

Bug: 1011446
Change-Id: Ib345c6f742b860a9041a9df21e003f802fe5648d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863632Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706430}

This reverts commit 8716ddc2.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 706414 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3MTZkZGMyNzQ2MmE5OGIxZWYwNDliZTY5N2M1YzBlNWJjZjYzNmMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-dbg/4735

Sample Failed Step: compile

Original change's description:
> Roll src/third_party/dawn/ 1093c4de2..cc071e45b (6 commits)
> 
> https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..cc071e45bb9c
> 
> $ git log 1093c4de2..cc071e45b --date=short --no-merges --format='%ad %ae %s'
> 2019-10-16 enga Split generation of dawncpp headers from libdawncpp
> 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling
> 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests
> 2019-10-15 senorblanco clang-win compile files for skia-dawn.
> 2019-10-15 cwallez Add dawnGetProcAddress.
> 2019-10-15 cwallez Split the libdawn target in components with a single purpose.
> 
> Created with:
>   roll-dep src/third_party/dawn
> 
> TBR=kbr@chromium.org
> BUG=dawn:22
> 
> Change-Id: Ib61611e5455abf1b66f33b1b68c311a428c3bf9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864683
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706414}


No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=dawn:22

Change-Id: I0a9279b00ded522a578ec0957a0ae528fd09aa54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864410
Cr-Commit-Position: refs/heads/master@{#706429}

This CL makes the header (title, subtitle, illustration) part of the
recyclerview that previously only displayed credentials.

This makes the entire sheet contents (apart from the handlebar)
scrollable.

Bug: 1012219
Change-Id: I81d5191cf007f4d6516a4700f983b81b17434c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859654
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706428}

 - Remove big bordered box
 - Move sync info into bordered box when a blue
   button is shown
 - Refactor spacing

Screenshot:
https://drive.google.com/open?id=1CmKpM_rEA92NO-dP_V71q7TghYAALV_S

Bug: 995720
Change-Id: I1e47024c57330a69c77632ac8020d11d6e983b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864786Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706427}

Apart from the build/tooling/test/third-party directories listed in
suppressions.xml, every usage of System#exit must be explicit and have
the @SuppressWarnings annotation, preferably with a short explanation of
why it is necessary.

Added @SuppressWarnings for all existing usages.

Removed the System#exit call in ChromeApplication since we have no
visibility into how often the application replacing bug is hit. Throwing
an exception with a custom message will help us see its current impact.

Bug: 1000651
Change-Id: Ia48598b32e339efccb0ca1b55ef03068da505410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851770
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706426}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be181e24..ad531032

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I162813eb82348c00ad2c88319c349eda7f687ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864872Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706425}

This affects the experimental codepath used to retrieve and store
encryption keys. The keys are associated to a user as determined by
identity servers, and using CoreAccountId for such IDs does not work
well on all platforms (namely, ChromeOS).

Bug: 1000146
Change-Id: Iaaab6f1867ac99c026e3474822e86ca5e80f5404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863803
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706424}

Using wpt-import in Chromium 3ba68b08.
With Chromium commits locally applied on WPT:
6386d9d8 "Update service_worker_unregister_and_register()"
f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I42c32bb0765bbccd8e5628e006cb64752cdb6ccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864871Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706423}

There are 2 NavigationThrottle that try to cancel and restart an
existing navigation via OpenURL call:
- NewTabPageNavigationThrottle
- PDFIFrameNavigationThrottle

Before this CL, these throttles tried to create OpenURLParams out of
NavigationHandle in an ad-hoc way - taking some navigation properties
into account and ignoring others.  This CL tries to fix this, by
introducing OpenURLParams::FromNavigationHandle that 1) should cover all
relevant navigation properties and 2) can be used from all throttles
that need this functionality.

It also turns out that by fixing how |source_site_instance| is
propagated we can fix some crashes happening in the wild -
https://crbug.com/1014483.

Bug: 1003957, 1007041, 1014483
Change-Id: I5acf27201c3a7a40ce7b239102a5075f26f4c5c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838381Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706422}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the XREnvironmentIntegrationProvider
interface, and adapt unit tests.

Bug: 955171, 978694
Change-Id: I261bdae8d49490a58a098545ef692fbf84b6d256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836416
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706421}

Bug: 1014475
Change-Id: I18f0192e1c1edb893177705e60687ddf022f1f7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862691Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706420}

Cascade order is
::part !important > !important > ::part


Bug: 1014400
Change-Id: If73f8280d0370e93f633f2460b744b073798090a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863059
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706419}

.. by calling PeerConnectionDependencyFactory::GetWebRtcSignalingThread()
directly.

This is now possible, after [1], where
peer_connection_dependency_factory.cc|h is moved to Blink.

[1] https://crrev.com/c/1805159

Note that to match the actual return type (base::SingleThreadTaskRunner)
the PCDF method is renamed to GetWebRtcSignalingTaskRuner().

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ia7d564ce94db4d8009d680f78925560681f98b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806845
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706418}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/67bce690decd..ab12219ba56a

$ git log 67bce690d..ab12219ba --date=short --no-merges --format='%ad %ae %s'
2019-10-13 junyer Fix the regexp_benchmark build with GNU make.
2019-10-11 junyer Oops, wrap a couple of lines.
2019-10-11 junyer Read flags using the GetFlag() style.
2019-10-11 junyer Make flags use the DEFINE_FLAG() style.
2019-10-11 junyer Remove a condition from exhaustive1_test.cc that is no longer needed.
2019-10-11 junyer Move util/flags.h into the testing target.
2019-10-11 junyer Don't declare testing::TempDir() in dump.cc itself.
2019-10-11 junyer Split out the fake testing::MallocCounter into its own file.
2019-10-11 junyer Remove the fake test_tmpdir flag in favour of testing::TempDir().
2019-10-10 junyer Remove the comment on NumCPUs().
2019-10-10 junyer Call .range(0) explicitly rather than just .range().
2019-10-10 junyer Move NumCPUs() into regexp_benchmark.cc.
2019-10-10 junyer Migrate to the new benchmark API.
2019-10-10 junyer Implement the new benchmark API as a layer over the old benchmark API.
2019-10-09 junyer Tidy up the ersatz benchmark library.
2019-10-07 junyer Move pod_array.h and sparse_{array,set}.h from util/ to re2/.
2019-08-26 junyer Partial revert of commit 7a10064.
2019-08-26 junyer Adjust a thread annotation.
2019-08-13 milkovic.marek Improvements in install target generated by CMake
2019-08-26 junyer Simplify the plumbing for re2.pc.
2019-08-19 junyer Add Clang 9 to the Travis CI matrix.
2019-08-19 junyer Don't assume that iterators are just pointers.
2019-08-18 junyer No, it was right before. Try the /cygdrive form.
2019-08-18 junyer Try under 'C:\Program Files (x86)' instead. Sigh.
2019-08-18 junyer Ensure that CMake is in the path on Windows.
2019-08-18 junyer Comment on why we pin to Visual Studio 2015.
2019-08-18 junyer Attempt to avoid VCVARSALL.BAT breakage entirely.
2019-08-18 junyer Attempt to address VCVARSALL.BAT breakage. Sigh.
2019-08-18 junyer Argh. Try a different flag.
2019-08-18 junyer Try to upgrade Bazel harder on Windows.
2019-08-18 junyer Upgrade Bazel before trying to build with it.
2019-08-18 junyer Switch to Starlark for C++ rules.
2019-08-15 junyer Configure Kokoro to run CMake builds on Ubuntu.
2019-08-15 junyer Configure CMake to require version 3.5.1, which is what Xenial has.
2019-08-15 junyer Upgrade Travis CI from Trusty to Xenial.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Change-Id: I2ecc4256aae4bb5ea7766857e2ed53bd5f624b79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861714
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706417}

https://skia.googlesource.com/skia.git/+log/7274850f96f2..083a75d6762c

git log 7274850f96f2..083a75d6762c --date=short --no-merges --format='%ad %ae %s'
2019-10-16 csmartdalton@google.com Revert "Reland "ccpr: Unblacklist Qualcomm with msaa""

Created with:
  gclient setdep -r src/third_party/skia@083a75d6762c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Bug: None
Change-Id: Ief90067b1b30106bb0305628e70aa221019cb0aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864452Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706416}

This CL adds net_base_address_tracker_linux_fuzzer.

Change-Id: I89c7c087f7c9c85deabcaf7d265bdc88564c312d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863151Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706415}

https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..cc071e45bb9c

$ git log 1093c4de2..cc071e45b --date=short --no-merges --format='%ad %ae %s'
2019-10-16 enga Split generation of dawncpp headers from libdawncpp
2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling
2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests
2019-10-15 senorblanco clang-win compile files for skia-dawn.
2019-10-15 cwallez Add dawnGetProcAddress.
2019-10-15 cwallez Split the libdawn target in components with a single purpose.

Created with:
  roll-dep src/third_party/dawn

TBR=kbr@chromium.org
BUG=dawn:22

Change-Id: Ib61611e5455abf1b66f33b1b68c311a428c3bf9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864683Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706414}

The tests aren't failing locally.

TBR=altimin@chromium.org
Bug=976218

Change-Id: Ic5e8c3984584f7388c80bee64da40ce4e88deebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864780Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706413}

This CL converts MdnsListenClientPtr and Binding<MdnsListenClient>
in chrome and services to the new Mojo type, and
uses pending_remote<T> in host_resolver.mojom.

Bug: 955171
Change-Id: Ie1821bd2d5edbbbcfc14ce8380053ce9cfaa2be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860535
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#706412}

This reverts commit 50b0289b.

Reason for revert: UDPSocketTest.TestUnexpectedSequences fails.
Bug: 1014916

Original change's description:
> Roll Fuchsia SDK from 889950275648 to 889947586298
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
> Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
> TBR=cr-fuchsia+bot@chromium.org
> 
> Change-Id: I654114143b038a86cc813bd5ce57508260abed5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#706330}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org

Change-Id: I1b5fbffa51bb3ecef38f2d370c89902ff33c911f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864710Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#706411}

https://chromium.googlesource.com/catapult.git/+log/44806300adbd..fc9cfb00f341

git log 44806300adbd..fc9cfb00f341 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 perezju@chromium.org [Telemetry] Add new LegacyPageTestCase

Created with:
  gclient setdep -r src/third_party/catapult@fc9cfb00f341

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:999484
Change-Id: Iaf35530fcda2e136fa909dc5b7a76e6705d38838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706410}

This reverts commit 9293d5c8.

Reason for revert: this is breaking compilation on linux-builder-perf.
https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/120938

Original change's description:
> GCC: Fix base::internal::InvokeFuncImpl
> 
> GCC doesn't like that the Value data member has no out-of-line
> definition. The problem is triggered specifically only when compiling
> 
>   components/services/leveldb/leveldb_database_impl.cc
> 
> which has lambda functions returning locally-defined classes.
> 
> The current code works as-is in C++17 mode which introduces the concept
> of inline variables, but in C++14 we need either an explicit out-of-line
> definition or a function member instead of a data member.
> 
> Use std::integral_constant for defining the value.
> 
> Bug: 819294
> Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io>
> Cr-Commit-Position: refs/heads/master@{#706384}

TBR=dcheng@chromium.org,jdoerrie@chromium.org,juri.valdmann@qt.io

Change-Id: I14e3e77219874f186fb04d63ee657630e8ee73fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864782Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706409}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b6fd37fa6f9..00170cc5e6fb

git log 1b6fd37fa6f9..00170cc5e6fb --date=short --no-merges --format='%ad %ae %s'
2019-10-15 afdx@google.com spirv-fuzz: Refactor 'copy object' and 'construct composite' transformations (#2966)
2019-10-15 dneto@google.com Update SPIR-V binary header test for SPIR-V 1.5 (#2967)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@00170cc5e6fb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
TBR=radial-bots+chrome-roll@google.com,jmadill@google.com

Bug: None
Change-Id: Ib1188523fb6a7f3aa600343d516260fe09f81d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864577Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706408}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f410c266cfa..48014ea23a48


Created with:
  gclient setdep -r src-internal@48014ea23a48

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ib5e5ab6296229caa19236c86552bc3b8555c3b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864459Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706407}

Echo cancellation is mainly for video conferencing. Disable it in CCA
could save ~10% cpu on Nocturne in video recording.

Bug: b:139788862
Test: Record video on Nocturne, measure performance by pprof and top.

Change-Id: Ib531c338a46e9a6c611e269ade1e96541be764ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864757Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706406}

This patch keeps the focus on the main menu
when changing from undocked back to docked again.

Bug: chromium:1002424
Change-Id: Ic36f3e6852cb4e0a43ced6387dfeb3e2491d1d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798344Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706405}

This patch uses the descriptions from composititing_reasons.cc
when tracing layers but transfers the reason via their short
name to make it compatible with LayerTree.compositingReasons
from the devtools protocol.

Bug: chromium:737838
Change-Id: Id019d725d51ae7b740ab10bd94a470c8a053bc0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800410Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706404}

Test is flaky for search/india and social. See bug.

TBR=sullivan@chromium.org

Bug: 1014661
Change-Id: I2c098f543ed2f6acd2575e821a21328e474735c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863379Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#706403}

This is based on the original change: https://chromium-review.googlesource.com/c/chromium/src/+/1478489

The goal is to be able to capture the peak of GPU Memory usage. So that we can
detect regressions caused by changes in gpu code/skia

In order to do this we are introducing the PeakGpuMemoryTracker in content/
This can be used to connect to the GPU service, to request the peak
memory seen over an interval.

The GPU service expands the MemoryTracker class with an Observer.
GpuChannelManager implements this in order to aggregate the memory
allocations. It responds to requests from content/

A new UMA group "Memory.GPU.PeakMemoryUsage" has been added, with
"TabChange" as the initial implementation. We will use the new API to
record the max memory seen during a tab change.

Bug: 908462
Change-Id: Iadb959b895edc7b2e756a812972b8410353ed571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756206
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706402}

Nigori is a special datatype because failing to commit local changes
(e.g. custom passphrase set) can lead to problematic scenarios (e.g.
user data exposed unencrypted) or in rare cases complicated
conflict-resolution scenarios (e.g. keystore rotation took place before
committing the custom passphrase) that worst-case cannot be resolved
synchronously (e.g. keystore keys are missing and hence keys are
pending for some time, until keystore keys are received).

It's very hard to universally reason about all side effects of local
commits and conflict resolution cases. Instead, this patch introduces
infrastructure that adopts the command design pattern to concisely
represent what the intended local change is.

Local changes may now fail to apply, in particular if there is a
conflict. But in such case the infrastructure allows dealing with the
failure, with custom logic that depends on the precise command type.

Similarly, success is only reported once the commit is acked by the
sync server, which is a desirable property and useful foundation for
future work. This may introduce additional latency in the existing UX,
e.g. while setting up a custom passphrase, but manual tests indicate
that it's not noticeable.

In this patch, only the infrastructure is introduced without actually
adopting it for the various local changes. Future patches will take
care of such adoption.

Bug: 922900
Change-Id: Ib55d3a401f1f68a1a910ee1e2b9119889d4f73b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864770
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#706401}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/810ee9415435..692ad2ff20be

git log 810ee9415435..692ad2ff20be --date=short --no-merges --format='%ad %ae %s'
2019-10-16 engeg@google.com chromite: make ResponseNotReady python3 compat

Created with:
  gclient setdep -r src/third_party/chromite@692ad2ff20be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I32207fdf87a8a0e032ba77ba6d87cf7e8dcc372c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864486Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706400}

- Refactored VAPID key manager to separate get key and refresh key
- Derive from sync secret if kSharingDeriveVapidKey is enabled
- Observe for VAPID key source changes, refresh cached key and
  re-register if cached VAPID key has changed

Bug: 1010968
Change-Id: I178a6cd931ad41ab0184dd8a511e8ac0569e2269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848171
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706399}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74f3784d..be181e24

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65adae7dbf5021bc194eebd35424cb303610720d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864870Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706398}

Convert the remaining bits in both the implementation and clients from the
browser and renderer processes for the XRInputSourceButtonListener
interface.

Bug: 955171, 978694
Change-Id: I2647b973b9784061918030bd2fb5f10e04b98212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844995Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#706397}

- As a follow-up of https://crrev.com/c/1841451, return the ECPrivateKey
  directly to avoid unnecessary hashing

Bug: 1010968
Change-Id: Iff13d775f511ba031eba33d63e4d47403d205280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863297
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706396}

.. by calling PeerConnectionDependencyFactory::GetWebRtcWorkerThreadRtcThread()
directly.

This is now possible, after [1], where
peer_connection_dependency_factory.cc|h is moved to Blink.

[1] https://crrev.com/c/1805159

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I7e1a516dff8ffbfbe69101a70b02b3da71e3b632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807396
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706395}