GitLab

The CFBundleBlocker's functionality is largely replaced (albeit without
an explicit allow-list) by code signing with library-validation and the
hardened runtime. Those code signing options also prohibit the program
text modification that mach_override performs, so it can be deleted.

Bug: 850193
Change-Id: Ieec7bf98d27f03a47140ac8abcf5e910db2eb01f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675912Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672268}

Add a README doc to educate people on developing new UI features that
support dark theme.

Bug: 941819
Change-Id: Ic364ab8dd4751a3e468b5d365b111fcbab682211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666611
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672267}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6abe28c3..ee5d757d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iccbe1a6634e536326526a4ac116d9661ed8e15c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677184Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672266}

This histogram has been tagged obsolete for 9 months,  let's remove it.

Bug: 974918
Change-Id: Ic6a260147a80fc29c737bd127517827bcf69344f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663503
Auto-Submit: Jonas Olsson <jonasolsson@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672265}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b9a1021d5b7d..c4ba097f066d


git log b9a1021d5b7d..c4ba097f066d --date=short --no-merges --format='%ad %ae %s'
2019-06-25 52076061+digit-google@users.noreply.github.com Fix BUILD.gn for Chromium build. (#741)
2019-06-25 52076061+digit-google@users.noreply.github.com BUILD.gn fixes for Fuchsia. (#733)


Created with:
  gclient setdep -r src/third_party/shaderc/src@c4ba097f066d

The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com

Change-Id: I433e7c17ebaf34ce2790de03cfcb8da1accc7caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676825Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672264}

We want android_browsertests to run a full Chromium browser. The piece
of Java code that owns the various top level UI is the
ChromeTabbedActivity, so we want to use that. We make our test activity
inherit from that, and thus instantiate its own NativeTest and run it
when Chromium Java startup is complete.

We copy a number of services and activities over from the Chromium
AndroidManifest.xml which are referred to during initialization and
cause exceptions to be thrown when not present. Long-term we should
merge the browser test activity into the main Chromium manifest file
and optionally use it when building android_browsertests.

We add some dependencies for various pieces needed to run a full
Chromium browser, that fail to load at runtime otherwise.

We remove the initChromiumBrowserProcessForTests() method which is
now unused as browser tests inject a replacement for ContentMain()
but otherwise use the regular startup paths.

We also remove the handlePostNativeStartupSynchronously() paths as
they are not used anymore. This is done as part of pumping the Java
startup tasks.

R=jbudorick@chromium.org

Bug: 961849
Change-Id: I4c59c450c2ad2da39473331e82a3f4959f33897c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672197Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672263}

Change-Id: I4a7dae4534339ec2f203efa3860d5b8a9e5e9ba4
TBR: lanwei@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677127
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672262}

If we don't remove the VerdictCacheManager on Shutdown, it attempts to
access the HostContentSettingsMap after it's been destroyed, leading to
a crash.

Bug: 978412
Change-Id: I88329185de8e3b70f353d781680b564e633e0d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676445Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672261}

Since we finished analyzing memory impact and cache performance,
we will deprecate Net.Cors.* metrics as we originally planned.

Bug: 975268
Change-Id: I7922d6f80135099c277a0e1e6277405e903ee967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670731Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672260}

Only changes docs.

This adds `adb install`'s signature mismatch error to the
troubleshooting. I realized this may happen if a Googler has installed
an official build of Chrome Debug (signed with dev-keys) and then tries
to install a locally compiled SystemWebView.apk with the same package
name, but without `use_signing_keys = true` (which is not generally
required for the quick-start).

This may be uncommon, but it's certainly possible and there's no reason
not to document it.

Bug: 918221
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I4c4de1209e0222e226445a907ed9bf6ad528a222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676683Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672259}

Currently TextPaintTimingDetector and ImagePaintTimingDetector dumps a
trace event whenever it finds a new candidate. However, the event won't
not be generated when the "loading" category is disabled. When we have
any preparation cost for the trace event, the cost would be wasted in
this case.

For this reason, we add a check in this change. We check whether the
event category is enabled before preparing the trace value.

In addition, we whitelist trace_event_analyzer.cc for blink tests
so that we can test the code path of enabling/disabling the trace
category.

Bug:976894,978475

Change-Id: Ibca63be435f7f96b2bad64fa3aaffe2df8ba232e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676230Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672258}

Bug: 972742
Change-Id: I5f17dcf6aea9a6182a30e844a1003ffce7d0c020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647357Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Cr-Commit-Position: refs/heads/master@{#672257}

Since this string is now fixed, there's no advantage to loading it from
gstatic, so let's just hard-code it to avoid the network delay (and
potential for showing an empty message box if the load fails).

Note that this also disables telemetry for clicks on the website link.
I don't think we've ever found that very useful so I'm okay with losing
it, but LMK if you disagree.

Change-Id: I8d066970b9b0a96c467b50e90bdfe87be272a5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677244Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672256}

Adding a function to detect when a renderingcontext2d has pattern and if
it is accelerated. Using that to handle the case when the pattern is big
and unaccelerated and it is being copied to an accelerated canvas.
Falling down to unaccelerated.


Bug: 969713
Change-Id: I32fa5170e9a45528bfe1233317f252d396e733b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671387
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672255}

- OfflineContentOnDino is launched
- AutoFetchOnNetErrorPage will be a new field trial

See crbug.com/887670 for launch bug

Change-Id: Ibdae9ba0e10bc950781cbe4aac86d6597b990eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667544Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672254}

This reverts commit 4860e09b.

Reason for revert: Cause of compile failure on win32-archive-rel (https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/1912)

Original change's description:
> DNR: Add filter_list_converter tool.
> 
> Filter List Converter is a tool to convert filter list files in the text format
> to a JSON file in a format supported by the Declarative Net Request API. It can
> either output the complete extension (with a manifest file and a JSON ruleset)
> or just the JSON ruleset.
> 
> This is based on the ruleset converter module in the subresource_filter
> component.
> 
> BUG=972290
> 
> Change-Id: Id67ccaa5cc3cc469da67865c3754b41182d1ab9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1139592
> Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672233}

TBR=lazyboy@chromium.org,dpranke@chromium.org,csharrison@chromium.org,karandeepb@chromium.org

Change-Id: I30c97f1d4a37414258ef627b827bf7d099053aaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 972290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677249Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672253}

This reverts commit fa0a6456.

Reason for revert: Reverting again after confirming that this change turned a flaky test into a consistently crashing test.

Original change's description:
> Add support for FIFE Avatar URL format
> 
> The method GetAvatarImageURLWithOptions() is updated to support
> image URLs coming in the FIFE Avatar URL format.
> 
> This should resolve issues related to color-inverted account images
> on the Chrome surface.
> 
> Bug: 911332
> Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672116}

TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org

Change-Id: Ic6d0b1b4080c2c795a2c60ae7bdec85324ad1751
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 911332,978578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676836Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672252}

Added to v8 in https://crrev.com/c/1675963.

R=jwd@chromium.org
CC=​ahaas@chromium.org

Bug: chromium:978425
Change-Id: Ie02378eb6075f537dd66ee70ef6438bac779e702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676166Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672251}

The current bio enrollment implementation in the virtual CTAP2 device
is stateless and does not have any storage. This CL makes it stateful
by tracking enrollments, remaining samples, and current enrollment
state.

Note that I am also considering switching the list of enrollments from
vector<pair<vector<uint8_t>, string>> to map<vector<uint8_t>, string>
for readability and simplified code in the virtual device. Feedback on
that idea would be much appreciated!

Bug: 974046
Change-Id: I8d2b1b5963b37989aea02d32596a34bbbbd6e774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666801
Commit-Queue: Matthew Webb <noviv@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#672250}

Bug: 977168
Change-Id: I2571bd8bb63eaa2049d8f80520c6d7f176ad2519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677066Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672249}

Incorporate a feature flag around PDF document subsetter metadata to
switch between enums indicating HarfBuzz or sftnly subsetters. The
metadata is later passed down to Skia, which will use the appropriate
subsetter. The feature flag, named "HarfBuzz PDF Subsetter," can be
toggled on chrome://flags.

Change the Skia build config to enable HarfBuzz's subsetter, meaning
that both HarfBuzz and sfntly will be available. The addition of
HarfBuzz adds a temporary 24kB to Chrome, with the intention of later
removing the 50kB that comes with sfntly.

Move printing_export.h to a new target to avoid a circular build
dependency. This is also a good first step in reorganizing the
'printing/' directory.

Original CL by Hal Canary [1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1531173

HarfBuzz as a PDF font subsetter through a Finch experiment.

Bug: 931719, 976905
Binary-Size: Increase is temporary and necessary for validating
Change-Id: Ibe67c6c13c5c2379124188a943763076360e9b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659130Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672248}

This CL removes the word 'modern' from the rest of the media controls
code.

Bug: 884215
Change-Id: I502c6717a8ce15d667e3fce0bd1726038aca2f76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677104Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672247}

Also adds support for showing the context menu on the All Apps button
with just the search entry.

Bug: 978458
Change-Id: I8c6a1229a84a7b60de2567c298ae1128096e9ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677064Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672246}

Change-Id: I68f882e5e906b66f23808067b1039dc8789accc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651062
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672245}

Bug: 974811
Change-Id: Ie7d2b0cffaa96a908b5c5a905b3e4e928452a436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658651Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672244}

https://skia.googlesource.com/skia.git/+log/69881fb0b5fb..234e27e5e242


git log 69881fb0b5fb..234e27e5e242 --date=short --no-merges --format='%ad %ae %s'
2019-06-25 jcgregorio@google.com Upgrade cipd package for vpython to latest.


Created with:
  gclient setdep -r src/third_party/skia@234e27e5e242

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@google.com

Change-Id: I05cc486134ce87aab0fa36c857fd4f7f80cf8c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676859Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672243}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52ceb42ee515..a74ad478c04c


Created with:
  gclient setdep -r src-internal@a74ad478c04c

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=reillyg@google.com,yhirano@google.com,futhark@google.com

Change-Id: Ib9e0a53304a9313ae7b5083d4ef297ad93e0b66a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676858Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672242}

The test is looking for an app called "Chromium", but on Google-branded
builds the app is called "Chrome".

Bug: 977737
Test: AppListClientImplBrowserTest.OpenSearchResult
Change-Id: I5666ae8f97c8b41e1119ba3f6150020b109c969c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674347Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672241}

Previously we checked for network connections, which gave a false
positive if the connected network had no internet connection.

The network connectivity is checked using the (new) CrosNetworkConfig service.

TBR=msarda@chromium.org

Bug: 960956
Change-Id: Id315812b3db1f5445ffdfb95011638e48abafd19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643953
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672240}

This converts a couple of the easy throttles that just needed to get
data from Profile instead of ProfileIOData, as well as converting
IsSafeRedirectTarget which now uses ExtensionRegistry instead of
extensions::InfoMap from ProfileIOData.

TBR=bsazonov@chromium.org

Bug: 824844, 976990
Change-Id: Iffb2ba970beeb4aacc0057b2f8ea6c6e0dd4b810
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671588
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672239}

<cr-input> had a mixin of --cr-input-row-container that was incorrectly
defaulting the value of the `justify-content` property to normal. When
the mixin was removed, <cr-input>s that relied on that value broke.

Bug: 978337
Change-Id: I37aaf6e260f901714cd6b4068a2f785bb19d2179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676745Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672238}

When a <network-config> element is used to configure a network
without also connecting to it, it was possible for it to get stuck in
an unresponsive state. In saveAndConnect_(), we either call
networkingPrivate.createNetwork() or
networkingPrivate.setProperties(), depending on the network's source.
In the createNetwork() callback, we previously did not close the
dialog, resulting in a dialog that stays open and does not respond
when the "Save" button is pressed.

This CL closes the dialog in that case and refactors the element so
that the same code path is used for both methods of network
configuration.

Additionally, this cleans up a check in internet_page.js to use !! to
force a boolean value.

Bug: 974737
Change-Id: Icca3148d854c645586e5dc0ed0749f6f99a5e362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674412
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672237}

Per discussion at:
https://chromium-review.googlesource.com/c/chromium/src/+/1665909/4

This CL is a preliminary CL for the above CL. This CL moves ItemAdapter
out of the ItemChooserDialog so that it can also be used by
BluetoothScanningPermissionDialog in the above CL.

Bug: 960960
Change-Id: I9e08b7dc43b7de6b8c7ca55c3ed3cf4d1693ead7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669908
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672236}

Bug: 895581, 879906
Change-Id: If67cbc221834449b84c2c9491890e06afa10f138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666911Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672235}

This reverts commit 911ea514.

Reason for revert: Earlier revert was a mistake. The failing test is flaky.

Original change's description:
> Revert "Add support for FIFE Avatar URL format"
> 
> This reverts commit fa0a6456.
> 
> Reason for revert: UserImageManagerTest.SaveUserImageFromProfileImage failing in browser_tests and viz_browser_tests.
> 
> Bug: 978578
> 
> Original change's description:
> > Add support for FIFE Avatar URL format
> > 
> > The method GetAvatarImageURLWithOptions() is updated to support
> > image URLs coming in the FIFE Avatar URL format.
> > 
> > This should resolve issues related to color-inverted account images
> > on the Chrome surface.
> > 
> > Bug: 911332
> > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888
> > Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#672116}
> 
> TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org
> 
> Change-Id: I70e2b5b7940158668ce455286cf3d3d8ac679b10
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 911332
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677157
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672221}

TBR=reillyg@chromium.org,msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org

Change-Id: Ic2eb6a7974cb0ac46dfb4524c1b971f897f0a751
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 978578, 911332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677247Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672234}

Filter List Converter is a tool to convert filter list files in the text format
to a JSON file in a format supported by the Declarative Net Request API. It can
either output the complete extension (with a manifest file and a JSON ruleset)
or just the JSON ruleset.

This is based on the ruleset converter module in the subresource_filter
component.

BUG=972290

Change-Id: Id67ccaa5cc3cc469da67865c3754b41182d1ab9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1139592
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672233}

Bug: 790202
Change-Id: I85de5a5e47f198c988148313107f65a546d4283d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677009
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672232}

https://android.googlesource.com/platform/external/perfetto.git/+log/db8b1cb70185..e39534277469


git log db8b1cb70185..e39534277469 --date=short --no-merges --format='%ad %ae %s'
2019-06-25 treehugger-gerrit@google.com Merge "Add support for opening traces from postMessage."
2019-06-25 fmayer@google.com Merge "tools/heap_profile: update trace_to_text prebuilt to handle interned state"
2019-06-25 lalitm@google.com Merge "Ignore exited processes for startup metrics"
2019-06-25 lalitm@google.com Merge "gn: fix incremental build of descriptor when changing transitive deps"
2019-06-25 lalitm@google.com Merge "trace_processor: fix process names for new short lived processes"


Created with:
  gclient setdep -r src/third_party/perfetto@e39534277469

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I45fd032da57dadb8b500d9083822cb08881be39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677029Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672231}

Bug: None
Change-Id: Ib855d479aa435d401de37496990eecc307a89eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676678Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672230}

This adds a DeleteCredentials() method to CredentialManagementHandler to
support deletion of multiple credentials identified by the
CBOR-serialized PublicKeyCredentialDescriptor.

It also extends EnumerateCredentialsResponse with the CBOR-serialized
PublicKeyCredentialDescriptor such that the UI can use it as an opaque
identifier for the credentials without having to do CBOR-serialization.
The FidoAuthenticator::DeleteCredential is changed to take
PublicKeyCredentialDescriptor rather than a sequence of bytes to
identify the to-be-deleted credential.

On a CTAP2 level, credentials are identified for deletion not just via
their credential ID but via the full PublicKeyCredentialDescriptor. The
spec is unclear on whether the non-ID related fields ('transports' in
particular) are significant or not. Hence, it's probably wise to just
echo the descriptor as it was received during credential enumeration,
rather than send an empty descriptor with only the credential ID.

Bug: 955859
Change-Id: Id1b7a9094876c701b21000399870bf439de4d8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674411
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672229}