GitLab

After this change, ContentElement should only be used for the main
web content. PlatformUiElement can be used to host platform UIs (such
as View on Android).


Bug: NONE
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If068d52d3134b5e1f70392523fdbfa4c047d1081
Reviewed-on: https://chromium-review.googlesource.com/1049961
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557177}

Also added a test to verify the argument.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5655f92b64251a89b1bea9eb1e42b146ff4a7e73
Reviewed-on: https://chromium-review.googlesource.com/1050413Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557176}

This CL slightly modifies the crazy linker to extract the DT_SONAME
of a given shared library. The goal is to use the soname as the unique
identifier for a library during dependency resolution, as this matches
the behaviour of the system linker.

More precisely:

- Before this CL, each library loaded by the linker is identified
  by a "name" that was the library path (with any directory sub-path)
  used to load the library.

  This prevents properly resolving DT_NEEDED entries, which explains
  one of the reasons why the crazy linker doesn't support the
  component build at the moment.

- After this CL, system libraries are identified by their basename
  only (which was already the case when they were loaded through
  DT_NEEDED entries, but changes what happens when they are loaded
  through the dlopen() wrapper).

  Ideally, non-system libraries should be identified by the soname,
  but this currently doesn't work, because it breaks RELRO sharing.
  The reason for this is that, when loading libraries directly from
  a zip file, the current client code (chromium_android_linker)
  passes and relies on the path to the host APK directly
  (e.g. something like /data/data/<package-name>-<number>/base.apk
  and a file offset. This will be addressed in a future CL.

BUG=802068
R=lizeb@chromium.org, pasko@chromium.org, agrieve@chromium.org

Change-Id: Ia282c29e80e8729c4079a80de7acf66975b7d1ee
Reviewed-on: https://chromium-review.googlesource.com/1042406
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557175}

This CL adds the images for the activity service, the add/edit bookmarks
and the ReadLater images.

Bug: 834299, 829718
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I03b9d19f04f7cfd2558ecf8ac468a14c14984b13
Reviewed-on: https://chromium-review.googlesource.com/1052107Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557174}

Following bot results are included.
5268 5272 5279 5284 5292 5295 5298 5302 5305

3 lines were removed and 2 lines were deflaked by consecutive
results since 5218.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5a967922b2921fef4663b9f950ac90f04177b835
Reviewed-on: https://chromium-review.googlesource.com/1050045
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557173}

Bug: skia:7765
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I2147e4450f134473b059399b67d58633d277e5bd
Reviewed-on: https://chromium-review.googlesource.com/1044787Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#557172}

This cl decouples the fling controller client for sending events from
the fling controller client for scheduling and progressing the fling.

The FlingScheduler implements the fling controller scheduling client.
It schedules fling by either adding the FlingController as an animation
observer to ui::Compositor or by Calling SetNeedsBeginFrame if the
compositor is not available.

BrowserSideFlingBrowserTest.TouchpadFling
TBR=nasko@chromium.org

Bug: 823310,249063
Test: BrowserSideFlingBrowserTest.TouchscreenFling,
Change-Id: I8c104daf41f87abdf0a78f3cb3d51274f279424b
Reviewed-on: https://chromium-review.googlesource.com/994181
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557171}

Currently Chromium will build the related fuzzer for an image codec
when the codec has been disabled. This hasn't been an issue so far,
since the PDFium BUILD.gn is still building the codec code even when
it is disabled. It is just building it with a macro that disables the
logic.

This behaviour is going to soon change in PDFium, to having the codec
code not being built at all when it is disabled. This will break the
Chromium fuzzer builds. This CL turns off building the fuzzer when the
related fuzzer is disabled.

BUG=pdfium:1080

Change-Id: I6b1ff78c5b379fac9c29ca38b79c133c3d1367bb
Reviewed-on: https://chromium-review.googlesource.com/1050702Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557170}

This CL fixes the testWebViewIsFirstResponderUponKeyPress test which was
failing for iOS 11.3+. The changes in iOS 11.3+ is that the WKWebView is
the first responder instead of the WKContentView.

Bug: 830124, 837564
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9b5c343579657c5db9d3973820e5c67ae495bcb4
Reviewed-on: https://chromium-review.googlesource.com/1052008Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557169}

A recent bug surfaced the fact that old clients (prior to USS) don't
handle well the case where invalid tab specifics are received over the
sync protocol (namely, with an invalid tab ID).

In the particular case of orphaned foreign tabs, i.e. tabs that have
been overriden -same tab ID- by a different sync entity -different tab
node ID-, the situation is problematic. AFAIK, these entities would only
be submitted by a USS client when custom passphrase is enabled, leading
to crashes in all devices a user is syncing with.

Fortunately, the USS implementation is behind a feature toggle and has
never been enabled or experimented with.

Bug: 840876
Change-Id: I20c9272b735f0515f4bf8c0e9fd15ca31c2113a0
Reviewed-on: https://chromium-review.googlesource.com/1051234
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557168}

If the user deletes urls from history for a specific day we only delete
navigations if there are no additional visits outside this time range because
url are not reported as being deleted to history observers unless all visits
have been removed.
To fix the issue, the restrict_urls parameter is passed through
HistoryServiceObserver to NavigationEntryRemover in order perform a
deletion for specific urls within the time range correctly.

Bug: 838086
Change-Id: I22226924b3ca9a3d0880aa62548c87d33b093d13
Reviewed-on: https://chromium-review.googlesource.com/1041956
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557167}

Split into separate test fixtures to make it more straightforward.

Bug: 783309
Change-Id: Ife5353fa61a07936c3ccf8c8255f253206038df8
Reviewed-on: https://chromium-review.googlesource.com/1052007Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557166}

This changes a behavior slightly: the task runner is change from
unthrottleable to throttleable. However, there should not be a strong
reason why the task runner should be unthrottled there.

We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading
and replace them with appropriate kInternal* task types.

Task type guideline: https://bit.ly/2vMAsQ4

Bug: 830489
Change-Id: I55519cb83aa40cbf4fd98bcd18a9424aa9a7b882
Reviewed-on: https://chromium-review.googlesource.com/1051308
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557165}

There is a ::i18n::phonenumbers::PhoneNumber and a
::autofill::PhoneNumber. To avoid ambiguity (especially in jumbo
builds where more types are known to more code), refer to
::i18n::phonenumbers::PhoneNumber with the full name inside
autofill code.

Also refer to PhoneNumberUtils from the same namespace the same
way for consistency.

Change-Id: Ic36cae9a8df0ceb07f3494fa34d8b08531cd46e4
Reviewed-on: https://chromium-review.googlesource.com/1050288
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557164}

This flag is holding out a Skia change which fixes a number of shadows.
This removes the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/1050466 to keep
https://review.skia.org/126615 from requiring rebaselines when rolling.

Change-Id: Ibb3af277be20e70e146e805fe1a2e4171742eabc
Reviewed-on: https://chromium-review.googlesource.com/1050203
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557163}

Using wpt-import in Chromium 8fd4e46f.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17183

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=danyao

No-Export: true
Change-Id: I34de3cc2a8864e7f115241e98de3a1c958a92a28
Reviewed-on: https://chromium-review.googlesource.com/1051667
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557162}

Change-Id: Iba6fc2f6d60830a8c745a4355cb4ec1677273435
Reviewed-on: https://chromium-review.googlesource.com/1051134Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557161}

To check for initial enrollment on OOBE, the system will first perform a
|DeviceInitialEnrollmentCheckRequest| exchange with the device
management server.
If the result of this exchange is that the device should be
force-enrolled, it will use |DeviceInitialEnrollmentStateRequest|
to query which domain it should enroll into.

Bug: 839353
Test: compile. Actual test will be added in a follow-up CL that uses these protos.
Change-Id: Iaa83065f339f9c49cb7af25c9e1e34bbdd1ad176
Reviewed-on: https://chromium-review.googlesource.com/1042186
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557160}

This is a temporary change that will be reverted once crashes can be
analyzed to confirm the working theory.

Bug: 836875
Change-Id: Iaeffbd6c78b604af66b33991392990d71648d4a9
Reviewed-on: https://chromium-review.googlesource.com/1050071
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557159}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I58e94995d48d4493f5c3bb91ab7e2c7f241b9aa6
Reviewed-on: https://chromium-review.googlesource.com/1051867
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557158}

BUG=762641
TBR=sammiequon@google.com

Change-Id: I427347e23b428da6344f13de9c826e2858ffb975
Reviewed-on: https://chromium-review.googlesource.com/1051947
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557157}

Bug: 837440
Change-Id: I216c457b53e795d229228e03df8dad42ac78dc07
Reviewed-on: https://chromium-review.googlesource.com/1049654Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557156}

The TabUnderProtectionEnabled policy was renamed to TabUnderAllowed in
CL:995632.
Rename the value in enums.xml too.

Bug: b/77374536
Change-Id: I0eede70c436b4e5260cb02e19838f2d22528594c
Reviewed-on: https://chromium-review.googlesource.com/1035322Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557155}

This CL implements the remote creation of bookmarks on the server.
It take many shortcuts that will be addressed in later patches such as
a naive ordering algorithm that assumes all bookmarks are created
under the bookmarks bar directly.

Bug: 516866
Change-Id: I10059fd3b7521927fb4db6b9ce0284f33fadead8
Reviewed-on: https://chromium-review.googlesource.com/1017201
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557154}

EmbeddedFrameSinkImpl enforced that it only created a
CompositorFrameSink one time. This doesn't work well with OOP-D and
isn't the approach taken for CompositorFrameSinks, so just remove that
condition. This will destroy the old CompositorFrameSinkImpl and create
a new CompositorFrameSinkImpl.

Bug: 768565
Change-Id: I7dcfdc35bd33fcb20544c22baa7417eaf84011b7
Reviewed-on: https://chromium-review.googlesource.com/1050436Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557153}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I30970fd51dd869abd73b1b16109e44178fbcee2e
Reviewed-on: https://chromium-review.googlesource.com/1051688
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557152}

This patch changes |CharacterIterator::CurrentContainer()| to return
|const Node&| instead of |const Node*| since it always non-null for improving
code health.

This patch is a follow-up of the patch[1].

[1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return
const Node&.

Change-Id: If2dc187244e4e8a489b56f9855b786c191579d9b
Reviewed-on: https://chromium-review.googlesource.com/1051138
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557151}

This patch changes |DocumentMarkerController::AddMarkerToNode()| to take
|const Node&| instead of |const Node*| since it always non-null for improving
code health.

This patch is a follow-up of the patch[1].

[1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return
const Node&.

Change-Id: I7041a969f730d07fcccaa8d745b6f2cb02ecbaab
Reviewed-on: https://chromium-review.googlesource.com/1051068
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557150}

This cl adds an initial support for Ozone (Linux) builds by
utilizing DekstopWindowTreeHostPlatform design.

Actually, it looks very similar to DesktopWindowTreeHostX11 with
a difference that this design in this CL uses Ozone abstraction
layer to communicate with Wayland and other backends.

In overall, BrowserDesktopWindowTreeHostPlatform, which is actually
DesktopWindowTreeHostPlatform, is created and initialized, which triggers
creation of a PlatformWindow, which can be either Wayland, or X11, or other
ozone platform.

Also, DesktopScreenOzone class is added. This object inherits ScreenBase and
is meant to fetch displays data from underlaying ozone backends and provide
aura with necessary data.

Bug: 578890

Change-Id: I2d203cd6d1a6ddea0afe062059c6c1f9eecdafd3
Reviewed-on: https://chromium-review.googlesource.com/1039567
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557149}

This patch changes |DocumentMarkerController::RemoveMarkersInternal()| to take
|const Node&| instead of |const Node*| since it always non-null for improving
code health.

This patch is a follow-up of the patch[1].

[1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return
const Node&.

Change-Id: I246eedf7cc4bb651d50ff0b6d50065e89f2312a3
Reviewed-on: https://chromium-review.googlesource.com/1051137
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557148}

TBR=tommycli@chromium.org

Bug: 841195
Change-Id: If5dca6a78dba27e63a01acd0ef7606f7e9eb78ea
Reviewed-on: https://chromium-review.googlesource.com/1051648Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557147}

This updated takes any stored changestamps for directories and for the
ResourceMetadataHeader and convers them to startPageTokens, which essentially
just adds 1 to the current value and writes it out as a string.

Bug: 840211
Change-Id: I0e5d736daae632a85d55fa549bae3ffdf81f0584
Reviewed-on: https://chromium-review.googlesource.com/1051213Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557146}

This CL fixes the animation occuring when opening a new tab in
background when the flag to enable BrowserContainer fullscreen.

Bug: 836730
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifa1abee606888938fe3b551903e16f92c7c60698
Reviewed-on: https://chromium-review.googlesource.com/1032772Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557145}

This patch changes |TextIterator::CurrentContainer()| to return |const Node&|
instead of |const Node*| since it always non-null for improving code health.

Change-Id: Idb0a827d78afe7a8b27e398db7023527a2f2380a
Reviewed-on: https://chromium-review.googlesource.com/1050053
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557144}

Bug: 793025
Change-Id: I433fd34af2ef79c5f29761c9f0aea8a794682842
Reviewed-on: https://chromium-review.googlesource.com/1047827Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557143}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Bug: 841171
Change-Id: I4c23bacf4f44799b63cebefe51a5f94965408bd8
Reviewed-on: https://chromium-review.googlesource.com/1051263
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557142}

This CL implements UniqueRendererFormId and UniqueRendererFormControlId
methods in forms and form control elements correspondingly, which
return consecutive numbers of the current form and the form control
element in the current renderer process. Hence these ids are unique in
the same Renderer process modulo unsigned int overflow (which is not
the problem for Password Manager and Autofill).

Details go/blink-form-stable-ids

Bug:831119

Change-Id: Ie0c54363bc069b0f8953a3238ccd08262c7efd3c
Reviewed-on: https://chromium-review.googlesource.com/1002847
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557141}

ReadIfReady() either completes synchronously, or notifies the caller
when it should be called again, rather than completing asynchronously.

Bug: 841180
TBR: xunjieli
Change-Id: I70258381380feea49279cb81a7f285f2b1d11f01
Reviewed-on: https://chromium-review.googlesource.com/1051447
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557140}

This patch expands ComputeSelectionType at call site
because if selection is none can be caught more early and
logic is now simple.

Change-Id: I6d5c7a7279097fbe0312d29cbf009d7424ff519b
Reviewed-on: https://chromium-review.googlesource.com/1051211
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557139}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9520b5b98bd3..7aaefdbb734f

$ git log 9520b5b98..7aaefdbb7 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 cmtice Re-enable CFI on caroline and terra release builders.
2018-05-08 ayatane sysmon: Fix error reference

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:838428,chromium:840873


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If6a4c93d5ee5c6ce8af44cb19895b5ce12b72dcb
Reviewed-on: https://chromium-review.googlesource.com/1051325Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557138}