GitLab

Changes between original submission and reland:

1.) Privacy-page subpages are now in lazy_load.html
2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings.
3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled.
4.) Reordered a few settings rows to match the most current mocks.

> Revert "Friendly Privacy Setting Initial Redesign"

> This reverts commit 544412a4.

> Reason for revert: Performance and functional regressions
> https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5

> Original change's description:
>> Friendly Privacy Setting Initial Redesign
>>
>> This CL does 3 things:
>> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag.
>> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on.
>> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag.
>>
>> Bug: 1014143
>> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088
>> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094
>> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
>> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
>> Cr-Commit-Position: refs/heads/master@{#714287}

Change-Id: If3fa33801604491b8648672ff53d37a818f2cd08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929443Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721579}

R=carlosk@chromium.org, harringtond@chromium.org

Bug: 1028976
Change-Id: I63e361cae052c1fb274cfefa9791b20ea9f596cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949449Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721578}

The permissions for the chrome.usb API was already removed earlier
(https://crrev.com/c/1916860).

Bug: 995294
Change-Id: I73468cf202f0d4137744aa5d127e663839569e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949796
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721577}

The method called to show the dialog used to take 9 parameters and the
list was growing. This CL bundles the parameters into a separate contents
object which requires the mandatory values to be passed in the constructor
and offers reasonable defaults and setters for the rest of the values.

In addition, some properties of the model are not actually meant to be
changed on the fly, so they are now marked readonly and set before building
the model. This requires a separate initialization step in the coordinator
and mediator.

Bug: 1028947
Change-Id: I4f121e5fee88d095d6c31add59111639e85faedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948931
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721576}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/576b9e489dca..c4eacc1612b6

git log 576b9e489dca..c4eacc1612b6 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 brgoddar@microsoft.com Coverage: Add title for visualization in coverage tool
2019-12-04 obrufau@igalia.com [css-pseudo] Expose ::marker pseudo-element in devtools tree (front end)
2019-12-04 yangguo@chromium.org Remove outdated extract_module script

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c4eacc1612b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:457718,chromium:963183
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ica48896b556d628525500cc39608aa3b3cd389d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950845Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721575}

- Replace CallJavascriptFunctionUnsafe('deleteHistory') with a
  FireWebUIListener() call.
- Remove global deleteHistory function in history.js and forwarding
  in app.js, and directly listen for the event in history_list.js.
- Add a test verifying that the event is correctly handled.

Bug: 1022212
Change-Id: If6f2f62dbe1bfa8c94313c32e448f892e8072c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947906
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721574}

This commit adds -Wno-deprecated to the relevant target's cflags for
non-mac builds. If we ever update XCode's bison version to 2.7 or
better, we will be able to replace '%pure-parser' with
'%define api.pure full' in xpath_grammar.y.

Change-Id: Ib0390d7c91828c095a86eb07acb854f09fa13060
Bug: 1028421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948245Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721573}

Using wpt-import in Chromium 6a67c60a.
With Chromium commits locally applied on WPT:
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"
a75430aa "Fix appcache tests."
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."
83e4a43b "Refactor VRPose to fit better with WebXr concepts"
a93be69b "Update reversing-an-animation test"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I84ba940af0ae8a965033238d77b513f6cfe6ae2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950885Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721572}

This patch is similar in spirit to the desktop equivalent changes in
https://chromium-review.googlesource.com/c/chromium/src/+/1924572.

The overall idea is that, if encryption keys are missing, the UI needs
to display this state as an error, and the user should be able to go
through a reauth flow to retrieve the keys.

The actual logic to trigger the key retrieval process is deferred to
future patches and reflected in TODOs.

Bug: 1012659
Change-Id: I0679e47f8c783fdfd2953989205964165b0f8147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930796
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721571}

Converting media/base to use BindOnce/Repeating as appropriate.

Bug: 1007799
Change-Id: Idc4cc28073203337983b87844eb1e5268adcb133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947229Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721570}

This CL converts base::Bind to BindOnce or BindRepeating, and also changes
relevant base::Callbacks or base::Closures to appropriate types.

This skips one base::Bind() call because it would require changing the
BluetoothAdapterClient::PauseDiscovery() API as well, so we leave it for
another CL.

R=hansberry@chromium.org, reillyg@chromium.org

Bug: 1007760
Change-Id: I6ac8b334a364a791adecbd5d93fe6935c72a9045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944630Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721569}

This addresses a side effect of crrev.com/c/1934836, that stretches all
children. Default gravity for linear layout positioned items always on
top.

Bug: 1030722
Change-Id: I1a981be06feb2126c04f36aa7306b64beb68de9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950856Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#721568}

Permanent bookmark nodes are created server-side and don't contain a
originator client item ID. Hence, they should be filtered out for this
histogram, otherwise they contribute to the left-empty bucket which is
precisely a problematic bucket that is expected to be practically zero.

Bug: 978430
Change-Id: I3bc75145c4ec5fc46489789b538a8ce62be5594f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947645Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721567}

Bug: 1027610
Change-Id: I6e2a7914a6f8694185f33e49d59a06cff21ef598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947557Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721566}

This closes SharingDialogViews when the main frame navigates to a
different origin. Right now this only affects the SharingDialog and
(for CrOS) the IntentPickerBubbleView but will be enabled for all
subclasses of LocationBarBubbleDelegateView in a subsequent change.

Bug: 1027408
Change-Id: I07ca9ce55042265d85e56a84c5e43efa3cb026d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948839
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721565}

The DCHECK was introduced long ago in
https://chromiumcodereview.appspot.com/11522009 where it may have been
necessary, but in today's implementation the code does not rely on
ThreadTaskRunnerHandle.

The DCHECK is a proxy for verifying that a global field trial list
exists, which can be checked more directly via the value returned by
FieldTrialList::AddObserver().

The patch is motivated by DCHECK failures observed recently on ios
after the codepath has been triggered from the sync thread, due to
https://chromium-review.googlesource.com/c/chromium/src/+/1827368.

Bug: 1011088
Change-Id: I075c28f86962c88b9331290c1b57f2da8a3af755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844992
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721564}

ios WebView does not integrate with variations, but the actual
production code WebView relies on may assume that there an instance,
leading to DCHECK failures.

This was surfaced by integration tests where, despite base::TestSuite's
attempts to instantiate FieldTrialList via FeatureListScopedToEachTest,
and due to shared libraries leading to ODR violations affecting
FieldTrialList::global_, DCHECKs could fire (mostly prevented landing
additional DCHECKs).

Bug: 1011088,1018667

Change-Id: I7ff3b356bd246c5f0a9b8776ae6d372bfd4a9df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950518Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721563}

It was found that BulkPrintersCalculatorFactory is leaking state between
tests and causing flakiness.  Change ownership from a singleton to an
object owned by chrome_browser_main_parts_chromeos to guarantee that only
one ever exists during tests and in production.  To accommodate this, adjust
users of the factory to handle a null factory which will occur during unit
tests and shutdown.

Bug: chromium:1015949, chromium:966561
Change-Id: I61eb5bc9e37363e95d26e8b07ae0cb0d5087c275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888517
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721562}

Ensures test coverage for active CryptAuth v2 Enrollment field trial.
See
https://chromium.googlesource.com/chromium/src.git/+/master/testing/variations/

See also cl/283612634.

Bug: 899080
Change-Id: Ibcee32294949352d48c8281ca793a5a7feb0321b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950666
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721561}

Disable it on ChromeOS release builds for being flaky.

TBR=dmurph

Bug: 1030733
Change-Id: I44db0ed9e8fce4c94d5e4833b2a88666c63eb27b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951084
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721560}

This reverts commit b344f6f2, while
keeping the buildbot changes which are safe to keep.

Bug: 967716
Change-Id: Ie983fb911aaa80f90536df1fd5c50dfc66927692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951146Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721559}

This change adds an IsAffiliationBasedMatch data member to the
UiCrendential class. This is intended to be used to determine whether
a credential is backed by an Android credential, and intends to replace
checking whether the UiCredential's origin_url starts with "android://".

This allows changing  UiCredential origin_url to be an url::Origin
instead of a GURL and update its name to origin. Lastly, this change
performs some minor clean-ups and updates effected tests.

Bug: 1030230
Change-Id: I3331b29541c88984fe5d17f9f11fd0d0fdb79b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948837
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721558}

This CL changes the accessibility label for Join Other button in tray
menu from "Join other..." to "Join other WiFi networks" to give more
context when using screen readers.

Fixed: 1027362
Change-Id: Id88e17add4fadd51671ebcfcbd40835a2564a114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949529Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721557}

Right now the chromedriver test testActionsMultiTouchPoint is slightly
flaky after we wait 100 ms for the page layout loading, we increase the
waiting time to 1000 ms to avoid flakiness.


Bug: 1011225
Change-Id: I9e8fcdf19522a5775171585af4f16b35fe69c615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951083Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721556}

https://android.googlesource.com/platform/external/perfetto.git/+log/b64ff931eb98..0eccc52635b4

git log b64ff931eb98..0eccc52635b4 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 eseckler@google.com processor: Actually propagate string pool size config to TraceStorage

Created with:
  gclient setdep -r src/third_party/perfetto@0eccc52635b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1026682
Tbr: perfetto-bugs@google.com
Change-Id: I23a617de1a67cb6d9e3b9d4098434446034ce135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950853Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721555}

Change-Id: I71a7ae90419fb5da9e5d65e99e59e0fb14d9e069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948051
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721554}

Plus two other cleanups as a follow-up to http://crrev.com/c/1927974

Bug: 607777
Change-Id: I5633c5e61b4c865b5623759f5ae05371edb66610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949004Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721553}

This adds the file as an EG2 target and updates #includes.

Bug: 987646
Change-Id: I10ff2d45efc784f36f2a394bfd75289617a78e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950851Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721552}

Add Packaged License screen before Login screen if device packaged with
license.


Bug: 1024809
Change-Id: I8bc6359658e352f1369ecb8ac94a2133a3eba756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924434Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#721551}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e99f60bbee4f..db3c93975a8f

git log e99f60bbee4f..db3c93975a8f --date=short --first-parent --format='%ad %ae %s'
2019-12-04 9856269+sarahM0@users.noreply.github.com spvc: Add missing APIs for HLSL support in Dawn - set_decoration (#924)

Created with:
  gclient setdep -r src/third_party/shaderc/src@db3c93975a8f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I7844561416b8bb11e74c342039f106f729f4ab95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950855Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721550}

On the removal the old parser on CL
https://chromium-review.googlesource.com/c/chromium/src/+/1814832
Password Manager started to send all forms the browser process, while
only forms with password fields are needed.

Bug: 875768

Change-Id: I7e212a5e8b0ad7a438666644b4a20c3f9437ab12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950504
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721549}

Bug: 901465
Change-Id: I4582ab90f20bb2acd1ed8f6bdfb08818ea5808b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950852
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721548}

Since the test uses a RunLoop now instead of MessageLoopRunner, the
Quit action will exit the RunLoop immediately, terminating the timer
and preventing CheckAnimation() from running again. We could pass a
OnceClosure in, but since RunLoop is on the stack, passing a pointer
to it is slightly more straightforward with less indirection.

R=vasilii@chromium.org

Bug: 1030275
Change-Id: I27efc585f8d63f7d9204288b45ed2d4b22b77b43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947559Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721547}

Adds a URL to the PaintPreviewProto. This is a simple addition that is
used to attribute the Paint Preview to originating from a URL. This only
applies to the root frame rather than any of its children.

Bug: 1030419
Change-Id: I59028fbebf3305cb52b04fca9c190712a2bb40f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949280
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721546}

Make ChromeWebViewPermissionHelperDelegate and
ChromeContentRendererClient work when building on desktop with plugins
disabled.

Bug: 1027360
Change-Id: I0fff3732718169432b1595fbecf497fbaf074975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949463
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721545}

Sample Histogram Recording
Histogram: WebUITabStrip.TabDataReceived.06_20 recorded 1 samples, mean = 31.0 (flags = 0x41)
0   ...
29  ------------------------------------------------------------------------O (1 = 100.0%) {0.0%}
34  ...

BUG=1016031

Change-Id: Icd415eb90e7afb81ff371517f5835b3aecfb794c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947814
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721544}

This adds the following debug URLS:
  - chrome://memory-pressure-critical/
  - chrome://memory-pressure-moderate/

These URLs will be useful to improve our memory pressure handlers.

Change-Id: I70e709c57a19661f7c268128e467fd93f87034a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940748Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721543}

Context: the Bottom-sheet Payment Handler UI observes the load finish
of the WebContents. Upon observing that, the UI check the validity of
the page of the payment handler app, and if invalid, close the page.

Old behavior: closing the invalid payment handler crashes.

Cause: because the load finish hook is called within WebContents, when
the hook tries to destroy WebContents itself, it causes a crash.

Change: defer destroying WebContents until WebContents is not being
used.

New behavior: Payment Handler UI destroys WebContents outside of the
observer hook. So the crash is fixed.

Bug: 1029995
Change-Id: I7968daaad793a949808fc30e6f08b03bb19c330f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949057Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721542}

Move the Wi-Fi configurations to UserSelectableOsType. Change the
ModelTypeController to respect the global "OS sync enabled" pref.
Refactor the printers ModelTypeController to share code.

Note: This means Wi-Fi config sync cannot ship before Split Settings
Sync.  However, it's much simpler than trying to support Wi-Fi config
being *both* a UserSelectableType and a UserSelectableOsType.
I've discussed this with the engineer working on Wi-Fi sync and we're
both OK with this plan.

Bug: 1013466
Test: existing components_unittests and unit_tests
Test: Run --enable-features=SplitSettingsSync,SyncWifiConfigurations
  and verify "Wi-Fi configurations" appears in Chrome OS settings.
  Verify turning it off and closing settings results in
  chrome://sync-internals showing that the Wi-Fi type is not syncing.

Change-Id: I878fecaf449248ae8747e37aa2e0e897130e63ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947396Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721541}

The code which read this policy was removed from Chrome Remote Desktop
in M76 but it looks like we did not officially deprecate the policy at
that point.  This CL marks it as deprecated and lists the last host
version which supports it.

Change-Id: I14e1dc3d5fc061703fc94f93ba7b75861b3fa317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949229
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721540}