- 05 Jun, 2019 40 commits
-
-
Xiyuan Xia authored
Bug: 958228 Change-Id: I7fbe6243e15daaf800f720f4b022360124ec661f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642962 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#666296}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971262 Change-Id: I0a5a2b0ea5cb6d046b0efbdbb4c67637afb015aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645130Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666295}
-
Robert Ma authored
Bug: 935698 Change-Id: Icdc04204eba3f98f1dd34e26be694d48887a068a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641520Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#666294}
-
Adam Langley authored
(Accessors like |GetUnsigned| will crash if the type of the value is anything unexpected.) Change-Id: Ic7c5e0971b00e2c566d32b18efc620780ee7c96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636649 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#666293}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971259 Change-Id: Idc4025936bf8a3275a7d52567c93bf2b047f08a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644837Reviewed-by:
-
Karolina Soltys authored
I'm saving to TLS the current task executor on registration, and providing it for the base::CurrentThread() trait. Bug: 968047 Change-Id: I753213ff57249ed55d10cb0a576ec56975a4088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642562Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#666291}
-
Daniel McArdle authored
Change-Id: Ie7ce5e6567d78c7a96da355c8413062c23344335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641369 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666290}
-
Mario Sanchez Prada authored
This interface used to be referenced from blink::PushController and implemented by content::PushMessagingClient, but now those two classes are gone we can safely remove this unused API. Bug: 939943 Change-Id: Id0cbf05091234f94fa69e0b65e1079d92afbdf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631596 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666289}
-
Karolina Soltys authored
I'm adding a trait specifying that the task should run on the current thread. It will be one of the 3 possible destinations (alongside ThreadPool and BrowserThread), specifying which will be made mandatory in a future CL. A future CL will add the desired functionality backing this trait. Bug: 968047 Change-Id: I16f244911b9e25da354148b034bd766c988dec11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642559Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Daniel McArdle authored
This CL improves the fuzzer coverage of ParsedCookie's mutator methods (SetName, SetValue, etc.). It also adds a check for the property that serializing, deserializing, and then reserializing a valid cookie produces the same cookie line both times. Change-Id: If2db605195daf2a7e77a8dded4b391281eb83c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643754Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#666287}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 781935 Change-Id: I9973c749525060323531229f997e5da1adee76f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645379Reviewed-by:
-
Claudio DeSouza authored
Having rendering_representative_perf_tests on testing/BUILD.gn adds a dependency into the //chrome tree for the //testing build process. This CL merely moves the target to //chrome/test in order to remove this dependency spread. Change-Id: Iae6b25d5ddcf8d014f4ca9f8a47499244980b04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635812 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666285}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971256 Change-Id: I3ac4e30183589e472541eb62ffe56f977efb962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644834Reviewed-by:
-
Yuki Shiino authored
This is a quick fix to remove v8::Persistent from IDL callbacks. V8PersistentCallback{Function,Interface}Base should be removed in a follow-up patch. Change-Id: Ic6526252749e6d70c8c02092ae0b07716702e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645713Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#666283}
-
Etienne Bergeron authored
This CL is removing useless forward declaration and unused include file. There is no behavior change. R=robliao@chromium.org, asvitkine@chromium.org CC=benck@google.com Bug: 944227 Change-Id: Ifcda56f000119dd3682eff2e7665f59a49c84ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643381Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#666282}
-
Yeol authored
When calling AddView from AddLabelledRowToGridLayout, released unique_ptr to pass to argument. Bug: 948287 Change-Id: I71373a27ee7b8c7ae3bf8c1fdb8eed86b806eac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644889 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Liquan(Max) Gu authored
ImagePaintTimingDetector has an overflow issue in multiplying two integers (height*width). In this patch we will use rect.Size().Area() to compute the size. As the function has handled the overflown issue properly, we can use it to fix the bug. The fix has been verified with a local run of the Cluster Fuzz. Bug: 969295 Change-Id: I67fda6339bbcbc8346b02397031d9a73c3c61f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643091Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666280}
-
Jose Dapena Paz authored
When RenderProcessUserData is destroyed from the destructor of RenderProcessHostImpl, it is done in the destructor of RenderProcessHost. At this point RemoveObserver override is already freed, so RenderProcessHost is pure virtual. This crash happens at least building with GCC: at /usr/include/c++/8/ext/new_allocator.h:140 (this=0x7fffffffcb50, __in_chrg=<optimized out>) at /usr/include/c++/8/bits/stl_tree.h:964 We need to destroy RenderProcessUserData before that happens. To do that we can just override RenderProcessHostDestroyed. Bug: 910288 Change-Id: I38107b178829b0cb7494f5333b765e5b087d82cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645366 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666279}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971252 Change-Id: I1b93944ca76b422c7b8c4972e161326717a612c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645475Reviewed-by:
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971241 Change-Id: Ib0e2541601ee7eef544ff5d5a0a9adc46f54762f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645793Reviewed-by:
-
Robert Ma authored
Also add Fuschia to the port list (should have been done in https://crrev.com/c/1640796). Bug: 958017, 567947 Change-Id: I872e95652477f472fc1f54421b08425900dbc283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643840Reviewed-by:
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971247 Change-Id: If2170d68287e5021e25986cc4dd875ca864c53fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645812Reviewed-by:
-
Vladislav Kuzkokov authored
Everywhere where needed the copy in PrintedDocument is available. Bug: 964948 Change-Id: I34a7e1eaddb884f5e0bff9710767ed03eda96ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631598Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666274}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 971241 Change-Id: I373aa360faa185ff15ff940fea5dd622b376d86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645160Reviewed-by:
-
kylechar authored
This CL adds temporary detailed logging for all the failures cases in the CopyOutputResult deserialization code. https://crbug.com/967856 is the result of a deserialization error and I haven't been able to reproduce it on a dev machine. Add logging so it gets picked up in canary or dev release to give more insight. Bug: 967856 Change-Id: I3b390c3ba9800f5c7f19d75a3cc0b9457c39d2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643495 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#666272}
-
Yuwei Huang authored
Bug: 965746 Change-Id: I0d9b31fea543ee0b9e661f2025bc9133863f9dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643786Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#666271}
-
Mark Cogan authored
After the switch to use WebStateListObserver instead of TabModelObserver, BrowserViewWrangler will get a notification that the active webState is changing when the app quits (the active webState is changing to nullptr). This in turn causes a call to -updateDeviceSharingManager, which explodes when there's no active WebState. The fix is to not call -updateDeviceSharingManager with a nullptr new active web state. Bug: 968475 Change-Id: I78b25c627d311d2e2a3f152e8cd8f663161962bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645230 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#666270}
-
Ehsan Karamad authored
TestNavigationThrottle::Status seems unused. Removing with this CL. Bug: None Change-Id: I69ba98e5b9eaa976861ada7dc772ca7f794d4115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642019Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#666269}
-
Xiyuan Xia authored
Bug: 958229 Change-Id: I444c8a563c328efcbfebe1426ddec692d41a171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643757Reviewed-by:
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 922951 Change-Id: Icdf09cc7c60f19ef7aaf8fa32503445f5c3c617c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645202Reviewed-by:
-
Pavel Shmakov authored
Based on flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_out_of_process_chrome_public_test_apk&tests=org.chromium.chrome.browser.profiling_host.ProfilingProcessHostAndroidTest TBR=erikchen@chromium.org,tedchoc@chromium.org Bug: 970205 Change-Id: Ia2164945ceecab937403e4c69e0d407b454e61d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645228 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666266}
-
Mario Sanchez Prada authored
This is no longer used now that we have removed PushMessagingClient from //content/renderer, so we can safely remove it. Bug: 939943 Change-Id: If7074fb428b25f16482d91940d84c48fd71bc3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631403 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6dc12884b53..bc5e8283ebb0 Created with: gclient setdep -r src-internal@bc5e8283ebb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I78823431426d4de688a5c4c1adde19a018626765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666264}
-
Elly Fong-Jones authored
On the slower macOS bots, this test sometimes takes ~150ms longer than kLargeResponseTimeoutMs for some of the timeout tests, so bump up the threshold for success. Bug: 905265 Change-Id: I0a968a0075d5ea7448f327a07ec36389de25fe7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642737 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: Ib0b41739551932824fc383dc869a3f9f5ab7dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642637 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#666262}
-
Jit Yao Yap authored
Change-Id: I41a7558c411870a106a7f5766f68c91a136ad579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645354Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#666261}
-
Pavel Shmakov authored
Disable flaky ServicificationBackgroundServiceTest#testHistogramsPersistedWithServiceManagerOnlyStart TBR=hanxi@chromium.org,tedchoc@chromium.org Bug: 970190 Change-Id: Iddad9df7ad507ede7f164e6702a535fd0ae2bcbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645227Reviewed-by:
-
arthursonzogni authored
Previously, navigation to a MHTML subframe was handled by the renderer process. This CL makes it use the normal path (e.g. driven by the browser process). After this and two other edge cases (about:blank, about:srcdoc) will be removed, then every navigation to a new document will be driven by the browser process. * Stricter enforcement could be added for https://crbug.com/943610. * It unblocks RenderDocument https://crbug.com/936696. Note: Some error pages will still be able to be driven by the renderer process. Others related CLs: * https://chromium-review.googlesource.com/c/chromium/src/+/1578544 * https://chromium-review.googlesource.com/c/chromium/src/+/1547522 Bug: 936696 Change-Id: If030dcc43dcc038a588285a639ea08b755310094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#666259}
-
Xida Chen authored
TBR=gayane@chromium.org NOTRY=true Bug: 856601 Change-Id: I03801abfea02047bbe200958d7a8bc7a560c7710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644994Reviewed-by:
-
Denis Kuznetsov authored
Bug=b:133461735 Change-Id: Ib75f9977dd9b5aa044fa9844dfcf35f27e0fd548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628718Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#666257}
-
