- 17 Aug, 2016 40 commits
-
-
ehmaldonado authored
that is failing. The idea is to recover some of the coverage that the other tests provide. BUG=625808 Review-Url: https://codereview.chromium.org/2241223002 Cr-Commit-Position: refs/heads/master@{#412507}
-
zqzhang authored
BUG=638532 Review-Url: https://codereview.chromium.org/2251013002 Cr-Commit-Position: refs/heads/master@{#412506}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5312417..d69d22b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2249183004 Cr-Commit-Position: refs/heads/master@{#412505}
-
xiaochengh authored
This patch removes parameter |node| from the above mentioned function because it can always be computed as the root editable element of |insertedRange|. This patch is a preparation for reducing the use of TextCheckingParagraph in spell checker, since TextCheckingParagraph was introduced for synchronous spell checking which no longer exists now. BUG=619452 Review-Url: https://codereview.chromium.org/2241293006 Cr-Commit-Position: refs/heads/master@{#412504}
-
raphael.kubo.da.costa authored
The dependency on glib is only present because we need to call g_type_init(), but commit 9d47fa16 ("Add calls to g_type_init") has moved the call to ProxyConfigServiceLinux, which is what actually uses it. R=pauljensen@chromium.org,mmenke@chromium.org,xunjieli@chromium.org Review-Url: https://codereview.chromium.org/2240793003 Cr-Commit-Position: refs/heads/master@{#412503}
-
srirama.m authored
Cleaning appcache video http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Review-Url: https://codereview.chromium.org/2252663002 Cr-Commit-Position: refs/heads/master@{#412502}
-
siva.gunturi authored
1.Handle the test inside window.onload. 2.Change image src of same size. This triggers img.onload. 3.Check for no layout on src change. BUG=638288, 637859 Review-Url: https://codereview.chromium.org/2250323002 Cr-Commit-Position: refs/heads/master@{#412501}
-
keishi authored
BUG=591606 Review-Url: https://codereview.chromium.org/2210483002 Cr-Commit-Position: refs/heads/master@{#412500}
-
yhirano authored
BUG=587663 Review-Url: https://codereview.chromium.org/2250353002 Cr-Commit-Position: refs/heads/master@{#412499}
-
tommyt authored
This change enables the stopNotifications function for remote GATT characteristics on Android. In order to do so, two distinct refactorings have been done; 1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class. 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications. BUG=584370 Review-Url: https://codereview.chromium.org/2051333004 Cr-Commit-Position: refs/heads/master@{#412498}
-
ioanap authored
TBRing for trivial rename in: c/b/android/browsing_data/browsing_data_counter_bridge.cc c/b/android/preferences/pref_service_bridge.cc TBR=bauerb@chromium.org BUG=620317 Review-Url: https://codereview.chromium.org/2230243002 Cr-Commit-Position: refs/heads/master@{#412497}
-
lizeb authored
Content type mapping is done in two places: in ResourcePrefetchPredictor, and in ResourcePrefetchPredictorObserver. The first one is undesirable, since it overrides the resource type set at URL request time. Remove the duplication, and move the summary creation to ResourcePrefetchPredictor. This will make it easier to add tests as well. BUG=631966 Review-Url: https://codereview.chromium.org/2228003002 Cr-Commit-Position: refs/heads/master@{#412496}
-
svartmetal authored
C++ reference says: "Unless otherwise specified, all standard library objects that have been moved from are placed in a valid but unspecified state" (http://en.cppreference.com/w/cpp/utility/move). According to this, current CL fixes UB related to |LayerTreeHost::swap_promise_list_| and |LayerTreeImpl::swap_promise_list_| incorrect usage. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2245053002 Cr-Commit-Position: refs/heads/master@{#412495}
-
yhirano authored
Having both kinds of copyToVector is confusing, and no one uses this function. BUG=None Review-Url: https://codereview.chromium.org/2249393002 Cr-Commit-Position: refs/heads/master@{#412494}
-
tobiasjs authored
This gets in the way of generating minidumps in WebView, and also interacts badly with the DumpWithoutCrashingToFd implementation. BUG=633979 Review-Url: https://codereview.chromium.org/2245403002 Cr-Commit-Position: refs/heads/master@{#412493}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a289b68e..e5312417 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2255493003 Cr-Commit-Position: refs/heads/master@{#412492}
-
guidou authored
Original CL https://codereview.chromium.org/2249963002 didn't actually add the DISABLED_ prefix. BUG=635032 TBR=aboxhall@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2250363002 Cr-Commit-Position: refs/heads/master@{#412491}
-
yosin authored
This patch converts "editing/deleting/delete-3608462-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_with_redundant_space.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2248033004 Cr-Commit-Position: refs/heads/master@{#412490}
-
mvanouwerkerk authored
Revert of [Android] Remove some dead code in CompositorViewHolder (patchset #1 id:1 of https://codereview.chromium.org/2248793003/ ) Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=638535 This crashes due to: 08-17 10:49:47.072 15523 15523 W System.err: java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to android.support.design.widget.CoordinatorLayout$LayoutParams 08-17 10:49:47.073 15523 15523 W System.err: at org.chromium.chrome.browser.compositor.CompositorViewHolder.updateContentOverlayVisibility(CompositorViewHolder.java:808) Original issue's description: > [Android] Remove some dead code in CompositorViewHolder > > After https://codereview.chromium.org/2241643003, Tab#getView() will > only return the wrapper framelyout that wraps infobars, content view or > native page view. This work simplifies the logic in > CompositorViewHolder. > > BUG=635871 > > Committed: https://crrev.com/01dca5c74d54e47c725ae94d7714884bf51f21af > Cr-Commit-Position: refs/heads/master@{#412133} TBR=dfalcantara@chromium.org,ianwen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635871 Review-Url: https://codereview.chromium.org/2250113003 Cr-Commit-Position: refs/heads/master@{#412489}
-
stkhapugin authored
Since find pasteboards are unavailable on iOS 10, this CL removes usage of UIFindPasteboard, replacing it with a simple static NSString variable BUG=630563 Review-Url: https://codereview.chromium.org/2250433003 Cr-Commit-Position: refs/heads/master@{#412488}
-
yosin authored
This patch converts "editing/style/relative-font-size-change-00[1-4].html" to use w3c test harness and integrates into "relative_font_size_change.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2250943002 Cr-Commit-Position: refs/heads/master@{#412487}
-
haraken authored
We stopped returning an empty handle from toV8(). Now we can remove the IsEmpty() check for the handle returned by toV8(). Also this CL removes ActiveDOMCallback::isScriptControllerTerminating. The check shouldn't have been necessary because if the ScriptController is terminating, ScriptState::contextIsValid() returns false and we won't reach the check in the first place. BUG=625512 Review-Url: https://codereview.chromium.org/2200263005 Cr-Commit-Position: refs/heads/master@{#412486}
-
eseckler authored
checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 Review-Url: https://codereview.chromium.org/2247313002 Cr-Commit-Position: refs/heads/master@{#412485}
-
vitaliii authored
BUG=635893 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2228553003 Cr-Commit-Position: refs/heads/master@{#412484}
-
hyungwook.lee authored
BUG=637509 R=hongchan@chromium.org,rtoy@chromium.org Review-Url: https://codereview.chromium.org/2159403002 Cr-Commit-Position: refs/heads/master@{#412483}
-
haraken authored
UserMediaController should follow the lifetime model used by other Supplement objects of LocalFrame. This CL doesn't change any behavior. BUG=610176 Review-Url: https://codereview.chromium.org/2206533003 Cr-Commit-Position: refs/heads/master@{#412482}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/2c947a8..ecae934 $ git log 2c947a8..ecae934 --date=short --no-merges --format=%ad %ae %s 2016-08-16 noahric@chromium.org Add a gyp/gn option to use dummy audio file devices. 2016-08-16 honghaiz@webrtc.org Do not switch a connection if the new connection is not ready to send packets. There is no benefit of making such switches. 2016-08-16 zijiehe@chromium.org Currently there is not way to programmically test whether a ScreenCapturer implementation can accurately capture updated regions. Especially in ScreenCapturerWinDirectx, which has a specific updated region spreading logic and cannot be tested through regular code path. So we need a controllable ScreenDrawer to draw some basic shapes on the screen. And a platform independent test case can use the ScreenDrawer to test a ScreenCapturer. 2016-08-16 honghaiz@webrtc.org Change the default backup connection ping interval to 25 seconds. 2016-08-16 danilchap@webrtc.org Cleanup RtcpReceiver::TMMBRReceived function 2016-08-16 minyue@webrtc.org Revert of Adding audio to video_quality_test. (patchset #10 id:230001 of https://codereview.webrtc.org/2136573002/ ) 2016-08-16 minyue@webrtc.org Adding audio to video_quality_test. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2249403002 Cr-Commit-Position: refs/heads/master@{#412481}
-
yosin authored
This patch converts "editing/deleting/delete-3608445d-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_then_nbsp.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2253693003 Cr-Commit-Position: refs/heads/master@{#412480}
-
yosin authored
This patch converts "editing/deleting/collapse-whitespace-3587601-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_map_area.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2253643003 Cr-Commit-Position: refs/heads/master@{#412479}
-
kojii authored
The "const Font& font" argument is not used in InlineTextBox::constructTextRun and all its variants. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2246383002 Cr-Commit-Position: refs/heads/master@{#412478}
-
yosin authored
This patch converts "editing/style/justify-left-crash.html" to use w3c test harness to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2254453004 Cr-Commit-Position: refs/heads/master@{#412477}
-
kbr authored
This is an important configuration to test, and with new capacity added to the Swarming pool, it should be possible to run them again. BUG=638508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2251913002 Cr-Commit-Position: refs/heads/master@{#412476}
-
wychen authored
BUG=638488 Review-Url: https://codereview.chromium.org/2250333002 Cr-Commit-Position: refs/heads/master@{#412475}
-
maksim.sisov authored
Improve the granularity of net-internals logging for upload to be able to discover where the hang is occurring in situations like in the issue 611436. BUG=613337 Review-Url: https://codereview.chromium.org/2227503003 Cr-Commit-Position: refs/heads/master@{#412474}
-
treib authored
and update call sites accordingly. This is the first of probably many follow-ups to https://codereview.chromium.org/2211983002/ TBRing a comment-only change in components/sessions/core/serialized_navigation_entry.cc TBR=marja@chromium.org BUG=627747 Review-Url: https://codereview.chromium.org/2232863002 Cr-Commit-Position: refs/heads/master@{#412473}
-
bugsnash authored
Fixed crash by replacing DCHECK in Node::mutableComputedStyle with returning nullptr if the NodeRareData is not an ElementRareData. Crash introcuded in https://codereview.chromium.org/1962953002. BUG=638102 Review-Url: https://codereview.chromium.org/2241193005 Cr-Commit-Position: refs/heads/master@{#412472}
-
yosin authored
This patch converts "editing/style/style-3681552-fix-002.html" to use w3c test harness and integrates into "typing_style.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2251643004 Cr-Commit-Position: refs/heads/master@{#412471}
-
yosin authored
This patch converts "editing/style/style-boundary-00[1-4].html" to use w3c test harness and consolidates into "style_boundary.html" to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2255683002 Cr-Commit-Position: refs/heads/master@{#412470}
-
yosin authored
This patch converts "editing/style/style-3681552-fix-001.html" to use w3c test harness and integrates into "typing_style.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2250653003 Cr-Commit-Position: refs/heads/master@{#412469}
-
xiaochengh authored
|m_paragraphRange| is a redundant member of SpellCheckRequest because it is always initiated with the same value as |m_checkingRange| [*]. So this patch removes this redundant member. [*] This claim was always true until revision r368035, where I allowed a |SpellCheckRequest| to have two different ranges for the first time, which is an unnecessary change, though. BUG=619452 TEST=n/a; no visible change Review-Url: https://codereview.chromium.org/2252973002 Cr-Commit-Position: refs/heads/master@{#412468}
-