- 04 Jun, 2020 40 commits
-
-
Yi Gu authored
Most TODOs are assigned to the linked bugs. TODOs related to GroupEffect are outdated so they are removed. Bug: None Change-Id: I7b413773904efd93c6b6959545c5d74f7d4760ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227299 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#775276}
-
Dan Harrington authored
AppType 2 is for the test application, but we're using that ID for now. If you use 3, the server responds with no content. Change-Id: Idf4cf0e2df21546d0a644f7502d837225d38ef2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231580 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#775275}
-
Prashant Nevase authored
To facilitate calling dark mode filter at raster time, dark mode filter module will be moved to cc/paint. This change replaces blink::Color by SkColor. Bug: 1091095 Change-Id: I65d888ab5df454592ac0df004b0bbe48e9a093d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167804Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#775274}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If0cc371d15135d1634d20706b1c74e504457a8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775273}
-
Aaron Colwell authored
This change simply allows a valid Handle to be duplicated after ChildProcessSecurityPolicyImpl::Remove() has been called for the process associated with the Handle. Handles are intended to keep security state alive beyond the process lifetime and some Handles are duplicated so they can be passed down into lower level code. This change fixes a bug where Duplicate() would generate invalid Handle objects if it was called after CPSPI::Remove() was called. These calls can happen because of Mojo message queuing and no ordering constraints between different Mojo interfaces. Bug: 977169, 1086306 Change-Id: Icacaf06b049ba88ae7152f5c7307312d73134824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226156Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#775272}
-
Nate Chapin authored
This is necessary for HTML imports, but other cases appear to break. Add a special-case in HTMLImportLoader Bug: 1090440 Change-Id: I85f8e8f9c3846e3e616efd983b4c037ca741122f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229152 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#775271}
-
Sammie Quon authored
Removes shadow before closing from close button, otherwise the scaling animation will leave behind the shadow, which gives a transparent ring look. This isn't need for swipe to close as there is no scaling animation. Test: ash_unittests OverviewSessionTest.CloseAnimationShadow Bug: 981509 Change-Id: I724343e29bcda4663c2a58e02ad7ed833525db9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228125 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#775270}
-
Betul Soysal authored
https://crrev.com/c/2180959 added a histogram to track the success rate of a mount namespace created in the Chrome OS's session manager. Track this on the Chromium side to see them in UMA. BUG=1072160 TEST=validate_format, pretty_print. Change-Id: Ia446d40eb6f3e76785ee3489b3356e905681319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227855 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#775269}
-
Sebastien Marchand authored
Change-Id: I7848f077a6b67623c2d3d6eb48090f7447dfce5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230329Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#775268}
-
Xiyuan Xia authored
Suspect the crash is because an animation observer of a child layer deletes the parent/child when stopping the BOUNDS animation in the Remove call. Also changes a simillar situation in SwitchToLayer. Bug: 1088432 Change-Id: Id9bacb230a9d0a6fa390ae3bc1a0410c983fb049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224031 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775267}
-
Guillaume Jenkins authored
With this change, it is no longer possible to use Windows native spell checking without ALSO using Hunspell as a fallback for unsupported languages. While it technically hasn't been possible for some time due to how the spell check code has evolved, this now makes it explicit. - Removes the kWinUseHybridSpellChecker feature flag - This was initially introduced so other Chromium projects could rely only on the native spell checker if they didn't want to also use Hunspell. However, there is no obvious need for that right now, so it is easier to remove the flag than to fix it. - Code using this flag now instead uses the kWinUseBrowserSpellChecker feature flag. - Removes the USE_WIN_HYBRID_SPELLCHECKER build flag - Similarly, this build flag was used to compile out the Hunspell fallback logic. Since the fallback logic is now mandatory, this build flag can be removed. - Code using this build flag now instead uses a combination of the OS_WIN and USE_BROWSER_SPELLCHECKER build flags. Bug: 1074450 Change-Id: I471a704901ac12d573ba2e5e42a5ef4f19a9cc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226307Reviewed-by:Guillaume Jenkins <gujen@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#775266}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I3ff912a7c22faac3e58f061807213fe89bc3deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231448Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#775265}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1e9759c011a..b674ea36ab2f 2020-06-04 zhin@chromium.org [codemirror] Update CodeMirror to 5.54.0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d0a36a88a713a4818c025e9d67e5661bcaa21df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231246Reviewed-by:
-
Anders Hartvoll Ruud authored
When a style resolve is a cache hit, we don't go through the normal process of applying declarations via StyleBuilder::ApplyProperty. We then also don't set the ChildHasExplicitInheritance flag on the parent style for cache hits. This wasn't a problem a before, since any style with a parent with this flag set could not enter the MPC. However, with MPCDependencies enabled, such styles can now enter the cache, and cache hits for those entries will then fail to set the flag on the parent style. To fix this, this CL adds a new flag HasExplicitInheritance, which pertains to the _current_ ComputedStyle being computed (not the parent). This way we can get the information we need into the MPC, and perform the necessary propagation to the parent style when we need to. TEST=external/wpt/css/css-transitions/inherit-height-transition.html Bug: 1057072 Change-Id: Ic03cdc6377ab5e58d6fe08a6fef2bd7505064f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228535 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#775263}
-
Devlin Cronin authored
If the default search provider was overridden by an extension, we show aprompt to the user confirming it was intentional. This customizes that prompt in different scenarios: - If Google was the old search provider, use "Back to Google" language. - If another search provider from the default list was used, use "Back to <other search provider>" language. - In all other cases, use the generic "Did you mean to change your search provider" language. This requires some fun plumbing in order to determine what the search engine would be, if the extension weren't enabled. In particular, finding the "secondary" search engine from the TemplateURLService. For this, introduce TemplateURLService::GetDefaultSearchIgnoringSource() and DefaultSearchManager::GetDefaultSearchIgnoringSource(), which allow querying for the default engine ignoring any from a specified source. Using this and ignoring the extension source, we should be able to find the "secondary" search engine. Add browser tests and UI tests for each of the dialog options (back to google, back to <other>, and the generic version). Bug: 1079364 Change-Id: I00fec35a7b3e3442fbe89c276513023e9ca12a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218805 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#775262}
-
Sammie Quon authored
Speculative fix for the linked bug. Was unable to repro manually, but created a test case that is plausible that has a similar stack trace. Test: TabletModeOverviewSessionTest.DestroyWindowDuringNudge Bug: 997335 Change-Id: Ib580740b4c059aa30e44af57e895c27b610f1650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225587Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: I634f70491987144d505f75bc93aa6b5b6734754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225341 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775260}
-
Edward Jung authored
Bug: 1088998 Change-Id: Idf5412744f4408b4aca7faeabb9cec1344b0478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228621 Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#775259}
-
Preethi Mohan authored
Bug: 1025371 Change-Id: I12bce9cd3f8f9a62cdb859db6d499b59f6d1a4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219409Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#775258}
-
Jonathan Koren authored
Makes the list of SDKs and the GCS bucket more configurable. Bug: fuchsia/52114 Change-Id: I0f2da8da42486f2fe84c3c71537151e2f5a1781c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181573Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Jonathan Koren <jdkoren@google.com> Cr-Commit-Position: refs/heads/master@{#775257}
-
Eric Orth authored
*Remove unused address-family breakouts *Convert SecureDnsMode times from per-request to per-job as the network stuff (per-job) is where we expect interesting data *Move handling of per-request metrics into RequestImpl for better organization. Slight behavior change of now including "incomplete" requests that were aborted or cancelled for full queue, but seems to be a reasonable simplification for a request-level metric. Also rename these metrics to be more obviously request metrics. *Update expirations to "never" since these are core metrics we want to keep (except the SecureDnsMode metrics). *Update owner on changed metrics to myself. Bug: 1088994,854018 Change-Id: Icabf35e4136ca3a0bad6774aea78bca55f242228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227377 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#775256}
-
Brian Sheedy authored
Adds most of the standard GPU gtests to the GPU CrOS builders. Several test suites are left omitted for now due to widespread failures in them. Bug: 1080424, 1087590, 1087567, 1087563, 1087558, 1087552 Change-Id: I5055d870d445f13fafa626f2d2d8a40afae8b654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219227Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775255}
-
Fabio Rocha authored
Manifest-based registration for protocol handlers should, as much as possible, use the same validation logic used by `registerProtocolHandler`. In order to do that we needed to modify NavigatorContentUtils a bit for some of the validation functions not be dependent on objects not known to the manifest parser (e.g.: Document, ExceptionState..). Instead, we extract some error handling logic out and pass arguments in the format ready to be validated. A subsequent CL will include modifications for the manifest parser to consume from the functions exposed here. Bug: 1019239 Change-Id: I38189e305b67a4ccb9820cbb450546e056774c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227469Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775254}
-
Andrew Xu authored
When calculating the target layout strategy, only two parameters are required: the scroll distance on the main axis and the length of available space to layout shelf icons. In other words, we don't need the scrollable shelf's view bounds which is the third parameter of the current function. This CL should not introduce any visible difference. Bug: 1042911 Change-Id: I57431969cb0bdaee71e5ba2b82faa4fdcc02428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231090Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775253}
-
Jun Kokatsu authored
This change adds Trusted Type policy for parse_html_subset.js, so that sanitization happens without a Trusted Types violation. Bug: 41905 Change-Id: I545d1a7a28b22d56f5c4539a3c20923ab26d6d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215701 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
-
Robert Ma authored
This prevents the server from dying silently in run_blink_[SERVER].py by checking whether the server is alive every second. (See the race condition where the server dies after a seemingly successful start in the linked issue.) Unfortunately, this does not fix run_web_tests.py. Bug: 1090491 Change-Id: Ifb5a73284716a980a752ce3ed9c8210ba9510f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229472 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775251}
-
Lukasz Anforowicz authored
Fields in system headers (and generated) code were not rewritten even before this CL, because |apply_edits.py| ignores edits that apply to files that |git| doesn't know anything about. But, before this CL, such fields would be considered "affected" and therefore Chromium code might see |.get()| appended when using such fields in |printf|, |reinterpret_cast|, etc. Such inconsistency would lead to build errors after the rewrite. After this CL, fields in system headers (and generated code) are explicitly excluded (early on, in the |field_decl_matcher|). Bug: 1069567 Change-Id: Icc9735b94558828c002572b38dcef12a812de35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204305 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Jon Mann authored
This reverts commit c222db59. Reason for revert: Breaks layout of some Chrome OS settings pages including network details and displays. Original change's description: > WebUI: Remove --cr-section mixin > > The CSS rules in the --cr-section mixin are moved into the only CSS > class left using it. A TODO has been added to address the similarity > of cr-row and settings-box, but this should not be considered high > priority. > > Bug: 973674 > Change-Id: I34437c39cb38b6fe0568a243a1eee41900ab6490 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216646 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773978} TBR=dpapad@chromium.org,johntlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973674 Fixed: 1091386, 1091389 Change-Id: Ief47ae2ffb0f7cbfb0e5e0c7331544214a6ac0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231462Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#775249}
-
Ken Rockot authored
The presubmit step for checking mojom backward-compatibility does not work properly when a mojom file is deleted. This is due to incorrect use of the presubmit input API, effectively not providing the checking tool with any information about deleted files. This fixes that. Fixed: 1091407 Change-Id: I4cd3d7bb5ce07a7d75e8bac99319c75ca6d28118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231266Reviewed-by:
-
Sean Gilhuly authored
The test in this filter file is for SkiaRenderer Dawn Vulkan, which is run only on Linux. To avoid possible test numbering collision or confusion, use this filter only on Linux. Bug: 1021566 Change-Id: I2f379093f3bed831e6b3037ee9d653cfeb35d08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225216Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#775247}
-
Robert Ma authored
Originally, I tried to use shutil.copy to preserve the mode of the files, but I found out there were tons of permission violations in the upstream, so I filed a bug * and tweaked the existing workaround. * https://github.com/web-platform-tests/wpt/issues/23997 Bug: 1091205 Change-Id: Id54c466192d671c758f04fcdf81b51eb9ebdf070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231264 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591214254-82dbd7c2e7bf4bdc6dd6038655b6e3a5aff423fd.profdata to chrome-win64-master-1591286362-902781b12ab9dd448871f9768174868838c7d326.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8abdb1dee4fef4ce246073deb27163729e5e7b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230249Reviewed-by:
-
David Schinazi authored
This is part of our effort to eventually make ParsedQuicVersion a class (instead of a struct). This CL does not change any behavior. Change-Id: I43000a2f7bdaa69f2cdf47e82976835d826104fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227316 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775244}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591214254-e18b6c29801bc822569148c5ef87c3e9d9cb875d.profdata to chrome-win32-master-1591286362-6877841deaea578e7b1f46c63cdb9931635faa06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id3d64796123032fc1767b72600756ab61d80ed28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231014Reviewed-by:
-
danakj authored
Delay navigating an iframe until after the main frame has finished loading its document so that, in case the iframe is in another process due to site isolation, the logging from the main frame and the iframe do not race and create flaky results. R=dgozman@chromium.org Bug: 1088441 Change-Id: Id33996ac3a07c307fde2b0fc099e35f1e2f0500f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229402 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775242}
-
Esmael El-Moslimany authored
Bug: 1091367 Change-Id: I8283c28f0bdbb2b1fa87bdab76e2dc508ff6bdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231291 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775241}
-
Daniel Cheng authored
Bug: 1059157 Change-Id: Ie40c9fd6ca3a0fc38a9618ba0c173794a0902903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228190Reviewed-by:
-
Filip Gorski authored
Color tint list for dark theme is behaving differently when: - selected - focused - pressed - activated Fix is to remove the alpha from these states. Bug: 927145 Change-Id: Ifc5409b85135e58c236a57f06432920e8134155d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218494Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#775239}
-
Chris Hamilton authored
This cleans up the scattered hooks in favor of a centralized hook, and tightens up assumptions in production code and in tests. It also cleans up various test harnesses, removing redundant notifications and using standardized harnesses. Change-Id: Iacca86a52e579053670a4e28ce3b7152ecb02a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219184 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775238}
-
Robert Sesek authored
Bug: 1088543, 1088544 Change-Id: I50ac8ec143eee0b931968e9e3aa7170b7f952a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227064 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#775237}
-
