- 21 Jan, 2021 40 commits
-
-
Lily Chen authored
Change-Id: Ife6e67c51e755f38dad7c1795fd2c0979943e67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642829Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#845778}
-
Tomasz Wiszkowski authored
This change adds TILE_NAVSUGGEST suggestion to the list of special match types that are excluded from GroupBySearchVsUrl. Bug: 1165941 Change-Id: I36791175c81289d752b69b01bfddf5844dd12d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641144Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#845777}
-
Austin Sullivan authored
Bug: N/A Change-Id: I3d0b3b83c35b322b650bba7bd636f71f2364275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630009 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#845776}
-
Evan Stade authored
Bug: 1147268 Change-Id: I7b67ba260d5b2f818ee52308a25cec8d496dac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638218Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845775}
-
Ajit Narayanan authored
Records how the Select-to-speak actions of sentence/paragraph navigation and exit were triggered (i.e. through button click or keyboard shortcuts). Bug: 1143814 Change-Id: I17b524d9683f1298ce3cfb4d5fa97fbdc3bc4415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602854Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#845774}
-
Austin Eng authored
This follows the deprecation of the old vertex_idx identifier in the WGSL spec. Bug: none Change-Id: If3cf3d3b985b79b85b9807b17e5458bacd0805dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643238 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845773}
-
Michael Lippautz authored
A past refactoring translated `unique_ptr<TaskRunnerTimer>` to `Member<DisallowNewWrapper<HeapTaskRunnerTimer>>` to preserve semantics. Inline HeapTaskRunnerTimer which avoids a dynamic allocation. Change-Id: Id3c788c3dedab1dbf3022e0d8ebe5dfca47235b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640373 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845772}
-
Jan Wilken Dörrie authored
This change extends expiring PasswordManager and PasswordGeneration histograms and marks "PasswordManager.OtherPossibleUsernamesUsage" as obsolete. R=chromium-metrics-reviews@google.com Fixed: 1165103, 1165104, 1165114, 1165115, 1165116, 1165118, 1165119 Change-Id: Ib2bd28896c05ddb9c24fe7f191299a7e58e39321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632651 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Michael Crouse authored
This is a reland of 3f534050 This resolves the builder issue for neon performance warnings. Original change's description: > Reland "[TFLite] Enable tflite in build for android and desktop." > > This is a reland of a4df03d0 > > This addresses the revert by removing neon from the TFLite build > for chromeos. > > > Original change's description: > > [TFLite] Enable tflite in build for android and desktop. > > > > Bug: 1165517 > > Binary-Size: Expected increase due to inclusion of TFLite in binary. > > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845026} > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > TBR: Andrew Grieve <agrieve@chromium.org> > TBR: Tarun Bansal <tbansal@chromium.org> > Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845478} Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. Change-Id: I6f3b3a4a8b4bfda89eae49f9c24b684ff8ec8dab Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642742 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845770}
-
Yuwei Huang authored
This CL makes the host uninstaller delete the settings file. Change-Id: If03663338817dba6b15f15ae4493e6edfce9290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640652 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#845769}
-
Felipe Andrade authored
Extend the expiration date of AuthPolicy and Kerberos histograms. The milestone of expiry is synchronized, to make maintenance of these histograms easier. Justification for AuthPolicy: the feature doesn't send enough data to DM Server to provide data about it's usage. Justification for Kerberos: the feature was launched recently. Bug: 1165074, 1165051, 1165019 Change-Id: Iaa2851945f39b6b34ffa6a9a33e8b43a33cfa3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626287Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Haiyang Pan authored
It consistently fails on android-pie-arm64-rel Bug: 1169250, 1147581 Change-Id: I7923d166f42cef1ef65ebb22adbc3409cdeb2206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643259 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845767}
-
Fredrik Söderqvist authored
If the pattern resource is marked for layout via a mechanism that does not invalidate its attributes - for example by changing a style property that only requires paint invalidation - a call to LayoutSVGResourceContainer::InvalidateCacheAndMarkForLayout() will fail to properly invalidate attributes, which leaves the pattern in an inconsistent state. Drop the early-out check for SelfNeedsLayout() in said method so that RemoveAllClientsFromCache() is called in the above case as well. Bug: 1167563 Change-Id: Ib5896da9e52a103b86dc6eb7ad08e30a572b6d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642777Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#845766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..79b1b0af2eb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I86c4579f227c264c132c1fe7f041508b40b89114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845765}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idd52f07051df27d6df91d5e4f4188efa73d04f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643137Reviewed-by:
-
Tommy Nyquist authored
This reverts commit 305cf78b. Reason for revert: Crashing many browser tests, in particular BackgroundTracingManagerBrowserTest.* Original change's description: > tracing: make PosixSystemProducer work in child processes on Posix. > > The security sandbox forbids making socket connections directly from > within most child processes (except the network utility process). Trace > data for renderers are missing from a tracing session with Chrome data > sources on non-Android Posix platforms. > > This change introduces a new Mojo interface, SystemTracingService, that > is shared between the browser and child processes for making a socket > connection to the system tracing service daemon. A child process > receives a Mojo remote interface and then invokes the OpenProducerSocket > method to open the socket connection in the browser process. The browser > process then passes the socket connection to the child in the response. > The child process then adopts the connected socket in initializing the > connection in PosixSystemProducer. > > Full design doc: go/crosetto-chrome-producer-dd > > SystemPerfettoTest.SandboxedOpenProducerSocket > > Bug: b/147789115 > Test: services_unittests: SystemTracingServiceTest.*, > Change-Id: Id698dc656b7b9ede723e3a887532c33544914edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435129 > Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844743} TBR=kinuko@chromium.org,primiano@chromium.org,skyostil@chromium.org,eseckler@chromium.org,chinglinyu@chromium.org,nuskos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/147789115, 1169185 Change-Id: Ibe932297b317fdee6cbd9ef5b09ad1aeffd2f1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643258Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#845763}
-
Peter Wen authored
Recursive resource deps is meant for an android_library target to directly depend on all of its transitive resource deps. A target that does this also needs to rebuild its build config file when its transitive java library deps change, since otherwise, if a transitive resource dep is removed from the build by being removed from the java target that used to depend on it, the recursive resource target's build config would be stale and the removed resource would be included in the final apk/bundle. Example: A: Resource dep that turns on recursive_resource_deps. B: Java library C: Java library D: Resource dep A depends on B depends on C depends on D. Previously, A's depfile would only contain D.build_config. But if C removes D as a dependency, and the removal doesn't result in a change for B.build_config, A.build_config would not be rebuilt, since it only depends on B.build_config (via direct dep) and D.build_config (via recursive_resources_deps). Thus entirely missing the change to C.build_config. Bug: 1168655 Fixed: 1168655 Change-Id: I500d307802d64ef81099540ebd6fb54f4953c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639227Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845762}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79b1b0af2eb9..dc8ef8034344 2021-01-21 fmayer@google.com Merge "Add ELOG to truncation path in UnixSocket." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I136ed8a0493cd4120750bcda93104e78c4eb1fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642815Reviewed-by:
-
Ben Mason authored
Change-Id: I75471776f45dd2d6cc7ee562f90c5690d2a23025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642958 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845760}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f28a06ba7281..203154b52a46 2021-01-21 syoussefi@chromium.org Vulkan: Remove swiftshader workaround for missing gl_Position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5b6dcf3cd35704ee71cd771e0c1ea2bc9809692e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643097Reviewed-by:
-
Anthony Vallee-Dubois authored
This is a reland of the CL reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2628949. Bug: 1166369 Change-Id: I86c177e525a8e330f2b135106488febb0e2d5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637954Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#845758}
-
Yuchen Liu authored
Bug: 177786478 Test: QA test shows the av sync is improved after disabling it. Change-Id: Ic9257ece4169b54b8b9126717657fb2abe80dcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643402 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#845757}
-
minch authored
Bug: 1166374 Change-Id: I9e513de723c7d27cd12ac0bb7604c4ebbe5200b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628254Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#845756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1890f38f2471..8d1dafc6c231 2021-01-21 vidorteg@microsoft.com [Loc] Migrate heap_snapshot_worker to Localization V2 2021-01-21 tvanderlippe@chromium.org Disable Karma coverage preprocessing for component_docs 2021-01-21 andoli@chromium.org [module.json extensions] persistence views 2021-01-21 soxia@microsoft.com Service Workers Test Runner filters date information 2021-01-21 andoli@chromium.org [module.json extensions] Adds documentation on extension registrations. 2021-01-21 andoli@chromium.org [module.json extensions] protocol_monitor 2021-01-21 wolfi@chromium.org Fix: show OpenedWindowDetailsView when clicking on respective item in If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1136655,chromium:1153091,chromium:1159502 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ec61b1d059fc8d54e4f1c402f9661688e25230c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642886Reviewed-by:
-
Henrique Nakashima authored
The getowners.py script periodically reads OWNERS files and git history and generates per-module data to be surfaced in go/clank- OWNERS files do not contain Monorail component, Team and OS information anymore, DIR_METADATA files have replaced them and broken the script since then. Bug: 1135347 Change-Id: Ib88e9d576d94ad5484b6a3dbbfff156639275dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634833Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845754}
-
Eugene But authored
Bug: None Change-Id: I8959d5ef64a2242bf7002cb826a40087d96ef292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638418Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0d023562bd9..230cd50238f2 2021-01-21 mtklein@google.com close out simple assembler TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ie33af84899b2882904cc92d804eb775c56165ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643236Reviewed-by:
-
Shengfa Lin authored
This reverts commit 28c5a54b. Reason for revert: The test failure cases mostly are real failures. Original change's description: > Disable __main__.ChromeDriverTest.testCanSwitchToPrintPreviewDialog > > It's flaky. > > I can't figure out how to mark it as flaky using this test harness, so disabling instead. > > BUG=1166314 > > Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#843395} TBR=mpearson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,shengfa@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1166314 Change-Id: Ia8c5f9f0bef64a21f2b0066ba1f218b5aed0874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641099Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#845751}
-
Matt Reynolds authored
This CL adds a histogram to record the reason why the HID device chooser was closed. Bug: 964041 Change-Id: I1fbe006314b0d2faab57771f07ccf57c5ed01c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600218Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845750}
-
Ahmed Fakhry authored
When recording a window or a partial region, the display can be rotated, or its device scale factor can change, leading to the DIPs display bounds changing. If we don't propagate this change to the recording service, the video capturer will try to fit (i.e. center and letter-box) the new frame dimensions into the original requested video resolution. This is ok when recording fullscreen, but leads to completely broken cropping when recording a region (See bug for video demo). It can also lead to a bad quality window recording. This CL fixes this issue by propagating display bounds changes to the service to reconfigure the video capturer and encoder if necessary (Demo of fix is on the bug). BUG=1168434 TEST=Manually, added a new test Change-Id: I9db5d29bddc217042b007b422b1084c86d8be959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641082Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#845749}
-
Joshua Pawlicki authored
If the device ID cannot be fetched, we prefer to still send the request with no ID. The client will be counted by CR counting, and we still prefer the client to get up-to-dateness info rather than fail the entire request. Bug: 1158707 Change-Id: Ic6a1a8653ff6db7fbfa2ed79d1906d2c8b50095a Fixed: 1158707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643178Reviewed-by:
-
Caitlin Fischer authored
The server-side config shows that the study has ended. Bug: 1126640 Change-Id: I8093fccdd6ab46e36178bb020ffec2ce3ed968ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631932Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845747}
-
Avi Drissman authored
Bug: 1164487 Change-Id: I7a2fbfd53d7321b3fead090ead52f1de699f53af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631428Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845746}
-
David Maunder authored
Speedup: 14397ms -> 5191ms (64% improvement) Bug: 1168647 Change-Id: Idbf3a3e10cd4e4b04e5f34d0d997ca4bd8b05f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640919 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845745}
-
Ben Pastene authored
This will prevent the goma bots from running tests on 10.10, which is being deprecated, and which appears to fail the tests anyway. Change-Id: I17ed6c430e5ea3ee7b7eaa95fd6653038706fece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641146Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845744}
-
Yuwei Huang authored
Looks like calls to AudioQueue APIs don't always trigger audio capture permission request, e.g. it doesn't seem to pop up the permission dialog after I reset microphone permission with `tccutil reset Microphone`. Without audio capture permission, calls to AudioQueue APIs will still succeed as if everything works, but what we get will be empty buffers. Bug: 1168729 Change-Id: I5491e420fb907a1e438f57ef172ecb997f99e6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641145Reviewed-by:
-
Alice Wang authored
This CL uses AccountManagerTestRule instead of SyncTestRule in SigninFragmentTest to facilitate ProfileDataCache update tests in the future. Bug: 1167672 Change-Id: If3d8753b5a894a76b9db2d961aaa336306b717ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632678 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845742}
-
Olivier Yiptong authored
This adds the ability in TableView to add a range of items comprised of only 1 item. This requirement manifests itself when using a "select-all" capability. Prior to this CL, only ranges of 2+ items would be allowed. Furthermore, this fixes a bug when all items are selected while there is no 'active' row in a table. This can occur when the selection UI is outside of the TableView. Change-Id: I950fca34e8c83b650d14e0d6da3e7ad9d0b84f33 Fixed: 1169260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641320 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845741}
-
Dan Harrington authored
get_element_shadow_root Bug: 1168659 Change-Id: I0f6ae65d0ea995d5ea9cc2effa34053be7423db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640639Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#845740}
-
Austin Sullivan authored
This method just overrode the identically behaving implementation from the base WritableStream class. Intent to Implement and Ship thread here: https://groups.google.com/a/chromium.org/g/blink-dev/c/98OnGPp1_M8/m/HK4lRghLAgAJ Bug: 1163351 Change-Id: I8b6ffc033bbef22eb699eac50d8f79b829fa5a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613527 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
-
