GitLab

Bug: 635619
Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716907}

The colored text is not breaking text runs. This is required to support
correctly the arabic script.

The characters are combining together to form a word. They are grouped
together by ligatures. Applying a color to a part of a word should not
break the ligature.

This CL is adding a unittest to ensure this behavior is working.

Bug: 1025561
Change-Id: I71211cb90fe6064a6d3be5a7de37e071675763fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923109
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716906}

Before this patch, setting more than one value in the set form field
value action proto could cause a hard crash of Chrome.

The existing code would run multiple "set value" runs at the same time,
causing them to interfere and eventually crash the process.

This patch adds a unit test that reproduced said crash and a fix for the
underlying issue.

R=arbesser@google.com

Bug: b/144152314
Change-Id: Icefa6f25cac56c034a296d1298a99a071bb9248d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924518Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716905}

Previously NDEFReader#scan() returns void and an NDEFErrorEvent will be
dispatched in case that the scan operation cannot be started
successfully.

This is not a well accepted pattern, and also to align with
NDEFWriter#push(), this CL makes NDEFReader#scan() return a Promise
instead.

Note that now NDEFErrorEvent is only used to notify Mojo disconnection,
a follow-up CL will remove it completely by using ErrorEvent instead.

The spec change:
https://github.com/w3c/web-nfc/pull/398
https://github.com/w3c/web-nfc/pull/432

BUG=520391

Change-Id: I1477258ab70f7e40da31ea8795d63125b6a13af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899586
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716904}

This reverts commit 19c93a8b.

Reason for revert: crrev.com/c/1913588 should have resolved the original flaky problem.

Original change's description:
> Disable flaky NFC web platform test
> 
> Bug: 1019663
> TBR: fbeaufort@chromium.org
> Change-Id: If58fd2c071cab7e77db76c96b78d6a25c46a7ccd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890532
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Commit-Queue: anthonyvd <anthonyvd@chromium.org>
> Auto-Submit: anthonyvd <anthonyvd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710781}

TBR=anthonyvd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1019663
Change-Id: I6f679cc86502a5a2b69e07fec751881e1fff8a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925492Reviewed-by: Leon Han <leon.han@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#716903}

They are handled the same as the integral type ones.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: I7d6ee4bd3939e8458f7a10b6697f1204c911345a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924515
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716902}

Missed giving ime/OWNERS access to input_ime.json.

Updated to include that file.

crrev/c/1918783

Change-Id: I2b09e1d3149e140f0c1c3fdf53e54e89975e3fd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923221Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Keith Lee <keithlee@chromium.org>
Auto-Submit: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716901}

This reverts commit 00f512ce.

Reason for revert: <INSERT REASONING HERE>
Speculative fix for crbug.com/1026473
Tests are unable to find any message strings.
Bug: 1026473
Original change's description:
> Support compressed .json grit files and compress chromevox messages
>
> This provides support for --gzip-output in grit/build.py, which:
> 1. Compresses individual output files.
> 2. Appends .gz to the compressed output files
>    (e.g. messages.json -> messages.json.gz).
>
> This makes it fairly simple to convert an extension (e.g. chromevox)
> to use compressed l10n files. Other than setting gzip_output = true
> in the .gn file, the only other required change is updating any
> test dependencies.
>
> Bug: 1023568
> Change-Id: I8318b1d87b828b512f890c6f2cf6d4d22462ed7d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913610
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716284}

TBR=stevenjb@chromium.org,dtseng@chromium.org,agrieve@chromium.org

NOTRY=true

Bug: 1023568
Change-Id: I4b506ef6d574a1e300383359aa2fbdc81b332252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925888Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716900}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5991b6c4ac8472c83f8ade8e66bfeed57a789072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924276Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716899}

UI Automation APIs ExpandToEnclosingUnit() and Move() for TextUnit
Paragraph is giving wrong output for PDF. It is not able to
correctly identify paragraph boundary because kIsLineBreakingObject
attribute is not set for Paragraph nodes in PDF. The fix is to set
kIsLineBreakingObject as true for Paragraph nodes.

Bug: 1025170
Change-Id: Ife69fc0646f1709d21c7a9fcc392524912a1988d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921929Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716898}

Previously, chromiumos_builder() ignored the **kwargs argument.

This was a problem in http://crrev.com/c/1923225, when the goma_backend
arg was not being passed to builder(). This resulted in some builders
not actually getting the arg to use Goma RBE backend:
- linux-chromeos-dbg
- linux-chromeos-rel

With this CL, these builders will get the correct goma_backend setting,
and start building using the Goma RBE backend.

Bug: 950413
Change-Id: Ie389646206ec96e39f1ad436db341ef213b539c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924182
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716897}

Adding myself to owner of fonts and render-text.

Change-Id: Ie4dabac0423821487055bf2ab79abc5f7c8f8c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924550Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716896}

Extension::VersionString(), Extension::DifferentialFingerprint(), and
Extension::GetVersionForDisplay() returned a `const std::string`;
there's no reason to do this, since it's a new string (and not a
reference to a member). Additionally, this could potentially result in
invocations of these methods creating a copy, if the caller did
something like:

std::string version_string = extension.VersionString();

Since the result would be a `const std::string`, a copy might be made to
fit into the non-const std::string required by the caller. Hopefully,
the compiler is smart enough to optimize this out, but it's better to
just un-const the result altogether.

Bug: None
Change-Id: Ic586e8e7f907431ddf5ee3efb7b111b9704c4144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919731Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716895}

Continuing along with the attempt to rebalance test suites, up to
the 75th percentile, telemetry_perf_unittests still has nearly 3x
to 4x more overhead than chrome_public_test_apk and
content_browsertests. It also runs a lot faster. Looking at the numbers
in https://bugs.chromium.org/p/chromium/issues/detail?id=1021686#c12
and fudging it a little, we can reduce 3 shards of
telemetry_perf_unittest to slow down runs by about 23% without
making it into the long pole. We might be able to pull it down further
but variance in data makes it hard to fully reason about this.

These extra 3 shards can translate to 6-12 more shards of
chrome_public_test_apk of content_browsertests depending which
percentile you look at.

Making a guess, this will let us pick up 5 more content_browsertest
shards (this has lower overhead) and 3 more chrome_public_test_apks
shards.

Bug: 1021686
Change-Id: I7acf9db5d9ee2b2b33b366da0702b1658444d4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922975
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716894}

Run clang-format on the JS files in:
chrome/browser/resources/bookmarks
chrome/test/data/webui/bookmarks

and remove extra indentation from HTML files in
chrome/browser/resources/bookmarks.

Bug: 1022213
Change-Id: I574e1c768247dbf5b437d5db9cf31bfe3f4cc738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922593
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716893}

Bug: 1009686
Change-Id: I63a4ff8b18ff7c7ec53586d10441b9e53cdb136c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925241
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716892}

The type-specific typed-array files like int16-array.h were unnecessary
and did not add functionality. I replaced them now with a templated
version of the original base class.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: I04b2c392af8737162b4251249d7af6ff50eee7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919354Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716891}

Previously, we only store phished saved password bit
in compomised_credentials only when it's reused on a
phishing site. However, when a saved password is reused
on a low reputation site, it should also be persisted.

Bug: 1026006
Change-Id: Ie4dd0431690a1e91521e493225375ae4221f167f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922948
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716890}

Switches the win10_intel_hd_630_experimental mixin back to triggering
tests on the stable driver version, as the experimental version has some
issues that will prevent us from promoting it to stable.

TBR=ynovikov@chromium.org

Bug: 1016459
Change-Id: I32ca010c0a90b893eb69b8c9a1f624b4f6de2827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925422Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716889}

During the GPU initialization, Some heavy jobs, like LoadLibrary, which are not
running on the GPU drivers might be very slow and cause the GPU watchdog to
terminate the GPU main thread. This CL adds two new functions PauseWatchdog()
and ContinueWatchdog() to allow the GPu watchdog to be paused and continued when
needed.

The implementation is added in GPU watchdog V2 only, no V1.

Bug:949839

Change-Id: Ia8a60fd08a5c07686499dbdc10a7abd19e47a507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861094
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716888}

This reverts commit 70df16a3.

Reason for revert: This is a culprit CL which fails
UnifiedMessageCenter ash_unittests 

Example:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15343

Original change's description:
> Implement pop in and out animations for stacked notification icons
> 
> Bug: 1025050
> Change-Id: I5073cb6f54036b86f1bf455e89f29d529ad25a4e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918038
> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716782}

TBR=xiyuan@chromium.org,tengs@chromium.org,amehfooz@chromium.org

Change-Id: I366f50b2c2e1e1468178bd137fb5d5d8d7b559ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1025050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925842Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716887}

This reverts commit 3e5e2582.

Reason for reland: Added proguard_enabled = true to test apk

Original change's description:
> Revert "Remoting: Enable Proguard tree-shaking to reduce method count"
>
> This reverts commit f31ef558.
>
> Reason for revert: compile failure on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6720
>
> Original change's description:
> > Remoting: Enable Proguard tree-shaking to reduce method count
> >
> > Bots are failing because remoting_apk is over the single dex method
> > limit.
> >
> > TESTED=Launched app and made sure it didn't crash.
> >
> > NOTRY=true  # Previous patchset passed. Urgent to fix build.
> >
> > Bug: 1026161
> > Change-Id: I2156f84d55ff214eab5cf0d77811baaa3b5f77e8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925215
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#716776}
>
> TBR=lambroslambrou@chromium.org,agrieve@chromium.org,estevenson@chromium.org
>
> Change-Id: I67d7c775be0d06f04bcf69f9331bceb364642fcc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026161
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925513
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716798}

TBR=lambroslambrou@chromium.org,agrieve@chromium.org,estevenson@chromium.org,steimel@chromium.org

Change-Id: I9e9e301a86c9a75d615df713884777b80bdbba8a
Bug: 1026161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925786Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716886}

This CL adds back the resource load priority preload audio and video
tests so they are not forgotten, but disables them which was the
intention of crrev.com/c/1440522. Also adds a note indicating pointing
to the spec complexity around why they are disabled.

R=yoavweiss@chromium.org

Bug: 735014,977033
Change-Id: I2707a1bd39102e894b803f10f3305b8b8efea796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902481
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716885}

These checks are using an obsolete a11y testing framework, based on
axs_testing.js.

Also in some of these cases these checks were already disabled, but the
suppression were still present in the code.

Bug: 807458
Change-Id: I9c5eb05b692df65b546f9ad0d4486deb4868995b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924698Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716884}

It's unlikely that we are going to move to this tech so I'd like
to remove this to streamline the codebase and prevent extraneous
work during maintenance and migrations.

BUG=954566

Change-Id: Icf0ac6e7d7bef36d6f40514ba8d02940de3a1546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924975Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716883}

It's possible to try to find the Object Replacement Character (ORC), so
we should not use that as a delimiter of invalid elements as we might
wrongfully think that the delimiters are an actual match, causing
crashes.

Additionally in some cases layout might fail causing the FindBuffer to
have null NGOffsetMapping, causing crashes. In this case we should skip
the entire block as we can't get the ranges correctly.

Bug: 1020105, 1002753, 1024256
Change-Id: I4c4cc886a84a919a617789db6d3bb0351a5d7477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924031Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716882}

This reverts commit eb4de739.

Reason for revert: breaks ios.cronet builder https://ci.chromium.org/p/chrome/builders/ci/cronet-ios

Original change's description:
> [promises] Make sure alignas value is compatible with heap allocations
>
> Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make
> sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations.
>
> For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61
>
> Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Carlos Caballero <carlscab@google.com>
> Cr-Commit-Position: refs/heads/master@{#714395}

TBR=gab@chromium.org,thakis@chromium.org,alexclarke@chromium.org,carlscab@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idbdb94a682ceb855a53b6108005d8fed57595ce3
Bug: 1026037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925776Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716881}

Previously the post delayed task will cause crashes on Linux and Mac. Every time we post a delayed task, then we refresh/close the tap, it will crash when the delayed task executed. It might because the WaitableEvent can only be used within single address space for Non-Windows systems[1]. And when we refresh/close the tap, the credit_card_access_manager is reset when DidNavigateMainFrame [2].

In order to fix it, we replace the callback with CreditCardAccessManager::SignalCanFetchUnmaskDetails function together with weak_ptr of credit_card_access_manager. With the weak pointer, the BindOnce callback won't be executed when credit_card_access_manager is reset.

[1] https://cs.chromium.org/chromium/src/base/synchronization/waitable_event.h?l=39-41&rcl=0b35f9e032c5ac21ef25df8d5cf113529ce2f4c3
[2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?l=1450-1451&rcl=fd806bd17d805398213f349649276356c5616c6e

Bug: 949269
Change-Id: I8e7acdb411e4421b55a685ff470b82fd954149d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922913
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716880}

Changes the following builder def functions to set Goma RBE backend by
default:
- in ci.star:
  - fyi_mac_builder()
  - gpu_fyi_mac_builder()
  - mac_builder()
- in try.star:
  - blink_mac_builder()
  - gpu_mac_builder()
  - mac_builder()

The changes to cr-buildbucket.cfg are all for setting Goma RBE as the
default for testers, which is a no-op.

Bug: 1025325
Change-Id: Ica7fc988f387c97a9eaada694dd5bb066e6ebbac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924333Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716879}

This is a follow up CL for
https://chromium.googlesource.com/chromium/src/+/0cf9a1a417bfc0d0a4ccec4ee30e9cc5f4375863

Bug: 1022263
Change-Id: I938f2cc0c10c6dfb3f3d4269f9ce6cbd6656a328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925828
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716878}

Bug: 939235
Change-Id: I72f4c1cafa13b9888556789aef644e9026019ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923981Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716877}

This CL updates the screen.orientation.angle web API to output relative to the
device panel. screen.orientation.angle is used by web apps using a desynchronised
WebGL canvas to achieve low latency performance via hardware overlays. This
requires alignment with the device output panel.

Fixed: 998131
Test: PanelRotationBrowserTest.ScreenOrientationAPI
Change-Id: I05efbfb8aecd5015b18f0e4f434ab67df6ca50b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911344
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716876}

This is a followup to [1] to use the terminology "subpage button"
rather than the pre-[1] behavior of a mix of "button" and "link" to
describe subpage routing buttons. This handles cases with
'cr-icon-button's with the CSS class 'subpage-arrow' that are not
contained in a cr-link-row (that case was handled in [1]).

Note that this does not apply the "subpage button" role description to
cases in browser settings with a cr-icon-button with the CSS class
'subpage-arrow' that do not actually route to subpages.

Also note that both this CL and [1] passed over some cases in which
the logic determining whether a button's effect is a subpage route is
conditional. It would be good to return to these cases in a followup,
but they are relatively few.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1881816


Bug: 1012104
Change-Id: I17d8a0ea9a20c44e060932b300cc3681d17b15c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925435Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716875}

Previously, each run of nfc_test() creates a new nfc mock object in the
start and destroyes it in the end.

Considering a test file containing multiple nfc_test() runs, in Blink we
have just one NFCProxy instance per page context to talk to these mocks,
that means our NFCProxy gets a broken NFC Mojo connection each time the
previous nfc_test() runs to the end then has to reconnect to another new
nfc mock for the coming nfc_test().

This is unnecessary and does not align with the product code logic that
always keeps one NFC Mojo connection alive per page context, unless
something unexpected happens in Device Service.

Also, this makes it easier for a nfc_test() to interfere with the next
one, e.g. a nfc_test() ends and closes the NFC Mojo connection, the
disconnection message will arrive at our NFCProxy asynchronously and we
can not have any assumptions on the arrival time, assuming it's still on
the way and the next nfc_test() has already started, at that point our
NFCProxy has no idea that the current Mojo connection was already closed
but continues to talk to it.

This CL makes one nfc mock object be reused throughout one test file to
address the above concerns.

BUG=1019663

Change-Id: I7e2ae9816936081e1f59688652e34b35a5295af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913588
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716874}

Create cc::Layer for composited ScrollHitTestDisplayItems only.

Non-composited ScrollHitTestDisplayItems will contribute non-fast scrolling
regions in the containing layer.

Bug: 738613, 931486
Change-Id: I9ea21b7a697c13b8c80355d82de78fe184d8e2a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920914
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716873}

Bug: 1012578, b/144121590
Change-Id: I8857cbd29cac21d986dca05282ade1493c1048d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924337
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716872}

There are a few reasons why this is desirable:
(1) Reduces need for complete event stack in ThreadLocalEventSinks,
    which was brittle before (e.g. crbug.com/983307).
(2) Makes it possible to flush event sinks while tracing in the future
    without losing not-yet-completed COMPLETE events from the stack
    (streamed tracing use case). Events that didn't end before the
    flush will still be present in the trace as BEGIN only.
(3) Prevents reordering of nested COMPLETE events - something which
    could confuse TraceProcessor in the past (events with identical
    begin timestamps would be imported incorrectly).

To achieve this, this patch also plumbs the EXPLICIT_TIMESTAMP flag
and thread id through to TraceLog::UpdateTraceEventDurationExplicit,
because it seems that android can add COMPLETE events with explicit
timestamps / threads [1].

[1] https://cs.chromium.org/chromium/src/base/android/early_trace_event_binding.cc?q=INTERNAL_TRACE_EVENT_ADD_WITH_ID_TID_AND_TIMESTAMPS&ss=chromium&l=31

Bug: 983307, 928738, 1006770
Change-Id: I66e685c04c068646d550f182185d3c45febcbfa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899852
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716871}

On Fuchsia official builds, unwind tables are disabled. This causes
base::debug::StackTrace to not have a proper stack trace. This CL
clarifies that this is the expected behavior for Fuchsia official
builds.

Bug: 1025329
Change-Id: I1ad87efb7bf6fefb18444eea121d1ec181ae3fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925767
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716870}

This simplifies the interface for the Previews Decider and UI service

Change-Id: Id50c986ba9e5fe00f6d8547101b1a7d162fc9584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925434Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716869}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0d10afabcf7a..d364d7600c32

git log 0d10afabcf7a..d364d7600c32 --date=short --no-merges --format='%ad %ae %s'
2019-11-19 rharrison@google.com Migrate away from nosetest to unittest (#896)

Created with:
  gclient setdep -r src/third_party/shaderc/src@d364d7600c32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I7e226b7ac37e35d2480ba676ff65e9fb028cbc45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925367Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#716868}