- 23 May, 2019 40 commits
-
-
Bill Orr authored
This reverts commit 217bbfe0. Reason for revert: Turning WPT-Notify back on. Original change's description: > Temporarily disable WPT-NOTIFY for WebXR tests > > Bug: 923060 > > Change-Id: Ia8fb926fd2f8e2366b8d8179154f080f95e40e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1418113 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623825} TBR=ddorwin@chromium.org,bajones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923060 Change-Id: If5d316d6cacbe785a68d7a2d8371b072485db634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626546Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662778}
-
Ben Kelly authored
In order to support moving CacheStorage off of the IO thread this CL does the following: * Makes CacheStorageDispatcherHost an internal detail of the CacheStorageContextImpl. The RenderProcessHostImpl now sends binding requests through the context. * The CacheStorageDispatcherHost becomes a SequencedBound<> object on the target SequencedTaskRunner. * As a consequence all the mojo interfaces are also bound on the target SequencedTaskRunner. * Some of the CacheStorageContextImpl initialization is also updated to respect the target SequencedTaskRunner. This CL does not update other context APIs (observers, cache_manager(), etc) to use the new TaskRunner yet. Those will come in later CLs. Bug: 960012 Change-Id: Iada6132a79952dd11b0a0ba8bfec3300d03327ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610679 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662777}
-
Sophie Chang authored
Bug: 964385 Change-Id: I1a294e74ad561cd1fcb6a5b2a08f707c4cc0caa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618058 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#662776}
-
Daniel Rubery authored
Based on feedback from the Chrome UX team, we no longer indicate Advanced Protection's involvement on DANGEROUS downloads, and we have changed the icon for UNCOMMON downloads to prevent users habituating to the red triangle icon. We expect a sharp increase in false positives for Advanced Protection users, so this should help a little with warning fatigue. Renders: https://screenshot.googleplex.com/eei9zcKgrnv https://screenshot.googleplex.com/cgxs53j2J0t Bug: 917190 Change-Id: I7a4b3f22b66cdaf9eab5fa2236ec6cd90b1d7f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603766 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662775}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/181e44c23185..6768b27cc897 git log 181e44c23185..6768b27cc897 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6768b27cc897 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1e95c6ef9c4c043bdbf40afc1f943a7149f2e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662774}
-
Daniel Cheng authored
Change-Id: Idb25eed43a7f6f2d024e3266614fe6242cf6f1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625740Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662773}
-
Jacob DeWitt authored
According to the Gamepad spec, y axis values should have -1.0 be up and 1.0 be down. WMR, OpenVR, and Oculus device APIs have 1.0 correspond to up, so we have to flip the signs for the y axis values that come from those platforms. The Oculus gamepad builder code already flips the sign for the y axis, which is why it's not included in this CL. Note that this will also affect the WebVR gamepads in the same way. Changes to input-selection.html are to help testing and debugging WebXR gamepads. Now the page shows tables for button and axis values which are updated in real-time. Bug: 965522, 965527 Change-Id: I08a1ecf4d5f90f41edcf5574fc9fd96e043482a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626393Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#662772}
-
Eric Stevenson authored
Some debug builds of Webview have 3 dex files now. Bug: 966542 Change-Id: Ib636f086042d2eb02f08f3390993594650f501b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627662Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662771}
-
Dave Tapuska authored
Apparently some clang plugin requires the value to be specified as kMaxValue as per comment https://chromium-review.googlesource.com/c/chromium/src/+/1221696/9/ui/base/ime/text_input_action.h#24 BUG=634330 TBR=shuchen@chromium.org Change-Id: I14cce2759494c2c7df303478168ebae2135e2b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625808 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662770}
-
Henrik Grunell authored
Feature was added in https://chromium-review.googlesource.com/c/chromium/src/+/1615018. Bug: 963810 Change-Id: I33b73b5b1527e40bd743c40f65821159b59ee818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626418Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#662769}
-
Siye Liu authored
We need to add one histogram to track number of active IMM32-based input method processor usage when TSF is disabled on Windows. Bug: 963686 Change-Id: I73433f2a3f6abb35b5e755f2f010e813718005cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617916Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#662768}
-
Esmael El-Moslimany authored
Change-Id: I87f1ec11f4fd70298f472cddeda669ceee58bee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626459Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662767}
-
Andrew Grieve authored
This reverts commit 055dc2c6. Reason for revert: Fixed webview tests (see patchset 2) Android: Never persist SharedPreferences in instrumentation tests. I'm hoping that this will reduce test flakes by removing a source of tests being able to change the behavior of other tests. * Uses InMemorySharedPreferences instead. * Asserts after each test that no SharedPreferences circumvented the fakes (which is possible by using non-application Context objects * Combines LifetimeAssertRule and CommitSharedPreferencesTestRule into a single BaseJUnit4TestRule. TBR=hanxi@chromium.org,agrieve@chromium.org,jbudorick@chromium.org,yliuyliu@google.com Change-Id: I9f15c5cdbd5a4d0fb97ccf83f2cce7293d18ca47 Bug: 441859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626963 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#662766}
-
Laís Minchillo authored
Record distribution of sslError from onReceivedSslError. Note regarding the placement of the UMA recording, onReceivedSslError is only called from AwContentsClientBridge.allowCertificateError so it should be the correct place to log this information. Bug: 948786 Change-Id: I9cb3c083534a094273221255efaaa2509144b7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601514 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662765}
-
Kyle Horimoto authored
A refactor [1] introduced use of the <cr-link-row> element, which exposed a layout bug caused by a stray </div> tag. This CL removes that tag to fix the layout problem. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1577594 Bug: 959328 Change-Id: I307308283dead18c0e17f51e059abbeaed2afe31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627655 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662764}
-
Ian Kilpatrick authored
When positioning a new formatting-context in the presence of adjoining floats sometimes a "forced" BFC block-offset will be set twice. When this new formatting-context was wrapped in a <div> (a parent which hadn't had its BFC block-offset resolved yet) we ran into a bug with our state machine. Upon the second time resolving the BFC block-offset the parent would resolve *its* BFC block-offset to the previous "forced" BFC block-offset. Upon the final relayout the parent would set the first "forced" BFC block-offset to its children causing an "infinite" loop (if we had a loop driving this machinery. This ensures we use the child's new BFC block-offset in this case. Bug: 966278, 966214 Change-Id: I5da2f3e90b9d2ff78f124247f6f68cd3a289ae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627692 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662763}
-
Nathaniel Steinbock authored
See change 1554130. Bug: b/132997084 Test: base_unittests Change-Id: I51769adf4402c5c78b387ff50f3b669056b4b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622735Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Steinbock <steinbock@google.com> Cr-Commit-Position: refs/heads/master@{#662762}
-
Esmael El-Moslimany authored
Bug: 966353 Change-Id: Id66b5bb439dea81d6ab56db8763681d6510932e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627695Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662761}
-
Eric Stevenson authored
This reverts commit 2385ddd3. Reason for revert: Broke chromium.android/android-jumbo-rel (crbug.com/966545) Original change's description: > [MFill Android] Retrieve addresses for sheet on native side > > This class adds the Address controller that collects data for the manual > fallback sheet on Android. > It does work similar to https://crrev.com/c/1599927, and the existing > PasswordAccessoryController. All three classes should be fairly similar > in behavior. > > The interface leans on the draft implementation of the bridge which > currently pulls data and might need changing to pushing data - I am open > for suggestions. > > Bug: 962548 > Change-Id: Id4c593a7af9eda815be16a85354bcfe241bc731f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614200 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662658} TBR=tmartino@chromium.org,fhorschig@chromium.org Change-Id: I35ff714d0d57c73268da8f3ade4bb68515b861cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627457Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662760}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/459b295bedce..0dee19bacc00 git log 459b295bedce..0dee19bacc00 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 robertphillips@google.com Revert "Track quad type on GrQuad directly" 2019-05-23 herb@google.com Start using strike specs in PDF. 2019-05-23 michaelludwig@google.com Track quad type on GrQuad directly Created with: gclient setdep -r src/third_party/skia@0dee19bacc00 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I047bb590277d7be2638986e221f69077007c7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662759}
-
James Cook authored
A few lines of CSS were accidentally dropped when os_settings_menu.html was forked from the browser version. Bug: 950007 Change-Id: I5c91b829cafed4b3af711547a0f196f9e6f7f6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627691 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#662758}
-
Evan Stade authored
This re-lands db977c4b Change to original: LoginUserInfo::fingerprint_state is default initialized Original change's description: > Mash cleanup: begin converting login mojo to C++ > > This patch moves types implemented in login_user_info.mojom to > //ash/public/cpp/login_types.h. The handful of methods on > mojom::LoginScreen which used these types are moved to C++ > interfaces. > > There are two new public-facing C++ interfaces: > 1. ash::LoginScreen, which is a direct translation of the mojom. > This is implemented by ash::LoginScreenController. > 2. ash::LoginScreenModel, which is used for the methods that > were simple thunks in LoginScreenController. > (LoginDataDispatcher implements this interface.) > > Bug: 958206 > Change-Id: I329d606b234556bf05aee40849f3aa5ccc6c0be0 TBR=tsepez@chromium.org,xiyuan@chromium.org Bug: 958206 Change-Id: I9567af3331638e38590f143f1b43e55d4b609c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626700Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#662757}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/943bf7fdf620..6e073100d205 Created with: gclient setdep -r src-internal@6e073100d205 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I155c739e9ef42f4652a055dc878dc95c9d25815d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626706Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662756}
-
Mike Dougherty authored
The |NSURL resourceValuesForKeys| is the current recommended way to obtain available disk space. Additionally, using the value of NSURLVolumeAvailableCapacityForImportantUsageKey excludes caches and temporarily files which can automatically be removed by the system when saving data. This provides a more accurate value which represents how much storage is available to the app. Change-Id: Ie954105d5ea0bb4dfa96b72df65adde572144dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624826 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#662755}
-
Scott Violet authored
This isn't necessarily a problem right now, but without this it's entirely possible that WidgetSlideAnimationDelegate is holding a reference to a deleted view, which makes me nervous. I came across this when looking at a crash that was the result of a UAF that I suspect was in this code. I believe you've since fixed it. BUG=940322 TEST=none Change-Id: Icfacdb7533ab9d1e8b2d99cbb29b459e2a21445a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627654Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#662754}
-
Anne Lim authored
Remove AutofillSaveCreditCardUsesStrikeSystemV2 since it's been rolled out 100%. Bug: 884817 Change-Id: I9df9a2c7bfafafd8a1d1568b8b1527569c15377b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623599 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#662753}
-
Mohammad Refaat authored
The only remaining observer is didChangeTab and it wasn't part of that bridge. Bug: 911350 Change-Id: Ibc058d467294ce056979c730a8742ac9436d57b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627006Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#662752}
-
Xing Liu authored
This CL fixed a typo in DownloadMediaParserBridge. Bug: 826021 Change-Id: Ied207ea958a0302e09e244466221e6f67b150771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625961Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662751}
-
Vladimir Levin authored
This patch ensures that we don't paint composited layers when display locked. This is similar to how we block non-composited layers as well. The reason for this is that they may not be laid out, and the display locking implemention (for now) ensures that nothing is painted. In the future this will change to paint just the self-element, not the subtree. R=chrishtr@chromium.org, rakina@chromium.org Bug: 966310 Change-Id: I8d5e557d833e0757e68bb5467224c0c74619e389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627550Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662750}
-
Kevin Bailey authored
This implements an experimental feature (behind a flag) to group Omnibox suggestions by type, search results first, followed by other types, after the default match, which does not move. Bug: 966462 Change-Id: I6870652be8f733b185ad1dcca946fb3091db0b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625811Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662749}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b40be11..bffe9927 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c8f5b28180f7dff28c9728fd33b8594adba0e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627730Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662748}
-
Lan Wei authored
In ProcessInputActionSequence function, we now check if both of the actions' ids and types match with the ones in session, so we should remove the check error for type. Bug: 606367 Change-Id: Id6306433155ba3087212ec27437d1209a25d19c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627632Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#662747}
-
siyua authored
Sorry missed these changes in previous CL. There are three new descriptions introduced.(The two store variations use the same one). mock: https://docs.google.com/presentation/d/1gBmqaamD_5QbEFo8KY03Ihi5LZ99kdCazd6Bb5khQ6M/edit#slide=id.g4de53d9b13_0_182 Will make sure these are translated for M76 Bug: 961082 Change-Id: I98ffec78c4d9cfcdba648647d8074558bed172af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626652Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#662746}
-
Eric Karl authored
This reverts commit e0c4b6ad. It turns out we needed image decode cache to support multiple colorspaces, so reverting this patch as we no longer need the complexity. Bug: 955161 Change-Id: I7394f048b5a9659d9c4ca4fd65dc480c7f04b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595016 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662745}
-
Sammie Quon authored
More details about crash in bug. Seems like multiple stacks which lead to OverviewController::OnAttemptToReactivateWindow. My guess is that there is a race between OnAttemptToReactivateWindow and the DELETE_SOON for overview_session_, so do not run OnWindowActivating when overview session is shutting down. Test: none Bug: 953437 Change-Id: Idb0aebc640f20aad8df3e10545e6c3f41c63d5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625962Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#662744}
-
Natalie Chouinard authored
Remove some workarounds and unnecessary checks now that we no longer support Jelly Bean. Bug: 923477 Change-Id: Ib8ed81b29b2ded7fab33b3a006f02735edb2a7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625958Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#662743}
-
Elly Fong-Jones authored
Bug: 965999 Change-Id: Ica5fb02f000171714ce40b670b2de532ad46503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625245 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#662742}
-
Ehsan Karamad authored
HTMLPlugInElement::PluginWrapper() can be called for a plugin element that does not have a document node frame. This causes a crash in MimeHandlerViewContainerManager::Get() which expects the passed |render_frame_| to be nullptr. Bug: 966371 Change-Id: I6ba558efdf416f421d1a540f947d79203b0bc985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627267Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662741}
-
Jenny Zhang authored
Bug: 963448 Change-Id: Ib1d140f23d04353371158879aaf984306e585420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625459Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662740}
-
Navid Zolghadr authored
Change-Id: I6b3a1bb41b8fd01217347c20e8bbd59367084112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625390Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662739}
-