GitLab

DedicatedWorkerTests are very slow compared to other tests. According to the
report (https://crbug.com/650346), these take 20% of the running time of
webkit_unit_tests. This CL saves the running time by shortening delays for
postDelayedTask(), setInterval() etc used in the tests.

Before this CL (Linux Debug Build):

[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms)

After this CL (Linux Debug Build):

[1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms)
[2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms)
[3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms)
[4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms)
[5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms)
[6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms)
[7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms)
[8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms)
[9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms)
[10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms)

BUG=650346

Review-Url: https://codereview.chromium.org/2384723002
Cr-Commit-Position: refs/heads/master@{#423789}

This fixes another place that previously forced clip for contain:paint,
causing corrupted painting in nested contain:paint containers.
Other places were fixed in https://codereview.chromium.org/1985933002.

BUG=648091
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2400063002
Cr-Commit-Position: refs/heads/master@{#423788}

BUG=616242

Review-Url: https://codereview.chromium.org/2396893002
Cr-Commit-Position: refs/heads/master@{#423787}

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2396793004
Cr-Commit-Position: refs/heads/master@{#423786}

************* Module gn_helpers
W: 68,17: Redefining built-in 'input' (redefined-builtin)
W:108,15: Redefining built-in 'input' (redefined-builtin)
W:242, 4: Redefining built-in 'id' (redefined-builtin)

Review-Url: https://codereview.chromium.org/2389353004
Cr-Commit-Position: refs/heads/master@{#423785}

BUG=569557

Review-Url: https://codereview.chromium.org/2396883005
Cr-Commit-Position: refs/heads/master@{#423784}

TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/2282203002 .

Cr-Commit-Position: refs/heads/master@{#423783}

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Review-Url: https://codereview.chromium.org/2396883004
Cr-Original-Commit-Position: refs/heads/master@{#423450}
Cr-Commit-Position: refs/heads/master@{#423782}

https://codereview.chromium.org/2084933002 added a dependency on
RuntimeEnabledFeatures.h, but the target doesn't depend on the generated
files.

BUG=none

Review-Url: https://codereview.chromium.org/2393363003
Cr-Commit-Position: refs/heads/master@{#423781}

Review-Url: https://codereview.chromium.org/2402463002
Cr-Commit-Position: refs/heads/master@{#423780}

If a URL request is cancelled by a requester, there's a chance on
URLResponseBodyConsumer to run OnReadable() on an invalid
ResourceDispatcher::PendingRequestInfo. That causes a null pointer
access.

This CL clears the URLLoaderClient earlier in the cancellation phase to
avoid the crash.

BUG=603396

Review-Url: https://codereview.chromium.org/2399463002
Cr-Commit-Position: refs/heads/master@{#423779}

This patch removes a TODO which states we should normalize calc() values
when parsing them for registered properties. I don't recall exactly why
I added this TODO but it doesn't seem that the spec says this needs to
be done. We already simplify calc() values in computation as per spec.

https://drafts.css-houdini.org/css-properties-values-api/

BUG=641877

Review-Url: https://codereview.chromium.org/2399803002
Cr-Commit-Position: refs/heads/master@{#423778}

This CL removes unnecessary header inclusions and refactors parameter passing
for startWorkerGlobalScope. This should not change behavior.

BUG=n/a

Review-Url: https://codereview.chromium.org/2401513003
Cr-Commit-Position: refs/heads/master@{#423777}

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG=622133, 647725

Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb
Review-Url: https://codereview.chromium.org/2345123002
Cr-Original-Commit-Position: refs/heads/master@{#422942}
Cr-Commit-Position: refs/heads/master@{#423776}

BUG=652872,652389
TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos
are not preloaded so we have to trigger that in a button onclick handler.

Review-Url: https://codereview.chromium.org/2400543002
Cr-Commit-Position: refs/heads/master@{#423775}

- remove pref for reading context first and manually list roles for which it makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when encountering whitespace as Google TTS appears to have been fixed. Note that this might not be the case on other platforms, but ChromeVox for Chrome OS works well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are not played at the same time sounding like a big error tone). Context is uttered first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2387413002
Cr-Commit-Position: refs/heads/master@{#423774}

Things moved:

- invalidation_adapter
- invalidation_helper
- pref_names
- report_unrecoverable_error (renamed from chrome_*)
- sync_prefs
- system_encryptor

This CL was mostly generated by a script but required tweaking the
SyncPrefs interface slightly to remove a dependency.

BUG=631271
TBR=stuartmorgan,jochen

Review-Url: https://codereview.chromium.org/2395533003
Cr-Commit-Position: refs/heads/master@{#423773}

Previously, scroll offsets were stored in a mix of float, double,
and int.

BUG=470718
R=skobes@chromium.org,bokan@chromium.org,aelias@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2387883002
Cr-Commit-Position: refs/heads/master@{#423772}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/22570732fbb1..b72737924a91

$ git log 22570732f..b72737924 --date=short --no-merges --format='%ad %ae %s'
2016-10-06 aiolos Update Android reference build.
2016-10-06 aiolos Revert of Update android chrome reference builds. (patchset #1 id:1 of https://codereview.chromium.org/2397953002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2398333002
Cr-Commit-Position: refs/heads/master@{#423771}

Some cases are benign - no network connection or already busy - but we want to be able
to separate out cases in M55 due to running on svelte device or if prerenderer did not accept
the request (eg, due to RECENTLY_VISITED check).

BUG=652486

Review-Url: https://codereview.chromium.org/2388303007
Cr-Commit-Position: refs/heads/master@{#423770}

base::mac::FSRefFromPath will be removed as it is relied on deprecated
API. The only place where FSPathMakeRef needed is
QuarantinePropertiesDeprecated API. So instead of having shared
base::mac::FSRefFromPath function which depends on deprecated API it is
better to use FSPathMakeRef right in place where it's needed as it will
be easier to clean up that code later.

BUG=650854

Review-Url: https://codereview.chromium.org/2389123002
Cr-Commit-Position: refs/heads/master@{#423769}

Modernizes the UI a bit and adds a DateTimeHandler for policy stuff
(notifications TBD) and to provide the time zone list (TBD).

BUG=546835,460542
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2393703005
Cr-Commit-Position: refs/heads/master@{#423768}

This performance test that is meant to draw to a GPU accelerated
canvas accidentally changed its behavior due to a recently added
heuristic that cancels GPU acceleration under certain
circumstances. This CL fixes the test to prevent it from triggering
the heuristic.

BUG=653565

Review-Url: https://codereview.chromium.org/2399013003
Cr-Commit-Position: refs/heads/master@{#423767}

As part of preparing ash::DisplayManager for relocation to ui,
eliminate its dependency on ash localization strings.

BUG=581462

Review-Url: https://codereview.chromium.org/2383313002
Cr-Commit-Position: refs/heads/master@{#423766}

Revert of Make ResourceFetcher return Resources with LoadError instead of nullptrs. (patchset #8 id:160001 of https://codereview.chromium.org/2231523002/ )

Reason for revert:
Reverting since it is causing flakiness on the blink bots. Latest flake:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7628

unexpected_failures:
http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php

TBR=japhet@chromium.org,alexmos@chromium.org,engedy@chromium.org,hiroshige@chromium.org
BUG=616234

Review-Url: https://codereview.chromium.org/2399243002
Cr-Commit-Position: refs/heads/master@{#423765}

Following r419951 getExecutionContext() may return null, so
return value must be checked.

BUG=653272
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2398313002
Cr-Commit-Position: refs/heads/master@{#423764}

This matches the obsolete/modern part of the security panel. A cipher
suite is a particular thing in TLS and is not just the bulk cipher.
Cipher is a more appropriately generic term for a decomposition we made
up.

BUG=none

Review-Url: https://codereview.chromium.org/2393393004
Cr-Commit-Position: refs/heads/master@{#423763}

After the CL, there is a separate EventSender instance for each
WebWidgetTestProxyBase.  Additionally EventSender transforms the
coordinates of the event before calling Blink, to make sure the
coordinates will work with the target widget.

Supporting EventSender via WebWidgetTestProxyBase requires
exposing WebWidgetTestProxyBase::web_view_test_proxy_base()
accessor and this in turn allows for clean-ups in some other
places - for example this allows to remove storing borrowed
pointers to TestRunner and WebViewTestProxyBase inside
WebWidgetTestClient.

BUG=616608
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2036873002
Cr-Commit-Position: refs/heads/master@{#423762}

Currently data use is measured as foreground and background. In some
cases where the app was transitioning from one state to different state,
data use at that time should be logged as unknown.

This CL changes the UMA to log on every network TX/RX of the URLRequest.
Earlier it was logged only when URLRequest completes.

BUG=648808

Review-Url: https://codereview.chromium.org/2399783003
Cr-Commit-Position: refs/heads/master@{#423761}

BUG=555865

Review-Url: https://codereview.chromium.org/2391453002
Cr-Commit-Position: refs/heads/master@{#423760}

Finish AppTasks on the UI thread rather than the insturmentation
thread during test setup and tear down. Also eclose the finishAndRemoveTask()
calls in a try-catch block so that otherwise passing tests don't fail
on Android framework exceptions.

BUG=653731

Review-Url: https://codereview.chromium.org/2396253002
Cr-Commit-Position: refs/heads/master@{#423759}

The following type hierarchy exists in core/animation: KeyframeEffect is a
subclass of KeyframeEffectReadOnly is a subclass of AnimationEffectReadOnly.
Type casts have already been defined to convert AnimationEffectReadOnly objects
to KeyframeEffect objects; this patch adds the equivalent for converting to
KeyframeEffectReadOnly.

Review-Url: https://codereview.chromium.org/2395993002
Cr-Commit-Position: refs/heads/master@{#423758}

. MojoShellConnection -> ServiceManagerConnection
. MojoChildConnection -> ChildConnection
. EmbeddedApplicationRunner -> EmbeddedServiceRunner
. *MojoApplication* -> *Service*

R=rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2398783002
Cr-Commit-Position: refs/heads/master@{#423757}

BUG=564904

Review-Url: https://codereview.chromium.org/2397993003
Cr-Commit-Position: refs/heads/master@{#423756}

BUG=

Review-Url: https://codereview.chromium.org/2384323002
Cr-Commit-Position: refs/heads/master@{#423755}

The Physical Web data source collects information about nearby devices
broadcasting URLs and makes the list of URLs and associated metadata
available to components within Chrome. This change adds an empty
implementation of the data source in Chrome for Android and makes it
available from a BrowserProcess.

BUG=636490

Review-Url: https://codereview.chromium.org/2361603002
Cr-Commit-Position: refs/heads/master@{#423754}

It frequently fails all three test runs on tablets.

BUG=581268
TBR=yfriedman@chromium.org

Review-Url: https://codereview.chromium.org/2400083002
Cr-Commit-Position: refs/heads/master@{#423753}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f7d080135d03..22570732fbb1

$ git log f7d080135..22570732f --date=short --no-merges --format='%ad %ae %s'
2016-10-06 benjhayden Finish value-set-table tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2396003003
Cr-Commit-Position: refs/heads/master@{#423752}

Currently GpuChannel destruction runs as a single large task in the GPU
process. This can cause watchdog timeouts on very busy systems, as we
can end up doing a huge number of GL commands in a single task.

This change adds logic to ping the watchdog thread at regular intervals
(assuming that destruction is moving forward, and hasn't actually hung).
This should prevent the timeout hangs we're seeing.

In addition to reporting progress in ContextGroup, we also report during
shader, program, and texture deletion, as these are the three cases
where we've actually seen timeouts.

BUG=612219
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2378583003
Cr-Commit-Position: refs/heads/master@{#423751}

Add temporary VLOG(1) messages to renderer-freezing code to
try to track down the cause of a strange crash.

BUG=chromium:648580

Review-Url: https://codereview.chromium.org/2395293003
Cr-Commit-Position: refs/heads/master@{#423750}