- 17 Jul, 2020 40 commits
-
-
Nigel Tao authored
This creates a common place for current and future use_wuffs_xxx_parser GN args. Change-Id: I8e08522cab23a7bded2206f04cda916cca450b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299688Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789407}
-
Chih-Hsuan Kuo authored
On Chromecast, the media renderer should be CastRenderer. So, when CastRenderer is enabled, Receiver, the remoting renderer, should be able to use CastRenderer to play remoting media. Bug: 1097701 Test: Tested on Chromecast Change-Id: Ief7774cf25832e373428f324985364b671ef920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256923Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#789406}
-
Kuo Jen Wei authored
To add sound effect to pause/resume UI, new 'recording-ui-paused' state is introduced to control the UI transition. Bug: 1072706 Test: Run "tast run 'camera.CCAUIRecordVideo'", check if sound effect is applied. Change-Id: I7e6305e302cea55a14a1174b484a5dc24b06fabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296548Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#789405}
-
Alex Rudenko authored
According to the crash report, the owner document could be a nullptr. This CL adds a check if an owner document is available and sets the execution_context to nullptr if it's not available. CSSStyleDeclaration::setCSSText that receives the execution context can handle nullptr values. Fixed: 1090899 Change-Id: I2e0b1a56e6b25e98c043f576dbd230f50c062516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300382Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789404}
-
Wolfgang Beyer authored
Relevant DevTools CL: https://crrev.com/c/2297420 Bug: https://crbug.com/1101262 Change-Id: I0ff6f03b1946f2d24da995107e4d5eb774a332b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299622 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Using the EarlGrey or XCUITest helpers to type do not trigger software keyboard pressed which are needed in order to dismiss the popover in this test. Replace grey_typeText with grey_tap on an arbitrary keyboard key to dismiss the credit card popover. Fixed: 1099432 Change-Id: If23c886437b264893700b943b86039f9a31a8f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303046 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789402}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c5f244817c2..b8c03e40673f 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d8502113..b8a4405e (789218:789356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I30a52cb72a3a2afb617ed15456f4502bb45cfe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789401}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594943787-51a385cad6026d977d7d0e8c786de56f21cce493.profdata to chrome-mac-master-1594963977-810cedbe35bd1c6db444ce1374d5ffa7453d77c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie1ca35034d1af5b278afce031e33b61fa54bd0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304355Reviewed-by:
-
Oleh Lamzin authored
Respect FrameSrc directive in WebUI, otherwise WebUIs use wider ChildSrc CSP to be able to embed iframes. In many places we are using 'frame-src' CSP with ChildSrc directive which is wrong. We have to either use 'frame-src' with FrameSrc or 'child-src' with ChildSrc. Mostly we just need to be able to embed iframe and do not need web workers, so 'frame-src' will be enough. Bug: 1105408 Change-Id: I6d7bd555f6411971db24fdfe9e3f299bf83a8a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302990Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#789399}
-
Mike West authored
This test is quite flaky[1] as far back as the dashboard lets me see, with no discernable cause. [1]: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TranslateManagerWithMainFrameLanguageDetectionBrowserTest.TranslateIframe&testType=browser_tests TBR: groby@chromium.org Bug: 1106446 Change-Id: Ib9f420e5c844575460c028f2aba94ea9f0b0d180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303433Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#789398}
-
Viktor Semeniuk authored
This change displays number of compromised credentials in the Passwords screen using plural string. Bug: 1075494 Change-Id: Ic155353280f2f40834fef78e26a1d4b12a6477a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301142Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#789397}
-
Frank Liberato authored
In addition to that, this CL also allows Status(kOk), so that return StatusCode::kOk; and return OkStatus(); are equivalent. Previously, the former reported !is_ok(). Bug: 1043289 Change-Id: I59d1b57dfde82f87b69a30a951a3c8f9c9f4aaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288838Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#789396}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=apotapchuk@chromium.org Change-Id: I3ab03d08aae2f344e9a59057b5e3a70cb82cb6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298839 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/832dab01db1d..4cbb6ef49709 2020-07-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If27ad984838287eaa453a01fcf4d8bcd47186e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304351Reviewed-by:
-
Ella Ge authored
This CL makes the DecidePermission check if it is possible to get a InstalledWebappGeolocationContext instead of checking the InstalledWebappBridge::ShouldDelegateLocationPermission GetInstalledWebappGeolocationContext() returns nullptr when either not running in TWA mode or should not delegate geolocation to it. It's mostly the same logic as the one in InstalledWebappBridge, except checking the current customtabsactivity instead of the LastTrackedFocusedTwaCustomTabActivity. so it's better using this one. Bug: 1106391 Change-Id: If66b10b44d71d30358088c00245c315be5c15829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303049Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#789393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/587380c5809d..8428d2664eb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: Ia750b6b2c186376c98299eda533e21a7e264e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789392}
-
Mike West authored
This reverts commit b5bdc990. Reason for revert: `MediaRouterViewsUITest.RouteCreationTimeoutForDesktop` started failing after this CL in https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2446?blamelist=1#blamelist-tab. The error message in the related test is https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874579294717582880/+/steps/unit_tests_on_Mac-10.15/0/logs/Deterministic_failure:_MediaRouterViewsUITest.RouteCreationTimeoutForDesktop__status_CRASH_/0: ``` Actual function call count doesn't match EXPECT_CALL(*mock_router_, CreateRouteInternal( _, _, _, _, _, base::TimeDelta::FromSeconds(timeout_seconds), false))... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: 0 unit_tests 0x000000010fcfba8c testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 92 1 unit_tests 0x000000010fcffc05 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() + 597 2 unit_tests 0x000000010fd00521 testing::Mock::VerifyAndClearExpectationsLocked(void*) + 401 3 unit_tests 0x000000010fd00371 testing::Mock::VerifyAndClearExpectations(void*) + 33 4 unit_tests 0x000000010f26566b media_router::MediaRouterViewsUITest::StartCastingAndExpectTimeout(media_router::MediaCastMode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) + 2491 5 unit_tests 0x000000010f2659a4 media_router::MediaRouterViewsUITest_RouteCreationTimeoutForDesktop_Test::TestBody() + 52 Received signal 11 SEGV_MAPERR 000000000008 [0x000114431eb9] [0x000114377dc3] [0x000114431dd1] [0x7fff70e295fd] [0x7fff70de9297] [0x00010f2659a4] [0x00010fd1860d] [0x00010fd193cf] [0x00010fd19d47] [0x00010fd283a7] [0x00010fd27e1f] [0x00011384b7fb] [0x0001138623b3] [0x00011386225f] [0x000113835f25] [0x7fff70c30cc9] [end of stack trace] ``` Bug: 1106647 Original change's description: > [MediaRouter] Add warning for invalid permissions > > This patch adds a new check to the media router views UI that, on Mac OS > X 10.15+ (Catalina), checks if the screen capture permission has been > granted, and shows a warning message and fails to cast if so. > > Bug: 1087236 > Change-Id: I3afdfdb06a011fee3e6fd5f199d375d0ab6eef88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298479 > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Reviewed-by: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789194} TBR=mfoltz@chromium.org,takumif@chromium.org,jophba@chromium.org Change-Id: I64651c90503bf90a2f9cfca99f7929efd35b4c23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302613Reviewed-by:
-
Corentin Wallez authored
Use the concept of "permissions" and "allowed paths" that make the code clearer as well as more inclusive. Bug: chromium:1101491 Change-Id: I374bc95250a97efbd3190d22c82261a6c31a03af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302195Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789390}
-
Adam Rice authored
The transferable streams implementation assumed that two kPull messages couldn't be sent without an intervening chunk. This wasn't true in the case of a compromised renderer, and since https://chromium-review.googlesource.com/c/chromium/src/+/2291180 hasn't been true in general. This change aligns the implementation with the proposed standard at https://chromium-review.googlesource.com/c/chromium/src/+/2291180. This fixes flakiness in the http/tests/streams/transferable/worker.html test. BUG=1106239,1106239 Change-Id: I12c9d011c4a42c8178fcaffa4ddd23e38fb82d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303329Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789389}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vqT-WqhwS504vwcLdBC9Y998VXTrAydEbVVHCjdZSPMC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202007160800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaa9b1d2fae90f6118a7c79ba45192441ea066f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303335Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#789388}
-
Joanmarie Diggs authored
This is a reland of a6bb85c6, which had been reverted due to a unit test failure. The new failure turned out to be a side effect of how the test runner bundles tests and addressed via 0144ebea. This reland includes additional improvements: Treating all style changes on containers with selectable children the same as we do for kListBox, and adding a sanity check for style changes coming from detached objects. Bug: 904977, 1062063, 1085481 AX-Relnotes: Windows and Linux assistive technologies are now notified when text attributes have been changed. This allows them to update any cached information they may have so as not to present stale/inaccurate data about text appearance. In addition, because a notification is emitted when a newly-typed word has a spelling or grammar error, the Orca screen reader now announces when the error indicator appears. Original change's description: > Emit accessible text-attribute-changed events > > * Add TEXT_ATTRIBUTE_CHANGED event so platforms can distinguish this > event from the more generic OTHER_ATTRIBUTE_CHANGED event that was > being fired. > > * Fire TEXT_ATTRIBUTE_CHANGED from the AXEventGenerator for: > - kBackgroundColor > - kColor > - kFontFamily > - kFontSize > - kFontWeight > - kMarkerTypes (e.g. for spelling and grammar errors) > - kTextDirection > - kTextPosition > - kTextStyle > - kTextOverlineStyle > - kTextStrikethroughStyle > - kTextUnderlineStyle > > * Fire state-change event for ATK when ATK_STATE_ENABLED changes. > (Detected as a side effect of debugging an issue with the above) > > * Eliminate some extraneous accessibility events resulting from the > ignored state being changed on an element. > > Bug: 904977, 1062063, 1085481 > > AX-Relnotes: > > Windows and Linux assistive technologies are now notified when text > attributes have been changed. This allows them to update any cached > information they may have so as not to present stale/inaccurate data > about text appearance. > > In addition, because a notification is emitted when a newly-typed word > has a spelling or grammar error, the Orca screen reader now announces > when the error indicator appears. > > Change-Id: I6a070154304f185dcd6343baadb728b0a4beec35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211224 > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778437} Change-Id: I776b86bbb7b691f42d0d2be01f6bd6877009c4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279799Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#789387}
-
Mike West authored
This reverts commit 3d677a19. Reason for revert: `linux-chromeos-dbg` began failing in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19625, with errors along the lines of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874588910239798816/+/steps/browser_tests/0/logs/Deterministic_failure:_CrElementsFingerprintProgressArcV3Test.Fingerprint__status_CRASH_/0: ``` [9471:9471:0716/140802.869423:FATAL:dedicated_worker_host_factory.mojom.cc(574)] Check failed: !connected. DedicatedWorkerHostFactory::CreateWorkerHostCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. #0 0x7f0d6306d98f base::debug::CollectStackTrace() #1 0x7f0d62e1600d base::debug::StackTrace::StackTrace() #2 0x7f0d62e15fc8 base::debug::StackTrace::StackTrace() #3 0x7f0d62e5751b logging::LogMessage::~LogMessage() #4 0x7f0d62e57dfc logging::LogMessage::~LogMessage() #5 0x7f0d62dddf4e logging::CheckError::~CheckError() #6 0x7f0d5b24076d blink::mojom::DedicatedWorkerHostFactory_CreateWorkerHost_ProxyToResponder::OnIsConnectedComplete() ... ``` This CL is the most suspicious in the range. Reverting to see if the bot recovers. Original change's description: > Introduce DedicatedWorkerToken. > > Subsequent CLs will migrate Shared and Service workers to use similar > tokens. This is in support of the performance.measureMemory API, endowing > workers with tokens that can be used as an identifier when communicating > information regarding V8 memory usage. > > BUG=1085129, 1096617 > > Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789141} TBR=falken@chromium.org,chrisha@chromium.org,dtapuska@chromium.org,afakhry@chromium.org,wfh@chromium.org Change-Id: I420aba017ab4a7ac28d94f296355fb434d24cb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085129 Bug: 1096617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302693Reviewed-by:
-
zengqiang authored
If an android application registers the PROCESS_TEXT intent but the exported value of Activity is false, the Chrome android or android webView still displays this menu item. If you click these menu items to start the external activity, the 'java.lang.SecurityException: Permission Denial: start Intent' crash occurs. Bug: 1105292 Change-Id: Ie4a033de25e43d67ec76284e3c21a7c3548b3045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291567 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Qiang Zeng <zengqiang1@huawei.com> Cr-Commit-Position: refs/heads/master@{#789385}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65a88eb4bed0..9acf5844cae6 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6fe87f4a226d to cc5513855cc5 (14 revisions) 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0a8f44c514ce to 0e82586297a8 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Test: Test: Test: CQ Change-Id: I62add8d316697184b4f8ed2f21605b8316017196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304350Reviewed-by:
-
Leo Lai authored
The introduced new class is meant to replace the current fake objects used in various browser tests. BUG=b:158955123 Change-Id: I743bd605321e7f384eb22a9ecac4fb40ae93e980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297062 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789383}
-
François Degros authored
BUG=chromium:912236 TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: I0ea62bb92376ab0ee68aef2a76ab9594c45cf341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303932Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#789382}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I589b5758f6a674c07decd4475504b814e7aefd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303466Reviewed-by:
-
Sven Zheng authored
Previously tryjob failed with: MBErr: Builder name "linux-lacros-rel" not found under masters[tryserver.chromium.linux] in "/b/s/w/ir/cache/builder/src/tools/mb/mb_config.pyl" Bug: 1104291 Change-Id: I1a4b1cb2a306a0d1562da1a0d4e712adfd852cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304311 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789380}
-
Karel Král authored
Refactor function ValueToString from the class base::trace_event::TracedValue into namespace base::trace_event. This is a follow-up of http://crrev.com/c/2299722 Bug: 1103623 Change-Id: Ied92ce36da432d84fef4b186f902c8ac581b416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302029Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#789379}
-
Guillaume Jenkins authored
Moves the ReportGenerator class from chrome/browser to components/enterprise so it can be reused by iOS code. As part of this move, the ReportGenerator constructor now also uses the base ReportingDelegateFactory instead of the desktop-specific one. Bug: 1092425 Change-Id: I634f898486bcec349d81425b3b5714f7a2c34328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298229 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789378}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I73d4b14fbcc444a0042ac8d21e52b6ea219cc584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304195Reviewed-by:
-
Rob Buis authored
When setting host, empty/incorrect port strings should not change the existing port [1, 2]. This CL also applies the new behavior to setting URL port with empty/incorrect value, since the code paths for setting port and host+port are shared. Behavior matches Firefox. [1] https://url.spec.whatwg.org/#host-state Step 2.4 [2] https://url.spec.whatwg.org/#port-state Step 2.2 Change-Id: I2aa62c1acaa4bc9c0f17dbd2e82c2f2bad1ccedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300103Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#789376}
-
Eliot Courtney authored
The current implementation only allows two buffers in flight at a time. This is because a new buffer may only be submitted when an old one is released, and initially clients of WBMH only submit the initial buffer plus one more (because of the immediate ack of the initial buffer). Further, only submitting a new buffer when an old buffer is released means that latency variation in receiving release messages directly translates into increased latency in submitting the next buffer. Under load when running linux Chrome on ChromeOS, IPC shunting release messages back from viz=>exo=>ozone can have latencies in the low tens of milliseconds. If buffers are shown in a separate DRM plane (i.e. not copied) they must be held onto for the duration of scanout. This plus the IPC release latency causes visible performance degredation. Currently this latency cannot be absorbed by the buffer queue in linux Chrome. This change introduces an output queue in WBMH. Note that this does not change the semantics of OnSubmission and OnPresentation (acking). For this change to be useful, clients (e.g. GbmSurfacelessWayland) also need to have an output queue, which I will add in a follow-up CL. In order to provide the guarantees swap ack expects this CL also adds some logic for destroyed buffers and out of order releases. For linux Chrome on ChromeOS, surface sync logic in Viz (in ChromeOS chrome) can cause buffer releases to be re-ordered - the new logic handles this case. Bug: 1062529 Test: added unit tests Test: Run linux chrome on chromeos Test: Run ozone linux chrome on Weston, software and hw accel Change-Id: I3574248c92a8cf12207154052194c0e021d2984f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287334 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#789375}
-
Meilin Wang authored
Bug: b/149246117 Test: unittest. Change-Id: I660ebe59f003b004dca13e19e60f51092528d961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275361 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789374}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d72cb4c076b7..65a88eb4bed0 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 1b9b53a39576 to cb2938a1afd7 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I33b357ec6127493532bc93de4a5ccef4090e8c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304370Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I21855838e72a69c32857e09d67e754267e571e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304369Reviewed-by:
-
Patti authored
This reverts commit cbf18954. Reason for revert: Suspecting this roll to be causing compile failures seen in https://bugs.chromium.org/p/chromium/issues/detail?id=1106623, will revert. Original change's description: > Roll SwiftShader from e8dd233c7a85 to 0e82586297a8 (4 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 > > 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) > 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 > 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs > 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789366} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I30ccd584ef929ccfd353f208fed4537d1d13f443 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302980Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie0ed5ccb637c1e3f17ed54ef1face49db93ae974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304331Reviewed-by:
-
Daniel Libby authored
Get rid of some cpplint warnings in these files. R=bokan@chromium.org Change-Id: I49793a90c4341e728dcde65c9509727597a4d582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302713 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15083559691..587380c5809d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1092528,chromium:1101179,chromium:1101820,chromium:812428 Tbr: patricialor@google.com Change-Id: If875208936d3c27ae7c4fc2033fc2b0c02b9c77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304141Reviewed-by:
-
