- 04 Jun, 2013 40 commits
-
-
sbc@chromium.org authored
This allows libraries installed by naclports "make" commands to be visible to create_nmf by default. BUG=179526 R=binji@chromium.org Review URL: https://codereview.chromium.org/15896036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203977 0039d316-1c4b-4281-b951-d872f2087c98
-
pam@chromium.org authored
Introduces a new Profile::CREATE_STATUS_REMOTE_FAIL type, and renames CREATE_STATUS_FAIL to CREATE_STATUS_LOCAL_FAIL. Adds callbacks and reorganizes profile creation to allow registration errors to propagate back up to the UI layer, and displays them in the profile creation dialog. Adds a spinner to the creation dialog. Adds UMA metrics. BUG=234991 TEST=manual Review URL: https://chromiumcodereview.appspot.com/15774008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203976 0039d316-1c4b-4281-b951-d872f2087c98
-
miguelg@chromium.org authored
- use them in the different components - minor cleanup of some of the elements while at it BUG=135948 Review URL: https://chromiumcodereview.appspot.com/15533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203975 0039d316-1c4b-4281-b951-d872f2087c98
-
sreeram@chromium.org authored
BUG=246634 NOTRY=true TBR=beaudoin@chromium.org TEST=none Review URL: https://codereview.chromium.org/15979028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203974 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
The previous patch (r203795) is not a good way because chrome.app.window.contentWindow is always undefined. This patch introduced another method to check if it is running as apps instead. BUG=243414 TEST=Confirm a close button works correctly on normal Files.app and doesn't work on chrome://files. R=mtomasz@chromium.org Review URL: https://chromiumcodereview.appspot.com/16207004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203969 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
If ProfileSyncService gets a transient network error trying to contact the backend, we no longer treat this as a fatal signin error. Also, we no longer display a "wait for the backend to startup" spinner in cases where we know the spinner will immediately be dismissed, to avoid a gnarly infinite loop in the UI code. BUG=244769 Review URL: https://chromiumcodereview.appspot.com/16173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203968 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
> Remove Activity Log usage of Extension objects > > Previously, the AL used Extension objects when notifying the UI of new activity. If an extension were uninstalled in the middle of logging something, the Extension object would be deallocated before the UI tried to use the reference. Since we are replacing the old UI, I am switching to using IDs instead of Extension objects. > > [[[ Reverted because it was causing heapcheck failures. Retrying a new version. ]]] > > BUG=236395 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203218 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203618 > > Review URL: https://chromiumcodereview.appspot.com/15686007 TBR=felt@chromium.org Review URL: https://codereview.chromium.org/16286017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203967 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
NOTRY=true BUG=NONE Review URL: https://chromiumcodereview.appspot.com/15894027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203964 0039d316-1c4b-4281-b951-d872f2087c98
-
nhiroki@chromium.org authored
BUG=243616 TEST=pass all existing tests Review URL: https://chromiumcodereview.appspot.com/16063009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203963 0039d316-1c4b-4281-b951-d872f2087c98
-
dharcourt@chromium.org authored
Previously the height of window title bars was added to the maximum content size of windows only if there was a maximum width as well as a maximum height. This fixes that so it's possible to specify maxHeight without specifying maxWidth to chrome.app.window.create(). BUG=246289 Review URL: https://chromiumcodereview.appspot.com/15969028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203962 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
Renaming on Drive takes significant amount of time. Renaming and immediately entering a directory, caused later staying in a directory which no more exists. This patch resolves this issue by changing to the new directory from the old one, once the renaming operation is finished. TEST=Create a directory, enter some different name, double hit ENTER. Try to create a directory again. Should not fail. BUG=227456 Review URL: https://chromiumcodereview.appspot.com/16351002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203961 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
BUG=229762 Review URL: https://chromiumcodereview.appspot.com/15896016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203960 0039d316-1c4b-4281-b951-d872f2087c98
-
pan.deng@intel.com authored
Since blink use content_shell to run layout test, we need to expose net::LoadTimingInfo through content_shell Contributed by pan.deng@intel.com BUG=246117 Review URL: https://chromiumcodereview.appspot.com/16324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203959 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=234837 Review URL: https://chromiumcodereview.appspot.com/16231016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203958 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
To use ISO_Level5_Shift modifier, we have to do same things as German Neo Keyboard. BUG=240980 TEST=Manually checked on link Review URL: https://chromiumcodereview.appspot.com/16222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203957 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
BUG=245053 TEST=manual R=mtomasz@chromium.org Review URL: https://chromiumcodereview.appspot.com/15761006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203956 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The term "feed" is irrelevant with Drive API, hence should not be used in code. BUG=165395 TEST=none Review URL: https://chromiumcodereview.appspot.com/16072024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203955 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Change NativeMediaFileUtil from the synchronous file util interface to AsyncFileUtil in order to support Picasa and iTunes file utils, which have to bounce to the utility process. Also remove unused write ops from NativeMediaFileUtil. BUG=151701 Review URL: https://chromiumcodereview.appspot.com/16304002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203954 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelbai@chromium.org authored
SQLiteCursor could be destroyed in Java object's finalize method, and UI message loop might already shutdown, we need to check if the post task succeeds, then wait for callback. BUG=239482 Review URL: https://chromiumcodereview.appspot.com/15701011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203953 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
Don't display the "charging not reliable" battery status in the non-charging-non-discharging state, as that can happen normally in some circumstances. Also, update the string to be more human-friendly. BUG=246336 TEST=manual, see bug Review URL: https://chromiumcodereview.appspot.com/16057022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203952 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203951 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
Previously, the AL used Extension objects when notifying the UI of new activity. If an extension were uninstalled in the middle of logging something, the Extension object would be deallocated before the UI tried to use the reference. Since we are replacing the old UI, I am switching to using IDs instead of Extension objects. [[[ Reverted because it was causing heapcheck failures. Retrying a new version. ]]] BUG=236395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203618 Review URL: https://chromiumcodereview.appspot.com/15686007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203950 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=reed@google.com Review URL: https://codereview.chromium.org/15995025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203949 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=danno@chromium.org BUG=246567 TEST=waterfall Review URL: https://codereview.chromium.org/15993010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203948 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203947 0039d316-1c4b-4281-b951-d872f2087c98
-
lushnikov@chromium.org authored
TBR=jamesr BUG= Review URL: https://codereview.chromium.org/16360004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203946 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
As prerequiste for linked bug. TBR=palmer@chromium.org R=jam@chromium.org,jamesr@chromium.org BUG=246357 Review URL: https://chromiumcodereview.appspot.com/16325022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203945 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=Samusaaron3@gmail.com BUG=246560 TEST=waterfall Review URL: https://codereview.chromium.org/15934011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203943 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203942 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=246098 Review URL: https://chromiumcodereview.appspot.com/16321002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203941 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=245693 Review URL: https://chromiumcodereview.appspot.com/16278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203940 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
BUG=221813 TEST=compile chrome TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/16067007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203939 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/16057010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203938 0039d316-1c4b-4281-b951-d872f2087c98
-
jinsukkim@chromium.org authored
A couple of exceptions: '... for your computer and mobile devices' -> 'computer and other devices' 'For mobile device' -> 'For Android device' These occur in the field 'desc', so don't affect the translation. They are all about Android device and 'Android device' seems better than just 'For device' to me. BUG=242805 Review URL: https://chromiumcodereview.appspot.com/15980011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203937 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
We shouldn't do find-in-page while a IME is composing. This CL delays the actual search until the IME composition is committed. BUG=158911 TEST=Test manually. Review URL: https://chromiumcodereview.appspot.com/15841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203936 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
A client's didReceiveResponse can cancel a request; by protecting the Context we avoid a use after free in this case. Interestingly, we really had very good warning about this problem, see https://codereview.chromium.org/11900002/ back in January. R=darin BUG=241139 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202821 Review URL: https://chromiumcodereview.appspot.com/15738007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203935 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=111316 R=marja@chromium.org Review URL: https://codereview.chromium.org/15979019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203934 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
Originally getter StepsRunner.next has a side effect, thus if it is called twice in one step, it shows unexpected behaviors. This CL removed the side effect. BUG=246463 TEST=browser_tests Review URL: https://chromiumcodereview.appspot.com/15682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203933 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/16217003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203930 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
R=jvoung@chromium.org BUG= https://code.google.com/p/chromium/issues/detail?id=246092 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372 TEST= unit_tests --gtest_filter=PNaClTranslationCacheTest.* Review URL: https://chromiumcodereview.appspot.com/16295020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203929 0039d316-1c4b-4281-b951-d872f2087c98
-