- 02 Jun, 2020 40 commits
-
-
Peter Marshall authored
This reverts commit 7e18556b. Reason for revert: Breaks devtools overlay: crbug.com/1090280 and link hovering: https://bugs.chromium.org/p/chromium/issues/detail?id=841792#c24 Original change's description: > Mac: don't use a custom tracking area in BridgedContentView > > Currently, in BridgedContentView we "opt out"[1] of BaseView's tracking area to install a different one which: > - Specifies `NSTrackingCursorUpdate` > - As a consequence, only tracks while app is active, since the docs say that always tracking is incompatible with cursor updates > > However: > - Empirically, cursor updates work fine without this (some test cases: move mouse between Omnibox and other parts of topchrome, move from webcontent links/inputs to topchrome and vice-versa). > - Only tracking while app is active means we don't get entered/exited events from app switching. This means: > - Switching away from Chrome while showing a topchrome hover tooltip keeps the hover on and makes the tooltip stuck > - Under some circumstances, hover stops working on switching back to Chrome (see bug) > - Even though we allow mouse clicks to function when Chrome is inactive (that is, we return `YES` from `acceptsFirstMouse:`, we don't process hovers in this case, contrary to other apps on the system. > > This change removes BridgedContentView's tracking area in favor of the default one and gives BaseView some explicit enable/disables, mostly to make tests happy. > > [1] By overriding a private method with a no-op! > > Bug: 841792 > > Change-Id: Ifb5d65e22299959b8cac25a9e0a0407650a40746 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216530 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773848} TBR=ellyjones@chromium.org,avi@chromium.org,lgrey@chromium.org Change-Id: Ic1344adb7cdf271636026a2b1e6def014852416f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841792, 1090280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223949Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774088}
-
Nohemi Fernandez authored
This enables the option on iOS Signout to clear all Chrome browsing data in preparation for release to Stable. Bug: 1005509 Change-Id: Ice46f42e681380d82c593d5b61a35701fc082acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214899Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#774087}
-
Olivier Robin authored
Bug: 1070996 Change-Id: I5797d54bf3689aba27854b01ef17e1efaff828e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218776 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774086}
-
Anatoliy Potapchuk authored
This will help us deduplicate some parts of kiosk session startup code. Bug: 1086414 Change-Id: I783ab28fa7fb2b2c9c7e7410a5802d2a98b94686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215845Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#774085}
-
Dominic Mazzoni authored
In http://crrev.com/c/2148248 we added support for computing the preferred language for a request, which isn't necessarily the same as the user's primary language or the primary language of the web page being visited. However, the request key we were expecting to get from the server was being generated based on the original language tag - while the request key computed from the server response was based on the computed language. As a result, if the computed language differed from the page language they didn't match and getting results would fail. The fix is just to compute the preferred language before we generate the request key. Bug: 1090234, 1070505 AX-Relnotes: N/A Change-Id: Ia2b4038d9e634c6908478333aae6c00781fba49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226300 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774084}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8dfdbeff84f3..f050cca7ec47 2020-05-29 andreperezmaselco.developer@gmail.com spirv-fuzz: Add push id through variable transformation (#3359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I012fe5be2d6b4c65edfb9cead0cf5fd2698f6d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774083}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/588bee56..125327ff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic2e9f7ebc1c1c6adc24eced6e4c997f75f96407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226437Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774082}
-
Eric Seckler authored
In order to support Perfetto-powered typed trace events in //base, we will add a dependency on //third_party/perfetto. This dependency would be hard to support in libchrome -- for that reason, we're making tracing support in //base optional at build time. This patch introduces a gn arg that enables base's tracing support. Disabling it is not supported in Chrome, but base_unittests and libchrome can also be built & run with enable_base_tracing=false. When support is disabled, a large part of the TRACE_EVENT API surface is mocked out with an empty implementation, so that few other places in //base code require preprocessor ifdefs. Doc: https://docs.google.com/document/d/1UQ4Ez7B-TeowijOUuMXuoWj1amZcQ7E2abt3s4jaAEY/edit?usp=sharing Test: args.gn: enable_base_tracing=false Bug: 1065905,1006541 Change-Id: I067e85411c51659626af0713ccfa6c18cfffc3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207225 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#774081}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/255926129b10..255362421f9e 2020-06-02 bmeurer@chromium.org Revert "Introducing a general UI interaction test for the Network panel" 2020-06-02 jacktfranklin@chromium.org Move removeURLFragment out of string utils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5658fce2fe0fc051c466465d0935388aa0c46d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226539Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591055861-b616b8ef5787fabc8c6bebc449f3453e58d43322.profdata to chrome-win64-master-1591084785-a13dc6edcaafb35c86311be7a5b625cf7a7ba201.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7b4e4f2cba3d7d48d9737f186d6613092d9eb065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226537Reviewed-by:
-
Thiemo Nagel authored
This reverts commit 926cd1f5. Reason for revert: Flakiness in BackGestureBrowserTest.PreventDefault Three failures observed on linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel https://chromium-swarm.appspot.com/task?id=4c8d35366f7d4710#BackGestureBrowserTest.PreventDefault,BackGestureBrowserTest.TouchActions,DemoSetupArcSupportedTest.ShowOfflineSetupOptionOnNetworkList,NetworkQualityTrackerBrowserTest.SimulateNetworkServiceCrash,SwitchAccessPredicateTest.LeafPredicate,TopControlsSlideControllerTest.DisplayRotation ../../chrome/browser/ui/ash/back_gesture_browsertest.cc:210: Failure Value of: recorder.HasReceivedEvent(ui::EventType::ET_KEY_PRESSED) Actual: true Expected: false Stack trace: #0 0x5585e4320fef BackGestureBrowserTest_PreventDefault_Test::RunTestOnMainThread() #1 0x5585e7da383d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5585e7900459 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #3 0x5585e78ff599 ChromeBrowserMainParts::PreMainMessageLoopRun() #4 0x5585e4a12dd9 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #5 0x5585e5c7fd84 content::BrowserMainLoop::PreMainMessageLoopRun() #6 0x5585e6079033 content::StartupTaskRunner::RunAllTasksNow() #7 0x5585e5c7ed8a content::BrowserMainLoop::CreateStartupTasks() #8 0x5585e5c81611 content::BrowserMainRunnerImpl::Initialize() #9 0x5585e5c7d3ad content::BrowserMain() #10 0x5585e7384f2d content::ContentMainRunnerImpl::RunServiceManager() #11 0x5585e73849b7 content::ContentMainRunnerImpl::Run() #12 0x5585e99d13d5 service_manager::Main() #13 0x5585e67835d4 content::ContentMain() #14 0x5585e7da33ba content::BrowserTestBase::SetUp() #15 0x5585e77dca3a InProcessBrowserTest::SetUp() Original change's description: > back gesture: Disable back gesture for {touch-action:none} web pages/apps. > > Bug: 1063144 > Change-Id: I85379cc2f4aded28ac9eefb09e2086d446f42168 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773852} TBR=sky@chromium.org,xdai@chromium.org,dtapuska@chromium.org,afakhry@chromium.org Change-Id: I5123a071659d23d7731a55d1420442c9b878b8bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225764Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774078}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/77e5316a515d..f8cc88b1e126 2020-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 500f77901f6d to 515b4041cc32 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I8553f267c0f264b287ae255bc542008f36048c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226467Reviewed-by:
-
Mark Brand authored
This patch passes the '--sm-disable' flag to openbox so that it doesn't try to use session management. If this flag is not passed, and openbox can connect to a valid x11 session manager (ie. configured in SESSION_MANAGER environment variable) then it will logout the current desktop session when it exits. Bug: 1090267 Change-Id: I3e0926596b1e64f7fcd5f51fd4ce78439582def6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193573Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#774076}
-
Friedrich Horschig authored
The metrics are used to guard regressions when the settings interface changes and should therefore (at the very least) be useful for another three milestones. Bug: 1089219 Change-Id: I9ae5478873a3461e12478138e35a2898387e3763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223944Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774075}
-
Lukasz Krakowiak authored
This change replaces base::RunLoop::QuitCurrentWhenIdleClosureDeprecated() call with a run_loop_->QuitWhenIdleClosure() call on RunLoop instance. Bug: 922118 Change-Id: Iaba52f507fad10859d3951e54134ce28c85ba02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215325 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#774074}
-
Olivier Robin authored
Change-Id: Ice70e2f999ce75c0f7c931c321bd2a6a1938248e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218177 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "khmer-selection.html" independent from platform dependent hit test behavior "move cart to boundary when hit point is above/below line." for a preparation of enabling EditingNG. Before this patch, the test simulates to move mouse pointer at top of the document, e.g. document.body.offseTop == 8. This patch changes it in text. Bug: 707656 Change-Id: Idae2250f392b19aead6fb9a75ab654a7fbc4007e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226380 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e714d17672f2..827cd8d44db7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I78e48b7342ac1b416b9d8707ff123d6a76b106f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774071}
-
Jochen Eisinger authored
This reverts commit d67cf55d. Reason for revert: Still breaks some SSO flows Original change's description: > Enable IntentBlockExternalFormRedirectsNoGesture by default > > Bug: 927509 > Change-Id: I56ec8b5cf524a4e1d14b29427931802f80d54a3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132197 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771584} TBR=tedchoc@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927509 Change-Id: I2fb4e6b38de9224cbf1f3be8dd3fd241bb860b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225898Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774070}
-
Kent Tamura authored
Before this CL ScrollableOverflow in LayoutNG was always larger than the line's bounding box. It was not compatible with the legacy layout, and it's helpless for <rt> positioning. This CL makes ScrollableOveflow compatible with the legacy layout. Bug: 1069817 Change-Id: I876874966088a59fdc218a83342c1d0e4c68ee87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225685 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591070241-ce04e1e2e870e385b3dffbd254a1f6cdfc41d3e5.profdata to chrome-mac-master-1591084785-865c57c71e414edfb8df16d78c98449eb450ba64.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I96c46df78d6290decf81d0f36b0c2c926931670a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226474Reviewed-by:
-
Fergal Daly authored
Change-Id: I65c8b0d59b8d8d3dd70ef30da2586e06f18b3077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226477 Auto-Submit: Fergal Daly <fergal@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#774067}
-
Ioana Pandele authored
This CL adds metrics for toggle impressions, toggle clicks and keyboard accessory impressions when saving is disabled. Bug: 1044930 Change-Id: I6501d1c4eb8dc21302f0b465c3974fb85487a99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213540Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#774066}
-
arthursonzogni authored
Reported by antoniosartori@, there was an error in the test: "blocked_iframe-are-cross-origin.html" In Javascript, lambda capture is done by reference. The reference was the loop 'variable'. As a result the second test case was run twice. The first test case couldn't work, because embedded enforcement do not apply to same-origin iframes. The patch fixes the test. TBR=mkwst@chromium.org Bug: 1041376 Change-Id: Id5f223aa138470cb263eea5b0af9f616a314a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218049Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774065}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0cc27fb68c0e..78a3c915a1d7 2020-06-02 rdb@users.noreply.github.com HLSL: Add better diagnostic when using in/out qualifiers in global scope (#2258) 2020-06-02 rdb@users.noreply.github.com HLSL: Recognize POSITION semantic et al in DX9 compatibility mode (#2255) 2020-06-02 rdb@users.noreply.github.com HLSL: fix handling of uniform qualifier in entry point parameters (#2254) 2020-06-02 40001162+alelenv@users.noreply.github.com Add default descriptorset decoration for acceleration structure (#2257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ife405f36b088842eee2b3f444165f7d990c73952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226462Reviewed-by:
-
Thiemo Nagel authored
This reverts commit 6cb8f1ee. Reason for revert: Could this be causing BookmarkBarViewTest22.CloseSourceBrowserDuringDrag failures? [0602/000817.871182:ERROR:test_launcher.cc(1041)] no test result for BookmarkBarViewTest22.CloseSourceBrowserDuringDrag [ RUN ] BookmarkBarViewTest22.CloseSourceBrowserDuringDrag X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 25 (X_SendEvent) Resource id in failed request: 0x600010 Serial number of failed request: 560 Current serial number in output stream: 563 [144/291] BookmarkBarViewTest22.CloseSourceBrowserDuringDrag (159 ms) https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests https://chromium-swarm.appspot.com/task?id=4c8cabe25bd9e510#BookmarkBarViewTest22.CloseSourceBrowserDuringDrag,WebViewFocusInteractiveTest.Focus_FocusEvent Original change's description: > [ozone/x11] Moved the DnD handling from X11WindowOzone to X11Window. > > This CL is the first step that prepares us to get rid of DWTHX11. > > As we proceed with that, at some point we will have to throw off the > DesktopDragDropClientAuraX11 because it is used by DWTHX11, and migrate > DnD to DDDCOzone. As the latter will be used on both Ozone and > non-Ozone, it needs the X11window to handle DnD. > > Hence this change. I move the DnD-related code from X11WindowOzone into > X11Window. > > Change-Id: I682c794d9cfab4b7ad6b6a9b89331526f31d227a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213578 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#774026} TBR=thomasanderson@chromium.org,msisov@igalia.com,adunaev@igalia.com Change-Id: I2d5147265dab2e820bcb5467530df280f0bf1823 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223945Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/db5db9a0afbe..255926129b10 2020-06-02 patrick.brosset@microsoft.com Introducing a general UI interaction test for the Network panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5e718f75fd63505303e228d73deaaab6105df497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226464Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5d0662b82d0..e246638c18ca 2020-06-02 fancl@chromium.org Use bug_id and project in AlertGroup instead of alert If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1090225 Tbr: wenbinzhang@google.com Change-Id: Ib75382ecf028bae22c1aaadb4b4d1dce72180605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226466Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id19328132035b613bf80c61df784182b6e76162e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226463Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3288b2d9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia201abbe95ab31794f22e11576f9d0c5b43f466a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774059}
-
Johann authored
run_blink_wptserve.py has no way of knowing which gen/ directory to serve files from. Document this fact. R=qyearsley@chromium.org Change-Id: Ia5caef49b7333e695665ca921790c4dedb30ac22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217275 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#774058}
-
Thiemo Nagel authored
This reverts commit 40342cdf. Reason for revert: It seems the CL has introduced high levels of flakiness in BackForwardCacheBrowserTest.DoesNotCachePaymentManager See e.g.: https://chromium-swarm.appspot.com/task?id=4c8c1a19978bfe10 Mac10.10 Tests has failed six times: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests?limit=200 Original change's description: > [bfcache] Blocklist documents/frames using PaymentManager > > As a note - this patch jumps from 47 to 49 in WebSchedulerTrackedFeature so as to prevent merge conflicts with the patch here: > https://chromium-review.googlesource.com/c/chromium/src/+/2212934 > > Some background on why we sometimes need to disable bfcache: > https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 > > Change-Id: I884e7b5262938c453cea7e1792b505c3a55447bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225355 > Commit-Queue: Harkiran Bolaria <hbolaria@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773982} TBR=nasko@chromium.org,haraken@chromium.org,altimin@chromium.org,hbolaria@google.com Change-Id: Id7b7cdaaed0815addf65795cb664d33520e6d841 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223943Reviewed-by:
-
Ravjit Singh Uppal authored
Bug: 1073883 Change-Id: I64bd8568ca8e9ab904f2159a3c69b99c13688a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218041 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774056}
-
Alex Rudenko authored
This reverts commit 176ec212. Reason for revert: the overlay seems broken on master, I'd like to revert to see if the merge caused it Original change's description: > [DevTools]: Remove highlight tool and use new resources from DevTools > > This CL removes inspect_tool_highlight.html and replaces it with > resources produced by DevTools[1], where the implementation has been > moved to in a separate CL[2]. > > [1]: https://goo.gle/devtools-overlay-reuse > [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892 > > Bug: 1078267 > Change-Id: I95d3faef98470e13430ed251cf135e59269358d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194865 > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774030} TBR=thakis@chromium.org,gbiv@chromium.org,petermarshall@chromium.org,jochen@chromium.org,blundell@google.com,mathias@chromium.org,alexrudenko@chromium.org Change-Id: I8b5b97d040e15b80441295ebe96e5b408f73bb72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225718Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "directionality-after-undo-replace.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ib3b187db88c54a79ba44023f1e2b1c655534232f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226323 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfe5e4df6de2..e714d17672f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ortuno@google.com Change-Id: I43b6d055a1c31654590022b8b7070186c2c4eb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226396Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b9f640ad..588bee56 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66fd2e37b17c74308468c7275c2545d182996801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226436Reviewed-by:
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: I12c279457aa360cbb0cd9ea53a4ae54db4d4d051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226003 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591012454-0e17033bf0adb2d9001d6af97cdfcbf8391457fc.profdata to chrome-win32-master-1591070241-638ab9c3267df589aa252b26b8cbbae9d2449ff5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e160f21adfbcc27ecf6ed64c0c2d5ca1f6c7d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226055Reviewed-by:
-
Mansi Awasthi authored
This change adds struct PP_PrivateAccessibilityChoiceFieldInfo to PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related PDF choice field data from the plugin process to the mimehandler process. Made the same changes to the C++ versions of these structs and added the appropriate conversion code. Bug: 1030242 Change-Id: I7aa6fd612de051d9e6b22e84e60c964d24685242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214734 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774049}
-
