- 19 Sep, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c173be04cac2..d6ef217affb3 $ git log c173be04c..d6ef217af --date=short --no-merges --format='%ad %ae %s' 2017-09-18 simonhatch Dashboard - Append n=1000 to show large chromium ranges. 2017-09-18 dtu [pinpoint] Bold Commit subject in bug comment. Created with: roll-dep src/third_party/catapult BUG=753029 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ief0bdee37bfbb217170b2bb5fd7bf568649f46b9 Reviewed-on: https://chromium-review.googlesource.com/672150 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502773}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d0cd2b3c. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2044 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Iec7cebc9cdd8a985060d663c9dbd4cf67bede11e Reviewed-on: https://chromium-review.googlesource.com/671155 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502772}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c86d0794ed37..8e258318e68f $ git log c86d0794e..8e258318e --date=short --no-merges --format='%ad %ae %s' 2017-09-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 10ce2d284..8b2142e37 (1 commit) Created with: roll-dep src/third_party/skia BUG=697758 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I23c180e9f9415729b04e82b733299c81f4ada579 Reviewed-on: https://chromium-review.googlesource.com/672143Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502771}
-
Xiaocheng Hu authored
This patch changes inclusions of Position.h in header files to forward declaration as much as possible to optimize compile time. Bug: 706527 Change-Id: I3597b0a2862dae6a89a754513a2d8ca2a5ead4a1 Reviewed-on: https://chromium-review.googlesource.com/670580 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502770}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I46f40b81ddd7836333b8522897057fb09a1c5b2a Reviewed-on: https://chromium-review.googlesource.com/671038Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#502769}
-
Reza.Zakerinasab authored
ImageData::ImageDataInCanvasColorSettings() creates an extra copy of data when image data uses U16 storage format and data must get converted from Little Endian to Big Endian. This change refactors this function to remove this extra copy. Bug: 766018 Change-Id: I54b90f79887be884449d0d4739c990e21bc6aa5b Reviewed-on: https://chromium-review.googlesource.com/670520Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#502768}
-
Xiaocheng Hu authored
This patch changes inclusions of EphemeralRange.h in header files to forward declaration as much as possible to optimize compile time. To make this change: - StaticRange::Create(EphemeralRange) is moved to .cpp file - The removal of the inclusion of EphemeralRange.h from WebRange.h resulted in a lot of inclusions of some other header files in other .cpp files. Bug: 706527 Change-Id: I922d5d02f50aae4f1c0730fd1aab1a1659e0b898 Reviewed-on: https://chromium-review.googlesource.com/670164Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#502767}
-
Chandan Padhi authored
Currently, TraceOutputter is a global instance created in a thread-unsafe way. This is a problem on android webview which runs gpu service on two different threads in the same process. With this CL, one TraceOutputter is created per thread for each of GpuChannelManager and InProcessCommandBuffer::Service. It also makes TraceOutputter non-ref-counted. Bug: 752528 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I32758531c7ed7fbaf5dd24b3349c5e24c149b7cc Reviewed-on: https://chromium-review.googlesource.com/667296Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#502766}
-
Takuto Ikuta authored
With this CL, some compile task can run without waiting link of //extensions/common There are many compile tasks depend on some json_features targets, and such compile tasks wait finish of link in //extensions/common in deps of json_features action. But //extensions/common is not used in code generation, so we can move it to deps of source_set. After moving to source_set, compile tasks in some targets depend on json_features no need to wait finish of link in //extensions/common, because gn knows object files only depend on source files. gn can't find such unnecessary dependency if link is in deps of action. ninja trace from building chrome without this CL. http://chromium-build-stats.appspot.com/ninja_log/upload/ninja_log.ULVV1ZrTGHxHCPKRs4uVIbYdrYmR2QkE-yjpfNJwCeI=.gz/trace.html ninja trace from building chrome with this CL. http://chromium-build-stats.appspot.com/ninja_log/upload/ninja_log.KRBZxtDbA2CEAq1J8eBrfI_iy6pi8GL0XPj54IiiLM0=.gz/trace.html Improved build time few seconds on Z840 linux. Bug: 725639 Change-Id: I80739045663d08236266b0697c40758e53773c59 Reviewed-on: https://chromium-review.googlesource.com/668343 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502765}
-
Scott Graham authored
Mostly just triaging and assigning bugs for specific tests. I couldn't repro these three ServiceWorkerDatabaseTest.DatabaseVersion_CorruptedSchemaVersion ServiceWorkerProviderHostTest.ActiveIsNotController WebContentsAudioInputStreamTest.MirroringOneStreamAfterTargetChange/0 so optimistically try enabling them. (URLLoaderImplTest.* are fixed by https://chromium-review.googlesource.com/c/chromium/src/+/671767 which is in review). Bug: 766356, 766360, 766362, 754861, 766223 Change-Id: I781b158a0b53277e7809c69a506df89911a348aa Reviewed-on: https://chromium-review.googlesource.com/671214 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#502764}
-
Yutaka Hirano authored
https://github.com/whatwg/html/issues/689 Bug: 752421 Change-Id: I12d9cc6f4556011729e1f4245868b864718e1f08 Reviewed-on: https://chromium-review.googlesource.com/666366 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#502763}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/29b7891d920f..59aa827d6b41 $ git log 29b7891d9..59aa827d6 --date=short --no-merges --format='%ad %ae %s' 2017-09-08 art-snake Use CPDF_ReadValidator to request linearized first page. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iae8398e25f83468baf317c0346e7176c2e3ab599 Reviewed-on: https://chromium-review.googlesource.com/671932 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502762}
-
Gregory Chatzinoff authored
This CL removes the IDC_SHOW_MAIL_COMPOSER command. The sole use of this command is in the Net Export WebUI page, so the command was replaced with a NetExportTabHelper that can trigger the Mail Composer UI. As a part of this removal, the CL replaces ShowMailComposerCommand with a context object. Since this was the last command supported by BVC, this CL also removes BVC's implementation of chromeExecuteCommand. Bug: 738881 Change-Id: I4c765ffc93c95aa313867161a8dfb04708a06497 Reviewed-on: https://chromium-review.googlesource.com/667810 Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#502761}
-
Tsuyoshi Horo authored
We already have OmniboxCombinedSpeculativeServiceWorker study on the server side. I think we need this test config on fieldtrial_testing_config.json. Bug: 732681 Change-Id: I568442e41a884b3995e50970a60e3f7309d2a513 Reviewed-on: https://chromium-review.googlesource.com/668349 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#502760}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/441164c72d1c..c173be04cac2 $ git log 441164c72..c173be04c --date=short --no-merges --format='%ad %ae %s' 2017-09-18 yukiy Rename cache_temperature states 2017-09-18 dtu [pinpoint] No taskqueue retries. Created with: roll-dep src/third_party/catapult BUG=736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I755e4e7a7ef8c47d4d7c525026427828b245d7e4 Reviewed-on: https://chromium-review.googlesource.com/671677 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502759}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03b690ef..dcf4cac7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib3b8692652cb930f741508f31b2f4d6c5e82ba91 Reviewed-on: https://chromium-review.googlesource.com/671726Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#502758}
-
John Budorick authored
This also switches from running tests through the butler to running tests alongside the butler s.t. we can independently control process lifetimes. Bug: 721889 Change-Id: I176b7340d9b3f097ad660b66ea64ffb4816287a8 Reviewed-on: https://chromium-review.googlesource.com/667808 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#502757}
-
Justin Cohen authored
The proper solution is to either way for ios/clean or refactor BVC to use topLayoutGuide. Unfortunately, this change will require more than just replacing usinag of StatusBarHeight, it will also require refactoring various portions of BVC so layout happens within -viewSeAreaInsetsDidChange. Instead, take advantage of the fact that, for now, the status bar frame can be used to fake the topLayoutGuide, and can be used at anytime. Bug: Change-Id: I7b05ce78a0104884fb77d21be512c641b1da0e95 Reviewed-on: https://chromium-review.googlesource.com/669484Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502756}
-
Ria Jiang authored
Based on discussions in https://chromium-review.googlesource.com/c/chromium/src/+/639954, WindowId.ToClientWindowId is confusing as it implies mapping but we are only using it to change the data type from WindowId to ClientWindowId. Remove it and update call sites. Bug: none Test: covered by tests Change-Id: I69bea9c002991955cee0426f85ebbdeca4cfbd09 Reviewed-on: https://chromium-review.googlesource.com/671106Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#502755}
-
Xiaochu Liu authored
It exposes a dbus method call LoadComponent that calls component updater API to install a chrome os component. BUG=chromium:763415 TEST=dbus-send is working on chrome os, component is downloaded. Change-Id: Iffd98416484b960352f4aa5724b7759a7936569f Reviewed-on: https://chromium-review.googlesource.com/668739Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502754}
-
Sidney San Martín authored
Change several small things after a review by bettes@: - Make the shelf slightly shorter. - Align the menu with the edges of the menu button. - Ditch the download started animation. - Update the look of Harmony buttons. - Use slightly darker icon colors. - Make the progress indicator stroke slightly thinner and move it inside the circle. Also: - Fix broken hover button active states (a switch statement was missing some `break`s). - Fix a hang on 10.11 (-viewWillDraw happens too late in the update cycle for some changes, -layout is early enough). Bug: 589943, 517992 Change-Id: I4f10f5267b676f4f7e5f9b53d80991efe3960423 Reviewed-on: https://chromium-review.googlesource.com/671144Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502753}
-
Daniel Park authored
Saves the current date in a SharedPreference when Chrome Home is first enabled. Removes the preference if Chrome Home is disabled. Bug: 739952 Change-Id: I6f0b1bd9693a7532616bdda8b4ad4bf74fdadaef Reviewed-on: https://chromium-review.googlesource.com/663832 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#502752}
-
Daniel Erat authored
Make ash::PowerButtonController force the backlights off three seconds after screen locking starts when the --force-clamshell-power-button flag is set. This avoids a long, awkward period where the display is on with the lock screen visible. The behavior on convertible and clamshell devices that don't have the flag is unchanged. Bug: 758574 Change-Id: I5a645def1205948419d7cbb711fbdbc2daaaf9e7 Reviewed-on: https://chromium-review.googlesource.com/671669Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#502751}
-
Daniel Cheng authored
This should only be called for local main frames, so just change the checks to DCHECKs. Change-Id: Ie82b446ab78ab06c9f6e741b6b4f1cb0a8f1a24d Reviewed-on: https://chromium-review.googlesource.com/665877 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502750}
-
kapishnikov authored
Do not enforce ICronetEngineBuilder.setLibraryLoader() in Java and Native builder implementations by default. Instead introduce a new NativeCronetEngineBuilderWithLibraryLoaderImpl class that enforces the library loader. BUG=766248 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ie78383084cd68b31f4a87463763891bd30368d21 Reviewed-on: https://chromium-review.googlesource.com/671416Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502749}
-
Rob Buis authored
Remove default value for title parameter in createHTMLDocument IDL as it is not mentioned in the spec [1]. In order not to break the binding provide a default value in the createHTMLDocument implementation. [1] https://dom.spec.whatwg.org/#ref-for-dom-domimplementation-createhtmldocument Bug: 335871 Change-Id: I3ae8cc5e4ccc191610bf29e997af0eeab70bac40 Reviewed-on: https://chromium-review.googlesource.com/669391Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502748}
-
Mark Pearson authored
Previously these keyword would not be recognized because we try to clean up the user's input before checking to see if it matches a keyword. This changelist makes use only try various cleaning of the user's input until we get a match (or tried all the cleaning steps we have). For example if the input such as "wiki:" matches a keyword, we don't do any cleanup. Tested amply with unit tests. Also tested interactively. Some key interactive cases: * typing an unusual keyword and pressing tab enters keyword mode. * typing an unusual keyword and pressing space enters keyword mode. * putting the cursor in the middle of a string and pressing space in a while that would make the left side into an unusual keyword puts the user into keyword mode * backspacing out of keyword mode works correctly * these suggestions for unusual keywords appear in the dropdown when the user types a prefix of them. * when the user is in keyword mode for one of these unusual keywords, switching tabs and switching back keeps the user in keyword mode. * when typing an unusual keyword with an additional thing that can be cleaned up (for example www.wiki: or http://wiki:), pressing space at the end of the keyword does NOT enter keyword mode. This seems reasonable to me. Pressing tab at the end of the keyword does enter keyword mode. Yay for fixing a four-digit bug. (It's one of the ~40 oldest existing bugs in chromium.) Bug: 2740 Change-Id: Ie53089421956acf5eb58fe1d1b53932e10169178 Reviewed-on: https://chromium-review.googlesource.com/664251 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#502747}
-
Rob Buis authored
From the comment it is clear loop should be tested here, not scrollDelay, ehich was already tested earlier. Bug: None Change-Id: I7b5c6c11f5c6f8bf41cd31c9b8d56c0e345b80d4 Reviewed-on: https://chromium-review.googlesource.com/671324Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502746}
-
Dan Beam authored
R=dpapad@chromium.org BUG=749296,761258 Change-Id: I214b60157dc8eb7bcda1d214b8433f003aad8bb6 Reviewed-on: https://chromium-review.googlesource.com/669683Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502745}
-
Morten Stenshorne authored
Bug: 766315 Change-Id: I791ae5a12f0602c95194a60659e29e572dce5c8a Reviewed-on: https://chromium-review.googlesource.com/668441Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502744}
-
Jialiu Lin authored
After user finishes changing their Gaia password, update password reuse info bubble to a regular phishing/social engineering info bubble. And some minor refactoring on GetPasswordProtectionService() Bug: 762738 Change-Id: I20f3b3dd513ff9e292d4a8b138622c6b6cdbacda Reviewed-on: https://chromium-review.googlesource.com/663761 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#502743}
-
Alex Chu authored
layers. Change-Id: I22890aa54b375e4d40b9acbd9c5b47056be7432c Bug: 736726 Reviewed-on: https://chromium-review.googlesource.com/651752 Commit-Queue: Alex Chu <alexchu@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502742}
-
Steven Bennetts authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I79847520659cac0b4598089b03dbd23e422fa68d Reviewed-on: https://chromium-review.googlesource.com/671461Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502741}
-
Steven Bennetts authored
This removes an undesired (and problmenatic) <html> wrapper from the element and a font include that was causing problems across the Settings UI. It also fixes an assert on startup when the feature is enabled. Bug: 760751 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icf647dab081c5edd51b1f1029fac22e4eaa0c303 Reviewed-on: https://chromium-review.googlesource.com/671464Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502740}
-
Derek Cheng authored
When attempting to cast via the dialog, clear previous non-blocking issues. This ensures issues are cleared on a successful cast, or that the newest issue is displayed if otherwise. This patch also simplifies the MediaRouter API by replacing the various Issues-related API in MediaRouter with GetIssueManager(). GetIssueManager() is implemented in MediaRouterBase, making it also available on Android. Also combined the Issues and their auto-dismiss callbacks in IssueManager into an Entry maintained in a single container. Bug: 763432 Change-Id: Iaa79f991760fa31e28ec50d0e23cbf8b9f39a28a Reviewed-on: https://chromium-review.googlesource.com/663104 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502739}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c5e4e7437af9..c86d0794ed37 $ git log c5e4e7437..c86d0794e --date=short --no-merges --format='%ad %ae %s' 2017-09-18 reed Revert "try to remove google3 flag" 2017-09-18 reed try to remove google3 flag 2017-09-18 fmalita Revert "Reland "Fix SkImageSource::filterBounds()"" 2017-09-18 angle-deps-roller Roll skia/third_party/externals/angle2/ f3d574545..10ce2d284 (1 commit) Created with: roll-dep src/third_party/skia BUG=None Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I4672a53c8fff4ff212db54191ba63d8f1158f817 Reviewed-on: https://chromium-review.googlesource.com/671653Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502738}
-
kelvinp@chromium.org authored
Tbr: nasko@chromium.org Bug: 766378 Change-Id: I3c0909c32f0ad64c96ce7a12b09602a0c279bc56 Reviewed-on: https://chromium-review.googlesource.com/671666Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502737}
-
Fady Samuel authored
When a parent first embeds a child, it picks a LocalSurfaceId for the child and embeds it. During that bootstrapping process, there is no fallback surface to provide because the child hasn't yet submitted a CompositorFrame to viz. Prior to this CL, if a primary surface isn't available and there is no fallback then SurfaceAggregator would report a warning, and the surface would simply be dropped. This CL addresses this bootstrapping problem. It introduces the notion of a "default background color" specified by the parent when the primary Surface is unavailable and there is no fallback yet. In that case, SurfaceAggregator will use the "default background color" to create a SolidColorDrawQuad in place of the primary Surface. This CL implements this color and plumbs it all the way from SurfaceLayer, to SurfaceLayerImpl, SurfaceDrawQuad, serialization/deserialization to SurfaceAggregator, ultimately where it decides whether or not to create a SolidColorDrawQuad in lieu of a surface or not. All unit tests along this plumbing have been updated accordingly. Bug: 766013 TBR: boliu@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I367f7eab7b0189d438926dea407076ef6007f0a4 Reviewed-on: https://chromium-review.googlesource.com/669444 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#502736}
-
Bret Sepulveda authored
This bubble was still passing margins to BubbleFrameView after that was handled by DialogClientView instead, which led to the margins being applied twice. Bug: 763137 Change-Id: Ifbdb5baa56cc6405b9434742602cdac6a9003f01 Reviewed-on: https://chromium-review.googlesource.com/671927Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#502735}
-
Ted Choc authored
Also fixes a javadoc to not make eclipse sad. BUG= Change-Id: I6196b08b96104a27dca2377303fb38322da0fae0 Reviewed-on: https://chromium-review.googlesource.com/671806Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#502734}
-