- 13 Aug, 2018 40 commits
-
-
Douglas Creager authored
Reporting specifies that the user agent should allow users to prohibit uploads on a per-origin basis. The Network Service's NetworkDelegate needs to actively disallow Reporting uploads until we're able to hook up the permissions manager across the service boundary. Bug: 845559 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib63890e3b045c0067969a70628191530a96d482f Reviewed-on: https://chromium-review.googlesource.com/1171571Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#582654}
-
Etienne Pierre-doray authored
IndirectReference brings complexity conceptually. The purpose of IndirectReference was to speed-up look-ups. Turns out that there is no significant impact on patching time when using direct references. Furthermore, this reduces coupling between TargetPool and ReferenceSet. Change-Id: Ic50dbf59e483a7fa1480c8eb37f4b1d01a53401a Reviewed-on: https://chromium-review.googlesource.com/1136578 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582653}
-
Zhiqiang Zhang authored
CAF reconnection service is enabled by default. However the reconnection service is used for recovering sessions when the app crashes and relaunches. MediaRouter won't need this feature so it should be disabled. Bug: 711860 Change-Id: Ib7b3e13af56c4be4286be7d50dc2b0e7868a3722 Reviewed-on: https://chromium-review.googlesource.com/1171795 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#582652}
-
Robert Liao authored
This is part 1 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 Change-Id: Ie57ac06eeda6afde915d3de6a1b60770a22e0da7 Reviewed-on: https://chromium-review.googlesource.com/1171907Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582651}
-
David Black authored
Previously, answers were not scrollable. Now they are. To accomplish this, we've: - Created an abstract AssistantScrollView class to share logic between UiElementContainerView and SuggestionContainerView which both have the need to scroll. - Moved AssistantHeaderView out of UiElementContainerView because it should not participate in the scroll. Known issue: We still have not addressed the WebView event processing issue, so it is only possible to scroll UiElementContainerView via mouse/touch events that do not involve the WebView. This will be addressed in a follow up CL. Temporary workaround: initiate scroll events from the margins beside the cards, not over the cards themselves. Known issue: If the user scrolls the content and then issues another query, we fade out the current answer and show our thinking dots. But if the content has been scrolled, the thinking dots collide with other views. To address this, I force scroll the content back to the top and disallow events while waiting for the next answer to come in. Need UX guidance on what might be a better approach. See bug for demo. Bug: b:110039692 Change-Id: I20dbca681b92981857c4266ef1882642503eb0da Reviewed-on: https://chromium-review.googlesource.com/1172144 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582650}
-
Leszek Swirski authored
The events in ChromeVoxEventWatcher are sorted to move LiveRegion entries to the end of the event list. However, Array.sort is not guaranteed to be stable, nor does it specify how the comparison function will be applied to the elements of the array. Instead, we can push events into two different arrays, and concatenate them after, preserving within-event order. Change-Id: Iec917f72295312760ba77080897eac86b8424b8f Reviewed-on: https://chromium-review.googlesource.com/1172775Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#582649}
-
Cole Winstanley authored
Implemented client-side replay from a ChromeDriver log file. Doesn't work for Android or remote browsers yet. Bug: chromedriver:2501 Change-Id: I40b634b5e7c5973a920b9ecd92cf7b039c867a4d Reviewed-on: https://chromium-review.googlesource.com/1137367 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582648}
-
Derek Cheng authored
Due to the way cast message delegates are layered, a cast message coming from a receiver first goes through KeepAliveDelegate, which inspects the message for keep-alive type and passes it through if it is not a ping/pong message. Instead of doing JSON parsing (which isn't safe in browser process), we will check for the heartbeat namespace and do a quick substring check for PING/PONG type. Also removed the now unused function and clean up tests to move usage of JSONReader to the test itself. Change-Id: I3c906b8215f7b7149b18c014278cdad3bdf6b3e7 Bug: 809249 Reviewed-on: https://chromium-review.googlesource.com/1170130 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#582647}
-
Elly Fong-Jones authored
Now that Button has a focus ring, use that instead of creating a second one. Bug: 872691 Change-Id: I078a223c491bd83121cf7a488595b26e3c56f81d Reviewed-on: https://chromium-review.googlesource.com/1172794Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582646}
-
Lukasz Anforowicz authored
The bug has been in fixed r574623 - let's remove the test expectations (FWIW the tests are passing when run 20 times on my local machine). Bug: 601584 Change-Id: I5f99d8a066407d3b7be0d5fc1bdaf389de181b87 Reviewed-on: https://chromium-review.googlesource.com/1169956Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#582645}
-
John Abd-El-Malek authored
Mark external/wpt/service-workers/service-worker/mime-sniffing.https.html as fixed with network service. This was fixed in r580143 TBR=shimazu@chromium.org Bug: 771118 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4766a79d1ddb3c017b35da0ced75f30e2a8113d6 Reviewed-on: https://chromium-review.googlesource.com/1172936 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582644}
-
David Black authored
Previously, ManagedWebContents would inform callbacks that it was ready for embedding after WebView creation. Now, we wait until after the first load has stopped. This prevents embedding from happening until all assets have been loaded. Previously, large cards (e.g. "nearby restaurants") would occasionally flicker as they were embedded before larger assets (e.g. map image) were finished loading. Bug: b:112498878 Change-Id: I0dce539800d5a18056e7d83a1078ccec70e7a25e Reviewed-on: https://chromium-review.googlesource.com/1172067 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, a popup disposition link in payment handler would always be blocked. This disposition is being used by legitimate payment handlers for opening USPS ZIP code lookup, for example. This patch allows opening popup disposition links in payment handler, as long as it was triggered by a user gesture. After this patch, both new foreground tab and popup disposition links can be opened with user gesture in payment handler. Bug: 863541 Change-Id: Ie1bf41cbd2fab4cd390eca08ea96e7af361efbd8 Reviewed-on: https://chromium-review.googlesource.com/1172792Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582642}
-
Troy Hildebrandt authored
Adds LevelDB.ApproximateMemoryUse.<clientname> histograms for memory use after initialization. This should give us the size of the MemTable right after initialization. BUG=870806,870813 Change-Id: I2c6ea6f176e92c319718ed29b6fb9192792bf7f1 Reviewed-on: https://chromium-review.googlesource.com/1162357 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582641}
-
Xida Chen authored
Previously we added debugging instrumentation DumpWithoutCrashing() in TouchActionFilter. It has been pointed out that this results in top crashes without real crashes, which could suppress other crashes. Since we have landed the CL for a few days and collected some data, this CL removes the debugging instrumentation before dev release. TBR=tdresser@chromium.org Bug: 869375 Change-Id: Iedd93b7393a65e6fb9b8aef40a0a554465ec859d Reviewed-on: https://chromium-review.googlesource.com/1172726Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582640}
-
Philip Jägenstedt authored
This will cause the tests to be imported: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#automatic-import-process The tests should already be mostly passing: https://wpt.fyi/results/ambient-light?label=experimental&sha=eea0b54014 No-Try: true Change-Id: I0dc98ff3040fe11664796757286138523daa6bce Reviewed-on: https://chromium-review.googlesource.com/1172300Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#582639}
-
Wez authored
This test appears to have timing-dependent flakiness. Bug: 836996 Change-Id: I52382fd881ac0872e98fcf71464f72dcc42f7dcc Reviewed-on: https://chromium-review.googlesource.com/1169960Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
This adds localization for the reason string fragments used in macOS Touch ID prompts. The prompts display a message starting with '"Google Chrome" is trying to ' (controlled by macOS) followed by the reason fragment (controlled by us). The user can confirm the prompt by providing their fingerprint, or click cancel. Bug: 848317 Change-Id: Ibe67c197554cde0af431516d968479b0f416629e Reviewed-on: https://chromium-review.googlesource.com/1166171 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582637}
-
Alex Newcomer authored
Apply a 2/3 transform to the svg icons to center them in the menu. Bug: 872843 Change-Id: I55df7e1ac9e848771110f36540fa4a4178d12d86 Reviewed-on: https://chromium-review.googlesource.com/1169780 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#582636}
-
Ned Nguyen authored
Change-Id: I670d6e246a2d37d6731d002951fe95d28c538387 Reviewed-on: https://chromium-review.googlesource.com/1170315 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582635}
-
Katie D authored
UI prefers no notifications as part of this migration. Bug: 866648 Change-Id: Ia72d46f6d15cb10b373a4e3753e655dc42381781 Reviewed-on: https://chromium-review.googlesource.com/1168288Reviewed-by:
-
Daniel Erat authored
Map the XK_Print X11 keysym to VKEY_SNAPSHOT rather than VKEY_PRINT; VKEY_SNAPSHOT is the correct keyboard code for the "Print Screen" key. Also fix the mapping in the Chrome OS IME keycode table and remove the now-unused VKEY_PRINT screenshot accelerator. Bug: 872094 Change-Id: If5535534a81da00500da427fb5ef5fdc0a8a58e2 Reviewed-on: https://chromium-review.googlesource.com/1170166Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Chris Hamilton authored
The current ModuleBlockingDecision was conflating "current run" state with the blocking decision that will be applied during the next run. This now encodes the "next run" blocking decision in ModuleBlockingDecision, and separates the "current run" state into a collection of booleans. The combined state is stored in a ModuleBlockingState struct. This allows additional edge cases to be cleanly described: - A module that was blocked in the current run, but will not be blocked in the next. - Allow differentiating between explicitly blocked and implicitly blocked modules. BUG=847544 Change-Id: I5fc9dd14dde312667a137c8a0919b74fd8841d99 Reviewed-on: https://chromium-review.googlesource.com/1169965 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#582632}
-
Wez authored
Test started flaking on the waterfall following the latest SDK roll, so disable it pending investigation. TBR=maxmorin Bug: 873676 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idb17f16b8df8948e061b5abb63cae5ae32e04b89 Reviewed-on: https://chromium-review.googlesource.com/1172938 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
- WmTestHelper uses WindowTreeFactory to create its WindowTreeHostMus. This way, the host root window is a client created top level window that could receive events and could be properly resized from the client side; - Update WindowTreeClientTest to use WindowTreeFactory instead of WindowTreeHostFactory; - Remove no longer used WindowTreeHost/Factory mojo interfaces; Bug: 866942 Change-Id: I39938727142a67fc4004e4ff52656bc1f714fb57 Reviewed-on: https://chromium-review.googlesource.com/1170187Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582630}
-
Katie D authored
Bug: b/112360716 Change-Id: I5f082ac425e9f8ac740d4af81059b3c379c04d12 Reviewed-on: https://chromium-review.googlesource.com/1168025 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#582629}
-
Scott Violet authored
WindowTreeClient has code for it, so no need for the same code to exist in MusClient as well. BUG=none TEST=covered by tests Change-Id: I50c18a0a2b08f045251a94c15472b0289a2cd7bf Reviewed-on: https://chromium-review.googlesource.com/1172734Reviewed-by:
-
Jacob Dufault authored
SaveScreenTimeProgressBeforeExit gets called after the lock screen was shown, which cancelled all running timers, including those that updated the lock screen state. If some other event fired, ie, timezone change, then the timers would get rescheduled. As a fix, don't cancel the timers which update lock screen state; only cancel in-session timers for the notification and recording actively used screen time. Bug: 872689 Change-Id: Ibbead3c2e455866fc09ced036c5c78a81e05357b Reviewed-on: https://chromium-review.googlesource.com/1171811Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#582627}
-
Mohsen Izadi authored
Platforms other than Android, use selection sent in RenderFrameMetadata rather than the one in CompositorFrameMetadata. There is no need to serialize/deserialize and send the unused data on each frame. BUG=859969 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfde9270deae40ebc57e15251b70597fd3e6a0f7 Reviewed-on: https://chromium-review.googlesource.com/1172142Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582626}
-
Raphael Kubo da Costa authored
Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having base::NoDestructor<T<U>> and passing an initializer list of Us does not work. Just explicitly create a base::flat_set in the constructor. See also: https://chromium-review.googlesource.com/1165360 Bug: 819294 Change-Id: I24593dc199df47c2f8fd316436517704d159e4fa Reviewed-on: https://chromium-review.googlesource.com/1170905 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
David Black authored
Motion spec still being delivered by UX but this should be a step in the right direction and removes a lot of our existing jank. Note: We still have yet to crossfade between mini/main/web states. Also revised some AssistantMiniView metrics per the spec. See bug for demo. Bug: b:112487675 Change-Id: I9cecb3afdd7d5e85e04d8ef95a25e5dfdd263c91 Reviewed-on: https://chromium-review.googlesource.com/1171952 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Sahel Sharify authored
With this change wheel event listeners that are registered on a window, window.document, window.document.body will be treated as passive if not specified otherwise. Intent to impl: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: I1561cd86ddd381e0405c84ba8f48ea7274d8906c Reviewed-on: https://chromium-review.googlesource.com/1162302Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build after commit d540c125 ("New implementation of MessagePopupCollection"). Bug: 819294 Change-Id: Ibf45feee935b25d48564f84326b95f33529ab879 Reviewed-on: https://chromium-review.googlesource.com/1172784Reviewed-by:
-
Kevin McNee authored
Bug: 803274 Change-Id: If56ee6ad0220b429b4497ccecef90eb257265478 Reviewed-on: https://chromium-review.googlesource.com/1170989 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#582621}
-
Paul Meyer authored
This crash was caused by incorrect wrapper tracing with ReportingObserver. This CL fixes this by making ReportingObserver ActiveScriptWrappable. Bug: 870930 Change-Id: Ie46db964c98b028c96d9deb2066c7db9ca0d449f Reviewed-on: https://chromium-review.googlesource.com/1169434 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#582620}
-
Dave Tapuska authored
The current pull request against the HTML spec is here: https://github.com/whatwg/html/issues/3799 Rename the RuntimeEnabledFeature from WindowPostMessageOptions to PostMessageOptions BUG=861735 Change-Id: Ia7980a85c10535f6d531c87f3790efcf6ed2d54d Reviewed-on: https://chromium-review.googlesource.com/1169304 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582619}
-
Lucas Furukawa Gadani authored
This CL exposes a Portal mojo interface when the Portals feature is enabled. Bug: 865565 Change-Id: I882070fd3225a42a7ab64c01c8ac4bbce156ae5a Reviewed-on: https://chromium-review.googlesource.com/1145710 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582618}
-
Katie D authored
Bug: b/77884324 Change-Id: If48e2d244446db26f17d1943b322dd0dce43cdb6 Reviewed-on: https://chromium-review.googlesource.com/1165847Reviewed-by:
-
Ivan Sandrk authored
Enable Managed Session by default when the policy controlling the behaviour is not set. Bug: 865947 Change-Id: Ie674d18b4a07ee5ebe6134f26b0f3c088dca5cf7 Reviewed-on: https://chromium-review.googlesource.com/1172602Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#582616}
-
Reza.Zakerinasab authored
Refactor blob mime types to avoid using string literals in the code. TBR=dgozman@chromium.org Bug: 846441 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I290808b25e7775931d838464f9470da36d0948bd Reviewed-on: https://chromium-review.googlesource.com/1169524 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582615}
-
