- 20 Mar, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL moves web_database.mojom from public/platform/modules to public/mojom/ to gather mojom files to mojom folder and updates paths for web_database.mojom. Bug: 919393 Change-Id: I730b8230193f959db19fc966be1058b9e8d59f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530315Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#642424}
-
Kouhei Ueno authored
We add two tests: - SXG served by appcache should load (this doesn't yet pass in Chromium) - SXG should take precedence when there's content in both appcache+sxg-inner-resp Bug: 940797 Change-Id: Id1463b92f22ab04859ca3f075ca0340225f00694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516533 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL removes unused DEFINE_TYPE_CASTS form canvas_rendering_context_2d.h Bug: 891908 Change-Id: I6c9db6b19912916a98e1241d737c5a41c1bd1047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530493Reviewed-by:
-
Chris Hall authored
Changing some EXPECT_* to ASSERT_* when their failure will guarantee later failures. This removes redundant/dependent errors and helps isolate the actual failure. R=aboxhall,dmazzoni BUG=889370 Change-Id: Icb00ff378ac10948648bb06a7b824532d953fd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520166 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642421}
-
Abhijeet Kandalkar authored
The primary motivation of this CL is to replace ToLayoutScrollbar with To<LayoutScrollbar> and ports other dependent files to refer to a new function name. Bug: 891908 Change-Id: Ieb930ad998dfbd01937f2fc527d3b8cc0bc43da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530494Reviewed-by:
-
Abhijeet Kandalkar authored
The primary motivation of this CL is to replace ToShapeClipPathOperation with To<ShapeClipPathOperation> and ports other dependent files to refer to a new function name. Bug: 891908 Change-Id: I7525f1a728581f6ada9aa730fd6a2f57deaefa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530495Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec795debc5c1..bf564e0beff1 git log ec795debc5c1..bf564e0beff1 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 sadrul@chromium.org tracing: Handle error running vinn. Created with: gclient setdep -r src/third_party/catapult@bf564e0beff1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:942288 TBR=sullivan@chromium.org Change-Id: I085e156c459404e736aff6cf398f6de03dc88e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642418}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37a9294d2eb9..c60fb3876762 git log 37a9294d2eb9..c60fb3876762 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@c60fb3876762 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I6f9f761f7a7aa99380118e4869c6679380f231e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531323Reviewed-by:
-
Takashi Toyoshima authored
Some tests in blink_platform_unittests call SetFetchCredentialsMode with kOmit, but it should not be needed. Just the default value, kInclude should work, and the actual default value in the production code. Bug: 742316 Change-Id: Ib215536b0f72daa953c9bb7fad6a931b69e3b29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530491 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642416}
-
Stuart Langley authored
This probably became unusued when we remove analytics support. Change-Id: I6dbc592bf3dfc03e4704780396d3bbe6268a0de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527946Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#642415}
-
Matt Falkenhagen authored
No longer needed following the launch of S13nServiceWorker. This also flattens ServiceWorkerURLJobWrapper into ServiceWorkerNavigationLoaderWrapper. Bug: 926114 Change-Id: I8271efb6bcab601f0b539183d2c50dc182078c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530417Reviewed-by:
-
Michael Lippautz authored
In the case that user roots are not provided, distances should start at 0. This is the case when full heap snapshots are provided with the gn flag v8_enable_full_heap_snapshots For production builds this flag is always false. V8 CL: https://crrev.com/c/1528994 Bug: 936797 Change-Id: Ifd247a082a4336b59d05f444ba54d281f9eae805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529096Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642413}
-
Timothy Loh authored
This CL changes the Plugin VM app in the launcher to be an internal app, simplifying the launcher integration and making it easy to add shelf integration (although the application id is not finalized yet so that has been omitted). Bug: 940319 Change-Id: Ic760bda32eda8b1f7fab9dc099e6d7770932a258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525704 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642412}
-
Yutaka Hirano authored
Now ResourceFetcher::SetConsoleLogger is gone, so we sets ResourceFetcher::console_logger_ only twice - at the initialization timing and at the detach timing. This CL introduces DetachableConsoleLogger to erase the latter mutation. This allows us to store a ConsoleLogger object in ResourceLoadScheduler. Bug: 914739 Change-Id: Ie9e29a3c92cb26bf20090d5463de9d7a398d230c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522497Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d196c3c607f0..f36e44456d61 Created with: gclient setdep -r src-internal@f36e44456d61 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I1314f2ed6a3953944df9d44191c961dd7e33e625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642410}
-
Kunihiko Sakamoto authored
This reverts commit 0a9cd867. Reason for revert: ShelfViewTest.IconCenteringTest is failing on bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ShelfViewTest.IconCenteringTest https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/21645 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/21646 Original change's description: > CrOS Shelf: Change icon centering strategy > > The main change here is that icons are first centered on the whole > screen, then, when space becomes tighter, they are centered over the > available area on the shelf. > > A few changes to make this work properly: > > * Fix an issue in |GetDimensionOfCenteredShelfItems| which was taking > into account all items, even the ones within overflow, making the > calculations incorrect. > * Another issue was that the code calculating ideal bounds would > assume control buttons (app list, back, overflow) were the same size > as app buttons (56) while they're actually a little smaller (40). > Giving control buttons their "real" size in the layout code allows > for the removal of some overrides at each button class level. > * Split out a small chunk from |CalculateIdealBounds| which is getting > too long. More of that to come in future changes. > * Make the special spacing between the app list button and the first > app icon also there on the other side for more symmetry. > > Also add some extensive test coverage. > > Bug: 891080, 933291 > Change-Id: If4bb69aa6e182cd29c02d467039b5d839d09f493 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512299 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642245} TBR=xiyuan@chromium.org,manucornet@chromium.org Change-Id: I4ad5f95b4c6b2db13e05a6e280e987f25981392b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891080, 933291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531922Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642409}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/core/animation and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I3f5f02b4ae13edecdf08a88e3b5326bf833f817f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531884Reviewed-by:
-
Matt Menke authored
Previously, it took a bunch of individual parameters, which was getting a bit excessive. Also, CommonConnectJobParams are now created by the HttpNetworkSession. This will hopefully make a couple refactors a bit simpler: * Switching over ProxyResolvingClientSocket to not need its own socket pools (It will need its own CommonConnectJobParams). * Slimming down SocketParams classes by adding more stuff to CommonConnectJobParams (Like the SpdySessionPool and QUIC globals). * Separating the WebSocket and Transport SocketPools. Bug: 921369 Change-Id: I23b9011a9c5b9dafa0eeb1e63f585417ffc0c355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529697 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642407}
-
Leon Han authored
Used features (for UseCounter purposes) of a controller service worker should be considered as part of information of this service worker. To be consistent with this logic, this CL puts them into blink.mojom.ControllerServiceWorkerInfo rather than always passing/accessing them separately like before. BUG=931092 Change-Id: Ic4f99e33b15b367226ea7440941b74422b3a6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527870Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#642406}
-
Noel Gordon authored
Mitigate this issue: make the thread_bundle RunUntilIdle when tearing down these unittests. See crbug.com/943570#c7 for rationale. No-try: true Bug: 943570 Change-Id: Ib8df70054ea9de3d7277da0b49e8885bf103b44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530385Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642405}
-
Julie Jeongeun Kim authored
This is a follow-up CL of [1]. It changes t.step() to t.step_func() from animations/prefixed and address review comments from [1]. [1] https://crrev.com/c/1525789 Bug: 936364 Change-Id: Ica1d58cd903ec8429f0ceac93a3ff3f1e514082b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530358 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2894d13a0d9b..37a9294d2eb9 git log 2894d13a0d9b..37a9294d2eb9 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@37a9294d2eb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Idcc39cd22e4d712922a544536d8e4c209d077946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531768Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e85c22df678..cf9613f166a2 git log 8e85c22df678..cf9613f166a2 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 brucedawson@chromium.org Avoiding writing ninjalog.cfg unnecessarily Created with: gclient setdep -r src/third_party/depot_tools@cf9613f166a2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:941810 TBR=agable@chromium.org Change-Id: I8142be62de15086d8c32147942abd18d370541eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531767Reviewed-by:
-
Raul Tambre authored
These changes allow more of Chromium to be built using Python 3. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I6897d00ce00ec6aa5d7ca216b9f302e725a21897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527522Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#642401}
-
Miyoung Shin authored
- unsigned long -> uint32_t - No logic change - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I73df0c545df9a669a0db7528fbf52e0c581189b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530357Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit cc9ce2e5. Reason for revert: Broke Android CFI compile https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/4788 Original change's description: > Enable cfi-icall on the CFI bots > > Previously cfi-icall was disabled because I mistakenly thought > is_cfi=true would enable cfi-icall. Enable it explicitly. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng > > Bug: 942060 > Change-Id: I0949e0f547f5ea17c54bb2fb4c99e269daf0f67f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529360 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642364} TBR=martiniss@chromium.org,vtsyrklevich@chromium.org Change-Id: I0e86b4b1c80df66a3c0849661e4c1902b6d5d950 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942060 Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530383Reviewed-by:
-
Miyoung Shin authored
- unsigned long -> uint32_t/wtf_size_t/uint64_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: Id05e83f486d1d11cac16ff17fbcd72b33ca986d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530502Reviewed-by:
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I128efc5bf744a18bc7794fcd7d7251d5eb404409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520126 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The failed because of a bad rebaseline. Rebaseline them again. TBR=wangxianzhu@chromium.org,ksakamoto@chromium.org Change-Id: I91592a17e5911f9e99de4afc7ba8c3feff411f85 Bug: 943907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531821 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0861b5e50a7f..d196c3c607f0 Created with: gclient setdep -r src-internal@d196c3c607f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: Icbd9d0b8f655558f61876f1841f5b8099d9ccb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531764Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86168611. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 35d5999d "Add pause to wait for scroll stop in WPT pointerevent touch test" 73fa2b38 "[wpt] Fix actionsWithKeyPressed.html.ini" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/IndexedDB kojii@chromium.org: external/wpt/css/CSS2/text rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ida6de87d7db1f10f41bfe9991ff763e230995322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531716Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642394}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/animation and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ia87ee21c53cdadcbbab23b6c4c3c8300068ab38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524400Reviewed-by:
-
Steven Zhu authored
Bug: internal b/127656475 Change-Id: Ib7681e6de5693ab25c5df96274b691b2ad0aa9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530838Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642392}
-
Peter Kasting authored
Using the default method as in https://chromium-review.googlesource.com/c/chromium/src/+/1367129 prevents extension popups from opening their own popup windows, e.g. JS alerts. Since there's no plan to deprecate that functionality and we can't come up with a good alternate route, this restores part of the previous code. This does not re-introduce the problem with long clicks re-showing the popup; that was sufficiently addressed by the rest of the previous CL. Bug: 941994 Change-Id: I59bb7d695b51e250a096b8ca8331876593507ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529753 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642391}
-
Hitoshi Yoshida authored
Implement ExtendedAttribute and ExtendedAttributes class to follow the designed APIs. https://docs.google.com/document/d/1ZPuPWjBSQVfVeJYptk7dYg1OAxx89-kwHz6oJlZGA5o/edit?usp=sharing Bug: 839389 Change-Id: I21e2f4dd02433d52c14b362bd9f2cafd4eee3667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520518 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#642390}
-
Joel Hockey authored
This reverts commit 94aaefbb. Reason for revert: Not helping to detect flakes Original change's description: > Try and debug flakes in ExtractMountNameFileSystemNameFullPath tests > > Bug: 942371 > Change-Id: I8364196af047263086580c11e7db5188ac6915bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530317 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641839} TBR=fukino@chromium.org,sammc@chromium.org,joelhockey@chromium.org Change-Id: I549986343c7764e044c179abb9bdda807973c241 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531883Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#642389}
-
Stuart Langley authored
Bug: 941590 Change-Id: Ic162bb3574599e85cefd43284e341aa0f7833742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524820 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#642388}
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I423a97dccb1de48deaec862e66dfa3add7ec8341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519969 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
Creating a VideoFrame instance from a V4L2 buffer reference is a common operation. The best place to do this is in the buffer reference itself, since it can export the required DMABUFs itself, has a reference to its own device, knows about its own layout, and can cache and reuse the VideoFrame instance instead of creating a new one for each request. This CL adds (and uses) such a method. Although it only works for MMAP buffers, it will probably be extended in the future to other kinds of buffers when they support queueing a VideoFrame directly. Bug: 792790 Test: VDA unittest passed in regular and import mode on Hana. Test: VEA unittest passed on Peach_pit. Change-Id: If387d8f11f8a5c72d7fc26907f5c9bea4835d8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517503 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642386}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c75272708a80..d537949d45f3 git log c75272708a80..d537949d45f3 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 dhanyaganesh@chromium.org chromeos_config: Change the sanitizer builds to be full builds 2019-03-20 tcwang@google.com chromite: Update HWTests in toolchain builders. Created with: gclient setdep -r src/third_party/chromite@d537949d45f3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I090a7d922eb687129b3e7c71b407c6d85a19bbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531763Reviewed-by:
-
