- 03 Jun, 2019 40 commits
-
-
Alex Oldemeier authored
For additional enterprise reporting, we need to retrieve the package id from the registration. This commit adds a getter and tests. Bug: 844468 Test: unit_tests --gtest_filter "CrostiniRegistryServiceTest.*" Change-Id: Icfea51476cf8e00068391a1953e5ab6ad0cc6e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634697 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665477}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/animation directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: Ied1032d67bcdaa52e7fa3265471fd53f4b5ddd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640743Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#665476}
-
Rune Lillesveen authored
Use Scoped* helpers to reset flags back to the default value for other tests. Change-Id: Icb5bdcdb36f09051703f0fab129211b617c4efee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637568Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665475}
-
Sam McNally authored
For enum histograms ranging from 0 to N, 1 should be passed as the min, N as the max and N + 1 (or the number of values) as the bucket count. For files app histograms, N + 1 is passed for both max and bucket count. This causes the middle value to not have a bucket. Pass N as the max to avoid this problem. Bug: 969600 Change-Id: I1725fdf8d97a9932174a47aaebe8382b3010db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640148Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665474}
-
JunHo Seo authored
A huge(tested on downstream build - chromium68 with gcc 8.2, about 180MB) compile warning messages are printed during building chromium. One of major warning messages is about memory operation. Previously, I tried to fix the warning by fixing related code( https://chromium-review.googlesource.com/c/chromium/src/+/1637021), but it was not accepted. As a second option, this CL suppress the warning. And the build flag is added only for (!clang and !win and !nonacl) build. Below is a sample message: src/third_party/blink/renderer/platform/wtf/vector.h:193:13 warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'class blink::Member<blink::TreeScopeEventContext>' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess] Bug: 819294 Change-Id: Ibfdc7bc278fc4f2a4640d770754de42ab5438e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638211Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#665473}
-
Alex Oldemeier authored
This adds fields for the Termina kernel version and a list of installed apps to the existing device management backend proto. Test: compile Bug: 844468 Change-Id: Iee48c736a67cf466beff91086374250f1cb22cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628617 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665472}
-
Darren Shen authored
Disable: SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNoneChanged Flaky on all bots. TBR=clamy@chromium.org,sunxd@chromium.org BUG=968970 Change-Id: I1db969e3a610cc8e2af385d8bbf0b5d6d6185e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640251Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665471}
-
Tomasz Moniuszko authored
Bug: 969015 Change-Id: I74bf788a0cabed4a78702a2fb9c6e033feaaf7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635684Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#665470}
-
David Staessens authored
To improve the readability of performance metrics printed on the command line when running the video_decode_accelerator_perf_tests, this CL makes change to use std::cout instead of VLOG(0). TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I13d2e246dc86af56461c488546a88053d4e56755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635121 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9f6a47f27cc..3e719632482a Created with: gclient setdep -r src-internal@3e719632482a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ifca0642135a19040b2ef60dfef64d7777a5c374f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640246Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665468}
-
Koji Ishii authored
When an inline box has |IsInLayoutNGInlineFormattingContext|, its containing LayoutBlockFlow must have |NGPaintFragment|. The stack trace of the issue indicates that there maybe cases where it doesn't stand. This patch adds two guards against such case: 1. Same as crbug.com/963103, |InlineFragmentsFor()| pretends it's not LayoutNG if the LayoutBlockFlow is dirty. This may affect code that reads from dirty tree such as scroll anchoring, but protects from reading deleted objects. 2. If something still wrong, CHECK before returning possibly deleted objects. Usually, an inline formatting context isn't so deep that this check shouldn't be too expensive. Unfortunately, implementing these guards to |InlineFragmentsFor()| broke several accessibility and scroll anchoring tests, which seem to read inline positions of dirty tree. This patch makes the guards opt-in, and let |InlinePainter| to opt-in. Also makes sure to clear |IsInLayoutNGInlineFormattingContext| when inserting to the tree. This is a speculative fix. Bug: 969096 Change-Id: Ic29c5c77e6a27b395d6cd7bafc2bfbbd858c14fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638973 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665467}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I76a0c2250e307c08730335d7f41003b90b626e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665466}
-
David Staessens authored
This CL adapts the video_decode_accelerator_perf_tests to write frame decode times to the metrics output json file. In addition frame delivery times will now be written to the same json file, instead of a separate one, so all performance metrics are contained a single file. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I972b67b93119fc0f5157890edcd9ef5845bd970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608968 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
os of builder is updated to 10.14. https://chromium-swarm.appspot.com/bot?id=build213-m9 Let me drop version specification until we need to pin that. Bug: 969553 Change-Id: I09cf8b75766973113903c84a408a3baa0e178478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640366 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665464}
-
Lei Zhang authored
ui::AXPlatformNodeAuraLinux::OnDescriptionChanged() calls g_value_set_string(), which internally duplicates a string into a GValue. The GValue needs to be cleared before destruction to avoid leaking the memory used for the string duplication. BUG=961907 Change-Id: I38086cd421667dc2a4edf2a9325c5b15cde5645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638947Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665463}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/core/css directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I667cab102b9b2cc7ea32ae60aa5de8545b56861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640301Reviewed-by:
-
David Staessens authored
This CL adds the --output_folder parameter to the video_decode_accelerator_tests and video_decode_accelerator_perf_tests binaries, so the default output folder for video frames and metrics can be overwritten. This is required to run the tests from Tast. TEST=ran new VDA (perf) tests on eve BUG=953114 Change-Id: Id536f0bc441dbf23ea3ab39434e340ec4503924e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605324 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Darren Shen authored
Changed ui/keyboard to ash/keyboard. Removed ash/virtual_keyboard (doesn't exist). Removed blakeo@ (no longer working on VK). TBR=yhanada@chromium.org Bug: 961568 Change-Id: I2183d5d442689547c6e09dcd323168e8444903e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638936 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#665460}
-
dpapad authored
This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget. Bug: 854268,778674 Change-Id: I3dbf4b3ace86d0966d09a01d5d0fa86d6ca9ba19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639239 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
John Budorick authored
Most of our kvm-enabled ubuntu capacity in pool:Chrome has moved to xenial. Bug: 954450 No-Try: true Change-Id: I38121933f5f3533d427ed178792d4f909f929bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638899 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665458}
-
chrome://flagsAlexey Baskakov authored
Bug: 915043 Change-Id: I0d3b27271ca725d5188f5efcf709750f8b3cdfcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640521Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665457}
-
David Staessens authored
This CL changes the output format of performance metrics for the video_decode_accelerator_perf_tests to json, to simplify parsing the output file from Tast. Results are written to: - perf_metrics/<test_name>.json - perf_metrics/<test_name>.frame_delivery_times.json TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I4af12c6413238a57f8ca2b0287e611a8cdf26466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605249 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/dom directory. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I63733c1a21476401370b2ec773c47f2a2c2ebe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640701Reviewed-by:
-
Kuo Jen Wei authored
Fulfill the TODO of judging camera facing from mojo API instead of device label. Bug: None Test: Test resolution switching function works normally on both builtin and external cameras. On HALv1 device, the resolution setting is hidden and can capture normally. Change-Id: I751a378ce94a32df836cafc3f1a786d3745f4fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638306Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#665454}
-
Md Abdullah Al Alamin authored
Previously when new unittest files were added to //src/tools/grit/ the grit/test_suite_all.py file was needed to be updated manually to run those tests. Now test_suite_all.py will search for unit tests in the grit directory and then run them using typ(//third_party/catapult/third_party/typ) like //third_party/blink/tools/run_blinkpy_tests.py 1) grit/shortcuts_unittests.py is renamed to grit/shortcuts_unittest.py to be consistent with existing unittest file names. 2) grit/format/gen_predetermined_ids_unittest.py and grit/pseudo_unittest.py files' unittest are skipped to run test automatically because they were not in included in the previously Bug: 965793 Change-Id: Iec4ac3214a9908b1eb2fee2a33e894ac7c99040d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638297 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 962834 Test: On both v1, v3 device, the resolution can be logged to GA dashbarod after capturing under different modes. Change-Id: Ib230863242b1ee38890d8865c89cfa6b5a77f6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637020 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
David Staessens authored
This CL adds a new metric 'frame drop rate' to the new video_decode_accelerator_perf_tests. TEST=ran new VDA perf tests on eve BUG=953114 Change-Id: I81bac2e01e42fcda3b08cb4608a974f9b5aa941a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577321 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change SearchController.search_ method to announce via Chromevox the following search results: * When there is any results: Showing results for $SEARCH_TERM. * When there is no results: There are no results for $SEARCH_TERM. * When clearing/cancelling the search: Search term cleared, showing all files and folders. Test: browser_tests --gtest_filter=" Search/FilesAppBrowse* : DriveSpecific/FilesAppBrowserTest.Test/drivePressClearSearch_DriveFs " Bug: 888581 Change-Id: I848c9344de87a758d18114dd045cf74d001ad32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630379Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#665450}
-
Noel Gordon authored
Dont report ISO speed 0, return "undefined" instead. Update the golden test file results to match. Test: piex/tests.sh PASS, speed unchanged. Bug: 965370 Change-Id: If7a62883ca89ccf8171934a7dff11ddb0ecaea10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638932Reviewed-by:
-
Darren Shen authored
Disable: - WorkerThreadRegistryTest.BasicObservingAndWorkerId - WorkerThreadRegistryTest.TaskRunnerRemovedCorrectly on Fuchsia. TBR=falken@chromium.org Bug: 969562 Change-Id: Iaee041bfb807cade7cab292cac839b81e31b1a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640522Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665448}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6d77e9e24c7d1f73f7ff6db3cd2c14a914697a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638933Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#665447}
-
Ting Shao authored
When ServiceWorkerImportedScriptUpdateCheck is enabled, main script response header check failures should cause update job failure. Bug: 648295 Change-Id: I0aa1b1cb96e8bba33745fb8d5f09baa55524e7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563693 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665446}
-
Darren Shen authored
Flaky failures on multiple bots, e.g. https://ci.chromium.org/p/chromium/builders/try/fuchsia_x64/299211 TBR=falken@chromium.org Bug: 968972,968971 Change-Id: I89baef8aed2e19121a6709e48348cdbce787714b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640581Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Idcf36e666b12cb0029f6c341c868ccf4e4cba450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639597 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665444}
-
Victor Costan authored
This CL replaces the bare new operator with std::make_unique and removes "return std::move" in favor of C++11's guaranteed copy elision. Change-Id: I66c210edc1d4529ef06ffde1bba3287d4cd3b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637248Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665443}
-
Darren Shen authored
This reverts commit a9d56928. Reason for revert: New test failing component_unittests. See 969547 Original change's description: > [omnibox] Rename the ZeroSuggestProvider::ResultType values > > This CL renames the ZeroSuggestProvider::ResultType values to be > more descriptive, and adds more commentary. > > They used to imply that we asked the default search provider for > zero-suggestions, which was sometimes misleading, since that's not > always true. > > Bug: 963173 > Change-Id: I85a55cb57749441d2adfdb53642247fd055b7d9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631903 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665330} TBR=mpearson@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963173 Change-Id: If450a7ed3c97689ff54847deaef0c4ad8bdf7e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640580Reviewed-by:
-
Victor Costan authored
The directory only has an OWNERS file since https://crrev.com/c/1282085 removed the code there on 2018-10-16. Bug: 888904 Change-Id: I6004e00e90a009c5fdf03968cd9b59f7f8ed0272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640578 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Darren Shen authored
This reverts commit 08842218. Reason for revert: Breaks compile for ios bots. See 969545 Original change's description: > Implement AppLaunchManager for controlling app-under-test for EG2 tests. > > No tests are added to smoke_egtest to test app relaunching, as it descends > from ChromeTestCase, which currently has logic which is required to run > every time the app-under-test is launched. Long-term, it is preferred if > this logic is moved to -setUp and executing before every test method. This > refactor will happen in a later CL as it requires some planning. > > Confirmed that smoke_egtest does however only launch the app once with the > change to use AppLaunchManager. > > Bug: 922813 > Change-Id: I7f33aa5a847f93295d918fdf4fff92aaf078f695 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635859 > Commit-Queue: ericale <ericale@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665367} TBR=rohitrao@chromium.org,eugenebut@chromium.org,lindsayw@chromium.org,ericale@chromium.org,monufriienko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922813 Change-Id: I425b5389d37527a30b5747a8d19339f52bcb7a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638929Reviewed-by:
-
Luciano Pacheco authored
Add a11y aria-live message for #view-button that announces the following messages: * After switching to List View: File list has changed to list view. * After switching to Thumbnail View: File list has changed to thumbnail view. Test: browser_tests --gtest_filter="GridView/FilesAppBrowserTest.Test/viewButtonSwitches" Bug: 888581 Change-Id: Ia6f02f6fa98a73b083d37e7cee84e9eb5a39f52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634512Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b0e0ade94cf..f9f6a47f27cc Created with: gclient setdep -r src-internal@f9f6a47f27cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ife1cbbc0616322d5ce2218f25639b0d995506b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640597Reviewed-by:
-
