GitLab

The COSE Key structures in our unittests were not in the correct format.

Change-Id: Ib2a7a914beaf3fdb4cd851076c49eae969810f44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177189
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#765399}

Bug: 1077852
Change-Id: If793d508092c4f339d2c416dcad0fe56d9fa5678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180366Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765398}

Previously after aZxHandleWatchController is finished or stopped it was
not possible to re-use for a new handle. That restriction is unnecassary.
This change updates the DCHECK to remove the restriction.

Also replaced mxio->fdio in two stale comments.

Bug: 1077837
Change-Id: I34af04abb9b5e9f6636cf90de40a80bf5d77f017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179766
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765397}

Bug: 1000989
Change-Id: I6d15008bcee143dd926fe342cdf15a3d13fe290b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176576
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765396}

This functionality is now contained within the help app.

Bug: b/149634001
Change-Id: Ifed722f9b2e0fda2fe9295c0c18153e40aca86a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169526
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765395}

Currently CdmService remotes are stored in a global static std::map that
is never cleared. This is fine since we only have one CDM |guid| used in
production so the size of the map should be at most one.

We plan to have multiple CDM processes (CdmService remotes), e.g. for
each origin. In that case, we should clear the CdmService remotes after
it's disconnected. Otherwise, the map size could keep growing.

Bug: 1077390
Change-Id: Ie294a8248c9e5ce05eb88c11022eb207fcbad464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177217Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765394}

This change should be safe as it should just make CrostiniRestarter
appear to be slower. In situations where we do not want restarters to
run any more (e.g. removing crostini), we have code to abort all
restarters so the "delay restart" behavior will not happen.

Notes
=====

Restarter shutdown observer registration
----------------------------------------
CrostiniRestarter now registers vm shutdown observer in Restart()
instead of the ctor. This is to correctly handle the case when there are
multiple restarters for the same vm: all restarters will wait for the vm
to shutdown without being terminated, and only the first restarter,
whose Restart() has been triggered, will kick off the restarting process
in OnVmShutdown().

This will cause a subtle behavior difference in a rare situation where
1) there are multiple restarters, 2) the first restarter is aborted just
before it gets OnVmShutdown(). The old behavior is that all restarters
will be terminated (because all of them get OnVmShutdown()), the new
behavior is other restarters will survive and one of them will be called
on Restart() by CrostiniManager::OnAbortRestartCrostini(). Note that if
the first restarter is not aborted, all restarters will still be
terminated by the FinishRestart() in OnVmShutdown() of the first
restarter.

CrostiniManager::OnStopVm()
---------------------------
CrostiniManager::OnStopVm() does not call OnVmStoppedCleanup() any more.
This is because when the VM is stopped, CrostiniManager::OnVmStopped()
will be invoked, and it already calls OnVmStoppedCleanup(). Removing
this avoids CrostiniRestarter::OnVmShutdown() to be called twice for the
same shutdown.

Bug: 1075731
Test: unit tests and manually testing (including removing linux with multiple delayed restarters)
Change-Id: Ic34e5333d544a2ff849079a085f342e669ed9523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172187Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Jason Lin <lxj@google.com>
Cr-Commit-Position: refs/heads/master@{#765393}

Javascript and testing improvements.
Addressing hsuregan and khorimoto's comments on previous CL (see bug).

Fixed: 1077314
Change-Id: I007ab73e223f57f1ab1115fd5ecfc97aaf4db91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178555
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765392}

This log will show up whenever there is no file exists, causes noise in
logs in the bots.

BUG=853604

Change-Id: I0c9905d5f460c3b36bc1b62b2198ca890c1428ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181692Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765391}

- deleted .style.yapf files in subdirs
- added root .style.yapf file
- reformat *.py files

Bug: 1051750
Change-Id: Ia50551d302bff115600bb4e532e29cc9ca5a9d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165727Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765390}

Bug: 1078101
Change-Id: I79afddab741466ad971e24ecd5b5f74b373f2b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181036Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765389}

Adds a new histogram Translate.Translate.AMPCacheURL reported
at same point that Translate.Translate is reported.


Bug: 797328
Change-Id: I0a3ff68f4fa47da4b866714fd575789ad34844e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176318Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765388}

Adds traces to measure the duration until the theme is set and the
background image is loaded. Since the background image is loaded in an
iframe, the load event is sent back to the NTP via a postMessage and
logged there. If we logged the background image load time in the iframe,
the event would be logged with respect to the iframe's load time and,
thus, wouldn't be comparable to other NTP traces.

Bug: 1061078
Change-Id: Iaf5ceec2c6ee44e0f838cf25ae2c1cbbe0f03a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181522
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765387}

If the retransmittable_on_wire_timeout is set to non-zero, but no custom
FLAGS_quic_max_aggressive_retransmittable_on_wire_ping_count is
provided, default set it to 200 which ensures that aggressive pings will
stop and falls back to 15s pings until forward progress is made on the
string. This helps mitigate data usage and battery usage if upstream
leaks long standing idle streams.

Bug: 1005610
Change-Id: I5b5072aaa13583ca8f1d76fea63ecfc04cb46591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181577Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765386}

In this cl, we add model params path for unibuild models.

Bug: 881215,1062070
Change-Id: I0dafba8a870741e87e2ac1bb99e4721b6beb6f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160672Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765385}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f47d332f161..9e99f7c84e3d

git log 0f47d332f161..9e99f7c84e3d --date=short --first-parent --format='%ad %ae %s'
2020-05-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@9e99f7c84e3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I2d15b13bf624a3818f85a8c5daf8b7a3088e9764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181720Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#765384}

R=calamity@chromium.org

Change-Id: Id70ede3e2f6fc11dc94a74d0c04ff442e76fea0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181578Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765383}

This adds kEncodeConstantQuantizationParameter to
VaapiWrapper::kEncode to configure how a VA-API driver controls
bitrate on video encoding, Constant Bit Rate (CBR) or Constant
Quantization Parameter (CQP).

In CBR, VaapiWrapper relies on the driver to produce a bitstream
following a specified bit rate. In CQP, VaapiWrapper caller
computes and provides an appropriate quantization parameter every
frame.

This CL introduces the new CodecMode and thus doesn't change
either functionality or behavior.

Bug: 1060775
Test: video.EncodeAccel.*
Change-Id: I3bf0b1eab142089ba6e945ff4b6e6dcc3b9651f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159178
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765382}

The intent picker flag is on by default for a few milestones. This CL
removes the flag.

BUG=939205

Change-Id: Iee1fe1a46f4d9d55e9d881cb7cea65f30d32351b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178552Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Melissa Zhang <melzhang@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765381}

It's been enabled by default for a while.

Removes focus/blur and traversal key handling from search result views.
With the feature enabled, focus stays with the search box view which
handles traversal keys and updates the selection accordingly. This means
that search results themselves are not expected to get focus, nor handle
traversal keys - search box view may still pass return and back keys to
the selected result view, so result views' code for handling these key
evens should remain.

BUG=1059887

Change-Id: I043a2456e97673b2d8c53c83b37538e3ca408239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093392
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765380}

Bug: 1060399
Change-Id: I90c035e1ee543ba2920c0bd9bf97db68e64b6257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181568
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765379}

TBR: dgrogan@chromium.org
Bug: 1076027
Change-Id: I19fed268e5c8950f95143c1777bd9a8fec5e5358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181440Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765378}

Change-Id: I48023ea72056a9dabd14b5fd9ec191870c40b75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181715Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765377}

Bug: 1070409
Change-Id: I1da7f077f637795ed239e82d67e1b94d49f7144a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174033Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765376}

Bug: 1058325
Test: Record a 2hrs video and check the thumbnail generation time
and content manually.

Change-Id: I189e7bdcf3b78c8aa41680456dcd556495e681dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179863
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765375}

MoveBrowsersInWorkspaceToFront() should not be called with an empty
workspace argument.

Also, a recent change [1] would sometimes call
MoveBrowsersInWorkspaceToFront() with the workspace of the browser
window, not the current workspace.  This is incorrect, so a comment is
added to make usage clear.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2093438

BUG=1076913
R=sky

Change-Id: If3a0be8b40352315a8afea8741e3888e5790d9fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181576
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765374}

This reverts commit f47c5813.

Reason for revert: The new test is failing on multiple bots, e.g.
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/24417
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/53585

Original change's description:
> Query Tiles: Use TileIterator to implement TileManager::GetTile().
> 
> Replace the recursive implementation with TileItartor. Also test is
> polished to cover the empty return case.
> 
> Bug: NONE
> Change-Id: Ifd86c560a89f639d4920cff88df5cca044fa83cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177297
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Reviewed-by: Hesen Zhang <hesen@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#765329}

TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org

Change-Id: I2acfc7c83b151d841dac914bb7b8195da63abdfa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: NONE
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181052Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765373}

The previous CL invalidates the cc texture and requests and update from the LayoutUpdateHost before hiding the Java view and starting the browser controls animation. However, we could still see the stale texture for a moment, though not as frequently.

With this CL, we will wait for the #didSwapBuffers() (the sequence is onCompositorLayout -> didSwapFrame -> didSwapBuffers) call to move on to the browser controls animation. This should mostly solve the issue.

One thing to note is that there is no guarantee the updated buffer will be the one currently displayed. If we still have issues, we can explore better options mentioned in the bug.

Bug: 1068346
Change-Id: I32d0de4359b3c086d7ba3e9fb744831b771ccfe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174857Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#765372}

https://chromium.googlesource.com/angle/angle.git/+log/4271443d7e44..41f7bcce04a8

git log 4271443d7e44..41f7bcce04a8 --date=short --first-parent --format='%ad %ae %s'
2020-05-04 cclao@google.com Vulkan: Add missing cache flush
2020-05-04 jmadill@chromium.org Vulkan: Update VMA integration.
2020-05-04 sugoi@google.com Fix clearing the program's validation-related cache too early

Created with:
  gclient setdep -r src/third_party/angle@41f7bcce04a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1074162
Tbr: courtneygo@google.com
Change-Id: Iafcd49f03b16ef17bda3071183df33360562f677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#765371}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1363c04b..f753bc34

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If92f4aab9b34700eb19a14d0e2c46955b856a2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181890Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#765370}

Now that KitKat (v19) is deprecated, merge settings-related style
resources under //components/browser_ui/settings from v21/styles.xml
into the base styles.xml.

Bug: 1009058, 971791
Change-Id: Iaa7adad93141fb970157c0b9fdc3a07f01895936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176515
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765369}

BUG=1046598
TEST=bots
R=kbr@chromium.org

Change-Id: I86f6251736db588366eb9fd3089cf00398752a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181225
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765368}

running theory is that it's possible for RTCVideoDecodeAdapter to
be destroyed while the callback is posting, so when it is finished the
result is dropped. Making the method static prevents this.

Bug: 1076817
Change-Id: I07f6ef991891af4b3646df87597f6abf7bcee94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181717Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765367}

This metric will get recorded each time the sync service starts and
whenever the total count changes.  The count of unique users
that record this metric can be used to find the active user count.

Bug: 966270
Change-Id: I06b79c2e703299d5585935d70003198a4958aa52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166123Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Jon Mann <jonmann@google.com>
Cr-Commit-Position: refs/heads/master@{#765366}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db551cbc8b4b..af417bfdda10


Created with:
  gclient setdep -r src-internal@af417bfdda10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC estade@google.com,keishi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1065456
Tbr: estade@google.com,keishi@google.com
Change-Id: I6c10bc00225bdab34a4810cc3a9355b183a19dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181644Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#765365}

BUG=1074222
R=thestig

Change-Id: I7789f5ed070997491aa3ea3366edae9a3c76a8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181050Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765364}

screenshots:
https://drive.google.com/a/google.com/file/d/1t90H0jzZynyzwd4-JdMlh6s_Q6KhWlsk/view?usp=sharing
https://drive.google.com/a/google.com/file/d/1gTirnwr0jhJghSWCkr2tnd0ySlaUF2Ai/view?usp=sharing

Bug: 1076449
Change-Id: I64292f34e40269707d2cc09cbdd7a4da4c56e303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173118Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765363}

Content menus use the AppService mojom, so it is asynchronous. When
right click on an icon for context menu, the context menu callback is
not run yet, so the checking in Ash
(context_menu_ && context_menu_->IsShowingMenu()) can't return true to
draw the round rect for the icon.

Add waiting_for_context_menu_options_ to the checking condition, to draw
the round rect for the icon.

BUG=1076839

Change-Id: I0fbc2809dd11afacddde9cf21db4043cb5196fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174251Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765362}

This is a follow up of https://crrev.com/c/2165906, and another
step forward to get rid of RenderWidget::SetHasTouchEventHandlers().
Note that the only reason the method is not removed as part of
this CL already is because this method is still overridden by
TouchEventHandlerWebWidgetClient class (web_view_test.cc).

It essentially moves the ownership of |render_widget_scheduling_state_|
from content::RenderWidget to blink::WidgetBase.

WebWidget gets an accessor, implemented by its 3 child concrete classes
WebPagePopupImpl, WebExternalWidgetImpl and WebFrameWidgetBase.

BUG=1071594

Change-Id: I1b54332695a6c7784737a3c54c9a1a76a91b0fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173482Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#765361}

Bug: 1015134
Change-Id: I7f119912e5a8ebbca92178c99220d9f66f5f7fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156143
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765360}