- 11 Jan, 2019 40 commits
-
-
danakj authored
When frozen there is no WebFrameWidget, so this cast is invalid. R=dcheng@chromium.org Change-Id: I7a103aeeeb9920d128e1b8ad0b6075fc830ca0d6 Bug: 920952, 917907 Reviewed-on: https://chromium-review.googlesource.com/c/1407038Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#622080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9e5c9014937e..f7f13a85db94 git log 9e5c9014937e..f7f13a85db94 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 mikenichols@chromium.org Revert "Removed the unused drop_file from chromite/cbuildbot" Created with: gclient setdep -r src/third_party/chromite@f7f13a85db94 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie8111b7ab549da45ef92a9ad04ed2e9bc901dd46 Reviewed-on: https://chromium-review.googlesource.com/c/1406958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622079}
-
Koji Ishii authored
As Finch indicated pre-paint is slower in NG, this patch splits the loop to compute VisualRect for fragments for when there's a selection for the LayoutObject and for when not. By splitting the loop, not only reducing the work within the loop, we could try to apply simplication of VisualRect for inline fragments as legacy does. For the branch when there is a selection, yoichio@ will look into it after the end of January. Bug: 636993 Change-Id: Ia06ad95e0cd7e0e9f2d663d26ee2fc7702c05908 Reviewed-on: https://chromium-review.googlesource.com/c/1405948Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622078}
-
Aleks Totic authored
Bug: 635619 Change-Id: Ib1b0bc2b86f80a1758cff6bcb157c26ec76fdf4c Reviewed-on: https://chromium-review.googlesource.com/c/1407270Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#622077}
-
Antoine Labour authored
This allows further reduce our dependency on GL. Bug: None Change-Id: Ie9d606bbaabda7ee0c0055750653ef1281fedf63 Reviewed-on: https://chromium-review.googlesource.com/c/1406290Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622076}
-
Philip Rogers authored
BlinkGenPropertyTrees (BGPT) has been enabled for tests for some time (status="test" & status="experimental" in runtime_enabled_features.json5 both enable the setting for tests). This patch removes the flag-specific expectations which are unused. Bug: 836886 Change-Id: I02f58268f5738e6c242cfadba8dd72c8aed87d0c Reviewed-on: https://chromium-review.googlesource.com/c/1405428Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622075}
-
Eugene But authored
NavigationItemCommitted is deprecated and should be removed. DidFinishNavigation is more general purpose method, which is called when navigation is committed, replaced or aborted. Bug: 781534 Change-Id: I77d79970548e4d5291b9953c09490fddb50c6d72 Reviewed-on: https://chromium-review.googlesource.com/c/1406076Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#622074}
-
Jan Krcal authored
This CL simplifies debugging sync integration tests (and possibly other tasks). Bug: 853688 Change-Id: I4a72855cc400d33743cf8fc00979270af2ac92e0 Reviewed-on: https://chromium-review.googlesource.com/c/1406972Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#622073}
-
Koji Ishii authored
This patch changes LayoutText to use |DirtyLinesFromChangedChild()| when it is removed. This change makes LayoutText behavior the same as LayoutInline in this regard. Before the change, LayoutText marked only the line it belongs to. When it is removed, however, it should mark the line its previous sibling belongs to. E.g., line 1<br>line 2 and removing "line 2" should invalidate the 1st line because its break token needs to be updated. Another example: <span>foo part</span>OfLongWord and removing "OfLongWord" may make "part" to fit to the previous line. There are tests that remove <span>s, but there were no tests that remove text nodes unfortunately. Given it turned out that we have separate code for each type on removal, this patch adds some tests, but will add more in following patches. Bug: 918812 Change-Id: I6ada5c9d9dbec51d03ed3f1fc9db8d70c031bdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1405127Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622072}
-
Wez authored
These tests were flakily hanging, with unsufficient diagnostic output for us to diagnose the issue. Now that we have per-Run() timeouts we can re-enable these tests to get diagnostic call-stacks when they hang. Bug: 913037 Change-Id: I5ef11d59e78304ac7182e3953d7a693f7ec502e4 Reviewed-on: https://chromium-review.googlesource.com/c/1406139 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622071}
-
Bin Wu authored
In QUIC, add WriteStatus WRITE_STATUS_BLOCKED_DATA_BUFFERED and use it to represent "A WritePacket caused socket to block and the packet is buffered in writer". Not protected, because this status code is not used in GFE. This is intended to be used by batch packet writers, for them, whether the packet that caused write block is buffered can vary from one WritePacket call to another. The per-class IsWriteBlockedDataBuffered() method is not enough to express that. Merge internal change: 228872041 R=rch@chromium.org Change-Id: I39bdd8f6d1b9e7442f7d51c54231002227790809 Reviewed-on: https://chromium-review.googlesource.com/c/1407030Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#622070}
-
Wez authored
Un-filter three tests which were flaking ~1 year ago: - DiskCacheBackendTest.InvalidEntry5 - DiskCacheEntryTest.ExternalAsyncIONoBuffer - URLRequestTest.NetworkDelegateProxyError There have been substantial filesystem and network changes in the platform, and we have enabled TestLauncher retries on the Fuchsia bots, so these should be safe to start running. Bug: 784448, 810521, 814811 Change-Id: I7166ab60ee8a5a8dc7097c0969da8c7bc57878b8 Reviewed-on: https://chromium-review.googlesource.com/c/1405595Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#622069}
-
Daniel Rubery authored
Since every file in a ZIP must have a valid Local File Header, we can bound the number of files in a ZIP by the number of Local File Headers. This should exactly match the number of files extracted by ZipReader, unless something fishy is going on. Bug: 873766 Change-Id: Idba1788ebd3dada29a9e847569f0af692e097c8c Reviewed-on: https://chromium-review.googlesource.com/c/1404056 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#622068}
-
James Cook authored
The check causes low-level browser_test flake across a wide variety of test suites, usually due to check failures during test suite teardown. This is test-only code, so relax the check until the root cause can be investigated further. Bug: 466089, 871010, 913006, 915360, 919347 Test: browser_tests Change-Id: Ife2ab6a6d260471f79873b6f0fd2914a4c7bb71d Reviewed-on: https://chromium-review.googlesource.com/c/1403353Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#622067}
-
Marijn Kruisselbrink authored
mojo::DataPipe should not be used in production code since it provides no way to deal with errors while creating the pipe. So switch usage of that class to instead just call CreateDataPipe directly. Bug: 918054 Change-Id: Idcae7fe5b587b88ea534474f0a4de7bf8113d370 Reviewed-on: https://chromium-review.googlesource.com/c/1406134Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#622066}
-
Adithya Srinivasan authored
Tbr: changwan@chromium.org No-Try: true Bug: 921089 Change-Id: I23cd864d189a5b5e9b52a7a169ec576e479f36fe Reviewed-on: https://chromium-review.googlesource.com/c/1407371Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#622065}
-
barkerd authored
This is possible because the implementation of the postMessage API was completed in https://chromium-review.googlesource.com/c/chromium/src/+/1323669. Bug: 898840 Change-Id: Ib3bfc9a9be1ea70be760204715b86ea8053e9ea8 Reviewed-on: https://chromium-review.googlesource.com/c/1406686Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: David Barker <barkerd@google.com> Cr-Commit-Position: refs/heads/master@{#622064}
-
Sergey Ulanov authored
The new version adds vulkan_fuchsia.h Bug: 861853 Change-Id: Iaad12a3ce67fbdb5908abc0ea5aebce3e8d40b55 Reviewed-on: https://chromium-review.googlesource.com/c/1406308 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622063}
-
wutao authored
In MdTab::OnFocus, it does not notify a11y event of focus, which causes the ChromeVox focus out of sync. This patch notifies the event as we do in the Tab::OnFocus. Bug: 876388 Test: manual Change-Id: I332c3dfa355d9ab41cf5848f549cde164d73b045 Reviewed-on: https://chromium-review.googlesource.com/c/1406196Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#622062}
-
Jun Mukai authored
The non-client area in ProxyWindow is set through "DraggableRegions", and this section is used for draggability of the window (see https://cs.chromium.org/chromium/src/apps/ui/views/app_window_frame_view.cc?sq=package:chromium&g=0&l=196). The same logic should be introduced on Mash, otherwise frameless app window can't be dragged. Bug: 920469 Test: ash_unittests Change-Id: If249d58dbf0a84aa3b333799f44f122dca04c4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1405458Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#622061}
-
Chris Harrelson authored
setting needs overflow recalc to PaintLayer. Bug: 918597, 918598 Change-Id: I7736dc073deabdcf773d29574f6448c08cb699b1 Reviewed-on: https://chromium-review.googlesource.com/c/1405452 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#622060}
-
Ovidio Henriquez authored
This change adds the chooser-exception-list Polymer element to site settings. This element will fetch the chooser exceptions from the C++ site and process them for display. The element uses a chooser-exception-list-entry to render each chooser exception in the list. This change also adds to ability for the paper-tooltip to have its target set manually. This allows the target to be set on the common paper-tooltip element used in chooser-exception-list and site-list without having to access its private `_target` property. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I3f127d2cf655b2d75157d7174a9bd5e434b583a8 Reviewed-on: https://chromium-review.googlesource.com/c/1357556 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622059}
-
Daniel Bratell authored
R=mmenke@chromium.org Change-Id: I34db82f8d15864eab67c6cd7dd6490ebac31ec02 Reviewed-on: https://chromium-review.googlesource.com/c/1407004Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622058}
-
Denis Kuznetsov authored
Bug: 916991 Change-Id: If13af642d61dc00b406e09ccdde7555829f9f1bf Reviewed-on: https://chromium-review.googlesource.com/c/1406975 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#622057}
-
Michael van Ouwerkerk authored
In the UMA dashboard we can use this to slice metrics like PrivateMemoryFootprint. Bug: 882370 Change-Id: I70f07590db3ad183325ed2e4e03fbe680413c937 Reviewed-on: https://chromium-review.googlesource.com/c/1405189Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#622056}
-
Dan Harrington authored
Bug: 908523 Change-Id: I014e6f5213096d7dd3f6f88454ac338eb4c9ed3c Reviewed-on: https://chromium-review.googlesource.com/c/1407113Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#622055}
-
Liquan(Max) Gu authored
In order to make FCP++ deal with both text and image, we combine Largest Image Paint and Largest Text Paint into Largest Content Paint. The largest content paint is the paint time of either the largest text paint or the largest image paint, depending on whether the largest text or the largest image is larger. We take whichever larger to be the largest content and use its paint time as Largest Content Paint. Bug: 919619 Change-Id: I623e0682b43b2a98ec681b3988159780ac0f7adb Reviewed-on: https://chromium-review.googlesource.com/c/1399282 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9af71a58413e..e58cda9a3da9 Created with: gclient setdep -r src-internal@e58cda9a3da9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I31082c1e4fef7224c52e508a44321c6238fe0fa6 Reviewed-on: https://chromium-review.googlesource.com/c/1407116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622053}
-
Steven Bennetts authored
This includes some deps cleanup of //chromeos. For explicit DEPS extraction: TBR=sky@chromium.org Bug: 918682 Change-Id: I551c9a78284e86aef229f7c12e9b8611d4514c07 Reviewed-on: https://chromium-review.googlesource.com/c/1405968 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622052}
-
Yuly Novikov authored
conformance2/textures/image_bitmap_from_image_data/ tex-2d-rgb9_e5-rgb-float.html deqp/functional/gles3/framebufferblit/depth_stencil.html TBR=kbr@chromium.org Bug: 921052, 921055 Change-Id: If6e3a998f7de646c20fd22396e0faa8b081a4a2b Reviewed-on: https://chromium-review.googlesource.com/c/1407111Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#622051}
-
Ayu Ishii authored
Bug: 916176 Change-Id: Ic2ff27655cec1a3ec4991a468710449b62457d80 Reviewed-on: https://chromium-review.googlesource.com/c/1392272Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#622050}
-
Ben Kelly authored
This is a reland of cc10cead The previous patch failed to build after the ResourceFetcher constructor arguments changed. This reland includes a mechanical fix to use the new constructor form. Original change's description: > Support IsolatedCodeCache for service worker pass-through responses. > > Previously code caching of scripts served from service workers was only > supported if the Response was produced from cache_storage. If the > service worker implemented a pass-through handler like: > > evt.respondWith(fetch(evt.request)) > > Then the v8 compiler could not store or load code cache for the script. > > With IsolatedCodeCache shipping it becomes much simpler to now > support this feature. This CL enables support by: > > 1) Fetching the code cache for service worker controlled scripts. > 2) Allowing the code cache to be used for pass-through responses. > 3) Storing any code cache produced for pass-through responses. > > We still explicitly disable code cache for service worker handlers that > produce either: > > a) Synthetic `new Response()` objects. > b) Response objects produced by `fetch()` to a URL different from the > original request URL. > > Bug: 917414 > Change-Id: I4efdc852a27069d2937056af0133a986e745b2be > Reviewed-on: https://chromium-review.googlesource.com/c/1394740 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621993} TBR=kinuko@chromium.org Bug: 917414 Change-Id: I547f0b410c59a14a1f9fff8f328b008ee7b1bb79 Reviewed-on: https://chromium-review.googlesource.com/c/1407029Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#622049}
-
Oksana Zhuravlova authored
This change moves the remaining output FrameHostMsg_CreateChildFrame parameters into the FrameHostMsg_CreateChildFrame_Params_Reply struct. Bug: 718652 Change-Id: I50678321dc49e2c449452292decf71dae8b90db3 Reviewed-on: https://chromium-review.googlesource.com/c/1405878Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#622048}
-
Dan Harrington authored
Watch for navigations and request coordinator changes to determine when the in-progress notification should be shown. A follow-up CL will introduce an instrumentation test to supplement the unit tests here. Bug: 883486 RELAND: This is a reland for https://chromium-review.googlesource.com/c/1381233 Changes to OfflinePageBridge were removed. TBR=petewil@chromium.org This is the same patch, but without the base CL. The base CL was unintentially submitted previously. Change-Id: I8e6988edcc0e8ca810f99c1961c9cdb9f730ba40 Reviewed-on: https://chromium-review.googlesource.com/c/1406939 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#622047}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36248fcd635b..31a486419e27 git log 36248fcd635b..31a486419e27 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 digit@google.com Improve no-long-lines check for Python files. Created with: gclient setdep -r src/third_party/depot_tools@31a486419e27 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890734 TBR=agable@chromium.org Change-Id: I9ab884eab3eec557371b5b10321f893ea09161fd Reviewed-on: https://chromium-review.googlesource.com/c/1406956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622046}
-
Dmitry Gozman authored
- Trigger static locals on main frame. We used to do that as a part of loading main resource, but now we don't. - Allow null Resource in DispatchDidReceiveResponse, it's not actually needed and will be missing for main resources. Bug: 855189 Change-Id: I51d2a433501bfdff4dba677d61210b62bec58802 Reviewed-on: https://chromium-review.googlesource.com/c/1401674Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622045}
-
Becca Hughes authored
At the moment on Android we trigger the kPlay or kPause actions if they are registered. This moves that logic a layer down to C++ so it will work for keyboard controls too. BUG=894255 Change-Id: I0eae3ac51b7d772643ab2a56091e3f0ddb6b2325 Reviewed-on: https://chromium-review.googlesource.com/c/1404178Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#622044}
-
Abhijeet Kandalkar authored
This CL fixes kiosk_browsertest away from talking to IdentityManagerFactory in favor of talking to IdentityManagerFactory. Bug: 920204 Change-Id: I584638eb5e31e39954658793dc25da80db993588 Reviewed-on: https://chromium-review.googlesource.com/c/1406729Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#622043}
-
Rune Lillesveen authored
Fixes crash when trying to set selectorText of detached @page rules. We only match local name part of the tag, so there should be no behavioral change here. Bug: 920303 Change-Id: I4b09b4e108506fd21d87844dec32209f5984de49 Reviewed-on: https://chromium-review.googlesource.com/c/1406716 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#622042}
-
Alex Newcomer authored
The shelf bg used to shift opacity as the launcher animation began, instead it should wait until the launcher is at shelf height. This changes two things: - Notify observers of target visibility changing when the animation begins. - Notify observers of actual visibility changing when the animation ends. Change-Id: I6e020406bb6fc0daf3430cec38c0abb6fb230a97 Reviewed-on: https://chromium-review.googlesource.com/c/1370368Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622041}
-