- 28 Apr, 2020 40 commits
-
-
Wei Lee authored
Currently we just drop the event when there is active window instance. We should minimize/restore the active window when receiving onLaunched event. Bug: b/155027774 Test: Manually test Change-Id: I41ddf53cfb439ad6b32ae628c35e271d709561eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167739Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#763298}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3b65543f79139bf68af3e9fec631d7790a1adf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763297}
-
Evan Stade authored
Clank was updated in 6fa66cda Bug: 1069895 Change-Id: I2d0210b61267c4473ec40c93d39214ac16400bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163419 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#763296}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2717702e9a1f..587fbb9ef3a5 git log 2717702e9a1f..587fbb9ef3a5 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 bclayton@google.com ReactorUnitTests: Speed up multithreaded tests Created with: gclient setdep -r src/third_party/swiftshader@587fbb9ef3a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If43d83f3c6b6b7a3af68cf42995c9618f999d800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169981Reviewed-by:
-
Rohit Rao authored
The allocator shim does not need to be multi-process aware, so it is acceptable to use the 64-bit specific vm_ functions in vm_map.h. This change allows the interception code to compile as-is on iOS. BUG=1075702 Change-Id: Idf94070abf5574e623a438c561e48435e3309503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168217Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#763294}
-
Alexander Hendrich authored
TBR=yuzus@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org Bug: 1075936 Change-Id: I8b0e0f14e37271abd464879683e2c63288bbc365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168873Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#763293}
-
Rune Lillesveen authored
Mark failure with correct bug id. Bug: 1074547 Change-Id: I9e4b9a1477154b0159379adac6d6dd1d22267385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169995Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#763292}
-
Finnur Thorarinsson authored
We're actively working on improving the PhotoPicker and these metrics help us determine whether the changes positively or negatively affect the users. Bug: 895776, 1072508, 1072507, 1072506, 1072505, 1072504, 1072503, 1072502, 1072501, 1072500 Change-Id: I0dfff13cbd46cb308a7250d38f590b6d4968443f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164813 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#763291}
-
Mathias Bynens authored
A DevTools CL [1] adds support for the new `revert` CSS keyword/value, which affects the autocompletion results. A previous patch [2] temporarily disabled these tests until the DevTools CL landed and rolled [3] into Chromium. This patch restores the tests with the new expectations. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168093 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2169647 [3]: https://chromium-review.googlesource.com/c/chromium/src/+/2169979 Bug: chromium:579788, chromium:1075437 Change-Id: I360c26061df9d53b5f5cf825ba9489950574eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169908 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#763290}
-
Mugdha Lakhani authored
PageInfoDelegateImpl returns a valid PermissionDecisionAutblocker after this change. A simple browsertest verifies this. Bug: 1052375 Change-Id: Iafde595163c7706b05bc91144fcc938eca49cebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165741 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#763289}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib00317ced8d77a8b4fdd7481bfe5782dd52e101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169486Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#763288}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I1c0c8450be6320577ebebe39a2cb1abc692fe8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164613 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#763287}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8a1fbea36994..bed1eba707ac git log 8a1fbea36994..bed1eba707ac --date=short --first-parent --format='%ad %ae %s' 2020-04-28 ddrone@google.com processor: Migrate LegacyIpc to reflection-based parsing Created with: gclient setdep -r src/third_party/perfetto@bed1eba707ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:149826806 Tbr: perfetto-bugs@google.com Change-Id: I56ff1bae3d3deea780f612218baa690b85033034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169980Reviewed-by:
-
Nate Fischer authored
This removes temporary migration code. This code existed to migrate canary and dev clients who used the Dev UI when developer mode was controlled by manipulating ContentProvider state, rather than the state of a dummy component (see https://crrev.com/c/2005973). Metrics suggest every client has upgraded past this migration code, so it's no longer required. Fixed: 1073724 Test: N/A Change-Id: I5d6e2e70642054e5dc3f04a5b045473542b77a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169477 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#763285}
-
Nate Fischer authored
No change to logic. This removes a redundant Intent variable, which was just a copy-paste error (the variable is declared and used on a different line). Test: Manually verify dev UI still works Change-Id: I748459463d6de8ae8cd3444c760e3cd2aaf8a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168769 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
-
Matthew Denton authored
Right now, the Network Service is responsible for creating the CertVerifier, according to the parameters passed into the NetworkContextParams. Creation of the CertVerifier is moving out of the Network Service, and into its own service. This moves the creation of the CertVerifier into a separate build target from the Network Service, making the Network Service depend on it. This allows the Network Service to continue to create CertVerifiers in-process, but makes it easier to move this into a standalone service. AIA/OCSP fetching has two variants - one using URLRequest and one using URLLoader. When running in process, the Network Service can just use the URLRequest interfaces directly, without having to indirect back through the URLLoader. Because the URLLoader interfaces are not needed at all by the Network Service during the transition, they are moved to the Cert Verifier service in this CL. The new directory, //services/cert_verifier/cert_net_url_loader (which uses URLLoader), is a conceptual parallel for the Cert Verifier service to the existing //net/cert_net (which uses URLRequest) used by the Network Service, and that will eventually be removed. Bug: 1015134 Change-Id: I32897c3e5e202eb60d9528052594af0bff5ac4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029194Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#763283}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/606fd4da917c..811c6e98ee25 git log 606fd4da917c..811c6e98ee25 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 mathias@chromium.org Add support for the CSS `revert` keyword/value Created with: gclient setdep -r src/third_party/devtools-frontend/src@811c6e98ee25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1075437,chromium:579788 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67975cfc2dc68f7e3027315aa935eae6cb846a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169979Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I78d1009ed98f7e67c2caed18c529d8618b1ae175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164893 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#763281}
-
arthursonzogni authored
[Android sheriff] In the next 2 build following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2166387 I have seen: Consistently failing: testHttpsBeforeAcceptForOptOut Flaky: testTapGesturesNearbyKeepSelecting testQuickActionUrl TBR=donnd@chromium.org,jinsukkim@chromium.org Bug: 1075895 Change-Id: Ie024a8882a44d401222a6d9c25ca2beaeccd0988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169987 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure to update the consumer of the toolbar when the a page has finished loading. This is the only callback we have when a navigation is cancelled, which can happen on the NTP when loading a AppStore URL. Fixed: 1074291 Change-Id: Ic71b28ef8cf4a102e9f28c9206e4fab8267fd6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167445 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#763279}
-
Mark Cogan authored
-[SceneController tabSwitcher:shouldFinishWithBrowser:focusOmnibox:] is crashing in release, and the only likely culprit is an NPE when de- referencing the Browser parameter. TabGridCoordinator's -showActiveTabInPage:focusOmnibox: has a code path that will pass a nullptr Browser into this method, guarded only by a NOTREACHED(), so it's live in release. This CL updates that code path (an unexpected value in a switch statement) to early return instead of continue. Bug: 1069243 Change-Id: I04839dc5785fb41d27f20679f49e1b955ffa6750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169988Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#763278}
-
Morten Stenshorne authored
This is a reland of CL:2152824, which got reverted because of use-after-free issues, which got fixed by CL:2165800 As part of the descendants walk that we perform when adding a box fragment that establishes an inline formatting context, update the first/last-for-node bits directly. Many thanks to kojii@ for suggesting and helping out with this solution! Once we add the last box fragment for a node, finalize the inline items. In addition to associating with the LayoutObjects, also set the first/last-for-node bits, if fragment traversal is enabled. Since we now require the layout results to be available for anything that establishes an inline formatting context (to set the first/last bits), we also need to store the layout results for the column fragments. Columns are not really associated with a LayoutObject, but we'll use the legacy LayoutFlowThread for this. Another option would be to create an anonymous block child of a multicol container that establishes an inline formatting context, but I decided against that for now. Expanded some NGFragmentItemTest unit tests, and added a new one, to make sure that we behave in RTL situations. This allows for supporting these bits in culled inlines as well. Enabled fragment traversal in NGFragmentItemTest, so that we can test it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The culled inlines test there also expects FragmentsVisualRectBoundingBox() to return something sensible, so remove the skipping we had in PrePaint for culled inlines, to just make this work. Will follow-up with cleaning up the first/last for node stuff added as part of CL:2111158. This will no longer be needed, but doing it in a separate CL is probably cleaner. TBR=kojii@chromium.org Bug: 1043787 Change-Id: Ie5078bcf22f192e70e39ddb3c432c4d56d3d3e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169929Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#763277}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc25fb6cb08..df658be0297c Created with: gclient setdep -r src-internal@df658be0297c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1067070 Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com Change-Id: I9d58ce95435514c10c4c00ed5324490d5b72bdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763276}
-
Abhijeet Kandalkar authored
This CL defines frame-widget-specific methods that will be invoked from the browser process to set an effective touch action on an out-of-process iframe. Bug: 1071585 Change-Id: I95853ba28dff97871579b35672716ea07900e921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162488 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#763275}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4395170e6091..7c83a44539bf git log 4395170e6091..7c83a44539bf --date=short --first-parent --format='%ad %ae %s' 2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src bcf6a2430e99..f03cb290ac10 (3 commits) Created with: gclient setdep -r src/third_party/angle@7c83a44539bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I458b482e0550ff88578a5a17fe6e0eabc43aad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169977Reviewed-by:
-
Takashi Toyoshima authored
base::flat_set is the best container to have the small number of headers set. This is a follow-up CL for http://crrev.com/c/2129787. Bug: 1067166 Change-Id: I3d8ced182aa0fe522fa96a7e2ae77f605a4dd2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169490 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
TBR=hta@chromium.org Bug: 1075915 Change-Id: I3a0ffc11523bfd613c49f807d82be8e822287d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169992Reviewed-by:
-
Alexander Hendrich authored
Test is also flaky on other platforms (see bug). TBR=estark@chromium.org Bug: 638576 Change-Id: I0abf86677e22baa16163f973b28d8866f7db10a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170066Reviewed-by:
-
sauski authored
Adds sauski@google.com as owner of: chrome/browser/resources/settings/privacy_page/ chrome/browser/resources/settings/safety_check_page/ chrome/browser/resources/settings/site_settings_page/ chrome/browser/resources/settings/site_settings/ Also extends ownership of tests for the above folders to sauski. Change-Id: Icc9a40dcfa3d302a149f1c0869aaa51e9a86e305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164896Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#763270}
-
Yan, Shaobo authored
Reland with a fix for doing memcpy on a temp variable in DawnTextureFromImageBitmapTest_VerifyAccessTexture. Fix this by storing the temp mailbox used in ProduceDawnTextureFromImageBitmap into a new added class member. > Revert "Implement CopyImageBitmapToTexture part II : Enable GPU T2T copy path" > This reverts commit 15e959f3. > Reason for revert: > Introduced asan failure in DawnTextureFromImageBitmapTest.VerifyAccessTexture > See: https://ci.chromium.org/p/chromium/builders/ci/win-asan/11729 Original change's description: > Implement CopyImageBitmapToTexture part II : Enable GPU T2T copy path > > This patch added the path that uploading imageBitmap contents to WebGPU texture if the backed resource > of imageBitmap is on GPU. > > It leverage shared image system to share content from image bitmap to a dawn texture as intermediate resource > and than starts a encoder and submit a T2T copy. > > But this path has lots of constraints and may failed. When it is not possible to using GPU uploading path, the API > will fallback to CPU path. > > BUG=966582 Change-Id: Icfb0a2b153cdcf95101106f849dfdd55dce8d83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163761Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#763269}
-
Sajjad Mirza authored
Any targets that set no_default_deps = true need an exemption because clang profiling uses the libc/crt functions. Targets that typically don't define a WinMain also need an exemption for the same reason. Bug: 1074006 Change-Id: Ifeb11d3103944daa0a9da4efbca444d5ed600f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163757 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#763268}
-
Dominik Röttsches authored
The optical sizing (`opsz`) and other axis parameters are directly compared against the base font instance. Variable axis limits are not taken into account. The San Francisco system font of Mac OS 10.14 and above has an optical size axis of 19.9 min and 20 max value, so we're calling makeClone() too often for usual font sizes of 12, 16 etc. as 12 != 19.9 but the optical size is always set to that value by default for font sizes under 19.9. Introduce a clamped comparison function which clamps the value to be set to limits first, then performs the comparison to what the font instance has. Bug: 1075572 Change-Id: I0d5e6eda96babcc2c0c48e12d57ab83337283759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144086 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#763267}
-
Victor Hugo Vianna Silva authored
This CL syncs the documentations of the corresponding pairs of methods in password_feature_manager.h and password_manager_features_util.h and adds a note referring the util methods to the feature manager ones. Bug: None Change-Id: I19d039bdaa77a297b7fc63bf457ab4c83de9c154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167755Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#763266}
-
Yoshifumi Inoue authored
This patch changes "paste-after-inline-style-element.html" to utilize selection_test() for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Id8834e84bb132b4b8b18edcdb90ecec32bbc0d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170008 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763265}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/667edf14ad72..f5132a05c893 git log 667edf14ad72..f5132a05c893 --date=short --first-parent --format='%ad %ae %s' 2020-04-28 csmartdalton@google.com Reland "Optimize GrTessellatePathOp's code to emit inner triangles" 2020-04-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3cb9c4bee9b3..4395170e6091 (11 commits) 2020-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9781ff27..78824aa9 (468 commits) 2020-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 60aa34a990fa..2717702e9a1f (6 commits) Created with: gclient setdep -r src/third_party/skia@f5132a05c893 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I449fdd3346dbdf7c029f437fe596dda78a36bbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169705Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/357Bm.....EVEB9... Created with: gclient setdep -r src/third_party/aemu-linux-x64@EVEB9... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I1b11281bf0b36d13411d1869c6ff36155b88e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169974Reviewed-by:
-
Jérôme Lebel authored
This patch is related to Trusted Vault reauthentication. Adding -[<SyncPresenter> showTrustedVaultReauthentication]. Adding implementation in BrowserViewController and RecentTabsTableViewController. Both implementation call -[<ApplicationCommands> showTrustedVaultReauthenticationFromViewController:self] to open the reauth dialog. Related to crrev.com/c/2152788 Bug: 1019685 Change-Id: Id7e25f12722d805bc384b11d827a93b54e202849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165746Reviewed-by:
-
Rune Lillesveen authored
We need a light/dark value pair for an svg background image in video controls, so change naming to prepare for that. Bug: 929098 Change-Id: Ie10a4d5696c999ec8f340631f6a35eefe2db769c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165725Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "format-block-from-range-selection.html" to utilize selection_test() for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic68c3612ed7ffd271bd7593c08e7febc3c518298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170011 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I9965fc4e57cd7d50e1bb53c6acae73613dd646db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164810 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763259}
-
