GitLab

This was originally submitted as http://codereview.chromium.org/8539038/ which was reverted because of a failing test on win.

This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided.

This should fix the notifications auto tests.

This CL also addresses the test failure on win (and a test failure on linux_chromeos triggered by the windows fix).

BUG=103821
TEST=Make sure all tests and autotests run

TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8480032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110972 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org

Review URL: http://codereview.chromium.org/8547003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110971 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110970 0039d316-1c4b-4281-b951-d872f2087c98

Also disable failing DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh

BUG=104986
TBR=adamk

Review URL: http://codereview.chromium.org/8616001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8354008

Review URL: http://codereview.chromium.org/8354008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110968 0039d316-1c4b-4281-b951-d872f2087c98

Extends existing suppression for CGContextShowGlyphsWithAdvances on Mac.

BUG=75142
TEST=Valgrind on Mac goes green
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/8615003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110967 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for BalloonViewHost::Init::GtkWidget leaks.

BUG=104998
TEST=Valgrind on ChromiumOS UI goes green
TBR=johnnyg@chromium.org

Review URL: http://codereview.chromium.org/8527024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110966 0039d316-1c4b-4281-b951-d872f2087c98

through HTTPS Proxies.  This also changes the mechanism used 
to restart HttpProxyClientSocket requests with auth.  Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets).  However, the 
approach was problematic in the face of, for example, ipv6.  The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110529

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110879

Review URL: http://codereview.chromium.org/8502024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110965 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/sizes:
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=1500&rev=110802&graph=chrome-si

linux-release-64/sizes
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=1500&rev=110802&graph=chrome-si

TBR=cmp@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/8603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110964 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it.

BUG=98716
Review URL: http://codereview.chromium.org/8603015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8587050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110962 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8562003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110960 0039d316-1c4b-4281-b951-d872f2087c98

Generalizes suppression with "bind" callback name change.

BUG=101146
TEST=Valgrind on Chromium OS and Linux go green.
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8616002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110959 0039d316-1c4b-4281-b951-d872f2087c98

R=jamiewalch@chromium.org

Review URL: http://codereview.chromium.org/8558034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110956 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org

Review URL: http://codereview.chromium.org/8608002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110955 0039d316-1c4b-4281-b951-d872f2087c98

Turn on -Wexit-time-destructors for (most of) the chrome target.

BUG=101600,94925
TEST=none
TBR=stevenjb

Review URL: http://codereview.chromium.org/8547005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8598031

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8547015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8615001

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8584002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8615001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8598031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110949 0039d316-1c4b-4281-b951-d872f2087c98

The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.

Performance comparison on z600 LOCAL_SOURCE build:
  Before: 24m31s (257m04s user, 23m19s sys)
  After:  20m55s (236m12s user, 22m10s sys)

Companion CL for updating Chrome OS to use strip_tests by default is here:
  https://gerrit.chromium.org/gerrit/11517

BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.

Review URL: http://codereview.chromium.org/8526022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110948 0039d316-1c4b-4281-b951-d872f2087c98

If the crash in CreateDownload moves here, then records are being removed from the table even though their ids are not being removed from returned_ids_. If the crash stays in CreateDownload, then there must be some other place where records are being removed from the table even though their ids are not being removed from returned_ids_.

BUG=103610

Review URL: http://codereview.chromium.org/8528037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110947 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110946 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8612004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110945 0039d316-1c4b-4281-b951-d872f2087c98

I think this is the correct fix, but it might be because my local git repo is in a bad state.

Review URL: http://codereview.chromium.org/8500012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20156
TEST=None


Review URL: http://codereview.chromium.org/8548012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8551009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8614003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8612007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98

This padding isn't shown; however it causes the headings to jump up when a find is
executed which matches anything in the headers. The referenced chrome bug contains
details on reproducing the problem; the webkit fix is non-trivial and possibly
controversial.

BUG=83292
TEST=Checked pages look the same


Review URL: http://codereview.chromium.org/8555030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110938 0039d316-1c4b-4281-b951-d872f2087c98

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115


Review URL: http://codereview.chromium.org/8600008

TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/8575019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110936 0039d316-1c4b-4281-b951-d872f2087c98

Avoids some asserts with ToT WebKit by using valid layers. Using all empty layers or resetting the root layer unnecessarily was causing problems.

BUG=None
TEST=compositor_unittest

Review URL: http://codereview.chromium.org/8561014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110935 0039d316-1c4b-4281-b951-d872f2087c98

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115


Review URL: http://codereview.chromium.org/8600008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual: trigger protector bubble, change search engine manually; bubble should vanish.

Review URL: http://codereview.chromium.org/8612002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110933 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8595014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104641
TEST=Enable WebUI lock screen and observe that when a user pod is activated the signed in indicator moves up 1 pixel with the account image.


Review URL: http://codereview.chromium.org/8586053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23239
TEST=


Review URL: http://codereview.chromium.org/8461009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110929 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis
Review URL: http://codereview.chromium.org/8472006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110925 0039d316-1c4b-4281-b951-d872f2087c98