- 14 Apr, 2020 40 commits
-
-
Marc Treib authored
This CL adds profile_store_action_ and account_store_action_ to MultiStorePasswordSaveManager (in addition to pending_credentials_state_ from the base class). Explicitly tracking the two states, instead of just a single "canonical" one, allows us to be more explicit in how conflicts are resolved, and in particular it allows us to handle some edge cases that we couldn't handle correctly before. It also adds an integration test for one such edge case. Bug: 1012203, 1060524 Change-Id: I9602c3641da761a76b2dc9a1f62b630ef2fbcb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139654 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#758777}
-
Donna Wu authored
The |resolver_| is in the reader, so no need to pass it to a closure carring the reader already. Also to align with other places, OnScanRequestCompleted() has been made to be a member method, so that |resolver_| can be cleared when settled. Bug: 520391 Change-Id: Ie5718243aa0f60498e042550b33ffcea5700ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145262 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#758776}
-
Andrei Salavei authored
Update IdentityManager initialization flow during the AccountManager migration. After the offline login the |user_context| has no token, hence the Primary account could not be setup for the IdentityManager. Add login account to the AccountManager in case it is not presented there to properly setup primary account for the IdentityManager. The primary account with token will be configured later during the AccountManager migration process. Remove |DeprecatedSetPrimaryAccountAndUpdateAccountInfo|. Bug: 987955 Change-Id: Ia1665e8337e26ca05af9a9abc43ab23816fce14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131912 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#758775}
-
Ankit Kumar authored
This CL adds restoring focus to the last focused element in PDF. Unit tests have been added to validate the scenario. Bug: 1057927 Change-Id: I760d2365671c610ce593016a0ac8fc439c7fbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061579 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758774}
-
Victor Hugo Vianna Silva authored
A preparation for https://crrev.com/c/2087914. Expectations on the values of SyncMergeResult::num_items_{added/deleted/...} are removed. Coverage for the sync merge logic is still present, since the tests already verified it by mean of other checks. The CL complements such pre-existing checks with checks on the initial and final size of the local model. One of the implementations of GetAllSyncData that was removed in crrev.com/c/2083455 is re-added to enable this. It is suffixed with ForTesting as with all other cases in crrev.com/c/2083455. Change-Id: If83c977b8e5dac6279b3fd7fc7517dc3d2dbc1f5 Bug: 1057577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091346 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#758773}
-
Corentin Wallez authored
//third_party/dawn:dawn_end2end_tests has been moved under //third_party/dawn/src/tests. Replace the _tmp target in gn_isolate_map with the new location of dawn_end2end_tests. Bug: chromium:1064305 Change-Id: I92eb438362258c668cd3babc99be947c91ba2b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144968Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758772}
-
Hiroki Nakagawa authored
This CL also removes the outdated comments on mojom::NavigationParams::navigation_start. Bug: n/a Change-Id: I4672611f52d861b797f2a472496813da6de35875 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132069 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#758771}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34be23373b9e..e70d25f6fa5d git log 34be23373b9e..e70d25f6fa5d --date=short --first-parent --format='%ad %ae %s' 2020-04-13 stevenperron@google.com Struct CFG analysus and single block loop (#3293) 2020-04-13 jaebaek@google.com Preserve debug info in eliminate-dead-functions (#3251) 2020-04-13 stevenperron@google.com Update acorn version (#3294) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e70d25f6fa5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I85bfde3af2be07118e03a6b2ab8c2dc9d8d17937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758770}
-
Aya ElAttar authored
Disabled the settings icon in the system tray when os settings is added in SystemFeaturesDisableList policy Bug: 1066795 Change-Id: I6131e5cb05b0e305f0d9007391d7cd5c1231adf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130855Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#758769}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Icaaaa15a2736ba0c4f0961bf15779d2a40008f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141502Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#758768}
-
Nohemi Fernandez authored
Use the accessibility label directly in the first run EarlGrey tests. This makes it simpler to transition to the new sign-in architecture. See go/chrome-ios-signin-migration for more details. Bug: 1005509 Change-Id: I4afa65b02169927c919cb51dd9884bb828a55fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144082Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758767}
-
Ramin Halavati authored
Adds a OTRProfileID::CreateUnique to create a unique OffTheRecrord profile id with the given prefix. Bug: 1033903 Change-Id: Iaa6408a17d72521b8c22feec82843ad4081abece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145875Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758766}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/kg4AQ.....vN52w... Created with: gclient setdep -r src/third_party/aemu-linux-x64@vN52w... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I18a62fbbbd39d747d8c3f0001f3d1b3b949d5aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148714Reviewed-by:
-
Yuki Shiino authored
Minor style change from V8Foo::kConstantBar to V8Foo::Constant::kBar. Bug: 839389 Change-Id: Icc2e2e0dae28cb98ea92b80dd3e13ba882d214e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147972Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758764}
-
Yuki Shiino authored
Removes regular indexed properties from Window, and moves the implementation of indexed/named properties to 'api' component. Bug: 839389 Change-Id: Icb3a92938bc6cdddc01e2323e7f06cbe2f2a5b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145526Reviewed-by:
-
Donna Wu authored
Bug: 520391 Change-Id: I3c687f7af552434f0050ae4216b70b27cf06d010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143654Reviewed-by:
-
Peter E Conn authored
Bug: 1040143 Change-Id: I30c0988fe53933014805bdec25effa16002baef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135759Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#758761}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/573da20d98ff..8c8408b7248c Created with: gclient setdep -r src-internal@8c8408b7248c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:138961540,chromium:149354484,chromium:153387728 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ib599d381d7b7a50563b2dd1815ba0d6d403dda43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758760}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f5e955d. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs" c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 8ab053d0 "[css-flexbox] Move stretch-table-child.html test to WPT" c05b5149 "[css-flexbox] Move relpos-with-scrollable-with-abspos-crash.html to WPT" 3e02f51b "[css-grid] Migrate stale-grid-layout-2.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I39e3c39fddc788aa9a179ff0897bd47fe405a803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148091Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758759}
-
Rohit Agarwal authored
Autofill assistant (AA) intents should be handled with AA only. Currently, ExternalNavigationHandler#shouldOverrideUrlLoadingInternal is unaware of target intent type and because of that AA intents which are not handled by the AA handler (for example AA intent sent from incognito) are launched as external intent. This CL 1) Simplifies and restricts the AA intents to be handled only with AA by introducing another abstract method isIntentToAutofillAssistant in ExternalNavigationDelegate and its implementation in ExternalNavigationDelegateImpl. It invokes AutofillAssistantFacade#isAutofillAssistantByIntentTriggeringEnabled internally. 2) AA intents not handled by AA now results in either 2a) OVERRIDE_WITH_CLOBBERING_TAB, in case a browser fallback url is provided. 2b) NO_OVERRIDE, in case a browser fallback url is not provided. This CL also adds unit tests spliced on browser fall back url and profile type. Bug: 1069459 Change-Id: Ia7517ff05963c1335d23796b5eaafb1af9155773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144037Reviewed-by:Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#758758}
-
Benoit Lize authored
PartitionFree() should not be called on data allocated with PartitionRoot*Generic*Alloc(). This happens to work, but is incorrect. This is part of a larger refactoring of PartitionAlloc (see linked bug). Bug: 1061437, 787153 Change-Id: Iad10ca5c89ed466584c7576958dbf8e77a243b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144139Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758757}
-
Jiewei Qian authored
This resolves an race condition when an App is session restored, and its file handling is being force enabled. FileHandlingExpiry service involves IPC calls, whose replies are received after ForceEnableFileHandlingOriginTrial. This causes FileHandlerManager to disable the App's file handling, if the App does not hold a valid origin trial token (even though File Handling was force enabled, and should not require a origin trial token). Fixed: 1064814 Change-Id: I294070a5cac4645784ff1d773c6f7845772b45b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143773 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#758756}
-
Jinsuk Kim authored
This CL updates the parameters passed around NewTabPage and the inherited pages(Incognito, Feed). Rather than passing ChromeActivity itself, we basically pass all the specific dependencies instead. Other changes are: - NativePageFactory is now non-static, and can be obtained from TabDelegateFactory.getNativePageFactory() - NewTabPageUma is non-static as well. Managed by NativePageFactory. Use of TabImpl.getActivity() used to obtain ChromeActivity dynamically was deleted along the way. Bug: 952703 Change-Id: I65e8c14ecfd61f0dc1bb64e2ddd9bee46d75f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131674 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758755}
-
Colin Blundell authored
This CL removes the remaining deps on Tab from InterceptNavigationDelegateImpl in order to make it suitable for componentization and sharing with WebLayer. To do so, observance of the Tab is moved to InterceptNavigationClientImpl. There is a slight reordering of method ordering calls in order to so: InterceptNavigationClientImpl starts observing the Tab immediately after the construction of InterceptNavigationDelegateImpl whereas that observance currently starts in the middle of the InterceptNavigationDelegateImpl constructor. However, no observer callbacks can happen as a result of the code running in the InterceptNavigationDelegateImpl constructor (and the TabImpl#addObserver call itself does not cause any observer callbacks), so this reordering is harmless. Bug: 1031465 Change-Id: Ic1f43d91076c414f095dd84f37bc24ca8a904e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135749 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
Remove the App Management flag as the feature is fully launched since M79. Bug: 1065766, 1068530 Change-Id: Iac13b9f64d3675363b6f8871aa2ba9fa77f443c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130462Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#758753}
-
Frédéric Wang authored
This CL adds a parameter to StretchyOperatorShaper::Metrics that returns the italic correction of individual glyphs [1] and glyph assemblies [2]. This is a follow-up of [3] and will be used for MathML layout. [1] https://docs.microsoft.com/en-us/typography/opentype/spec/math#mathglyphinfo-table [2] https://docs.microsoft.com/en-us/typography/opentype/spec/math#glyphassembly-table [3] https://chromium-review.googlesource.com/c/chromium/src/+/2100940 Bug: 6606 Change-Id: I5cb1e72ed2dbaba516b7ffc5893ce0cf1ea8f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144961Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#758752}
-
Yan, Shaobo authored
Current Shared Image system lacks of supporting for producing dawn object from a resource created by gl backing factory. This ability is required in an important API CopyImageBitmapToTexture from WebGPU. This patch support ProduceDawn in SharedImageBackingFactoryGLTexturePassthrough by: 1. Creating an internal used backing buffer and use copyTexutureCHROMIUM to copy from original gl backing resource to it. Passthrough command buffer rely on ANGLE's support of copyTextureCHROMIUM 2. ProduceDawn on the internal backing buffer. For validating command buffer, a copyTextureCHROMIUM like API needs to be implemented. BUG=1036142,966582 Change-Id: I24ccaaa589d90a7a1101228155c6eafaf173b2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073858 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#758751}
-
Reilly Grant authored
This change adds temporary info-level log messages around code called when a wake lock is released to debug an Android-specific failure which is not reproducible on a local build. Bug: 1064550 No-Presubmit: true Change-Id: I7bb461c0407857c93792511c0f0a2d33e9000bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147926 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758750}
-
rbpotter authored
Since we are not writing a new implementation for cloud print interface, remove cloud_print_interface_manager.js and use addSingletonGetter for the cloud print interface, to make it more similar to the pattern used by other Web UIs. Change-Id: If355914ed3f47083795e33c8e1f63b8463cd4d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146213 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758749}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ce8c96ad90a..5e43b27e8b45 git log 3ce8c96ad90a..5e43b27e8b45 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 mathias@chromium.org Reformat module.json files Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e43b27e8b45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070492 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6089fc6f56f94389b134154b6c2acba78d1a2f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148105Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f50063625a0c..ad653d8378d7 git log f50063625a0c..ad653d8378d7 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cf2c8e6068c8..dee4d7a54e44 (5 commits) 2020-04-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 94450aa9..8ab26431 (253 commits) Created with: gclient setdep -r src/third_party/skia@ad653d8378d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I45afcf50f0886101c6f3e65cd54e4d4d826a44f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148102Reviewed-by:
-
Koji Ishii authored
This patch adds checking CullRect in |NGBoxFragmentPainter|. The logic is the same as |NGPaintFragment| versions of the corresponding functions. Bug: 982194 Change-Id: Iaf1c7bdf9ac04ced4a772ee04f2f8497e1cb8911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145522Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758746}
-
Victor Costan authored
On Windows builds, the method name Scheduler::GetCurrentTime() conflicts with the GetCurrentTime() macro defined in //base/win/windows_types.h. Scheduler::GetCurrentTime() is referenced in a MOCK_CONST_METHOD0 macro, which has been re-implemented recently in googletest. Under the new implementation, the naming conflict results in the compilation error in in https://crbug.com/1070043#c2. This CL fixes the naming conflict by renaming Scheduler::GetCurrentTime(). No behavior changes are expected. Bug: 1070043 Change-Id: Ifd9040083b948ed457ddeb156677cfa84ff331c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146350Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#758745}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9e072e138e6..573da20d98ff Created with: gclient setdep -r src-internal@573da20d98ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ic9ab179fa0b167dd6623a200df9fb6a007ae2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148489Reviewed-by:
-
Austin Tankiang authored
Bug: 1069669 Change-Id: Iebbe4b6f8461639f780918322da87dd413c4f1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147989Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#758743}
-
hrome://appsDaniel Murphy authored
I accidentally didn't associate the uninstall window to the browser window when updating the uninstall code to support BMO. R=calamity@chromium.org, loyso@chromium.org Fixed: 1070159 Change-Id: I2fa4e50bd28af7283b57491d0e49c3a60350566a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147545 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Sujie Zhu authored
We missed cleaning up several TODOs in https://chromium-review.googlesource.com/c/chromium/src/+/2103654 Bug: 1059087 Change-Id: Id65eb7a906af95b8cc3eacc1aaad45b3279cdbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148081 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#758741}
-
Matt Menke authored
We want to get rid of the single argument call as the two argument methods are safer and more flexible. Bug: 1068194 Change-Id: If94b80790e8dc3d9a8b634ad65d6c10f564b694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146091 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758740}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b71a96f818c6..08f4d59e0b17 git log b71a96f818c6..08f4d59e0b17 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 Jianning) Ding Decode the returned encoded bytes of subprocess.check_all/check_output. Created with: gclient setdep -r src/third_party/depot_tools@08f4d59e0b17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068779 Tbr: agable@chromium.org Change-Id: I59323b98c1d6f31cc004639eedc8bbcc5afe0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148101Reviewed-by:
-
Tanmoy Mollik authored
Currently ProfileDataCache doesn't support vector graphics. This cl replaces the use of Bitmap with Drawable in ProfileDataCache.BadgeConfige so that vector graphics can be provided to it. Also this cl adds a new factory method in ProfileDataCache to create an instance of this class with a provided badge resource id. Bug: 1064957 Change-Id: I23e5417611787f5d3d17f1a2b81c195bcea781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130246 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#758738}
-
