- 17 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95e01a220bc7..469205e1adaf git log 95e01a220bc7..469205e1adaf --date=short --first-parent --format='%ad %ae %s' 2020-03-17 titovartem@webrtc.org Roll in third_party/turbine 2020-03-17 danilchap@webrtc.org Disable libaom decoder by default Created with: gclient setdep -r src/third_party/webrtc@469205e1adaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I632af5f56bf26f2845b47ebe38b2909cd670d17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751042}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/005f42a834ed..e8ce957aec8c git log 005f42a834ed..e8ce957aec8c --date=short --first-parent --format='%ad %ae %s' 2020-03-17 lalitm@google.com Merge "tp: strip trace processor on Android builds" Created with: gclient setdep -r src/third_party/perfetto@e8ce957aec8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic2c6821bf46b665c260f07cba989f3b9aa579434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751041}
-
Anupam Snigdha authored
Added squiggle underline style in IMETextSpan for IMEs that apply those formats during an active composition such as MS Japanese IME. Currently, the squiggle format is only applicable for composition markers. Bug: 1033764 Change-Id: I6b159def5d1a9f5983b023a08a8d2dbacf02efe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093292Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751040}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I696fd9dc63e716cda3ec16aec9dd171f649ec4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101530Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751039}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from core/animation/. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I9cb6b51e35926ef0ab7a9a7cfcdfd8cd6895839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101227Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751038}
-
Robert Liao authored
NativeTheme uses the ColorProvider codepath in light mode and if the ColorProviderRedirection feature is enabled for selected colors. A bonus change is that views_examples_exe will now initialize the FeatureList. BUG=1056955 Change-Id: I3867724bcf97f17888bd7bedd3cc01203f54c3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097356Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751037}
-
Ana Salazar authored
Hotseat background blur is disabled during overview to avoid double blurring with the overview background. This blur should be disabled during the transition animations as well. Add test to ensure that the HosteatTransitionAnimation::Observer methods' animation starting is called the same times as animation ending + animation aborted. Bug: 1059454 Change-Id: I3391bc188f33085ca29b586382ad7cc86b460028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092691 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#751036}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1facd5e8d114..141ac68fa0f7 git log 1facd5e8d114..141ac68fa0f7 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 fmalita@chromium.org [skottie] Cleanup: split animators into separate CUs 2020-03-17 michaelludwig@google.com More comparison fixes 2020-03-17 csmartdalton@google.com Change GrProgramInfo::visitProxies to "visitFPProxies" 2020-03-17 csmartdalton@google.com Delete GrOpsRenderPass::drawMeshes 2020-03-17 michaelludwig@google.com Fix unsigned/signed comparison in assert 2020-03-17 michaelludwig@google.com Refactor GrMemoryPool into reusable GrBlockAllocator Created with: gclient setdep -r src/third_party/skia@141ac68fa0f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I04a57f88fb3b8244517d6e42a7643ebef3a4fa2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107325Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751035}
-
Meilin Wang authored
The initial patchset is a cherry-pick of the original reland CL: https://chromium-review.googlesource.com/c/chromium/src/+/1903755 The above CL introduced a bug where a paused podcast auto-resumed playing when you try start another voice interaction, e.g. by saying "ok google" or pressing the mic button. This bug has been fixed in patchset 4 by reverting part of the change in the original CL, where |AssistantManagerServiceImpl| should not observe |AssistantMediaSession| otherwise it will form a loop between them. This CL also created unittests for |AssistantMediaSession|. Misc: Minor code refactor on |AssistantMediaSession| and |AssistantManagerService| for the test usage. Bug: b/150486679 Test: manully. Change-Id: I779a6dc2c42ac528b8c19d9f474532975bb3c629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102643 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#751034}
-
Side Yilmaz authored
FeedContentStorageConformanceTest. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates FeedContentStorageConformanceTest class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ia8893512bcabf2eb504bab9f7d64fb98d967a1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106579 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751033}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c99efb2f8c62..a30b7bd35b10 git log c99efb2f8c62..a30b7bd35b10 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 sokcevic@google.com Move subcommand_test to py3 Created with: gclient setdep -r src/third_party/depot_tools@a30b7bd35b10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie1bb97587ee06928e68c63ce826d9e974c69353d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751032}
-
John Budorick authored
Bug: 1062289 Change-Id: Id91bf4d5fafc33e01b1b53d8534e97a21edf4560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107309Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751031}
-
v.paturi authored
The hand-coded methods to set and get the force dark mode setting are being used alongside the auto-generated methods based on the settings in settings.json5. The hand-coded methods are merged with the auto-generated methods as they are meant to do the same thing. The hand-coded methods invalidate the color scheme while the auto-generated methods invalidate paint. A change in the force dark settings should ideally invalidate both. So a new change type is introduced which invalidates both color scheme and paint. Bug: None Change-Id: Ice0c4b97a30d5d7f7d91b7ea5a30a67b5b19d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081727Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#751030}
-
Vladimir Levin authored
This patch continues the refactor and clean up of the code: - Rename functions to align with what we are now calling concepts - Remove some unneeded layout invalidation, since style adjustments will invalidate style if needed R=chrishtr@chromium.org Change-Id: I4911d90289e6dd9b5b1a61c2e2c1aba2931fa9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103348Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751029}
-
Scott Violet authored
This fixs a number of cases and enables strict mode in tests. Hopefully that helps prevent any other access from being added. The trickier cases are jacoco injects code that accesses the disk, and LayoutInflater may trigger loading classes, which triggers disk access. BUG=1059770 TEST=covered by tests now Change-Id: I50f81836f838b023fe09fd5f760cb7484edd8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100589 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751028}
-
Josh Nohle authored
Add execution time and success metrics to UpdateDisplayConfigurationTask. Fixed: 1058473 Change-Id: I7cf24fd10f0f84d71b28483cb0120bb77d64aab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088496Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#751027}
-
Andrew Grieve authored
This reverts commit 962e7030. Reason for revert: Failing on swarming https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747 Original change's description: > Make java_deobfuscate not require being built first > > Makes the tool easier to use, and easier to document how to use by not > requiring it to be built first. We have only a single non-prebuilt .java > file, so it's easy enough to just check in the .class file for it. > > Bug: 995290 > Change-Id: I7b934b3337eccb044a470dd92270ce7338b1fd20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106257 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750855} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: Ic279958503760f08a5a4885391705a89db8f982f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107680Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751026}
-
Omer Katz authored
Introducing AtomicWriteMemcpy to replace memmove used for moving elements in a vector (by atomically copying element by element). The Existing AtomicMemcpy is renamed to AtomicReadMemcpy. Bug: 986235 Change-Id: I08c39f1bfc6af0902db68f0e41fedfb4c4eef893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105215 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751025}
-
Alexander Timin authored
R=nasko@chromium.org,jsbell@chromium.org Change-Id: I30a490342c039cdab09e4a37454043a2d3ff84ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106157Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751024}
-
Omer Katz authored
When calling ConstructAndNotifyElement, we assume the element already exists and can be concurrently traced. In such cases updating the member should use atomics. Using operator= in this case takes care of both atomics and the write barrier. Construct still calls the member ctor since this is assumed to be a new buffer that cannot be traced yet. Bug: 986235 Change-Id: I6c7053e8d084e9c2852bee1e3192196483bfb727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105373 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751023}
-
nancy authored
This CL moves ExtensionUninstaller back to the ui/ash/launcher directory to uninstall extensions from extenions context menus. BUG=1061892 Change-Id: Icd08981c95bc07ca9eda0645a53952873ba45eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105687Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751022}
-
Henrique Nakashima authored
Bug: 1041473 Change-Id: Iafb3db8f2d11924614cd563428541e983538ea47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099295Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#751021}
-
Hsin-Yu Chao authored
NextHandsfreeProfile feature flag triggers ChromeOS audio server to register HFP 1.7 to BlueZ. This will be used for dev team to qualify ChromeOS for HFP 1.7 and end users to enable wideband speech feature. verify WBS is enabled using Sony WH-1000XM3 headset. Bug: b/149188379 Test: Manual enable NextHandsfreeProfile in chrome://flags and Change-Id: If3539cc4d6d589152ab4244a7cc4a8b738396799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094519 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751020}
-
Christoph Schwering authored
This CL makes the whole as opposed to only the <cr-icon-button> clickable. Bug: 1062231 Change-Id: I740cc90e6806ebb33678fbd3e5572d1d44984560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106088 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751019}
-
Daniel Cheng authored
Hopefully, this will help confirm the theories... Bug: 1061138 Change-Id: Id452de7f436f9970517814540db06343fbc896c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106536Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751018}
-
Boris Sazonov authored
Removes gogerald@chromium.org from chrome/browser/android/signin/OWNERS and chrome/android/java/src/org/chromium/chrome/browser/signin/OWNERS. Bug: None Change-Id: I6994892311d67973f1222f910cfd9407005cddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095099 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#751017}
-
Mehran Mahmoudi authored
This adds a null check on back press handling logic in ChromeTabbedActivity. Bug: 1062244 Change-Id: I91da10c179568e95182818e4d5ab5d6aa3e9dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107165 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#751016}
-
Rainhard Findling authored
* Removes outdated safety check focus code that on click of the safety check button tries to focus the safety check parent, which is no longer focusable (see crrev.com/c/2100823). Bug: 1015841 Change-Id: I9806232b054278116734efbf0f3cf159432945c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106089Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751015}
-
Fredrik Söderqvist authored
While using the "wrong" PaintInfo may not actually be "wrong" as such, it raises questions. Thus, update PaintInfo usage so that it matches the expected scoping/lifetime at a certain spot to avoid confusion. Change-Id: I2a8aec6ca847beebed477589f3abf08f412ba8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106172Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751014}
-
Xiaocheng Hu authored
We want to eliminate Font::Update(), as it allows switching the FontSelector of a Font, which is a bad pattern. This patch eliminates all call sites that calls the function with an explicit nullptr, by replacing it with on-demand creation of Font::font_fallback_list_ with a null FontSelector. Note that: - We can't DCHECK non-null FontSelector for Font::Update(). Some callers may call it with a nullable parameter - We can't create a FontFallbackList on all Font objects. Otherwise, we may get a memory regression. So we use on-demand creation. Bug: 1049295 Change-Id: Icc1e87c8517220a2ff8d92f00b311546e8e77541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106394Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751013}
-
Scott Violet authored
cached_feature_flags.cc includes CachedFeatureFlags_jni, so it's target (//chrome/browser/flags:flags_android) needs to depend upon the target that generates the header. BUG=none TEST=none Change-Id: I015f67257754c2af565c1935c1b58b3f11badbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106964Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751012}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icd71c87ecaf14e57249ed5091208aafc2614bf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751011}
-
chrome://managementRoger Tawa authored
Bug: 1062259 Change-Id: I327a62f258c3c6a5bc6fb139204aba8b35748968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106459 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#751010}
-
Fredrik Söderqvist authored
Since ScopedSVGPaintState has its own "internal" PaintInfo (accessed via GetPaintInfo()) we don't need to have local PaintInfos in a number of SVG painters, but can use the one passed in (or one that is actually being locally mutated like in SVGContainerPainter). Add a comment in SVGForeignObjectPainter about the seemingly frivolous PaintInfo usage. Also drop some level of indentation where possible. Change-Id: I59efc150c666a725d626b1b5ca643d3041d3fe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106167 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751009}
-
Peter Kasting authored
* Use a ScopedObserver * Init in declaration * Move functions in .cc to better align with order in .h Bug: none Change-Id: I3e961c61f17356414d1d0b9124da9e9da883e069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107154 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751008}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c19ea32ca5dd..e73d36798847 git log c19ea32ca5dd..e73d36798847 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 tvanderlippe@chromium.org Add coverage reporting to ninja typescript 2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.networkProjectManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e73d36798847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058320,chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie80225a37dad82f0c9af3f1890fc7af12e53fd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751007}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17637854..f9434816 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdfc9db693c4b1bb5ab139415d2a5e4bfaa2a5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107434Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751006}
-
Morten Stenshorne authored
This flag was hardly checked at all in the code. It has been implied by LayoutNG for a long time already. There's also a linux-layout-tests-fragment-paint bot still lying around, but I couldn't figure out how to remove it. Bug: 988015 Change-Id: I4f7099a0127c51721e5baaeb6200f3143382f715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106060Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751005}
-
danakj authored
The test watches for IPC messages sent to a process, but if multiple frames/widgets end up sharing a process it can see messages it didn't intend to watch. So we ensure we're watching messages only to the intended frame tree, and since each frame has a unique size this is sufficient to also watch only the intended frame+widget. The watcher causes the RunLoop to exit when it sees the value it was looking for, but then another message may happen before it finishes exiting which replaces the value. R=avi@chromium.org, wjmaclean@chromium.org Bug: 1061934 Change-Id: I89abce4aece1dedea267e732619cc2c5db159460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106116 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751004}
-
Katie D authored
It was accidentally removed in https://chromium-review.googlesource.com/c/chromium/src/+/1881497. Change-Id: I8b1a830895522dcc3e11ee1f5b6b2f149aeb5fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107169 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#751003}
-