GitLab

This restores the behavior that the window title won't be shown
in the window frame for container windows (ARC++/Crostini). The
exception is when a debug title ("extra title") has been set, in
which case the debug string is shown.

Overview mode will use the normal title, unless a debug/"extra" title
is set, in which case it uses that.

Bug: 842476
Change-Id: Id0df3466b66e769363f313772bf63ff9f26e7b80
Reviewed-on: https://chromium-review.googlesource.com/1058560
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560373}

Refactors logic to keep video wake lock to more easily integrates PIP
videos.

Bug: 840889
Change-Id: I2e0e7c922a1416159d7622fe8b71048fe28afb65
Reviewed-on: https://chromium-review.googlesource.com/1063085Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560372}

This test is currently in
headless/lib/headless_devtools_client_browsertests.cc.
I'm working on porting it to Javascript for easier maintenance.
This PR doesn't cover the entire test yet, so I'll follow up with
  more but figure it'd be good to check in a snapshot to begin with.

Bug: 838291
Change-Id: I647e0fef263adde129f7c12d48283708a4e84ca0
Reviewed-on: https://chromium-review.googlesource.com/1066940Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560371}

Migrate the cloud print API to use UIThreadExtensionFunction instead of
ChromeAsyncExtensionFunction.

Bug: 634140
Change-Id: Ic80be088ff5185a441a87b716227aef1433e5623
Reviewed-on: https://chromium-review.googlesource.com/1066817
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560370}

Bug: 840751
Change-Id: Iedd393cfc3b11d11dbc60b87c9f3a747a7463116
Reviewed-on: https://chromium-review.googlesource.com/1065131Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560369}

This gives the child process time to flush I/O. This can help avoid the OS restarting in the middle
of flushing data. It's also needed because swarming jobs fail when the browser quits with child
processes still alive.

An example flake is
https://chromium-swarm.appspot.com/task?id=3d8cd8e056a4b310&refresh=10&show_raw=1. Roughly half of
the layout test runs on Win Mojo are flaking as a result.

Bug: 820996
Change-Id: I9c3b13f83c716f020f555cbe2aa14e20c8825ed3
Reviewed-on: https://chromium-review.googlesource.com/1066622Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560368}

This patch was inspired by trying to fix scrollbar
appearance of
external/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html

Vertical scrollbar was missing, and horizontal scrollbar was too short.

Scrollable overflow is the space fragment will contribute to its
container's scrollable area. For box, and text fragments, this area
is equivalent to its border-box. Lineboxes are different, linebox
size is independent of its scrollable area because linebox height
is line height, and not "border-box" height.

https://drafts.csswg.org/css2/visudet.html#inline-non-replaced
"The vertical padding, border and margin of an inline,
non-replaced box start at the top and bottom of the
content area, and has nothing to do with the 'line-height'.
But only the 'line-height' is used when calculating the
height of the line box."

This patch adds ScrollableOverflow method to all fragments.
ScrollableOverflow of all fragment types except Linebox
return border-box.
Linebox returns sum of its children scroll overflows.

This fixed "missing vertical scrollbar" portion of my test case.

Tests:
I've added 2 tests for overflow with inline children.

overflow-inline-001.html tests padding and layout overflow.
This tests currently fails, will have to wait for the part 2
of this patch, "Inline_end padding for inline children".

overflow-inline-002.html tests linebox ScrollableOverflow.

1 test was rebased because results are closer to Legacy with NG
(1px diff)


Bug: 728378
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id1bc204f0863eac23926c3cd1dbef0c544eb9b29
Reviewed-on: https://chromium-review.googlesource.com/1067243
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560367}

ChromeCast receivers require the codec name in OFFER message to be
lowercase.

Bug: 734672
Change-Id: I0fb98ea4c4db3448dba277b34299aff5b498438e
Reviewed-on: https://chromium-review.googlesource.com/1067538
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560366}

This gives us waterfall coverage for loopback audio streams.

Bug: 843961
Change-Id: I350382ed055f894e5a44edcf7e5ec4b851835aab
Reviewed-on: https://chromium-review.googlesource.com/1065992
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560365}

We relied on LayoutTreeBuilderForElement to compute style through
StyleForLayoutObject for these tests. Compute style in style recalc pass
as we would do in production.

Bug: 843520
Change-Id: Ib03317c479f06f3aecad668a8bdba0924fa5b8f5
Reviewed-on: https://chromium-review.googlesource.com/1065683Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560364}

https://skia.googlesource.com/skia.git/+log/4dc5a454052e..8e3bf09e8eb7

$ git log 4dc5a4540..8e3bf09e8 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 benjaminwagner Omit failing test.
2018-05-21 enne Fix unit tests when workarounds are enabled
2018-05-03 egdaniel Reland "Remove GrBackendObject and all related functions from Skia."
2018-05-21 bsalomon Add perspective support to GrTextureOp.
2018-05-21 egdaniel Move gn setup for vulkan library/headers into their own third_party directory.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I657d5cf312f7eb7100c2412fe8c0348faafa2686
Reviewed-on: https://chromium-review.googlesource.com/1067590
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560363}

In the current Omnibox, we only showed the elevated popup when there
are Autocomplete results to display.

In the new UI Material Refresh, we display the elevated frame (with no
results) whenever the Omnibox is focused and user input is in progress.

This CL implements this.

TBR=rdevlin.cronin@chromium.org

Bug: 823535
Change-Id: Ia1bf5597123a4bf576bc5d9ef714d760560fcf0e
Reviewed-on: https://chromium-review.googlesource.com/1066457
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560362}

It seems to work properly, has tests, starts up quickly, and generates
proper crash reports. Turn it on for everybody.

Note: This app only runs if the user sets "Show taps" in about:flags
or passes the --show-taps command line switch.

Bug: 840380
Test: chrome --show-taps still shows touch points on the screen
Change-Id: I8df4dff6ecdd9f15ed4409112161152fbb344b00
Reviewed-on: https://chromium-review.googlesource.com/1067783
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560361}

This CL increases the specificity for the VR CSS changes for the media
controls. This fixes an issue where some of the CSS rules were being
overridden by more specific (but non-VR rules).

Bug: 840839
Change-Id: I62504e5bc23af6c73c888ad9bcada3d525752746
Reviewed-on: https://chromium-review.googlesource.com/1062767Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560360}

Child frame process never becomes IMPORTANT even when visible. So change
the condition for adding to moderate binding for becoming visible
instead.

Note in this implementation, there is no guarantee that root frame is
ordered before sub frames in BindingManager.

Bug: 813232
Change-Id: Ia8a7e76c557a59054194f921bfdf1b0cedf5e4be
Reviewed-on: https://chromium-review.googlesource.com/1067516Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560359}

ContextCacheController needs the context lock, but was not set up in
ui::InProcessContextProvider, causing data races.

Bug: 845173
Change-Id: Ia9e3ae509efd2aa880f80fde55d92bd835db32b9
Reviewed-on: https://chromium-review.googlesource.com/1067537Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560358}

The test compares two versions of MapToVisualRectInAncestorSpace,
one with GeometryMapper and one without.

Bug: 831762
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If385614a90d5276f1e995f268e81c04cc72abeff
Reviewed-on: https://chromium-review.googlesource.com/1065174Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560357}

I audited calls to dynamically resolved functions once again and found
several more candidate calls that would fail if reached and are included
in the chromium build.

Bug: 701919
Change-Id: I37d4e90654e005c85aa264593067ea08d610204d
Reviewed-on: https://chromium-review.googlesource.com/1067781Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560356}

And make SSLConfigServiceMonitor use them.

BUG: 755309
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I72f16fdd74eecf2a9b565895fc97d90654384b16
Reviewed-on: https://chromium-review.googlesource.com/1022691
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560355}

Bug: 843770
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5026217516d2c2b82c876d56086865c5ee9aa668
Reviewed-on: https://chromium-review.googlesource.com/1066946Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560354}

This patch fixes three bugs:
* Dragging the window via finger touch on the titlebar only works about
50% of the time.
* Touching the custom titlebar caption buttons would "leak" to the
window underneath, if the top window was closed or minimized.
* Touching and dragging the custom titlebar caption buttons would
cause further touch input on other widgets (like popup bubbles) to
not work.

This patch fixes them all at once by revising how we handle mouse events
synthesized from touch:
* We were letting all mouse events synthesized from touch fall through
as regular mouse events, unless they were targeted at HTCLIENT. They
would cause problems like setting mouse capture incorrectly (causing bug
#3) and cause double inputs (bug #2). This patch instead marks these
events as handled and ignores them, unless otherwise noted below.
* We now DefWindowProc events targeted at HTCAPTION and HTSYSMENU
instead of simply ignoring them, which fixes bug #1. Our special drag
handling in HandleMouseInputForCaption works poorly for touch.
* We also DefWindowProc events targeted at the caption buttons when
custom titlebar is off, which is required for them to work.
* When we do the hittest for the above targeting, we no longer convert
LPARAM to window coordinates before sending WM_NCHITTEST, because the
point should remain in screen coordinates. This was causing all three
bugs to reproduce inconsistently, since we would sometimes get HTCLIENT
or HTNOWHERE for events clearly targeting non-client area.

This patch doesn't specifically address the broken pen touch case, but
as a side effect it makes dragging the window with the pen work slightly
more often.

Bug: 838870, 832291, 843486
Change-Id: Ie7d339f7b1b75acb14377d8411234d8faa16755f
Reviewed-on: https://chromium-review.googlesource.com/1048877
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560353}

Bug: 829614
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia776792f78d23d2d9536de200de7135e1c4fee9a
Reviewed-on: https://chromium-review.googlesource.com/1067515Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560352}

Now that Widevine should support 'cbcs' content, add a regular
EncryptedMediaTest that attempts to play 'cbcs' content with MSE.
This leaves the previous test that tests only ECK, as it checks
different CDM interface versions.

BUG=658026
TEST=new browser_tests pass

Change-Id: I954a5d78747458c69ff08f7c3c847ab717559b84
Reviewed-on: https://chromium-review.googlesource.com/1062950Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560351}

This is adding a flag to be able to control whether Web Audio should be
restricted by autoplay. It will allow testing and experimenting.

Bug: 841933
Change-Id: Icdec2e74b210f0cf49db87f79ac9a1cb60d94d63
Reviewed-on: https://chromium-review.googlesource.com/1067148Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560350}

Bug: 838908
Change-Id: I6b4e582ec1e572b3c35f105bb5f42f46f70df2d5
Reviewed-on: https://chromium-review.googlesource.com/1064412
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560349}

Basically a quick hack to reduce latency when hardware decode is not
supported, while a more permanent solution is developed. (c.f.
https://chromium-review.googlesource.com/c/chromium/src/+/1066620)

Bug: 839951, 522298
Change-Id: Ib2b51454942e02f144b99605be7915827fc18154
Reviewed-on: https://chromium-review.googlesource.com/1066697
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560348}

It is possible to reliably tell if link was activated with or
without user gesture via GetNavigationActionInitiationType().
This CL remove fallback to [self userIsInteracting] heuristic.

Updated all link click tests to use real tap events, instead
of JavaScript clicks.

Added testLinkWithBlankTargetWithoutUserGesture test to verify
that JavaScript link click popups are blocked.

Bug: 809706
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2811513c0e160b29e20fb0d69ae3ceed316a9653
Reviewed-on: https://chromium-review.googlesource.com/1066773
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560347}

https://chromium.googlesource.com/catapult.git/+log/5b4ef865e888..5926c612e546

$ git log 5b4ef865e..5926c612e --date=short --no-merges --format='%ad %ae %s'
2018-05-18 dtu [pinpoint] Store `comparison_mode` in JobState.
2018-05-21 wangxianzhu [trace-viewer] Update according to chrome side Frame Viewer trace format

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:842238


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I276a53c887b39261686e2c0922c94b6dda906bb0
Reviewed-on: https://chromium-review.googlesource.com/1067777Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560346}

This reverts commit 00db3ddc.

Reason for revert: Breaks Linux CFI build here: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8024

Original change's description:
> Let lld emit colored diagnostics when invoked from ninja.
> 
> Bug: 841221
> Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
> Reviewed-on: https://chromium-review.googlesource.com/1067460
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560343}

TBR=thakis@chromium.org,rnk@chromium.org

Change-Id: I3811083daa622dca605ca32be5cc4c7098b60b4a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841221
Reviewed-on: https://chromium-review.googlesource.com/1067949Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560345}

https://pdfium.googlesource.com/pdfium.git/+log/9e1739218386..588a35b1db1e

$ git log 9e1739218..588a35b1d --date=short --no-merges --format='%ad %ae %s'
2018-05-21 thestig Avoid indexing into std::vector inside a tight loop.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:843899


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I10c2e2c3c6719e434ac71065ad6c9dce0f236443
Reviewed-on: https://chromium-review.googlesource.com/1067539
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560344}

Bug: 841221
Change-Id: I72d13c78a2c623865a4f29542d25f6b3488b350b
Reviewed-on: https://chromium-review.googlesource.com/1067460Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560343}

https://chromium.googlesource.com/catapult.git/+log/421df92ae3d4..5b4ef865e888

$ git log 421df92ae..5b4ef865e --date=short --no-merges --format='%ad %ae %s'
2018-05-18 benjhayden Roll eslint to 4.0.
2018-05-18 benjhayden Shorten normalizedPercentage units to a single decimal digit.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8b249edc8a21ee27b7f1b59d29c398cc8d73daeb
Reviewed-on: https://chromium-review.googlesource.com/1067495
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560342}

This CL refactors a small piece of code in
RecentTabsTableViewController. This method was previously hard to read
and had superfluous variables.

Bug: 804590
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19af585c6177ef45bb7a6a255a8d3371c5b73073
Reviewed-on: https://chromium-review.googlesource.com/1067081
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560341}

This addition to LayoutRectOutsets is only used for inline layout,
but brings an unnecessary dependency geometry -> text.
Moving utility closer to the usage makes reasoning about deps easier.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib29fe76da950b1e1316a0d9573fca0b2c93c1c84
Reviewed-on: https://chromium-review.googlesource.com/1062664Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560340}

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 842851
Change-Id: I16b89ae5bf77ae69da2fd8933658a26f668608a7
Reviewed-on: https://chromium-review.googlesource.com/1067259
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560339}

BUG=747675
R=thakis
TBR=dpranke

Change-Id: I8d3cdab732a10d81480f6476fbdccff2c8ef34e5
Reviewed-on: https://chromium-review.googlesource.com/754033Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560338}

This removes the support for system-wide Xcode.

R=huangml@chromium.org

Bug: 835036
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I925587983d618593771522a28ccd4bdf0cd16d78
Reviewed-on: https://chromium-review.googlesource.com/1064829Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560337}

On Mac, they discovered long ago that quitting after holding Cmd+Q was a bad
idea since apps underneath Chrome would get the repeated Cmd+Q key event and
would also close [1].  Their solution was to delay quitting until the shortcut
is released.  To give users confirmation that Chrome is quitting, all browser
windows are faded out.

The same issue occurs on Linux and Windows (I've unintentionally closed many
background apps writing CL [2]), so this CL implements the Mac solution.

[1] http://dev.chromium.org/developers/design-documents/confirm-to-quit-experiment
[2] https://chromium.googlesource.com/chromium/src.git/+/6cbd505d3cb04e3e108e61a74f82421b66f0f655

BUG=243164
R=sky

Change-Id: Ia3de4acaf463cd5b202743d44f763c6d52fbe963
Reviewed-on: https://chromium-review.googlesource.com/1066924Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560336}

Renaming SystemDownloadManagerStub to StubSystemDownloadManager for
consistency with StubOfflinePageModel.

Bug: NONE
Change-Id: I7cb2d9d13b7c31a44c24b030d33125d38e1efd2f
Reviewed-on: https://chromium-review.googlesource.com/1063036
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560335}

Change-Id: I2451fcbfd31bb70628d138838ec95327cb8af91b
Reviewed-on: https://chromium-review.googlesource.com/1066599Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560334}