- 26 Feb, 2019 40 commits
-
-
Tim Song authored
BUG=934608 Change-Id: Id673d62c802072036a8b6b63161104b26f9768bd Reviewed-on: https://chromium-review.googlesource.com/c/1482115 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635437}
-
Yutaka Hirano authored
SinkPeer is designed to read all the response body in order to let the network stack store the contents to the HTTP cache. We need to read the response body rather than discarding it. Bug: 894819 Change-Id: I9ba34d3b765c7d3f1127ad18f5aac17c3eddd6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1481137Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#635436}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b2ef4ac9fd6..478c5c145fc9 Created with: gclient setdep -r src-internal@478c5c145fc9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38b49fce033267045a7848c41f08bba34a5db9c4 Reviewed-on: https://chromium-review.googlesource.com/c/1488497Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635435}
-
Nate Fischer authored
net-debugging.md was accidentally omitted from navbar.md, making it less discoverable. This adds it in, so this page can be discovered from the grey-ish top bar of the other docs pages. Details on navbar can be found: https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md#Navigation-bar R=ctzsm@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3e870833a3e86c8703301e296effce7139e66dd Reviewed-on: https://chromium-review.googlesource.com/c/1488533 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635434}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/5432359239b23e0810aea8c78adcd37f637936f4. The original CL caused crashes due to handle reset in a two-phase read, so this CL delays the reset operation a bit. Original description: WebURLLoaderImpl is not destructed when the request is cancelled, so it's better to destruct the response body handle in WebURLLoaderImpl::Context::Cancel manually. Bug: 894819, 927184, 929793 Change-Id: Ie3822049bb796ba180ad428f97bd873cec3a17f0 Reviewed-on: https://chromium-review.googlesource.com/c/1481143 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - Used ToUnsigned instead of ToFloat - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I0701321485e056d639f43d1f32af8d0054ea6b52 Reviewed-on: https://chromium-review.googlesource.com/c/1488471Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635432}
-
Miyoung Shin authored
- unsigned short/int -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I072bdca3916a24def0ceda5915b4b45afaf1dfad Reviewed-on: https://chromium-review.googlesource.com/c/1487760Reviewed-by:
-
Rakina Zata Amni authored
ReattachLayoutTree/RebuildLayoutTree can't be called on elements with the NeedsStyleRecalc/ChildNeedsStyleRecalc flag set, which might be the case for locked elements because we block style recalc. Marking of the NeedsReattachLayoutTree/ChildNeedsReattachLayoutTree is done inside RecalcStyle and whitespace reattachment marking. The first case is OK because we already block RecalcStyle, this CL is fixing the second case. In this CL, we save a per-DisplayLockContext |whitespace_reattach_set_| that will save locked elements needing whitespace reattachment. After we finished style recalc on locked elements (after forced update or when the budget allows), we will mark those elements as needing layout tree reattachment, just like the global whitespace reattachment in StyleEngine. Bug: 882663, 912949 Change-Id: Ib83845601db24342a30d556689c2a08244491a33 Reviewed-on: https://chromium-review.googlesource.com/c/1460581 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#635430}
-
Takuto Ikuta authored
Fix for https://bugs.chromium.org/p/chromium/issues/detail?id=922875#c107 Bug: 922875 Change-Id: Ifddc1f7ebf14117ed734bfbab6fd16b13632979a Reviewed-on: https://chromium-review.googlesource.com/c/1488395 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#635429}
-
Maksim Sisov authored
This patch fixes software rendering path by adding mojo APIs to call newly created WaylandShmBufferManager, which uses Wayland APIs to create shm buffer and commit it. Also, some code is rearrenged and moved to WaylandShmBufferManager instead. WaylandSurfaceCanvas is also moved to a separate file. gn args: use_ozone=true ozone_platform_wayland=true use_xkbcommon=true ./chrome --ozone-platform=wayland --use-gl=swiftshader --in-process-gpu Test: ./chrome --ozone-platform=wayland --use-gl=swiftshader Bug: 910998 Change-Id: Id52fc41e165232cd08eeb471542eab11d6e1cae4 Reviewed-on: https://chromium-review.googlesource.com/c/1454623 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635428}
-
Dan Beam authored
The changes in this CL should be exactly equivalent and have less superfluous symbols. There's precedent for discouraging unnecessary characters when safe, i.e. https://google.github.io/styleguide/cppguide.html#Return_Values R=dpapad@chromium.org BUG=none Change-Id: I04d7480ebd54a33cfb962a3d2d9e1a58a3d1ea4c Reviewed-on: https://chromium-review.googlesource.com/c/1450645Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (doing your perf) <dbeam@chromium.org> Auto-Submit: Dan Beam (doing your perf) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635427}
-
Shawn Anastasio authored
Ideally page size would be detected at run-time on ppc64 systems, but this would most likely require a significant refactor. Since 64k is the de-facto standard and binaries compiled for 64k are likely to function on 4k systems, it was chosen to use 64k as the default page size in the partition allocator on ppc64. This change is part of the effort to upstream a set of patches that allow chromium to build and run on ppc64le hosts available here: https://wiki.raptorcs.com/wiki/Porting/Chromium Change-Id: I23369f261766bdf7aab1b3dc730b94b7f4ba4a96 Reviewed-on: https://chromium-review.googlesource.com/c/1480970 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#635426}
-
Mei Liang authored
This CL adds a package-protected API getTabCount(boolean isIncognito) to TabCountProvider. This API is needed because the IncognitoToggleTabLayout need the count for normal model even when the current model is incognito. As is, TabCountProvider only provides current model count. Bug: 935818 Change-Id: I0b6f2184226c74820ef6b6e00d7a04118d07d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/1488021 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635425}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac6d4c0c8eae..202077e2810d git log ac6d4c0c8eae..202077e2810d --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 53c8957c337d..377d493a0847 (1 commits) 2019-02-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@202077e2810d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I2cec030b69543573a7c104740e1e3848de7d135a Reviewed-on: https://chromium-review.googlesource.com/c/1488495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635424}
-
Michael Martis authored
This change updates the HTTP request sent to the image annotation server to request image descriptions as well as OCR, and updates the service API to expose this data. This change has been manually tested, but more unittests are to come shortly in another CL. Bug: 916420 Change-Id: Ifd919c376f117e25db93389ab4091c18c684e016 Reviewed-on: https://chromium-review.googlesource.com/c/1478652 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c6b8283de9c..7b2ef4ac9fd6 Created with: gclient setdep -r src-internal@7b2ef4ac9fd6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iada240a538f285b8af5386ca65cacd87d8e3d204 Reviewed-on: https://chromium-review.googlesource.com/c/1488494Reviewed-by:
-
Joey Arhar authored
Manually tabbing through the network panel with and without the search sidebar open worked fine after removing the "tabindex = 0" Bug: 933049 Change-Id: Ifd5c85f27c0cf0311323c5da1dd289c2fa31b27b Reviewed-on: https://chromium-review.googlesource.com/c/1481604Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#635421}
-
Jinsuk Kim authored
Detached state of Tab from Activity/WindowAndroid can be obtained dynamically from Tab. This CL removes the private field that caches the state. Bug: 925242 Change-Id: Ib6050875843239d346f46eb7c5a26d1f881c4339 Reviewed-on: https://chromium-review.googlesource.com/c/1474883 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635420}
-
Alexey Baskakov authored
Refactor ReparentTab util. ReparentTab and RevealAppShim are unrelated steps. Bug: 915043 Change-Id: I37a1f463bf06e41e91c4bb0229a125af11903bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1482432Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#635419}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bcfbf6e94c22..ac6d4c0c8eae git log bcfbf6e94c22..ac6d4c0c8eae --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b433073ba38..53c8957c337d (1 commits) Created with: gclient setdep -r src/third_party/skia@ac6d4c0c8eae The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4291acfae1f48be1ef809be68469f3529478c165 Reviewed-on: https://chromium-review.googlesource.com/c/1488492Reviewed-by:
-
Mohit Hotwani authored
Bug: internal b/125939889 Change-Id: I636ca19438715f364ea5c62edc7a02a340798dd8 Reviewed-on: https://chromium-review.googlesource.com/c/1487530 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Auto-Submit: Mohit Hotwani <hmohit@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635417}
-
Antonio Gomes authored
This is the first out of N CLs that switch blink away from using ToLocalFrame() / IsLocalFrame() macro-based downcast helpers to use the new DowncastTraits mechanism from t_p/blink/renderer/platform/wtf/casting.h R=jbroman@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 hange-Id: I9dcd3b40361370d4595ccf291b2fb698f2726e43 Change-Id: I9dcd3b40361370d4595ccf291b2fb698f2726e43 Reviewed-on: https://chromium-review.googlesource.com/c/1487391 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68c821939d22..8c6b8283de9c Created with: gclient setdep -r src-internal@8c6b8283de9c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1f5ff54a25d773fbece87eae1175af4a0fc6b8e2 Reviewed-on: https://chromium-review.googlesource.com/c/1488491Reviewed-by:
-
John Abd-El-Malek authored
Mark http/tests/inspector-protocol/network/blocked-by-client-network-observer.js as flaky after network service enabled by default. See findit: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzA4ZGI5YmM0NmJlYzFkMDAzN2Y0NGY4ZmRhZmY3YjdkNzI3MjRlMAw TBR=caseq@chromium.org Bug: 933880 Change-Id: Icdf04efc789f485883a0737078e10861f92979bf Reviewed-on: https://chromium-review.googlesource.com/c/1488325Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635414}
-
Kunihiko Sakamoto authored
Before this patch, Content-Encoding header of inner response was not checked (content was assumed to be "mi-sha256-03" encoded). Currently we only support "mi-sha256-03" inner encoding, so this patch makes SignedExchangeHandler reject (causing fallback redirect) the signed exchange if its inner Content-Encoding is not just "mi-sha256-03". This also refactors the logic to check integrity scheme, by moving them into single place, SignedExchangeHandler::CreateResponseBodyStream(). Note: This shouldn't affect amppackager, because it strips additional content-encodings in b3. https://github.com/ampproject/amppackager/issues/243 Bug: 931055, 934629 Change-Id: Icc0bde36194d4a387ab30968cccf1bef4c81fe60 Reviewed-on: https://chromium-review.googlesource.com/c/1482351Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635413}
-
Sheng-Hao Tsao authored
This CL updates version number to 6.0.0. On a second thought, I think jumping the number to major release level is more clear. Bug: 935051 Test: None Change-Id: I735c7214c395da1043ff188ff7072c9880e22b19 Reviewed-on: https://chromium-review.googlesource.com/c/1485622Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#635412}
-
Anupam Snigdha authored
HighestAncestorToWrapMarkup This patch adds a restriction in HighestAncestorToWrapMarkup to check for the presentational elements in the ancestory of start and end position's common ancestor till the enclosing block so it doesn't cross the block boundary. This helps in creating the right markup during serialization when we have an ill-formed HTML like <b><p></p></b> which should be serialized as <p><b><b></p>. Test: run_web_tests web_tests/editing/deleting/merge_paragraph_with_presentation_elements.html BUG: 856413 Change-Id: I5fd03d837e61dea4c66a2ac376b612ac8711dea1 Reviewed-on: https://chromium-review.googlesource.com/c/1482117 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635411}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca34240a5b2c..7180cebfd347 git log ca34240a5b2c..7180cebfd347 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 crouleau@chromium.org Disable failing and flaky scroll tests 2019-02-26 crouleau@chromium.org Revert "Reland "speed: Look only for the appropriate devices/browsers."" 2019-02-26 crouleau@chromium.org Revert "Replace CustomizeBrowserOptions() with CustomizeOptions() step 1" Created with: gclient setdep -r src/third_party/catapult@7180cebfd347 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934649,chromium:932409,chromium:8888888801528 TBR=sullivan@chromium.org Change-Id: I0643df30a5f27eedee1f9d924a5ebad32015f304 Reviewed-on: https://chromium-review.googlesource.com/c/1488132Reviewed-by:
-
Alex Danilo authored
When setting up the menus for file open, if a file type has no default Chrome extension set as the default we used to try to choose a default handler by matching against any sniffed MIME type or its file name extension. If there was no clear 'winner' for being set as the default handler for the file type, we'd prefer one of our white-listed handlers over a handler that explicitly matches the file name extension. e.g. a '.ica' file contains plain text, but if there is a Chrome extension registered that lists '.ica' in its 'file_handlers' in the manifest, it fails to be chosen as default if there is a text editor installed that can process MIME types of text/plain. This change retains the MIME and file extension information used when choosing the list of extension handlers, and tries to find an explicit file extension handler before falling back to using the MIME type. Bug: 803930 Tests: Ran all browser unit and integration tests. Added unit test Change-Id: I02772846fde2b06094256917f51114726c1e0a47 Reviewed-on: https://chromium-review.googlesource.com/c/1474873 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#635409}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/peerconnection have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of IceTransportProxy, QuicTransportProxy and QuicPeerForTest classes, they make sense to use USING_FAST_MALLOC because they have been used as member variables with smart pointers. In ByteBufferQueue and ByteBufferQueue classes case, they make sense to use DISALLOW_NEW because they have been used as member variables with a reference type. Lastly, the rest of the other classes make sense to use STACK_ALLOCATED because they are used by function inside. Bug: 919389 Change-Id: Ia428d8ec65bf5406ed1886fae3d916d7ad497b89 Reviewed-on: https://chromium-review.googlesource.com/c/1487755Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/modules/service_worker have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of RawScriptData class, it makes sense to use USING_FAST_MALLOC because it has been used with smart pointers. In Receiver class case, it makes sense to use DISALLOW_NEW because it has been used as a member variable with a reference type. Additionally this CL annonates HTMLMediaElementRemotePlayback with STAIC_ONLY. Bug: 919389 Change-Id: I084e8207dfb51170bba4a5255e0ecc3ef262d599 Reviewed-on: https://chromium-review.googlesource.com/c/1487759Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/843909c91ada..bcfbf6e94c22 git log 843909c91ada..bcfbf6e94c22 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c63d95525cde..0546b5380780 (4 commits) Created with: gclient setdep -r src/third_party/skia@bcfbf6e94c22 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ia0b5e03aed8f566a8c1bc9e6b497cb6288be8073 Reviewed-on: https://chromium-review.googlesource.com/c/1487121Reviewed-by:
-
Alexandre Courbot authored
The following warning has started to appear when building Chromium: media/gpu/video_decode_accelerator_unittest.cc:1466:2: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi] There seems to be no valid reason for this semicolon to be here, so remove it. Bug: None Test: Build and run VDA unittest. Change-Id: Iaca323d6f1d71f8fa6e8120f16c3e54f4281007d Reviewed-on: https://chromium-review.googlesource.com/c/1487761 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635405}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9b433073ba38..53c8957c337d git log 9b433073ba38..53c8957c337d --date=short --no-merges --format='%ad %ae %s' 2019-02-26 hliatis@google.com Wrong macro being #undef'd in VkGetProcAddress Created with: gclient setdep -r src/third_party/swiftshader@53c8957c337d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125417927 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4b0d6f1534d37a06c6de6174a5a4aa8b06d8a678 Reviewed-on: https://chromium-review.googlesource.com/c/1487123Reviewed-by:
-
Luciano Pacheco authored
Add test for <quick-view>: the Esc key should close <quick-view> and return focus to the file list. Bug: 933062 Change-Id: Ib38eed2658f5a2c939f12df9afbe07587b909d3a Reviewed-on: https://chromium-review.googlesource.com/c/1487752Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635403}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/466f1ea1157f..68c821939d22 Created with: gclient setdep -r src-internal@68c821939d22 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6c19804ac0cbda9852878b860c4d3f361a70b5ca Reviewed-on: https://chromium-review.googlesource.com/c/1487122Reviewed-by:
-
Hirokazu Honda authored
Video Frame Writer writes video frame buffer into file without taking stride and extra padding into account. VFWrite should write only the visible data of video frame buffer into file. Bug: None Test: VDA unittest --frame_validator=dump Change-Id: I1469d03923fb348a0bf59cd3605bdec98d829f56 Reviewed-on: https://chromium-review.googlesource.com/c/1481270Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635401}
-
Peter Collingbourne authored
If one of these flags is passed then this would cause the test runner to wait for a debugger for the --gtest_list_tests run instead of actually listing the tests. Change-Id: I168cd617e6ee998fbd63bede03baac38ec161c3d Reviewed-on: https://chromium-review.googlesource.com/c/1460478Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635400}
-
Noel Gordon authored
Make em++ compile -Os and export needed SDK symbols: cwrap and the SDK callback helpers addFunction and removeFunction). Compile and link the PIEX with with piex.cpp, which will be added in a future CL. Bug: 935285 Change-Id: I1c3ebcf088cb8ece69767b9d26012bc015083615 Reviewed-on: https://chromium-review.googlesource.com/c/1487754Reviewed-by:
-
Hiroki Nakagawa authored
As a cleanup, this CL makes WorkerScriptFetchInitiator passes ControllerServiceWorkerInfoPtr and base::WeakPtr<ServiceWorkerObjectHost> instead of Optional<SubresourceLoaderParams> to its CompletionCallback (i.e., DedicatedWorkerHost::Start() or SharedWorkerHost::Start()). The motivations of this change are as follows: - In Start(), SubresourceLoaderParams was used for associating subresource loader factories with AppCache (see [1]), but this path was moved to WorkerScriptFetchInitiator by [2]. Now SubresourceLoaderParams is used only for service worker controller info, and passing such the partial valid struct would be error-prone. - Start() takes 2 arguments that suffixed with "subresource_loader_" (i.e., subresource_loader_factories and subresource_loader_params). This seems confusing. Directly passing the controller info seems to remove this confusion. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1154743/ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1451602/ Change-Id: I532822e78449702f096fa6f00aa7b53e9753e6f9 Bug: 906991 Reviewed-on: https://chromium-review.googlesource.com/c/1485616 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#635398}
-
