- 14 Jul, 2020 40 commits
-
-
Justin Cohen authored
Bug: 1101058 Change-Id: Ic2bb25d5652a77c401471f067c76feef7e740303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277977 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788393}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::GetRegisteredOrigins(). Bug: 1055677 Change-Id: Ifca679ed80a0b06c6e30bab824275b8b6b5a8137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291922Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788392}
-
Fergus Dall authored
This reverts commit c670ba45. Reason for revert: Test is still broken, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57063 Original change's description: > Reland "Turn on Media History by default" > > This is a reland of ccf0e2f9 > > Fixes TSAN issue in the constructor of sql::Database > by moving it to the main thread. > > Original change's description: > > Turn on Media History by default > > > > BUG=1024351 > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787954} > > Bug: 1024351 > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788312} TBR=beccahughes@chromium.org,steimel@chromium.org Change-Id: I49684e84563a84f09c8436d55371c88122129132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297209Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#788391}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/a5812a0bf342..ad56e3f17dd1 $ git log a5812a0bf..ad56e3f17 --date=short --no-merges --format='%ad %ae %s' 2020-07-14 quiche-dev Consolidates bool members of quicspdysession to reduce wasted padding. 2020-07-14 wub In bbr2sender::adjustnetworkparameters, 1) do not inject a bandwidth sample to max bandwidth filter, and 2) update pacing rate after cwnd is updated. protected by --gfe2_reloadable_flag_quic_bbr2_improve_adjust_network_parameters. 2020-07-14 bnc Minor improvements to quic/core/http:end_to_end_test 2020-07-14 dschinazi Deprecate Q048 and Q049 2020-07-14 bnc Fix hpack error code mapping to quicerrorcode. not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ieb4bc409e7d0c6a569107588453dac88c29e27b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298167 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788390}
-
sczs authored
Bug: 1085419 Change-Id: I32f6f41bc6f4650b313cf3834bd4ac57c5a196f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298058 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788389}
-
Evan Stade authored
in /chrome/android/java/src/org/chromium/chrome/browser/language This CL was uploaded by git cl split. R=jiameng@chromium.org Bug: 1071603 Change-Id: Ie57f00678c08c9356ce815d3b5cc9b7d4e9d4eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290920 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788388}
-
David Tseng authored
R=akihiroota@chromium.org, dmazzoni@chromium.org Bug: 1102990 Change-Id: I4c5c31cef91a1aeefd35cff34efc1a408c7f6b40 AX-Relnotes: ChromeVox now plays a sound when a pass through gesture (double tap and hold) is performed. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296889Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788387}
-
ssid authored
Change-Id: I6d0169f8f83ca8604daea50cf708ec78a9cfdace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295940 Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#788386}
-
Dan Sanders authored
The existing query APIs IsDecoderConfigSupported() and GetVideoEncodeAcceleratorSupportedProfiles() are fallible because the list of supported profiles may not have been retrieved from the GPU process yet. This CL adds APIs to check if the supported profiles have been fetched and to register to be notified when they have been. Bug: 1047994, 1105258 Change-Id: Ib4b9cce8599c00218cb72912186a893a91a65f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249103 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#788385}
-
Lukasz Anforowicz authored
As described in https://crbug.com/988938#c11, we suspect that the flakiness might have been fixed already and we just need to reenable the tests (and monitor the Flake Portal). Bug: 988938 Change-Id: I5ab97ddc8aaa5eabc4a3ea9b61d4551075920cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292997 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788384}
-
Xiqi Ruan authored
Show pin enrollment screen in OOBE flow for supervised account when tablet mode is on by adding an account type checking to DiscoverScreen. Bug: 1093458 Change-Id: Id0d93344261238c4f02578261a17251c9df835ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265359 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788383}
-
Jordan Bayles authored
This patch fulfills the various TODOs in the attached bug by deleting the entire class, since it is effectively no longer used outside of unit testing. Bug: 1015477 Change-Id: I1ff22b0d9c8357c8bf75286f2f247fb2092d0eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296010Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#788382}
-
Stephanie Kim authored
This reverts commit 64ecc629. Reason for revert: Need more powerful mac machines Original change's description: > Add mac-official builder > > Bug: 1072012 > Change-Id: I2c1842c0406f7278b5bd303a8df21d8d1dfa0e23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292513 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Stephanie Kim <kimstephanie@google.com> > Cr-Commit-Position: refs/heads/master@{#788317} TBR=gbeaty@chromium.org,kimstephanie@google.com Change-Id: Iae6b6479623d430663061c907e9e17807756d5c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1072012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298323Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#788381}
-
Steve Becker authored
SessionMessageWindow::OnWndProc() returns true without setting the LRESULT* result out function parameter. The caller then uses |result|, which contains an uninitialized value. The fix updates SessionMessageWindow::OnWndProc() to always return false, which makes the caller use DefWindowProc() to set |result|. Bug: 1058556 Change-Id: I2d1876049e27e9043e9b3a690ffc6697369ea255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295980Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788380}
-
danakj authored
The main frame can change over the life of the TestRunner, if we swap the frame on navigation. Instead, bind the current frame, via the TestRunnerBindings. This means the FindInProcessMainWindowMainFrame() is only used for a) TestRunner::SetMockScreenOrientation() which is a bug to be fixed b) TestRunner::FinishTest() (and callers to it). That means we no longer rely on the main frame being stable or consistent in order to be correct. FinishTest() will do the right thing and find the main frame's process. The last issue is that the "main window" is only set on the RenderView (well, the RenderView's BlinkTestRunner) at the start of the test, so if swapping the main frame also changes to a different RenderView then it will not know it's the main window. Either the browser needs to keep the "main window" bit up to date or we can move the BlinkTestRunner::TestFinished() code up to the browser process, where it can invoke the right things in the right renderer. The tricky bit is.. the synchronous layout at the end of the test done in the renderer. But this only matters if the frame is already in the main frame's process. R=avi@chromium.org Bug: 1069111 Change-Id: Iae77bbabeeb074ba1595e7652f07f31cb556a1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298053 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#788379}
-
Aleks Totic authored
not subclass of LayoutBlock. TablesNG, and Video tag need it. NGBlockNode: :FirstChild needs to handle LayoutBox subclasses that are Change-Id: Iba678185e713d478b8831203ee3e87615ce443ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296481Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#788378}
-
Scott Violet authored
'Page' is a much more widely known term then renderer. This also fixes the tests so they work with older implementations. BUG=1072442 TEST=NavigationTest.*PageInitiated* Change-Id: I9c02cc2c4107a0527e2a7564ae96e486e3db8b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298223Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#788377}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316a44100fb7..61e9eac61475 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1101531,chromium:1105180 Tbr: jianli@google.com,pmonette@google.com Change-Id: I1cf9150e2a5cb8b0a1fa02503259e13b97e034c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788376}
-
James Long authored
With the move to Single File Components, we are now able to use eslint-plugin-vue to its full capacity. Almost all the code changes in this CL are generated by `eslint --fix`. The only two style violations that I manually fixed: * Invalid use of `this` in templates * Adding types to props Bug: 1093962 Change-Id: I97126621b7721f6b81e745b8f6a5aecc29705f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293161 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#788375}
-
Jian Li authored
This reverts commit 9819cecd. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6434 Original change's description: > Avoid testRunner.eventSender in > paint/invalidation/table/table-overflow-scroll-in-overflow-scroll-scrolled.html > > Bug: 1047176 > Change-Id: Iba4344ebc6d44f6e122c3871cb0fee5454553a9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297100 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788218} TBR=wangxianzhu@chromium.org,lanwei@chromium.org Change-Id: I10e2320a515fa2b5162248ac32667b0e1a622077 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298347Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788374}
-
Sorin Jianu authored
This reverts commit 1d114582. Reason for revert: it is breaking the Android tests https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%209%29/27588 Original change's description: > Fix sequence checker asserts in CrxDownloader. > > The code crashes because there is a race condition between > the main sequence and another task runner when the instances > of the CrxDownloader are destroyed. > > On the main sequence, the CrxDownloader is being used to > download a file, then the reference to this instance > is released. The CrxDownloader is using a task runner > to run a blocking task, which validate the file it has just > downloaded. This task runner receives a closure which holds a > reference to the CrxDownloader. > The reference is released after the task is run, and therefore, > it results in a race when the dtor of CrxDownloader is being > invoked. > > Besides removing the offending sequence checkers of the > destructors of the CrxDownloader classes, this CL changes > where the timer of the BackgroundDownloader is destroyed. > The timer has sequence affinity and it must always > be destroyed on the main sequence. > > Bug: 1105289,1105460 > Change-Id: I78e002502ce6f5501c78d1e849f51b47bf3dc092 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297696 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788330} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: I87c30dbc1542c14e18c69c0806f138508f99bf9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105289, 1105460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298439Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788373}
-
Weilun Shi authored
It moves the implementation part to base/strings/escape and makes functions in net/base/escape as an interface and call the same function in base/strings/escape. This cl also updates callers in net// to use functions in base/strings/escape instead of interfaces in net/base/escape. Callers outside of net// still uses interfaces and they should be migrated in the follow up cl. Bug: 1068052 Change-Id: I6826ac4d132d8e460cfb778255ffac9fb888ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275365Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#788372}
-
Sammie Quon authored
See attached bug for screenshots/specs. The first users will be the new desk button and the close desk buttons respectively. This CL is assuming there will be many future buttons converted to this style so it adds two decorator helpers to apply ash styles on ImageButton and LabelButtons. Also modifies GetRippleAttributes to match the spec. Left out adding background blur to the close button for now as it may have a performance impact that may want to be discussed. Also left out the wallpaper updates as depending on the not yet released wallpaper spec may be implemented in a certain way. Test: manual Bug: 1103739 Change-Id: I3e446e627366fd89d67948571aee04de5a2e93c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293576Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#788371}
-
Lukasz Anforowicz authored
Since r774391 the dropped link opens in a new tab (via NavigationPolicy::kNavigationPolicyNewForegroundTab). This means that it doesn't matter which frame is used to initiate the navigation, since the navigation should always translate into an OpenURL with WindowOpenDisposition::NEW_FOREGROUND_TAB and handled in the new window/frame. After this CL, the navigation will be always initiated through the local frame that is handling the dropped URL. This helps avoid RemoteFrame::Navigate which doesn't know how to handle NavigationPolicy. and let's us restore the test asserts in the DragAndDropBrowserTest.DropValidUrlFromOutside test. Fixed: 1087898 Change-Id: Icc6b2d8da37f181a32663917a02850a72d9c5297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290705 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#788370}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic6d2666e7c4f4b0883e6b8749f8769218936bd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788369}
-
Andrew Comminos authored
Similar to RenderWidgetHostInputEventRouter, attribute touch events to the frame ID that contains the first touch point. Bug: 910421 Change-Id: I6e1671a4133c367d813bf33214b683967b955ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283493Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#788368}
-
Yuri Wiitala authored
Leave all protobuf messages/enums/fields in-place in the protobuf definition, but deprecate them all. Then, remove all C++ code related to DRM. (This is a feature that never launched.) Bug: 1102847 Change-Id: Iae7ce89e35d22e50c1360d2f4618981f8a79e682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285875 Commit-Queue: Yuri Wiitala <miu@chromium.org> Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788367}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594752201-0c95582c1872e1e49765b4de426f33851485714b.profdata to chrome-mac-master-1594758783-89b5869eda45090ee3c154382bf0c8063de97283.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9509269a478cf8623b266495d4bcfc9478bf8c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788366}
-
Alex Gough authored
Bug: 1102447 Change-Id: I9f19ff9903a88fa0ff01fa1c7f42e2772e49baa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298039Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788365}
-
Miguel Casas authored
crrev.com/c/2292813 (in 86.0.4202.0) removed one of the multiple calls to VaapiWrapper::PreSandboxInitialization(), concretely the one in the main() function, leaving only one in the test SetUp() method. This broke the graphics.VAAPIUnittest.* in the CQ eve. This CL fixes that by leaving a single call to said static method, in the main() function. Bug: 1105335, 1040291 Change-Id: I0b1bfa14f8768c6111697f591b0c8ff120c46e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298263 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iba361e63fcd6d68b4034e7cdac08cc5d17924c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788363}
-
Sean Topping authored
Introduces a set of mojo APIs for creating Web UI pages in the Cast browser. Clients to the mojom::WebUi interface can provide Web UI resources over IPC, and can also control the Web UI page remotely. Merge-With: eureka-internal/356806 Bug: internal b/147754908 Test: CQ, build/run Chromecast Change-Id: I0671a8477dd41eeec171cf5c4537cfe0c99fc9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042636 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788362}
-
Muyao Xu authored
Bug: 687380, b/154273698 Change-Id: I0b143744da0581abd82251ef001ae02da5d250b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280389 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#788361}
-
Robert Ogden authored
The connect-timing UMA isn't being populated, this is why. Bug: 1105219 Change-Id: Ie59f81dd899e8ec5253b8885397dd6a15a351154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298165Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#788360}
-
Tom Anderson authored
* Remove usage of Xlib from //ui/ozone. Also replace Xlib types with XProto types in function signatures that are used in //ui/ozone. * Rewrite and simplify software non-SHM codepath for drawing images. * Moved PutARGBImage from x11_types.h into x11_util.h and renamed to DrawPixmap since it now takes an SkPixmap. * xcbproto: replaced BYTE with void in PutImage/GetImage so that base::RefCountedMemory can be used. * Got rid of x11_util_internal.h and moved it into x11_util.h. It was originally added to prevent including Xlib.h in x11_util.h, which caused conflicts due to macros, however this no longer appears to be an issue. BUG=1066670 R=nickdiego Change-Id: Ieff52b3748945fbb6a5a42bbd496550ad7862e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285287 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#788359}
-
James Long authored
Vue SFCs (Single File Components) offer many benefits (see website: https://vuejs.org/v2/guide/single-file-components.html). This highly mechanical CL migrates the current Vue components to SFCs by taking the following steps: For each file in src/vue_components: * Rename the file to .vue. * Move the `template` field into a <template/> tag. * Move the imports to the top of a <script/> tag. * Assign the rest of the component to a const in the <script/> tag. * `export default` the previous const at the end of the <script/> tag. Caveat: Sometimes ${} notation was used to insert constants into the template literals. This cannot be done in the <template/> tags, so constants are redeclared as a computed property of the component. For each of the .css files: * If the selector is for part of a component, move it into a scoped <style/> tag in that component. * If the selector is part of a component, but affects a child of that component (eg. autocomplete or d3's auto-generated svg elements), move it into a non-scoped <style/> tag in that component. Bug: 1093962 Change-Id: Id4b6307109cb06bbe195e7ac5668b08782cd487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293180 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#788358}
-
Emily Stark authored
This CL removes the "edit bump" for simplified domain field trials. The edit bump is the tendency of the selection or cursor to move around once you start editing and the URL unelides. We can avoid this in the simplified domain field trials by uneliding to the full URL on hover. This means that most of the time, by the time the user has made a selection, the URL has already been unelided and there is no jump. (Technically it is still possible for the user to select before the animation has finished, resulting in a bump, but the user would have to be rather speedy to do this.) This is implemented by pushing the elision logic from LocationBarModelImpl into OmniboxViewViews (when the field trials are enabled, to avoid introducing any bugs in Chrome's default state). OmniboxViewViews now has the full unelided URL as its display URL, which is what it unelides to on hover. When computing what to elide to, it strips the www subdomain from the host and elides to the result (or to the registrable domain if configured). There is more work to do after this CL for when reveal-on-interaction is enabled. Currently, with this CL and with that flag enabled, we'll unelide and show the full URL on page load (eliding to the simplified domain after interaction). This is a bit of a regression on simplicity/UX; the desired behavior instead is to show the URL with scheme+trivial subdomains elided on page load, and then expand to the full unelided URL if there is a hover before interaction. I'll implement this in a follow-up CL. Bug: 1101486 Change-Id: If7fb9c0418099acdf6016e44171f8a0b3d613a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289218 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788357}
-
Reilly Grant authored
This change cleans up all the calls to base::Bind() so that they are either base::BindOnce() or base::BindRepeating(). It also catches a few cases where base::BindRepeating() was used when base::BindOnce() would have worked. Bug: 834319 Change-Id: I8d63b425633feed42fdcb2267e2495fede6bb84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298119 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788356}
-
Moe Ahmadi authored
Adds a timing histogram in LocalHistoryZeroSuggestProvider to record the time it takes to query normalized search terms from the keyword search term database and sort them. This is added to identify potential performance regressions for the larger age thresholds for local history zero-suggest. Bug: 1096615 Change-Id: Iaa079cc84a496e1eeeab8138a7d5208118e99bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296344Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788355}
-
Garrett Beaty authored
mac-osxbeta-rel was removed from the branches because it is an FYI builder that is not the mirror of any try builders and is red on the branches so it is a distraction for sheriffs. Removing it from the branches causes 'Mac Builder' to fail on the branches when attempting to trigger it. The no-op scheduler job will allow the trigger to succeed. Bug: 1105569 Change-Id: I219a89c559b06106b75921ba678d2ab9eb69ea06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298168 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#788354}
-