- 28 Aug, 2020 40 commits
-
-
Aaron Leventhal authored
This code in AXNodeObject::InsertChild() to clear the inserted child's children, was added in WebKit, to support a use case that no longer exists. Specifically, an aria-hidden=false descendant of aria-hidden=true is no longer exposed. The spec may change again to allow that, but it would better to find an implementation that does not require reworking entire subtrees whenever a node changes. Performance improvement for dynamic changes in large subtrees. Also required for CL:2192752 to land. AX-Relnotes: n/a Bug: 1107988 Change-Id: I43f1fc880e7740cb937f273db76c6429e43e8d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204154Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#802786}
-
Wez authored
Bug: 1120914 Change-Id: I712e0f02f28eaeb9e51bf260aa1fa5bfcdbd5f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377876Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#802785}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.11-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I47b06187fddc0b423ec23642c988c405e7c7a5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802784}
-
Bailey Berro authored
Bug: 1123074 Change-Id: I3cc11088dd8ae2e17e1a6f6f6c3a083a3ffe8e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382218 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#802783}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.11-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f6cb5b425bd07e39ee2e6346414bf4f15447d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382691Reviewed-by:
-
Jesse McKenna authored
This change makes IdleWakeups aggregate only measurements taken while the target process was running. Zero values taken while the process was not running (output rows showing "0 processes") are excluded from the final average and median. This prevents 0 values during idle time from skewing down the final results. Change-Id: I10a301cf7e20da5b51db6e986f18c9b37d73d05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380198Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#802781}
-
Adrienne Walker authored
https://chromium-review.googlesource.com/c/chromium/src/+/2365358 added the use of filesystem_proxy, but for in memory databases it is null. Previously this was handled because blob_path was set to empty, and so removing empty files would fail silently in the base file_util functions. Now, with a null filesystem proxy, it would crash. Instead of implicitly failing, explicitly check for the filesystem_proxy where needed. Bug: 1122011 Change-Id: I5e79e89c380e0e2ad9a4f80f14bcd614564b8940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382392Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802780}
-
Alex Newcomer authored
Implements ClipboardImageModelFactoryImpl. Previous CL landed ClipboardImageModelFactory, and all ash-side usages of the factory. This CL implements rendering of HTML via ClipboardImageModelRequest. Bug: 1117230 Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802779}
-
Devlin Cronin authored
A bunch of variables were stored as members on the test, even though they weren't used. Clean them up where possible. Bug: None Change-Id: Ieb6fb26099926092f4dccfe798fa67b6a5b91e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381250Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802778}
-
Jeroen Dhollander authored
This simplifies the code in multiple ways: 1) BloomControllerImpl no longer relies on any of the other Assistant classes, like |AssistantInteractionObserver| and |AssistantActionObserver|. 2) BloomControllerImpl no longer needs to expose methods like HasInteraction() and GetLastInteractionResolution() just for the purpose of unittests. Bug: b/165356952 Tests: chromeos_components_unittests --gtest_filter="Bloom*.*" Change-Id: I150c2be11ccad611bf468ad33c5835e9c7146d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365753 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802777}
-
Ben Joyce authored
local runs would be ran with: rdb stream -new -realm chromium:public ./out/Debug/bin/run_net_unittests --result-sink-upload Need to add --result-sink-upload to recipes. The rdb stream will be active on the bots, as a gn.arg Bug: 1104245,1104238 Change-Id: I8cbc9246110c28579e11c26ed92aad133a187a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365216 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802776}
-
Evan Stade authored
Bug: 1057100 Change-Id: I76e10024a499eb65f4f0f217c25f571eccd1c542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373394Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#802775}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7c4e9418e36..b1e3f57ef7c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I857dc50c8409e8fd341dd6e57284f24eaf9d9cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382203Reviewed-by:
-
Maksim Sisov authored
This is a reland of 75363679 Original change's description: > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > This is a reland of f985905e. > > This change broke our headless build: > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > assert(ozone_platform_x11) > ^----- > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > "//ui/events/platform/x11",. > > Fix: > Don't include x11 build for headless case. > > Original change's description: > > X11 and Ozone: enable use_x11 and use_ozone > > > > This is the final change that enables use_x11 > > and use_ozone for Linux builds and (as it was > > before) excludes X11 for chromeos, chromecast, > > lacros. > > > > in order to run ozone/X11/wayland, one must pass > > —enable-features=UseOzonePlatform > > —ozone-platform=x11 or wayland. otherwise, > > non-ozone/X11 is used. > > > > it’s also possible to completely disable X11 > > so that clients, who need that kind of build can > > continue to have that. > > > > Bug: 1085700 > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801523} > > Bug: 1085700 > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801692} Bug: 1085700 Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802773}
-
Jacques Newman authored
Placeholder gets exposed as an attribute on the input accessibility node, so there's no need to add its text children. This duplication was causing Narrator to read the placeholder text twice. This effectively reverts CL 1649466: UIA Placeholder Text Navigation AX-Relnotes: n/a Change-Id: If1a3218b64e0fdc2d4dd167faa1f5d9fe4d91c98 Bug: 1121729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375904Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802772}
-
Richard Knoll authored
This handles outgoing transfer updates from the PayloadTracker and gracefully closes outgoing connections after 1 minute. Bug: 1085067 Change-Id: Ia16fc5fdb8cfd1846b130385414064dc3bd2a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379900Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802771}
-
Joe DeBlasio authored
This CL hacks in a histogram to record safety tip status alongside whether the preceding navigation was initiated by the same origin, a different origin, or unknown. To keep the signal as clean as possible, this histogram only records at the reputation check following navigation commit. This means that: * It only records once per page load, and * It only records when the tab is loaded in the foreground. This CL is submitted entirely without new tests. That's a slightly risky move, but those tests would be somewhat complicated, the logic is pretty straightforward, and I'm trying to sneak this into M86. I've manually verified that it does what I expect, as well as accounted for the possibility that the committed URL won't match the reputation check's URL in the metrics. It should hopefully then be fairly obvious if it's recording the wrong thing once real data starts rolling in. This CL also adds the initiating origin to the reputation service object, rather than plumbing it through alongside other reputation information. I don't know if this is a great idea or not, but I'm hoping that we can use that stored info to carve out more false positives in the future. If we do that, we'll likely need to store the data like this, since initiator origin isn't readily available in the visibility callback (since we don't have a navigation handle). Bug: 1109246 Change-Id: I013ebd75ef47c70c81bfe41f45f31feef4603774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380678 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#802770}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/336f984f8cbc..02f6b66357eb 2020-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-08-28 brucedawson@chromium.org Print packaging file size/count stats always If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib870b694c9a52c201c8bcca10d5ea79d5edcb49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382493Reviewed-by:
-
Chong Gu authored
Bug: 1123095 Change-Id: I1e875997179c73c0504690e3efe1809b11e9d864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382295 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802768}
-
Elaine Chien authored
Bug: 1122724 Change-Id: I5cc4574546a5ca4fed41dd8f0c50f17d70a7034b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380583Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#802767}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.11-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I57b69bd0fed2fd6cfac870ee2f2eac62a34ae69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382498Reviewed-by:
-
Xing Liu authored
We should use Calendar.HOUR_OF_DAY to parse the time. The Android time picker widget gives us HOUR_OF_DAY instead of Calendar.HOUR. Bug: 1122999 Change-Id: I7b4de8b9316ed84281e2b8b3aec2fbc0b92c08cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382294Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802765}
-
James Cook authored
CreateScreenshotDelegate does not need a mojo-compatible delegate. That comment is left over from the mustash project. Bug: none Change-Id: Ie0eb0a89687abc9366903f982f8755d051b60c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382397 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598613564-5098a3febf11f8ec7b96c750766d9c7bc759629e.profdata to chrome-mac-master-1598637591-8ae79944c569ee90562dcd97e5dcdbd0077c5a06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If1cb7e963397f0c351528cfe3f8f51e9ea0f43cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382495Reviewed-by:
-
Jeffrey Young authored
Add new metric "Ash.AmbientMode.EngagementTime" to record usage time of each ambient session. BUG=b:163529518 Change-Id: I0c7652fee7fcd6491ba5f43b59dbef2d6f5e36da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367398 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802762}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41f8db90. With Chromium commits locally applied on WPT: 40203c99 "Fix typo in feature policy README" 41f8db90 "[LayoutNG] Correct border painting for fieldset fragmentation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42d4c2ba34f0d3a224f0879c7ede49712261422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382150Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802761}
-
Koji Ishii authored
Legacy and NGPaintFragment ignores empty rects (i.e., width and height are zero) even when their offsets are outside of the frame rects. This patch changes |NGInkOverflow| to match the behavior. Note, the behavior of `backdrop-filter` using the visual rect for inline boxes look questionable and weird, probably needs a separate fix, but it helped to find the change of the ink overflow in r784976 <crrev.com/c/2269389>. Filed crbug.com/1123089 for the `backdrop-filter` issue. The 3 rebaselines for paint/invalidation were incorrectly rebaselined by r789685 crrev.com/c/2300667 due to this issue. Bug: 1122021 Change-Id: Ida5fc770963efedd219eecf602c2f33dfec51b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802760}
-
Dana Fried authored
This CL: - sets throbber height equal to location bar height - ensures that the throbber paints over the border and not under it - fits border in 24x24px space with padding around (same as other toolbar icon heights) - uses 12pt font by default In order to accommodate double-digit numbers using system fonts, we shrink the font slightly when there are 10 or more tabs. See: https://docs.google.com/presentation/d/1vhfCoRyOyyCrj_0ZVHthV1aW8aPReFiqGUEXiqAj9mo/edit#slide=id.g90c8105bab_0_15 Change-Id: Ica739933f8b36ab56f644666979f02b3124a92d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374665Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#802759}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Nightly/media_app_202008280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MnmDAUwQadNlsA_kV1-e9jcBLwfneTyY3-p7R76j8GAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I6669e68b0614657031f7b47781a2f302b2e6b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802758}
-
Himanshu Jaju authored
- Adds a SingleThreadTaskRunner for WebRTC medium to allow jingle calls - Replaces SequencedTaskRunner with SingleThreadTaskRunner for platform SingleThreadExecutor impl Bug: 1122532 Change-Id: I611ef85ec96fbcad3eeb160fd74b9e688edfc5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379727Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#802757}
-
Xianzhu Wang authored
This is based on the feedback in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0. This feature is not supposed to be enabled for web tests. Bug: 1121839 Change-Id: I2713381e147dabf7b24090738afd1cd02e7c53b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380313Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I910a6047ad1c87164f2cb5cb3abf6bc1808d26f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382059Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#802755}
-
Yao Xiao authored
This reduces the overall memory. And hopefully it could fix the regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2324204, which could allocate a regex for every input element. Bug: 1116302 Change-Id: I00f1fa7ad07664d5ab799e760483034c1a1594fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357464 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#802754}
-
Josh Nohle authored
Removed all occurrences of "master" terminology in device_sync directory. The only risky change could be to the cryptauth_api.proto. However, the changed field name is only used for v1 Enrollment, which is not currently used on ToT; v2 Enrollment has been enabled by default for a few milestones. Ideally, even the renamed field will be removed when v1 Enrollment is completely shut down server side. Bug: 1123072 Change-Id: Ia33c5acf7382512b17c33a46f215bcb324151c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382219 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802753}
-
Darwin Huang authored
This improves readability, and is part of modernizing ui/base/dragdrop. This is also recommend by the style guide, per: https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs Refactoring change only. No functional changes expected. Change-Id: I3b4e5145bf7bc682fa356fe1ea1b37448cd5bd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378886 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802752}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47ebbfa449fd..7bc80aa34110 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com,tinazwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com,tinazwang@google.com Change-Id: Id98d36c752fc9fad3c6b1787e7e77cad30a6c3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381936Reviewed-by:
-
Marijn Kruisselbrink authored
Bug: 1121422 Change-Id: Icd7eeb702f9143c0670170d80da19645f6350900 Tbr: agawronska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382206Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#802750}
-
Matthew Mourgos authored
Bug: 1122723 Change-Id: I861fd0f8fd6ae76863fd1828829d62549ca53eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368423 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802749}
-
Solomon Kinard authored
The purpose of this CL is flake mitigation. This paragraph relates to running each apitest 3000x apiece. These are crashes even when the test is only succeed(). The flake rate is around 1.3% with unrelated crashes. Relevant tests seem to have a similar heuristic. Dave mentioned it might be good to file a bug for it. Flakiness may have been caused by instantly checking tab url. This CL leverages a TabListener object to await tab updates. Once a tab has been updated, the url can be chekced more reliably. A queue of depth one was implemented here not expecting more than that. For the normal test, didPerformQuery cannot be run first/parallel due to race condition errors where two succeed occur simultaneously when the test framework was only expecting one, causing error. These tests pass locally, as did the previous version. The previous version was run with `--gtest_repeat=20`, in addition to this version. Bug: 1119846 Change-Id: Idcb3a3aa82e4ce9df7a36da9a69071634c1a6ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368147 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802748}
-
Vladimir Levin authored
This patch renames an enum to eliminate any ambiguity between CompositorRenderPass and AggregatedRenderPass. Future patches will also rename the types used. R=weiliangc@chromium.org, magchen@chromium.org Bug: 1106418 Change-Id: I523a85d4220d892a5028b1570411e792bf64879f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380092Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802747}
-
