GitLab

Move prefs::kSaveFileDefaultDirectory into DownloadPrefs.

Merge ChromeDownloadManagerDelegate::last_download_path_ with kSaveFileDefaultDirectory.

Add RegisterOverlayPref(kSaveFileDefaultDirectory) to PrefsTabHelper::InitIncognitoUserPrefStore in order to prevent leaking the path to the on-record prefs.

When the user sets kDownloadDefaultDirectory in chrome://settings, also set kSaveFileDefaultDirectory so that the save file picker shows that path.

bauerb: chrome/browser/browsing_data/ + chrome/browser/prefs/ + chrome/browser/ui/prefs/
achuith: chrome/browser/chromeos/
dbeam: chrome/browser/ui/webui/options/

BUG=179520
BUG=102782

Review URL: https://chromiumcodereview.appspot.com/12662032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203140 0039d316-1c4b-4281-b951-d872f2087c98

- Factor out SandboxOriginDatabase interface to SandboxOriginDatabaseInterface
- Implement SandboxIsolatedOriginDatabase which implements the same interface
  and only handles a single origin without database

BUG=242272
TEST=SandboxIsolatedOriginDatabaseTest.*
TEST=manually tested (launch Chrome w/o change, launch an app which uses HTML5 FS API, write some data -> launch Chrome with change, make sure the same contents appear & origin database's gone)
TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/16150002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203139 0039d316-1c4b-4281-b951-d872f2087c98

> Add ManagedUserTokenFetcher to fetch scoped-down tokens.
> 
> TBR=rogerta@chromium.org
> BUG=228833
> 
> Review URL: https://chromiumcodereview.appspot.com/15977002

BUG=245241
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/15675014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203138 0039d316-1c4b-4281-b951-d872f2087c98

These errors were caught by Clang.

BUG=82385

Review URL: https://chromiumcodereview.appspot.com/16196003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245164

Review URL: https://chromiumcodereview.appspot.com/16194012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203135 0039d316-1c4b-4281-b951-d872f2087c98

Move DownloadOperation related tests from FileSystemTest to newly added DownloadedOperationTest.
Add a new method FakeFreeDiskSpaceGetter::Reset().

BUG=244344
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/16189010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203134 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates chrome's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/16109004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203133 0039d316-1c4b-4281-b951-d872f2087c98

When socket bind failure happens on enabling remote web debugging,
retry using a socket name with PID suffix to ensure uniquiness.
This allows several channels of Chrome to have remote web debugging
enabled simultaneously. Also, this preserves backwards compatibility,
as in the case of the single Chrome instance on a device, remote
debugging socket name is unchanged.

It seems easier to add retry functionality to UnixDomainSocket,
as DevToolsHttpHandler creation is heavily asynchronous.

BUG=222338

Review URL: https://chromiumcodereview.appspot.com/16093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244668
R=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/16134005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203130 0039d316-1c4b-4281-b951-d872f2087c98

So that we can tell if the origin has isolated storage partition or not.

BUG=242272
TEST=ExtensionSpecialStoragePolicyTest.HasIsolatedStorage
R=asargent@chromium.org, michaeln@chromium.org

Review URL: https://codereview.chromium.org/15862008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203129 0039d316-1c4b-4281-b951-d872f2087c98

Incognito mode may be always-on by configuration policy. When that is set then
the TaskManager shouldn't open a new non-incognito window.

The TaskManager doesn't have an associated Profile, so it uses the last used
Profile. This change introduces a getter for the last used allowed Profile,
which returns the OTR Profile if that's dictated by policy.

BUG=244246

Review URL: https://chromiumcodereview.appspot.com/16072014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203128 0039d316-1c4b-4281-b951-d872f2087c98

The sign-in flow always opens in a non-incognito window, and should be disabled
when only incognito is allowed.

BUG=244246

Review URL: https://chromiumcodereview.appspot.com/16072010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203127 0039d316-1c4b-4281-b951-d872f2087c98

This change factors out DriveMetadataDB V0-V1 migration functions into
metadata_db_migration_utils.{cc,h}, and also moves function to deprecate batch sync origins into the files.


BUG=none
TEST=unit_tests --gtest_filter=\*DriveMetadataDBMigrationUtilTest\*

Review URL: https://chromiumcodereview.appspot.com/15951007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203126 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements UsageTracker::GetGlobalLimitedUsage without gathering usages for all origins.
Using cache-disabled temporary unlimited storage will no longer hurt performance for other origins, after the change.

The CL also fixes usage calculation: the usages of cache-disabled limited origins will be counted as limited storage,
 though it was counted as unlimited, previously.

BUG=220029
TEST=UsageTrackerTest.LimitedGlobalUsageTest

Review URL: https://chromiumcodereview.appspot.com/15950004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203125 0039d316-1c4b-4281-b951-d872f2087c98

These tests verifie that the crash of NaCl module introduced by r200088 does
not occur when PPB_FileIO_Private::RequestOSFileHandle is called with
PPB_FileIO opened with PP_FILEOPENFLAG_EXCLUSIVE. 

BUG=243241,241726
TEST=
browser_tests --gtest_filter="PPAPI*Test.FileIO" passes
Revert r200088
browser_tests --gtest_filter="PPAPI*Test.FileIO" crashes

Review URL: https://chromiumcodereview.appspot.com/15864005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203124 0039d316-1c4b-4281-b951-d872f2087c98

This patch cleans up tests on the Javascript side for Files.app:
- Introduce a StepRunner, which runs multi-step test cases.
- Add checking for Javascript errors after each test case.
- Add missing comments.

TEST=browser_tests
BUG=244327

Review URL: https://chromiumcodereview.appspot.com/15809007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203123 0039d316-1c4b-4281-b951-d872f2087c98

This change is per jam@'s review comment on https://codereview.chromium.org/12389073/ . The switch is redundant with --enable-stats-collection-bindings .

BUG=None
TBR=tonyg

Review URL: https://chromiumcodereview.appspot.com/15804006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203121 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240959

Review URL: https://chromiumcodereview.appspot.com/15725006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203120 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/15703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203119 0039d316-1c4b-4281-b951-d872f2087c98

Translate.LocalesOnDisabledByPrefs is not sorted correctly. Presubmit runs
pretty print script and aborts upload.

TBR=isherman
NOTRY=true

Review URL: https://codereview.chromium.org/15690019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203117 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/16056002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203114 0039d316-1c4b-4281-b951-d872f2087c98

This logs the user locale when the Translate feature is disabled by the user. This allows us to investigate the correlation between the user locale and the usage rates of the Translate.

I'll commit this CL after https://chromiumcodereview.appspot.com/15311006/ is committed.

BUG=242142

Review URL: https://chromiumcodereview.appspot.com/15970002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245125

Review URL: https://chromiumcodereview.appspot.com/15848006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203112 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a regression from http://crrev.com/88149

BUG=234472

Review URL: https://chromiumcodereview.appspot.com/15111002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203111 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15764006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203109 0039d316-1c4b-4281-b951-d872f2087c98

This CL added the selector for the column divider at the next to the checkbox in
order to remove it.

BUG=245072
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/15737030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203108 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234594

Review URL: https://chromiumcodereview.appspot.com/15715018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203107 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates the remaining references to the old location
to point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=darin@chromium.org
BUG=239545
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15648012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243997

Review URL: https://chromiumcodereview.appspot.com/15730007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203102 0039d316-1c4b-4281-b951-d872f2087c98

This feature is required to prevent user base expansion without removing extension
for user that use the app. See crbug.com/242806 to see more details.

BUG=242806
TEST=ExtensionServiceTest.ExternalPrefProvider
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/15899007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245147

Review URL: https://chromiumcodereview.appspot.com/15737031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203100 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176647

Review URL: https://chromiumcodereview.appspot.com/14582021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203099 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new IPC message QuitApp which is sent by the shim when the user
quits the shim (right click -> Quit). The AppShimHost responds by closing all
windows associated with the app. The shim actually quits when the extension
eventually closes and AppShimHost closes the channel to the shim.

BUG=168080
TEST=Start an app using its shim.
Right click the app in the dock and select quit.
The shell windows of that app should close.

Review URL: https://chromiumcodereview.appspot.com/14579005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203098 0039d316-1c4b-4281-b951-d872f2087c98

Populating this for not-yet-fetched file causes NOT_MODIFIED case on downloading the file.

BUG=229764

Review URL: https://chromiumcodereview.appspot.com/16152003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236029
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/15935013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203096 0039d316-1c4b-4281-b951-d872f2087c98

The file is a remnant of r203082.

BUG=244363
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16219003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16077005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203094 0039d316-1c4b-4281-b951-d872f2087c98

This column allows us to see what text is used to detect a language.  The text is generated from the web page seen by the user, and doesn't include HTML tags.  The text is sent from the renderer process to the browser process each time when detecting.

This feature will help us to solve the problems, for example, the problem where the translation infobar indicates the web page language we don't expect.

For now, with this CL, the text is always sent even though the translate-internals tab page doesn't exist.

BUG=175967

Review URL: https://chromiumcodereview.appspot.com/15728008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203093 0039d316-1c4b-4281-b951-d872f2087c98