- 25 Feb, 2019 40 commits
-
-
Polina Bondarenko authored
Create new boolean policy to control wilco DTC. BUG=b:123926018 TEST=unit_tests/browser_tests Change-Id: Ib93830ad7ba4e9bc03d77a54fa426d64c6b09473 Reviewed-on: https://chromium-review.googlesource.com/c/1485932Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#635104}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/478d7d46f8d7..507158f88d4d git log 478d7d46f8d7..507158f88d4d --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b47c816ad7e6..e2d8b1286ce3 (1 commits) Created with: gclient setdep -r src/third_party/skia@507158f88d4d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icd33b24c1c5aac56a231dfe802602024464efde7 Reviewed-on: https://chromium-review.googlesource.com/c/1484630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635103}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94d5c4836101..ee9ff700224e Created with: gclient setdep -r src-internal@ee9ff700224e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibdbf8b5d91bc4d149cdadaf0f0eb8de243af344b Reviewed-on: https://chromium-review.googlesource.com/c/1484628Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635102}
-
Anthony Cui authored
Modify InstallFakeModules to handle case where fake_modules is None. Refactor InstallFakeModules to use less nesting. Bug: 934370 Change-Id: I67bfa6b63330efffcdf053e1c23d371073eeefce Reviewed-on: https://chromium-review.googlesource.com/c/1480999 Commit-Queue: Anthony Cui <cuianthony@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#635101}
-
Alex Clarke authored
This reverts commit e92ad529. The underlying problem is not fixed. Original change's description: > Revert "Disable WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion on Linux" > > This reverts commit 122a91af. > > Speculative revert, the underlying problem may have been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1480462 > > Original change's description: > > Disable WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion on Linux > > > > The test is flaky > > https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&tests=WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion > > > > Bug: 934088 > > Change-Id: I4d783da07af305a094d41f32383e16e98ca48f43 > > Reviewed-on: https://chromium-review.googlesource.com/c/1481310 > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > > Auto-Submit: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#634589} > > TBR=alexclarke@chromium.org,altimin@chromium.org,cfroussios@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934088 > Change-Id: I502e52fad830c8403d431fbe4675bb3ea9bff6c1 > Reviewed-on: https://chromium-review.googlesource.com/c/1484308 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635052} TBR=alexclarke@chromium.org,altimin@chromium.org,cfroussios@chromium.org Change-Id: I74ddbd712d31568968cc0234c35662c219372236 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934088 Reviewed-on: https://chromium-review.googlesource.com/c/1486332Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635100}
-
Pavol Marko authored
If there's policy for Ethernet with Auth: None, which doesn't set any "Recommended" information, assume that IP and DNS config fields are "Recommended" so they are still editable in the UI. This is for backwards compatibility, as some users are setting e.g. Proxy through policy but want to edit IP settings on the device. This can be overriden by setting Recommended: [] and should be removed when we implement setting Recommended by default on the server (https://crbug.com/931412). Bug: 820213 Test: Manual with CL:1468501 Change-Id: Ie642a2722bd1a4506148f3352ebfb37d12a47bcc Reviewed-on: https://chromium-review.googlesource.com/c/1474650 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635099}
-
Maks Orlovich authored
This reverts commit 90c86f0c. Justification for revert of revert: Fixed build/merged with a trunk change Bug:850044 Change-Id: Ie96c714b34aad37684692cf1a644cf15e1fae8ea Reviewed-on: https://chromium-review.googlesource.com/c/1482562Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635098}
-
Jérôme Lebel authored
Adding advanced section in Manage Sync settings, with: + "Encryption" + "Google Activity Controls" + "Data from Chromium sync" Screenshot: https://screenshot.googleplex.com/kNxH9b2eZBf Bug: 914059 Change-Id: I6863362d19a6b8fdc5690b11802a5376b877b152 Reviewed-on: https://chromium-review.googlesource.com/c/1477231Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635097}
-
Olivier Robin authored
The web_state will be used to access helpers that can provide custom error pages. The URL is a convenience parameter to avoid checking the error.userData every time the URL is checked. Change-Id: I091cdc5f25f25aa500d629cb27885aac97049511 Reviewed-on: https://chromium-review.googlesource.com/c/1482971 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635096}
-
jonross authored
When perfoming a navigation while hidden on Android, we invalidate the LocalSurfaceId. We were however not always allocating a new id when becoming visible. Most of the time different sources generate an id: - WebContentsAndroid::OnScaleFactorChanged - WebContentsViewAndroid::OnSizeChanged - RenderWidgetHostViewAndroid::OnDidUpdateVisualPropertiesComplete - RenderWidgetHostViewAndroid::ShowInternal (for evicted frame) However it is possible to perform a naviation to the same page, while hidden, and not evicted. Which bypasses all of these. This change updates RenderWidgetHostViewAndroid::ShowInternal to also generate an id when the current one is invalid. Additionally we no longer notify DelegateFrameHostAndroid::DidNavigate when navigating while hidden. As this takes the current embedded surface to be the fallback. Since we are navigating, the current surface is not correct. Instead we will notify it after the embed from becoming visible again. TEST=NoCompositingRenderWidgetHostViewBrowserTest.ValidLocalSurfaceIdAllocationAfterHiddenNavigation BUG=931215 Change-Id: I28e4d2bf3633dd4d21c484be5fdbffeeaefc91b5 Reviewed-on: https://chromium-review.googlesource.com/c/1483364 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#635095}
-
Mikel Astiz authored
The actual logic being toggles was removed in https://chromium-review.googlesource.com/c/1349649 and the feature toggle became unused even before that, so let's clean it up. Bug: 905639 Change-Id: Iabc1d043b5d8e8a4bfcfd7586ef324a7fdae91d7 Reviewed-on: https://chromium-review.googlesource.com/c/1477836Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635094}
-
Abhijeet Kandalkar authored
WebRemotePlaybackState is referenced only from the Blink side. This CL drop web_remote_playback_state.h from public/ and replace enum WebRemotePlaybackState with PresentationConnectionState. Bug: 919392 Change-Id: Ib1b8428b56085a23108cd5f7f7deb9094ac0ab65 Reviewed-on: https://chromium-review.googlesource.com/c/1480010Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#635093}
-
Julia Feitosa authored
Bug: 933768 Change-Id: I8778058205a5e6f6f5973cb2831292c7da985329 Reviewed-on: https://chromium-review.googlesource.com/c/1479730Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Julia Feitosa <carvalheira@google.com> Cr-Commit-Position: refs/heads/master@{#635092}
-
Thomas Tangl authored
- Linkify 'settings' instead of 'choose what to sync in settings'. - Add a period(.) at the end of the sentence. Bug: 930928 Change-Id: I1d565ce978026956db98d627d2cc12f269928c46 Reviewed-on: https://chromium-review.googlesource.com/c/1482461 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#635091}
-
Daniel Bratell authored
There are several kMeasure in blink and with -Wshadow enabled there will be warnings about blink::kMeasure being shadowed. This moves blink::kMeasure to blink::NGTableCellChildLayoutPhase::kMeasure which avoid that warning. I'm interested in making blink -Wshadow clean because I think that can reduce the risk of certain jumbo problems. Bug: 923510 Change-Id: Ifac4ce2c9cf61ee7e7d72da4dc5055d4f490a5cc Reviewed-on: https://chromium-review.googlesource.com/c/1484309Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#635090}
-
Gyuyoung Kim authored
BlinkMemoryMgt: Annotate GamepadStateCompareResult and GamepadComparisons with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/modules/gamepad have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of GamepadStateCompareResult class, it makes sense to use STACK_ALLOCATED because it has been used only in functions. In GamepadComparisons class case, it makes sense to use STATIC_ONLY because it only has static functions. Bug: 919389 Change-Id: Ia159dedc96494faa2642385a6106b260d2a5530b Reviewed-on: https://chromium-review.googlesource.com/c/1484394Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/modules/media* have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of MediaControlTimelineMetrics and MediaErrorState classes, they makes sense to use DISALLOW_NEW because they have been used as member variables with a reference. In UserMediaClient class case, it makes sense to use USING_FAST_MALLOC because it has a factory function which returns a std::unique_ptr<UserMediaClient>. Lastly, MediaStreamTrackContentHint class case, it makes sense to use STATIC_ONLY because it only has static functions. Bug: 919389 Change-Id: I011a21d61716c68cd6bbefe6d86482f6654963ad Reviewed-on: https://chromium-review.googlesource.com/c/1484967Reviewed-by:
-
Jérôme Lebel authored
Adding ios_chromium_strings_grd and ios_google_chrome_strings_grd directory and OWNERS files. Those directories are used to store sha1 of screenshots, for translation strings. This is used by: crrev.com/c/1477231 Change-Id: Id3c17fde4e7234074bd22274e0918bd987682526 Reviewed-on: https://chromium-review.googlesource.com/c/1484306Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635087}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd7343011657..0b43037aaed9 git log fd7343011657..0b43037aaed9 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 treehugger-gerrit@google.com Merge "Fix chromium roll (attempt 2)." 2019-02-25 lalitm@google.com Merge "trace_processor: allow out of order columns in span join" 2019-02-22 fmayer@google.com Merge "Allow to release UnixSocketRaw from UnixSocket." 2019-02-22 taylori@google.com perfetto-ui: Quantize counter tracks 2019-02-22 hjd@google.com Merge "trace_processor: Add fuzzer for trace parser" 2019-02-22 ilkos@google.com Merge "Add unpartitioned and mixed partitioning span joins" 2019-02-22 taylori@google.com Merge "perfetto-ui: Add 'm' selection, shift preview and more." 2019-02-22 hjd@google.com Update traceconv hashes 2019-02-22 primiano@google.com Merge "Fix chromium build" 2019-02-22 lalitm@google.com Merge "docs: add docs for traceconv" 2019-02-22 lalitm@google.com Merge "ui: update output of trace_to_text to be usable in the UI" 2019-02-22 primiano@google.com Merge "Add get.perfetto.dev appengine instance" 2019-02-22 hjd@google.com Merge "perfetto-ui: Remove deprecated presubmit no-unused-variable" 2019-02-22 hjd@google.com Merge "perfetto-ui: Bump version of rollup" 2019-02-22 hjd@google.com Merge "Add tools/traceconv" 2019-02-22 treehugger-gerrit@google.com Merge "Disable heapprofd cts tests due to flakes." 2019-02-22 rsavitski@google.com Merge "Mention Android Q requirement in README." 2019-02-21 primiano@google.com Merge "TraceProcessor: speed up sorting using one queue per cpu" 2019-02-21 primiano@google.com Merge "Fix overflow in StringWriter" 2019-02-21 lalitm@google.com Merge "trace_to_text: flip (experimental <-> old)_{json, systrace}" 2019-02-21 hjd@google.com Merge "perfetto-ui: Fix jumping label in counter track" 2019-02-21 lalitm@google.com trace_to_text: add support for json output using trace processor 2019-02-21 primiano@google.com Introduce base::CircularQueue and improve trace processor sorter Created with: gclient setdep -r src/third_party/perfetto@0b43037aaed9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:124511342 TBR=perfetto-bugs@google.com Change-Id: Iba8ddee6f80b95d283efbebab106939106214315 Reviewed-on: https://chromium-review.googlesource.com/c/1484626Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b47c816ad7e6..e2d8b1286ce3 git log b47c816ad7e6..e2d8b1286ce3 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 bclayton@google.com Fix CMake build documentation Created with: gclient setdep -r src/third_party/swiftshader@e2d8b1286ce3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ief728f8569e97c939f45a51905f3e6e858927b7a Reviewed-on: https://chromium-review.googlesource.com/c/1484627Reviewed-by:
-
Tanja Gornak authored
As of today, no status of the FCMInvalidationService is recorded if service isn't started. It makes hard to spot the regression, which happens when invalidation service can't be started. This CL introduces new statuses, which will be recorded, when invalidation service was unable to start. BUG=924957 TBR=pastarmovj@chromium.org Change-Id: I5fcca7518df5f933b708cd9d0b31042aed734afd Reviewed-on: https://chromium-review.googlesource.com/c/1483015 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#635084}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I7ae64b98d2f4d76d9eaafde8c8c90effefbf9398 Reviewed-on: https://chromium-review.googlesource.com/c/1485695Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I273219c09aabf030af3136e0aae824ceb33ceda2 Reviewed-on: https://chromium-review.googlesource.com/c/1484397Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I1baa1264432a341f3c9189144c41f58f28d57afc Reviewed-on: https://chromium-review.googlesource.com/c/1484403Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 898b1a4f. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I02216465b445a2fd2bf83b623ef8313d8b99a5d5 Reviewed-on: https://chromium-review.googlesource.com/c/1484862Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635080}
-
yoshiki iguchi authored
Previously, we used the common message "Unlock the device to perform the action" but this CL prepares the specified message for this purpose. Bug: 933624 Test: manual Change-Id: I0821670a470e6aabe6db99671cc8148141e3fe72 Reviewed-on: https://chromium-review.googlesource.com/c/1477553 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635079}
-
Amos Lim authored
Move On*Event(Stub) functions from EmbeddedWorkerTestHelper to FakeServiceWorker. Bug: 934665 Change-Id: Ia78da603e2e5d80def4aabd176f379681b4d43d2 Reviewed-on: https://chromium-review.googlesource.com/c/1484402 Auto-Submit: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#635078}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Idbc1bf0f8c178f22f729cd167e0bdc57818484ba Reviewed-on: https://chromium-review.googlesource.com/c/1477619Reviewed-by:
-
Tom Anderson authored
Fixes/improvements made by this change: * Makes it possible to run Chrome or any other app with the same font configuration that's used on the bots and in tests by setting an environment variable (requires a newer FontConfig that supports FONTCONFIG_SYSROOT): $ FONTCONFIG_SYSROOT=/path/to/src/out/Release out/Release/chrome * Removes absolute file paths in generated fontconfig cache file. This fixes the last bit of non-deterministic output on the Deterministic Linux bot. * Prevents fonts.conf from being dynamically generated since it no longer contains any absolute paths. Now it can be loaded directly from a file. * Gets rid of static initialiers in cc/paint/paint_op_buffer_unittest.cc. This was causing some cc_unittests to fail since the SIs were calling into Skia, which was initializing FontConfig before base::SetUpFontconfig() was called. BUG=822737,908463 R=thakis,drott,danakj Change-Id: I036c6a3fcb8d64037f0180e679ec0f2feeb6beed Reviewed-on: https://chromium-review.googlesource.com/c/1019978Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635076}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19d0104abbeb..3812fa949a49 git log 19d0104abbeb..3812fa949a49 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 brandtr@webrtc.org Delete VideoCodecTestParameterized. Created with: gclient setdep -r src/third_party/webrtc@3812fa949a49 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie6e63ebdf9e67a7bec7983dee20b61a3330271aa Reviewed-on: https://chromium-review.googlesource.com/c/1484623Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48d5237abd4d..94d5c4836101 Created with: gclient setdep -r src-internal@94d5c4836101 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5dec402317a6a9f7e5f49c1c92564147da0a60ce Reviewed-on: https://chromium-review.googlesource.com/c/1484625Reviewed-by:
-
Michael Lippautz authored
This allows for clearing the DragState in case the Document is scheduled for shutdown. Bug: 928781, 843903 Change-Id: Ie00428a7503122c68a0e96e32d124301b8b381f8 Reviewed-on: https://chromium-review.googlesource.com/c/1485834Reviewed-by:
-
Sylvain Defresne authored
WebStateListOrderController::GetValidIndex() always returned zero if the index of the newly selected WebState was greater than the index of the closed WebState, instead of just reducing the index by one. Fix the bug and introduce unit tests to ensure the behaviour will not regress. Bug: 934944, 872523 Change-Id: I3d58780ab42236bba5b46b085a5a18d351ec6f7a Reviewed-on: https://chromium-review.googlesource.com/c/1484096 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635072}
-
Mario Sanchez Prada authored
Remove these classes and replace them with a base::OnceCallback<void(bool)> callback instead that is run with |true| for "allowed" and |false| for "not allowed" situations, when processing the associated asynchronous responses. Bug: 933881 Change-Id: I08102e2f1f8f2c98c3f76cc4eff4cbc4bfa56ef1 Reviewed-on: https://chromium-review.googlesource.com/c/1481337Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#635071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5bbd02d6bb3d..478d7d46f8d7 git log 5bbd02d6bb3d..478d7d46f8d7 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@478d7d46f8d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ib541822d825630236da941dc4f32dea9489bbb34 Reviewed-on: https://chromium-review.googlesource.com/c/1484622Reviewed-by:
-
Daniel Bratell authored
kInvalidateDescendants was used both in blink/paint and blink/css and to avoid shadowing, this makes the one in the blink namespace (InvalidationType::kInvalidateDescendants) into an enum class. This will make is easier/possible to later turn on the -Wshadow warning. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warning this avoids is: In file included from third_party/blink/renderer/core/paint/block_flow_paint_invalidator.cc:5: third_party/blink/renderer/core/paint/block_flow_paint_invalidator.h:31:5: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow] kInvalidateDescendants ^ third_party/blink/renderer/core/css/invalidation/invalidation_set.h:52:25: note: previous declaration is here enum InvalidationType { kInvalidateDescendants, kInvalidateSiblings }; ^ Bug: 923510 Change-Id: Ib1ab2720adf1abda4c9ded69d8e086d1e8f3f360 Reviewed-on: https://chromium-review.googlesource.com/c/1483084Reviewed-by: -
Colin Blundell authored
This CL takes another step toward the elimination of FakeSigninManager by removing its ForceSignOut() method. All clients are ported to use identity::ClearPrimaryAccount() instead. The latter internally blocks until the clearing of the primary account is processed, which we exploit to remove blocking that clients were previously doing when calling FakeSigninManager::ForceSignOut(). Bug: 796544 Change-Id: Iebe8190e54bd065fafac4912925c6b619b51f919 Reviewed-on: https://chromium-review.googlesource.com/c/1485832Reviewed-by:
-
Lowell Manners authored
This interface is being refactored around the organic use cases that have emerged since it was introduced. This does not include GetAccounts(), which is currently unused. Change-Id: I9bf4f88201c452d8cb450cac58ecaac40fcf6ee6 Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/1474763Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635067}
-
Pin-chih Lin authored
Add level as a input test stream property to specify requested level. Currently it is only valid for H264 codec. ForceLevel is implemented to check whether the output level satisfies the requested one (only for H264 now). Moreover, in order to test lower level (ex. Level1) a new test stream with the video size 128x96 is added to media/test/data. In addition to verifying the level confiuration, it is also required to specify the higher level (ex. Level5.1) for vea_unittest when we want to test 4k (2160p) video encoding for 4k-supported platforms. BUG=886564 TEST=build and run video_encode_accelerator_unittest on Eve and Elm TEST=./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.yuv:320:192:1:out1.h264:200000:30::::40 TEST=./video_encode_accelerator_unittest --test_stream_data=bear_128x96_40frames.yuv:128:96:1:out1.h264:64000:30::::10 TEST=use 3840x2160 raw video as vea_unittest input with Level5.1 on Eve (2160p video is too big to upload to media/test/data) Change-Id: I68512f5e848a35abbe0c3af802d0926261780241 Reviewed-on: https://chromium-review.googlesource.com/c/1469809Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Auto-Submit: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635066}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/83684f9c1387..8deadd8d022c git log 83684f9c1387..8deadd8d022c --date=short --no-merges --format='%ad %ae %s' 2019-02-25 iannucci@google.com Add named cache for xcode installation. Created with: gclient setdep -r src/third_party/dawn@8deadd8d022c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I511387f41cffac35cd13b3bc12a08b2f030bc033 Reviewed-on: https://chromium-review.googlesource.com/c/1484621Reviewed-by:
-
