- 05 Feb, 2020 40 commits
-
-
behdad authored
Main_30fps_impl_60fps story in representative perf test is marked as a control test, so that if this test fails as a result of high noise, it would invalidate the failure of other tests and would result in less false positives. Bug: chromium:1029846 Change-Id: I50c8e41108d584f2f5cbcf095be50dc09228406b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025510 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#738735}
-
Ionel Popescu authored
Prior to this CL the focus ring color wasn't impacted by the system accent color. The new behavior is that if the system accent color is changed then it is going to be used as the focus ring color. Not being able to use the default system accent color as the focus ring color is a known trade-off we're taking for having a consistent default black & white focus ring across all platforms. Bug: 1022120 Change-Id: Iacd35404530e190b45e5866c7a11cf86d5001ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031863 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#738734}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/02b17a5507ae..703a5d76d9ba git log 02b17a5507ae..703a5d76d9ba --date=short --first-parent --format='%ad %ae %s' 2020-02-05 trevor.axiom@gmail.com Reland "Reland "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""" 2020-02-05 hta@webrtc.org Cleanup: remove unused sctp_content_name 2020-02-05 ilnik@webrtc.org Make RtpEncodingParameters to not reverse active flags order Created with: gclient setdep -r src/third_party/webrtc@703a5d76d9ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:396091 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea7da4ca7d1972ac01b8df38e70ea068da0dfc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738733}
-
Robert Flack authored
This test is failing on mac with a persistent use after free error. TBR=ellyjones@chromium.org Bug: 1049284 Change-Id: I90023aa1017a48400e5ae09aa93d07b397370acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040057 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738732}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8e8e1d0dd729..dd48b7e2d06e git log 8e8e1d0dd729..dd48b7e2d06e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 amaiorano@google.com Fix MSAN LLVM jit false positives 2020-02-05 bclayton@google.com Disable new gcc 9 warning [init-list-lifetime] Created with: gclient setdep -r src/third_party/swiftshader@dd48b7e2d06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4f2d15a26a92a212de405bef9c92ee6b650bb2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039990Reviewed-by:
-
Lan Wei authored
We used to use a timer to send fake mouse move events when updating hover for scrolling or layout change. We changed to another way of doing it by setting a state at scroll end and layout change, and sending a fake mouse move event at the next frame to update hover. The new change has been landed for few months, now we remove the flag "UpdateHoverAtBeginFrame" and clean the code. Bug: 1016560 Change-Id: Ia4e2775f55b3b53b1bba7d3df187f11b7a226a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032414Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#738730}
-
Natalie Chouinard authored
Move Developer Settings alongside other tracing code. Bug: 1047357 Change-Id: Iae70854b966607321a661d58e7680cb154c99178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036516 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738729}
-
Matt Jones authored
The BottomSheet previously attempted to check the state of find-in-page by looking up its view. Not only does this not work correctly, but there does not appear to be any poor interaction between the widget and find-in-page. This code has been removed. Bug: 1002277 Change-Id: Idd9f39605365c177c72a98d82a84407bb801c8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738728}
-
Tom Anderson authored
This CL adds 3 new bots: * Linux Ozone Tester (Wayland) on chromium.linux - Triggered by linux-ozone-rel - All tests have --ozone-platform=wayland * Linux Ozone Tester (X11) on chromium.linux - Triggered by linux-ozone-rel - All tests have --ozone-platform=x11 * linux-ozone-x11-and-wayland-rel - Trybot that is a combination of the above 2 bots and linux-ozone-rel - Eventually, linux-ozone-rel (trybot) will inherit this bot's config and this bot will be removed. Requires tools/build change: https://chromium-review.googlesource.com/c/chromium/src/+/1962128 BUG=1043896 R=estaab Change-Id: I4b3575526ba485f80d2fb03cfed677aa943b47b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032518 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#738727}
-
Becca Hughes authored
Add the cached aggregate watchtime for audio+ video playbacks on the origin. We are planning to use this for ranking so we need fast access. BUG=1024351 Change-Id: I90e6dd4e162457cc6a6cf5c00593a6ca7f7d6581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036796 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738726}
-
Ayu Ishii authored
This test failes because the cleanup to "unsubscribe" cookies would occur after the registration has already been unregistered for non-workers. This change removes the cleanup to "unsubscribe" and just relised on "unregister" for cleanup. Related issue[1]. [1] https://crrev.com/c/2014100 [2] Error(Googlers): http://screen/E5X6dNVEGQz Bug: 1047155 Change-Id: I64b62d2a15e391c3da074b2a3a5a8114b02469ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040370Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#738725}
-
Theresa authored
This reverts commit 2af9b000. Reason for revert: Broke downstream Original change's description: > Move three classes to components/browser_ui/widget/ > > Move the following classes to components/browser_ui/widget/ > - FeatureHighlightProvider > - InsetObserverView > - MenuOrKeyboardActionController > > BUG=951455,1010176 > > Change-Id: I7eac449f45b52f243fea468554b2a9f6c4868d32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040002 > Commit-Queue: Theresa <twellington@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738708} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: I1e69220a94e55f2b8f59019d73911d752bc4a5a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951455, 1010176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040176Reviewed-by:
-
Daniel McArdle authored
With this commit, StartClientCertificateRequest null-checks the ViewAndroidHelper, ViewAndroid, and WindowAndroid pointers before dereferencing them. This is a speculative fix for the attached bug. Bug: 1048855 Change-Id: Ibb677fe94238428fa6f31b375fc327336dcb1d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039893 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#738723}
-
Kenneth Russell authored
Remove suppression on Win / OpenGL / passthrough / Intel. Bug has been fixed in ANGLE. Bug: 1048861 Change-Id: I2fa696eea8d2dd08c325c172769041865b2d1e9e No-Try: True Tbr: enga@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040062 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738722}
-
Daniel Hosseinian authored
Add a fuzzer for Chromium that is very closely based off of [1]. Rename harfbuzz_fuzzer to hb_shape_fuzzer. Apply some formatting changes in hb_shape_fuzzer.cc to adhere to the Chromium style guide. [1] https://github.com/harfbuzz/harfbuzz/blob/master/test/fuzzing/hb-subset-fuzzer.cc Bug: 1046803 Change-Id: Ide991e12f95d6733bbd71acc265c444972b8be99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032170Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#738721}
-
Mason Freed authored
See crbug.com/1049126 - the origin trial system is not supported by headless clients. See [1] which does not override the implementation of GetOriginTrialPolicy(). In the meantime, we need to re-enable Web Components v0 for all headless clients to avoid site breakage. [1] https://source.chromium.org/chromium/chromium/src/+/master:headless/lib/headless_content_client.h [2] https://source.chromium.org/chromium/chromium/src/+/master:content/public/common/content_client.cc;l=104;drc=2271977bc199216d8266c8a99f8a0b4f147ae0cc Bug: 1049126 Change-Id: I9af33d03ad34d4ed23a8f5680641ff2066a02840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039601 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#738720}
-
Sergey Ulanov authored
Added --canvas-msaa-sample-count and --gpu-rasterization-msaa-sample-count in the list of switches allowed in the WebEngine config. These flags are useful to turn off MSAA, which may be required to save memory. Bug: fuchsia:43693 Change-Id: Ib519cc7bede46a5ff7879d1a9678fbf88e33de2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040200 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738719}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/47b15048a1fa..7fe6efba4ae3 git log 47b15048a1fa..7fe6efba4ae3 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 cwallez@chromium.org Add initial CMakeLists.txt files Created with: gclient setdep -r src/third_party/dawn@7fe6efba4ae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1cb25a29d5dd77050337a177c6dd09c4ff8a8d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037983Reviewed-by:
-
Natalie Chouinard authored
Move Search Engine settings alongside Search Engine code. Bug: 1047357 Change-Id: I97f1d8ccd4937d59aaff851db4f911b5426024e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039600Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Victor Costan authored
Change-Id: Ic04ca0131da2a1fe558ffa2a5359ba1372889679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040068 Commit-Queue: Jay Harris <harrisjay@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738716}
-
Kent Tamura authored
The behavior with kRestoreOnLoad==true caused one regression, crbug.com/1035662, and it was fixed. We think the new behavior has no major issues, and we don't need to keep the old behavior. This CL has no behavior changes. Bug: 1008708 Change-Id: I449a5d90489f9729dfd85aa9d0d229461967bc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038410Reviewed-by:
-
Aaron Leventhal authored
Bug: 1006767 Change-Id: I9665b2e1c935bece54e92d94a327071128f3efb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032788 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738714}
-
Liquan (Max) Gu authored
Context: PaymentHandlerMediator does not stop the posted tasks on PH hidden. In the example of the bug, PaymentHandlerMediator has found the page to be insecure in several WebContents observer hooks. Each of them posts a hide() task. When several of such task is posted, the first task would release WebContents; the subsequent tasks who tries to access WebContents would trigger the crash. Before Change: Clank would crash when users clicking an http link in a payment app. After Change: No crash happens. Change: * In ServiceWorkerPaymentAppBridge, whenever it tries to access WebContents, check whether if it has been destroyed. * PaymentHandlerMediator stops the pending posted tasks on PH hidden. * (side) fix CCT PH UI for always closing on open. Bug: 1049262 Change-Id: I9f849854c48e92e06ada1348a80d761a0b4db744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039995 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738713}
-
Henrique Nakashima authored
Useful while I'm refactoring flags. Change-Id: I5cce35bbe1c6072b0ad20bf99fc9e34dbcb69cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040066Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738712}
-
Sam Sebree authored
This change addresses the bug in which autofill text does not display correctly in high contrast mode with forced-colors turned on. Bug: 1046141 Change-Id: I06e1e1c9165e6d430c4df2167e69adf142665616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024032Reviewed-by:
-
Xiaocheng Hu authored
This patch reduces style recalc after loading a web font, by: 1. Allowing a Font object to be reused after loading a web font, by calling FontFallbackList::Invalidate() when accessing a FontFallbackList after font updates. 2. On the style and layout update after font loading: a. Traverses the document, and invalidates styles on nodes where font metrics are required for style computation: when length units 'ch' and 'ex' are used, or when 'font-size-adjust' property is set. b. Stops using IsLoadingCustomFont() related checks for style or layout invalidation. c. Traverses the layout tree to manually invalidate layout, since font changes are no longer reflected in ComputedStyle differences. Bug: 441925 Change-Id: I932b733e71a6de936f95bdff435ce177997820ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952189Reviewed-by:Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738710}
-
Karan Bhatia authored
Add a simple perf test for SubstringSetMatcher. I plan to change a bit of the internal implementation, so this will help to measure any perf difference as well as catch future regressions. BUG=974391 Change-Id: I03ad4d2ae531c524256db095285761ea4529b270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038070Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738709}
-
Theresa Wellington authored
Move the following classes to components/browser_ui/widget/ - FeatureHighlightProvider - InsetObserverView - MenuOrKeyboardActionController BUG=951455,1010176 Change-Id: I7eac449f45b52f243fea468554b2a9f6c4868d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040002 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738708}
-
Peter Kotwicz authored
This reverts commit f8a4ba13. Reason for revert: GN modifications broke components_background_task_scheduler_junit_tests Original change's description: > Background task scheduler : Split code into public and internal > > This CL separates the public interfaces from the internal code of background > task scheduler's Java code. > > 1 - The public classes/interfaces are left at top level components/background_task_scheduler > while the implementation code is moved to internal/ > 2 - Internal code is moved to a separate package as well. > 3 - The factory will be a separate target that depends on public and internal. > 4 - Some classes need to be referenced from both chrome/ and internal code, > e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, > have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal > > We should probably move the NativeBackgroundTask as well to components/ which > will greatly help the dependent code to live in components/. Will think about it in a future CL. > > Bug: 1045765 > Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738560} TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org Change-Id: I33c04539e01afae186023e7e011842994d8589ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040373Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738707}
-
Marc Treib authored
Bug: 1034915 Change-Id: Ida5008f8292c1f885c18ead46a04d3c456857674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031025 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738706}
-
Gary Kacmarcik authored
Bug: 946001 Change-Id: I9131bb30d774cd38d169cb92d41fd357cdf0d71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040000 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#738705}
-
Jay Harris authored
Some users are reporting that badging stops working after several days of leaving the app open. We do not have steps to repro, so I'm speculating that it's caused by the mojo connection failing. To test this, I'm going to create a new connection each time we set the badge. If the issue continues to be seen after this CL lands, it can be reverted. Bug: 1048880 Change-Id: Idbcca7be2d08ed8011f05351482705af8f0fea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035521Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738704}
-
Takuto Ikuta authored
Bug: 984869 Change-Id: I1376a7ca637041c4d71bea60c6354b6a63054958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038810 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738703}
-
Carlos Knippschild authored
This reverts commit e6780b7e. Reason for revert: seems to be breaking "browser_tests" on "linux-chromeos-chrome" Original change's description: > Add browser tests for Reader Mode omnibox icon. > > Bug: 992074 > Change-Id: I2b54639a15222d2c30cf419c606b62ebd28597e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951893 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738661} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,katie@chromium.org,gilmanmh@google.com Change-Id: I96214b491da480cd85f809ddb451c48f8a358ba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992074, 1049350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040069Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738702}
-
Jared Saul authored
Was set to ENABLED_BY_DEFAULT in https://chromium-review.googlesource.com/c/chromium/src/+/2017911 Change-Id: Ib93f62d678007d38043b59575cb9ee73f80f84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036355 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Brian Osman authored
Picks up a minor change to stop using a to-be-deprecated Skia API Change-Id: I842ca9ddf7ff818f0ec975eb9f87ff2e461f7371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040192 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#738700}
-
Fredrik Söderquist authored
Using the "max presentation time" concept we can greatly simplify the "once" animation-policy by essentially letting it define a limited window of the timeline in which the animation will be active. This allows us to drop the associated timer and other doodads, leaving just a fairly simple method that is called whenever the container's presentation time is reset. There is a small change in behavior in that the container is no longer explicitly paused, but rather just halted after 3 seconds. Replace the layout test with a set of unittests. Bug: 998526 Change-Id: I2aaa927198bc7918b5767381753a5334ebcd115d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030969Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738699}
-
Robert Liao authored
Remove Uses of Microsoft::WRL::ComPtr<T>::GetAddressOf() in //chrome/services/util_win/util_win_impl.cc Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. BUG=914910 TBR=pmonette@chromium.org Change-Id: Ib7f6b2a03ead757f5b7d3897c2eb788104cc15db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040004Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738698}
-
Hesen Zhang authored
- Setup prefetch notification service, factory and client code. Bug: 1047037 Change-Id: Iccc82d8b49f63213294eb0440fc59138db756912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029293 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738697}
-
Askar Aitzhan authored
Since Tango is being shut down & feature "Cloud Policy over FCM" is being enabled: * Enabled on ToT (M81) * Enabled 100% on Finch experiment starting from M78 Bug: 1048214 Change-Id: Ie69bf1b89d2b9c4496479374b310eae9394be1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035880 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#738696}
-
