GitLab

With Xcode 6, the home directory of the iOS Simulator and iossim
processes must match so that the iOS Simulator can find the SimDevice
object created by iossim. Since the existing behavior of iossim is to
create a new, random, home directory on each run (if no -u value is
specified on the command line), the home directories will be  mismatched
if iossim is launched multiple times without killing the iOS Simulator
in between runs.

The fix here is to only override the home directory in iossim if -u
is specified. Since this will often reuse the default SimDeviceSet
(at ~/Library/Developer/CoreSimulator/Devices), functionality
is also changed to reuse an existing SimDevice if possible (though
iossim will create a SimDevice if necessary).

BUG=None
TBR=rohitrao

Review URL: https://codereview.chromium.org/382563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282139 0039d316-1c4b-4281-b951-d872f2087c98

The //build directory in GN shouldn't refer to anything outside of itself so that non-Chrome projects can copy it and re-use the build configuration. speechd relies on third_party/speech-dispatcher. This patch just moves the loader to the speech-dispatcher target, which makes more sense anyway.

TBR=grunell@chromium.org

Review URL: https://codereview.chromium.org/377403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282138 0039d316-1c4b-4281-b951-d872f2087c98

R= binji@chromium.org
TEST= none
BUG= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/382603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282137 0039d316-1c4b-4281-b951-d872f2087c98

a lot.

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/379923013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282136 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/376313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282135 0039d316-1c4b-4281-b951-d872f2087c98

R=hansmuller@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/385433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282134 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to nearby
code.

BUG=81439
TEST=none
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/375133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/380803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384650

Review URL: https://codereview.chromium.org/336923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282130 0039d316-1c4b-4281-b951-d872f2087c98

MessageLoopProxy is deprecated.

BUG=391045

Review URL: https://codereview.chromium.org/375403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364644
TEST=Start Chrome with --new-profile-management turned on. From the avatar
menu, select "Not <name>". The User Manager should show up. Ctrl+W should
close it, but other accelerators (eg. Ctrl+t) should not work.

Review URL: https://codereview.chromium.org/380763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282128 0039d316-1c4b-4281-b951-d872f2087c98

This creates data url for both output and expected pngs, 
and prints the error bounding rect.

BUG=236196

Review URL: https://codereview.chromium.org/371863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282127 0039d316-1c4b-4281-b951-d872f2087c98

Move Key/User context

BUG=387613
TBR=stevenjb@chromium.org
TBR=davemoore@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/378513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282126 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/378383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282125 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/380503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282124 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Enabled chrome_proxy benchmarks on Android as we now have a TryBot. (https://codereview.chromium.org/367753003/)

Reason for revert:
chrome_proxy tests need live server access. Android chromium.perf bots don't have access to live servers and all tests under tools/perf are now part of chromium.perf. 

It seems chrome_proxy trybot for now can use flag --also-run-disabled-tests to explicitly run these tests.

Original issue's description:
> Enabled chrome_proxy benchmarks on Android as we now have a TryBot.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281182

TBR=tonyg@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/379233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/376273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282122 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requisite for http server refactoring,
https://codereview.chromium.org/296053012/.

1) Introduce SocketLibevent for tcp and unix domain sockets.
2) TCPSocketLibevent utilizes SocketLibevent.
3) For backward compatibility, TCPSocketLibevent::AdoptConnectedSocket()
   allows the empty address.

BUG=371906

Review URL: https://codereview.chromium.org/348803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282121 0039d316-1c4b-4281-b951-d872f2087c98

domain_reliability
favicon
history
url_fixer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/377393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282120 0039d316-1c4b-4281-b951-d872f2087c98

A race can exist where two build targets build the same libchrome.  It
can manifest as:
  .../arm-linux-androideabi-objcopy: error: the input file '.../libchrome.2085.0.so' is empty

Move the temporary directory used to transfer stripped files between the
strip and pack actions from <(SHARED_INTERMEDIATE_DIR) to <(intermediate_dir).
Also, remove nugatory inter-action dependency, and make actions previously
consuming <(strip_stamp) consume <(pack_arm_relocations_stamp) instead.

BUG=392417

Review URL: https://codereview.chromium.org/376193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282118 0039d316-1c4b-4281-b951-d872f2087c98

Since scroll handlers do not block composited scrolling, the existing
input latency metric will only report the response time for the
compositor when scrolling a page with a handler. This is not accurate
for pages that implement scroll-synchronized effects, because the
scroll handler needs to be invoked so that the page contents are
updated with the new scroll offset.

This patch fixes the problem by forwarding latency information from the
impl to the main thread when we are scrolling a layer that has an active
scroll event handler.

In the case the scroll handler is no-op, the latency information will be
terminated as a failed commit.

Sample trace:
https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing

BUG=347366

Review URL: https://codereview.chromium.org/365463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381866

Review URL: https://codereview.chromium.org/369353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390884

Review URL: https://codereview.chromium.org/379813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282113 0039d316-1c4b-4281-b951-d872f2087c98

GetNexeFd() in ppb_nacl_private_impl will change soon to be an internal method,
not one exposed through the PPB_NaCl_Private interface. From inside Chromium,
base::Callback is much easier to use than PP_CompletionCallback or
TrackedCallback.

This is one of a series of changes to refactor the pexe downloading logic in
the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/380773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282112 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes (https://codereview.chromium.org/371933003/)

Reason for revert:
revert this as all related CLs are committed

Original issue's description:
> Disable another WebView fullscreen video test until we land fullscreen IPC changes
> 
> there are 2 changes needs to be submitted before we reenable the tests:
> 1. https://codereview.chromium.org/290643005/ and
> 2. https://codereview.chromium.org/292573004/
> 
> the blink change will break all the tests, so we need to reenable the test after the chromium change lands
> 
> BUG=367346
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281627

TBR=boliu@chromium.org
BUG=367346

Review URL: https://codereview.chromium.org/382583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282111 0039d316-1c4b-4281-b951-d872f2087c98

Currently, AcceleratorController delivers accelerators to GlobalCommandsListenerChromeOS (which is an AcceleratorTarget). We respect the same conditions found within AcceleratorController to disallow shortcuts in specific instances (e.g. login screen locked screen, empty windows). AcceleratorController is owned by the ash::Shell and knows about existing keyboard shortcuts/actions.

BUG=336761
TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.*

And, manually, on a desktop build of Chrome with GYP_DEFINES=chromeos=1...

with a component extension:

Verified that
- a global shortcut (ctrl+shift+0) works with focus in
1. web content
2. shelf
3. toolbars (omni box, View(s)).

Verified that processing does not occur in the following cases (similarly to most other ash accelerators) as expected:
- OOBE
- locked screen
- desktop with no windows open
- sign in screen (after logging out).

Review URL: https://codereview.chromium.org/350943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391861
R=asargent@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/377833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282109 0039d316-1c4b-4281-b951-d872f2087c98

Ports over more gyp logic for the icu target. Doesn't correctly account
for host toolchains yet, but it's closer.

All hail GN. oRZ

BUG=none

Review URL: https://codereview.chromium.org/377113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282108 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/381643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/380783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282105 0039d316-1c4b-4281-b951-d872f2087c98

Blink won't find carriage returns from Windows clipboards.
Strip those characters before calling WebContents::Find.

The newline character is displayed wrong in textfields.
Swap it out for the Unicode newline symbol: ␤ (0x2424).
(the glyph isn't available on Win Views for me now...)

See before/after pics at http://crbug.com/371450#c7

BUG=371450
TEST=Find-in-page works well for string containing line breaks.
R=pkasting@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/374253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/379923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282100 0039d316-1c4b-4281-b951-d872f2087c98

Changed registration API to work for one network at once.
Fixed comments.
Replaced argument GCDDevice with just string id.

BUG=383167
R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org

Review URL: https://codereview.chromium.org/363883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282099 0039d316-1c4b-4281-b951-d872f2087c98

implement it for mDNS (WiFi devices forthcoming)

BUG=383167

Review URL: https://codereview.chromium.org/356613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282098 0039d316-1c4b-4281-b951-d872f2087c98

Note: this is a reland of https://codereview.chromium.org/373153002/
after plugging a memory leak.

BookmarkStorage isn't ref counted anymore since
https://codereview.chromium.org/370323002, and the LoadCallback() task
now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
raw pointer to the BookmarkLoadDetails object, which is still owned
by BookmarkStorage and may have been destroyed when the background
task runs.

This happened on iOS tests after a recent merge.

TBR=sky@chromium.org
BUG=165760

Review URL: https://codereview.chromium.org/376203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282097 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect usage of ProfileInfoCache in GAIAInfoUpdateService: SetGAIANameOfProfileAtIndex may change the profile index.
Also add some warning comments in profile_info_cache.h.

BUG=372381

Review URL: https://codereview.chromium.org/373083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282095 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/378363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282094 0039d316-1c4b-4281-b951-d872f2087c98

in Google Update settings.

Consequentially, the backed up client_id now keeps its dashes and crash_keys
strips them at runtime rather than when backing it up
(https://codereview.chromium.org/372473004/ will add support for stripped
client_id backups for some time).

Also rename a lot of methods involved in setting the client id; having all of
them named "SetClientID" makes this series of calls very hard to follow!

BUG=391338
TBR=thestig

Review URL: https://codereview.chromium.org/365133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282093 0039d316-1c4b-4281-b951-d872f2087c98