- 22 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c0546b9817ee..3acdefa9aad9 git log c0546b9817ee..3acdefa9aad9 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 hferreiro@igalia.com Omit "Skipping <branch>" message when unneeded Created with: gclient setdep -r src/third_party/depot_tools@3acdefa9aad9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id18bf39261ffc192f3593a1451cdc91f9e15bab5 Reviewed-on: https://chromium-review.googlesource.com/c/1482620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634610}
-
Guido Urdaneta authored
Prior to this CL, the event was fired before the transceiver state was updated, in contradiction with the spec, which says it should be fired after the transceiver state is updated. Bug: 920200 Change-Id: I757cc0161a5da4888cd628619180e24a54dc732b Reviewed-on: https://chromium-review.googlesource.com/c/1458203 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#634609}
-
Danil Chapovalov authored
by making WebrtcTaskQueue::RunTask properly static RunTask supports running after WebrtcTaskQueue is destroyed, it has protection |this| is not accessed in that case, however calling non-static non-virtual function of a destroyed object is still an undefined behaviour Bug: chromium:933851 Change-Id: Idc30bc59eff1193997d7e53537cd1493b668dd08 Reviewed-on: https://chromium-review.googlesource.com/c/1479233Reviewed-by:
Per Kjellander <perkj@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634608}
-
Christos Froussios authored
http/tests/devtools/tracing/worker-events.js virtual/threaded/http/tests/devtools/tracing/worker-events.js are flaky on Mac10.13 Tests (dbg) Bug: 934768 No-try: True No-presubmit: True Change-Id: Id114e2e590e1d4642160b228cee9987b65a28c2c Reviewed-on: https://chromium-review.googlesource.com/c/1482731Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634607}
-
Alexandre Courbot authored
We have made V4L2ReadableBufferRef's destruction thread-safe, but they still hold a scoped_refptr to their V4L2Queue. This means that the V4L2Queue can be destroyed from V4L2ReadableBufferRef's destructor, i.e. in the incorrect thread. Fix this by changing the scoped_refptr to a WeakPtr. This design also fixes another issue: it lets us invalidate the WeakPtrs if buffers get reallocated, making it impossible to access the wrong buffer after such an event. Methods of V4L2ReadableBufferRef that make use of the queue accordingly check that the WeakPtr is valid and return an error value if it is not. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: I82722033d9b902fd44f5c090be47ffb4469222a3 Reviewed-on: https://chromium-review.googlesource.com/c/1481186 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634606}
-
dstockwell authored
Bug: 902646 Change-Id: I60ade36f35629834b8ef4249e05635a28a8a702e Reviewed-on: https://chromium-review.googlesource.com/c/1481279 Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634605}
-
Greg Thompson authored
BUG=933004 R=wfh@chromium.org Change-Id: I911be4cbfc38a4d41dec85d85f7fe0f50ddca392 Reviewed-on: https://chromium-review.googlesource.com/c/1481210 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634604}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/timing has not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of the EventTiming, SubTaskAttribution, and TimeClamper classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. Bug: 919389 Change-Id: Ib8cddb4c1e4db37b6542bfabae7a13cc4a6d5749 Reviewed-on: https://chromium-review.googlesource.com/c/1482250Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634603}
-
Boris Sazonov authored
This CL fixes an issue introduced in https://crrev.com/c/1466744. SetUrlKeyedAnonymizedDataCollectionEnabled was using 'true' instead of 'enabled' parameter when calling UnifiedConsentService, making it impossible to disable UKM from SyncAndServicesPreferences. Bug: 933648 Change-Id: I30abdb2a65472357e5054e36e8338527390f8433 Reviewed-on: https://chromium-review.googlesource.com/c/1480005 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#634602}
-
Christos Froussios authored
This reverts commit 8f219b08. Reason for revert: broke base_unittests on win-asan First failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/3559 Original change's description: > [Sampling profiler] Make ModuleCache::Module a reference type > > Changes ModuleCache::Module from a value type to a reference type, > with ModuleCache maintaining ownership of the Module. ModuleCache needs > to own its Modules to properly support Windows, which reference counts > its modules. > > ModuleCache is retained as a struct to minimize the size of this change, > but will be changed to a class in a later CL. > > Bug: 931418 > Change-Id: Ifa5bb0e763de14d91c1663ba01aeb3bab09447be > Reviewed-on: https://chromium-review.googlesource.com/c/1477817 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634408} TBR=wittman@chromium.org,alph@chromium.org,oysteine@chromium.org,charliea@chromium.org Change-Id: Iad9daf5933823b3139d4a81d5d2d6ba6b8e655f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/1482894 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Christos Froussios authored
This reverts commit 9de3faa3. Reason for revert: Prevents reverting https://chromium-review.googlesource.com/c/chromium/src/+/1477817 due to a merge conflict. This needs to be reverted before reverting the guilty CL. Original change's description: > [Sampling profiler] Move Windows module cache into ModuleCache > > Moves the parallel module caching implementation for Windows into > ModuleCache. This implementation will be merged with the existing module > caching implementation over the course of later refactoring CLs. > > Bug: 931418 > Change-Id: I65309bca1edc2675e7e5d74e0305bf5cfe017fd1 > Reviewed-on: https://chromium-review.googlesource.com/c/1478035 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634493} TBR=wittman@chromium.org,alph@chromium.org,charliea@chromium.org Change-Id: I081c040b0a187a0d955625a6a76f832ad3bb567e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/1482895Reviewed-by:
-
Allan Sandfeld Jensen authored
The fix was lost in refactoring that ended up duplicating the last_find_request_completed_with_no_matches_ member. BUG=669983 Change-Id: I09229496d183ef3f9b69c6089a6ac3ecd8b5ef82 Reviewed-on: https://chromium-review.googlesource.com/c/1477835Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This reverts commit 91b547aa. The same functionality will be submitted in a separate CL that will re-suspend based on system wide wake locks and not just ARC++ wake locks. BUG=chromium:898297 TEST=ArcWakeLockBridgeTest unit tests. Change-Id: I626733d89dfa7aadeb620997091abd0a2f958c10 Reviewed-on: https://chromium-review.googlesource.com/c/1372333 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#634598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8ea42840ca..4309189029fc Created with: gclient setdep -r src-internal@4309189029fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iec08f54dfd6b736fdd6c4c3290a16e91363a8898 Reviewed-on: https://chromium-review.googlesource.com/c/1482617Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634597}
-
Egor Pasko authored
In crrev.com/634314 I forgot to upload the last changes addressing the latest comments from perezju@. Transferring those tweaks into this followup change. Bug: 925453 Change-Id: If8293d9b63977082f645697bd8fb110fbaae5ceb Reviewed-on: https://chromium-review.googlesource.com/c/1481299Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634596}
-
Christos Froussios authored
This reverts commit 21a4eef0. Reason for revert: ios_web_inttests is broken on ios-webview Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/6599 Original change's description: > [ios] Add FindInPageManager Inttests > > Creates FindInPageManagerTest to test FindInPageManager and FindInPageManagerDelegate. > > Bug: 919685 > Change-Id: Ia9b680582677f984dd9b775155f8f21b0285b768 > Reviewed-on: https://chromium-review.googlesource.com/c/1448912 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634434} TBR=eugenebut@chromium.org,michaeldo@chromium.org,thegreenfrog@chromium.org Change-Id: I4c1829451a7e68e2fbde2a9e8badbfe644389048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919685 Reviewed-on: https://chromium-review.googlesource.com/c/1482951Reviewed-by:
-
Daniel Bratell authored
https://chromium-review.googlesource.com/c/chromium/src/+/1474976 introduced a BstrToUTF8 which in jumbo builds collided with an existing (but different) BstrToUTF and broke Windows builds. This renames one of the conversions to "BstrToPrettyUTF8" since it not only converts but also makes the string readable for logs. If the methods had been indentical it would have been suitable to move them to content/browser/accessibility/accessibility_tree_formatter_utils_win.cc I think. TBR=dmazzoni@chromium.org,iapres@microsoft.com Bug: 928949 Change-Id: I33660b867e6a4bcabfd274ba976ef642dd65db3a Reviewed-on: https://chromium-review.googlesource.com/c/1482452Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#634594}
-
Christos Froussios authored
This reverts commit 76efdcf8. Reason for revert: Suspected of breaking FileSystemProviderApiTest.RemoveWatcher FileSystemProviderApiTest.AddWatcher in browser_tests on linux-chromeos-rel Example failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20439 Original change's description: > Migrate file_system file manager APIs to UIThreadExtensionFunction. > > BUG=934541 > > Change-Id: Ibd06bda730bd10c270d187d83f68315159fa6a43 > Reviewed-on: https://chromium-review.googlesource.com/c/1482172 > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Anand Mistry <amistry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634562} TBR=sammc@chromium.org,amistry@chromium.org Change-Id: I56ca79cb7a1d358539d31d3c1156859232e08ce3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934541 Reviewed-on: https://chromium-review.googlesource.com/c/1482970Reviewed-by:
-
Oystein Eftevaag authored
Tracing clients like devtools will request trace events only for a specific label, like "traceEvents", and the expected output is then just a flat JSON list of corresponding events, with no extra metadata or data from other labels. R=ssid@chromium.org,eseckler@chromium.org Bug: 839084 Change-Id: I39774f9e8798baee64d4416eac2ba67cf734a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/1481122Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634592}
-
Robbie Gibson authored
Bug: 913958 Change-Id: I6c37831e3ed06d03a4eed468dc7da5f561c2897e Reviewed-on: https://chromium-review.googlesource.com/c/1474759Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#634591}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. Bug: 926204 Change-Id: Id94473af07c7050ad813475ba045421c1f2c1a36 Reviewed-on: https://chromium-review.googlesource.com/c/1470700Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634590}
-
Christos Froussios authored
The test is flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&tests=WorkerThreadTest.TestTaskExecutedBeforeThreadDeletion Bug: 934088 Change-Id: I4d783da07af305a094d41f32383e16e98ca48f43 Reviewed-on: https://chromium-review.googlesource.com/c/1481310Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634589}
-
Marc Treib authored
Generally, SyncService (the interface) should be preferred over ProfileSyncService (the implementation). This CL moves some browser tests which don't actually need ProfileSyncService over to SyncService. Bug: 924508 Change-Id: I1da7583c209b196053c95b29362034daac78a201 Reviewed-on: https://chromium-review.googlesource.com/c/1481334 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#634588}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/509f53e8e4d4..4a8ea42840ca Created with: gclient setdep -r src-internal@4a8ea42840ca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I81891f574e2784a397c48979238be1e3913bb724 Reviewed-on: https://chromium-review.googlesource.com/c/1482616Reviewed-by:
-
Yutaka Hirano authored
Bug: 934636 Change-Id: Ica9965dc176845f7f90aa6950eda3b25063126ce Tbr: mkwst@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1482292 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#634586}
-
Yutaka Hirano authored
The test calls 'fetch()' and waits for a request to finish. Strictly speaking, the request may not complete unless you read the response body. I'm going to land a change that makes the behavior more explicit, so this CL fixes the test beforehand. Bug: 894819 Change-Id: Id8edd93bcad47df2a1907892f231be094f789e02 Reviewed-on: https://chromium-review.googlesource.com/c/1478325Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#634585}
-
Sammie Quon authored
Use floats instead of ints for the overview item bounds calculation pipeline. The pipeline consists of multiple levels which all do rounding which results in some jank. Use bounding_box_f. Mouse will be handled using the newly added coordinate conversion functions in a separate cl (there seems to be an offset, it was non-trivial). Mouse drag is also much less common. This patch also changes the regular dragging calculations. Previously used and offset from previous bounds. This now calculates the new centerpoint based on the location and the initial distance from event to bounds centerpoint. Test: manual Bug: 927405, 871355 Change-Id: I9c6f96c04aab0a44ab0a5ca177bee58aa4d9ed77 Reviewed-on: https://chromium-review.googlesource.com/c/1471513 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634584}
-
Jakob Ivarsson authored
Add WebRTC-Audio-NewOpusPacketLossRateOptimization to field trial testing config and remove WebRTC-Audio-OpusMinPacketLossRate. Bug: 932093 Change-Id: I2a0ad3882b8acfb6a66e41230090e7f9eedf6272 Reviewed-on: https://chromium-review.googlesource.com/c/1479960Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jakob Ivarsson <jakobi@google.com> Cr-Commit-Position: refs/heads/master@{#634583}
-
Yuki Shiino authored
Converts PaintWorkletGlobalScope.registerPaint's second argument |paintCtor| into IDL callback function type. Also, makes Paint Worklet use |PaintCallback| of callback function type. Change-Id: I6706499705a116c85f5c092a46309854db88708c Reviewed-on: https://chromium-review.googlesource.com/c/1478850Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#634582}
-
Yutaka Hirano authored
This reverts commit 9405f035. Reason for revert: TranslateManagerBrowserTest.AppCacheInteraction is failing on some bots: see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20438 for example. Original change's description: > [reland] Making Google Translate compatible with |request_initiator_site_lock|. > > This is a reland of https://crrev.com/c/1441277 that > - Trims the test down in a speculative attempt to avoid test flakiness > (I verified that the test still fails without the corresponding > changes in TranslateHelper::Translate) > - Adds logging statements to the test, to help in case trimming of the > test doesn't address the flakiness. > The original CL description follows below. > > Google Translate executes its scripts inside "isolated worlds". This is > quite similar to how extension content scripts execute and has a > consequence of using |request_initiator| set to the origin of the > isolated world (rather than to the origin of the page where the script > was injected). This is problematic for 2 reasons: > 1. It leads to renderer kills, when an AppCache verifies > |request_initiator| using CPSPI::CanAccessDataForOrigin. > 2. It leads to incompatibility between |request_initiator| and > |request_initiator_site_lock| which can also cause wrong/harsh > security decisions (e.g. CORB blocking of otherwise benign requests). > > This CL addresses the problems above, by making sure that requests > initiated by the Translate's "isolated worls" will use a separate > URLLoaderFactory. > - For injecting and selecting the factory on the renderer side, the same > mechanism is used as for extension content scripts (i.e. > URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is > populated for the origin associated with the "isolated world"). > - For simplicity and to avoid races, the separate URLLoaderFactory is > sent from the browser to the renderer process in the same, single IPC > that triggers script injection into an isolated world (i.e. in > translate::mojom::Page::Translate method). > > As a side effect, this CL also causes Translate's requests to go > directly to the NetworkService (rather than to the AppCache's > AppCacheSubresourceURLFactory). This seems desirable. > > Bug: 925457 > Tbr: John Abd-El-Malek <jam@chromium.org> > Tbr: Daniel Cheng <dcheng@chromium.org> > Change-Id: If03198d98a3c78031718eecb21ec1ae39db5530f > Reviewed-on: https://chromium-review.googlesource.com/c/1481535 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634432} TBR=dcheng@chromium.org,jam@chromium.org,anthonyvd@chromium.org,lukasza@chromium.org Change-Id: I02c798f40caa942c3a3f801ff83529e138a54057 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925457 Reviewed-on: https://chromium-review.googlesource.com/c/1482439Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#634581}
-
Findit authored
This reverts commit 8af85474. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 634467 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGFmODU0NzQ4ZjIyNmE5OWRkY2QzYjA5ZTU1ZTQyNDE0ZWMwMmVlZgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/11425 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: NetworkChangeManagerClientBrowserTest.DISABLE_ReconnectToNetworkService Original change's description: > Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService > > This test is flaky on ChromeOS when the network service is enabled. > > Bug: 934583 > Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1482005 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634467} Change-Id: Ia976e39e8c7307ab85c208c644e9fc3faf36a6c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934583 Reviewed-on: https://chromium-review.googlesource.com/c/1482598 Cr-Commit-Position: refs/heads/master@{#634580}
-
Nate Fischer authored
This refactors how we plumb args.platform through run_cts.py, and provides clearer error output: * If your device is higher than the supported platform range, we recommend using the max supported platform * If your device is lower than the supported platform range, explain that we don't support this because WebView is not updatable * If we auto-select a platform, this writes an info log to explain what platform we chose (useful for debugging) This renames --platform to --cts-release, since "--platform" was a bit unclear, and improves the --help description to better explain how to use this. This also adds unit tests for the logic behind the actionable exceptions. Bug: 934170 Test: vpython android_webview/tools/run_cts_test.py Change-Id: I4574ebf1a760c47e6ae09389ebb73b7ece1967d5 Reviewed-on: https://chromium-review.googlesource.com/c/1481076Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634579}
-
Aleks Totic authored
Bug: 635619 Change-Id: Id3063b1b1c5f31bb3678c30ecca792333424cee1 Reviewed-on: https://chromium-review.googlesource.com/c/1482595 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634578}
-
Gyuyoung Kim authored
BlinkMemoryMgt: Annotate the classes of svg and testing of renderer/core with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/svg and //blink/renderer/core/testing have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of the Commands, and SimPage classes, they make sense to use DISALLOW_NEW because they have been used as a member variable with a reference. In SVGPathQuery class case, they make sense to use STACK_ALLOCATED because they have been used in function without new allocation or smart pointers. Bug: 919389 Change-Id: I1230ae019a0ce9f6548c4d71deba5c1da4ae60f3 Reviewed-on: https://chromium-review.googlesource.com/c/1481149 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Rakina Zata Amni authored
<wbr> elements indicate to the browser that a long string might be broken into lines, for example in long URLs. Since most of the time the line is not broken on the <wbr> elements, users expect to be able to find-in-page text that have <wbr> in between. This CL makes it so that when we encounter <wbr> in find-in-page, we ignore it (so we combine the text before and after the wbr) and not add an object replacement character like we previously do. Bug: 933684 Change-Id: I8593225016e5a0bd8f7436c64a8fe099963c90bb Reviewed-on: https://chromium-review.googlesource.com/c/1482271Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#634576}
-
Abhijeet Kandalkar authored
This CL replaces use of AccountFetcherService::OnRefreshTokensLoaded() method by IdentityTestEnvironment. As per new implementation, AccountFetcherService is wrapped inside ITE to interact with identity_apitest. Bug: 929603 Change-Id: I95bd34d549e6a03703ca15014de87359469547e8 Reviewed-on: https://chromium-review.googlesource.com/c/1458404 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Add logging as warn so it shows up in the logs file. Add logging for: - Earliest startup of Files app. - Before trying to change to the initial directory. - After finished changing to the initial directory. - If there is no initial directory. Change background page logs from debug to warn to have information about the volumes initialization. We can turn this back to debug once we figure out this bug. These cover the bare minimal of the Files app initialization. Add a util function to return a debug string from a give entry, to use in the logging during startup. Bug: 904658 Change-Id: Iaa14b8fe5ac171f4fa2cd070edadaf370e50c5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1480302 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634574}
-
Alexandre Courbot authored
We are planning to introduce VideoFrames backed by a V4L2-allocated buffer. Such VideoFrames need to prevent that buffer from being reused during their lifetime. They will do so by retaining a reference to the V4L2ReadableBufferRef they were created from. However, contrary to V4L2 buffer references VideoFrames are typically passed between threads, and have a more blurry lifetime. Thus we may destroy the VideoFrame and release the V4L2ReadableBufferRef in a thread different from the one it was created in. Worse, this can also happen after the thread in question or even the V4L2 queue the buffer originated from has been deleted, rendering it impossible to post the destruction to the correct message loop. This CL thus makes it legal to destroy a V4L2ReadableBufferRef from any thread, and even after their originating V4L2Queue has been destroyed. To allow this the only task performed during buffer reference destruction, namely returning the reference to the free buffers list, must be made thread-safe. Also the free buffers list must be able to survive the V4L2Queue's destruction. For this, the thread-safe V4L2BufferList class in introduced, and referenced using a scoped_refptr from the V4L2Queue and all the buffer references. When buffers are freed on the queue, it creates a new instance of V4L2BuffersList, so buffer references can still reference and return to the old one. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: Ib37cf55232aca040f1267e3d0357ebb7c40c7d6c Reviewed-on: https://chromium-review.googlesource.com/c/1481185Reviewed-by:
-
Risan authored
This CL implements OpenFile logic using DriveFS if it is enabled. Otherwise, VirtualFileProvider is used. BUG=b:119597913 TEST=Manually "Open With" a file in Google Drive (FilesApp) with an Android app (with and without DriveFS enabled). TEST=Tested that FSP still works (open zip mounted file with Google Photos). Change-Id: Ie206f22e717f4c31330f6beb33520d151ec07e66 Reviewed-on: https://chromium-review.googlesource.com/c/1475143Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Sarthak Kukreti authored
This adds histogram declarations and enums for the histogram added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1152301 BUG=chromium:808303 CQ-DEPEND=CL:1152301 TEST=None Signed-off-by:
Sarthak Kukreti <sarthakkukreti@chromium.org> Change-Id: I91f8775cf49b78f4689e143142323d85a7e528fc Reviewed-on: https://chromium-review.googlesource.com/c/1227503Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#634571}
-
