GitLab

BUG=376924

Review URL: https://codereview.chromium.org/295983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272720 0039d316-1c4b-4281-b951-d872f2087c98

Since we had to change it on Win/Linux, I thought it would be good to be 
consistent and draw the frame on Mac as well.

BUG=372721

Review URL: https://codereview.chromium.org/298973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374686

Review URL: https://codereview.chromium.org/297833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
NOTRY=true

Review URL: https://codereview.chromium.org/297903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272717 0039d316-1c4b-4281-b951-d872f2087c98

Crash seems to indicate we're registering twice for a
notification. Perhaps we're calling ScheduleLoad and TabIsLoading for
the same tab. Only way I could see that happening is if ShowBrowser()
activated some other tab. This should help isolate if that is
happening.

BUG=368236
TEST=none
R=marja@chromium.org

Review URL: https://codereview.chromium.org/299053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272716 0039d316-1c4b-4281-b951-d872f2087c98

To show the information about ServiceWorkers I added iframe of "chrome://serviceworker-internals/#iframe" to chrome://inspect.
And I used postMessage() to achieve the cross-domain messaging between chrome://inspect and chrome://serviceworker-internals.

BUG=358657

Review URL: https://codereview.chromium.org/298993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/296133015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272714 0039d316-1c4b-4281-b951-d872f2087c98

After r271640, they no longer need this information, since the browser
process sets it in crash reports.

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/296213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272713 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/292743017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272712 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the StatusChangeChecker class hierarchy to allow for more code
sharing.  Allows children of StatusChangeChecker to share logic around
performing a blocking wait, checking exit conditions, and timing out.

As before, the sharing is acheived through inheritance.  We should move
to a delegation pattern if this becomes too complicated, but I think the
use of inheritance still makes sense for now.

This is a pre-requisite for a future patch that adds a new kind of
StatusChangeChecker that does not listen to ProfileSyncService changes.
I expect that there will be many more kinds of StatusChangeCheckers
defined in the future.  This refactoring will help us share code between
them.

This is attached to issue 97780 and 95742 because it will enable us to
write more StatusChangeCheckers that we can use to refactor tests that
currently listen for snapshots and self-notifications.

BUG=97780,95742

Review URL: https://codereview.chromium.org/299843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272711 0039d316-1c4b-4281-b951-d872f2087c98

The streamsPrivate API provides the response headers for the original URL request in the stream details. This passes them along to the plugin with the URL.

This also adds the ability for the plugin to cancel the stream, which is necessary if the plugin wants to re-request the original URL.

BUG=303491

Review URL: https://codereview.chromium.org/275333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272710 0039d316-1c4b-4281-b951-d872f2087c98

Also, add an optimization to not decode frames if we are behind and multiple frames are currently decodable.

Review URL: https://codereview.chromium.org/289483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272709 0039d316-1c4b-4281-b951-d872f2087c98

Turns MetricsLogChromeOS into a metrics::MetricsProvider. Splits the
ChromeOS-specific unittests out from the MetricsLog test into separate
ChromeOSMetricsProvider tests. Also moves LogChromeOSCrash() from
MetricsService to ChromeOSMetricsProvider.

BUG=374221
R=asvitkine@chromium.org
TBR=derat, pam

Review URL: https://codereview.chromium.org/292433015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272708 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Don't expose --disable-gpu-compositing, only set internally. (https://codereview.chromium.org/300523002/)

Reason for revert:
Makes a bunch of virtual/softwarecompositing tests Timeout on Mac
https://code.google.com/p/chromium/issues/detail?id=377145

Original issue's description:
> Don't expose --disable-gpu-compositing, only set internally.
> 
> The flag isn't meant to be set externally, it doesn't work on most
> configs. It's only meant internally to make sure the renderer doesn't
> try to use GPU when the browser is in software.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272636

TBR=jbauman@chromium.org,piman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/299383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272707 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272705 0039d316-1c4b-4281-b951-d872f2087c98

The test added in this CL DomDistillerTabUtilsBrowserTest.TestSwapWebContents
consistently fails on some bots, e.g.
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/41414
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27225
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48492

> Add support for distilling current WebContents
> 
> This CL adds the utilities needed for using the current WebContents when
> distilling web pages.
> 
> BUG=361939
> 
> Review URL: https://codereview.chromium.org/266073003

TBR=nyquist@chromium.org

Review URL: https://codereview.chromium.org/297163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272704 0039d316-1c4b-4281-b951-d872f2087c98

The CL broke asan/lsan bots on linux, and chromiumos e.g.

LevelDBPrefStoreTest.BasicObserver (run #1):
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5babfb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x61f3699 in LevelDBPrefStore::OnStorageRead(scoped_ptr\u003CLevelDBPrefStore::ReadingResults, base::DefaultDeleter\u003CLevelDBPrefStore::ReadingResults> >) chrome/browser/prefs/leveldb_pref_store.cc:406
    #2 0x61f2ea7 in LevelDBPrefStore::ReadPrefs() chrome/browser/prefs/leveldb_pref_store.cc:329
    #3 0x336efee in LevelDBPrefStoreTest_BasicObserver_Test::TestBody() chrome/browser/prefs/leveldb_pref_store_unittest.cc:97
...

Indirect leak of 4096 byte(s) in 1 object(s) allocated from:
    #0 0x5bad4b in operator new[](unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:57
    #1 0x7e66db5 in AllocateNewBlock third_party/leveldatabase/src/util/arena.cc:62
    #2 0x7e66db5 in leveldb::Arena::AllocateFallback(unsigned long) third_party/leveldatabase/src/util/arena.cc:33
    #3 0x7e2a88a in NewNode third_party/leveldatabase/src/db/skiplist.h:182
    #4 0x7e2a88a in leveldb::SkipList\u003Cchar const*, leveldb::MemTable::KeyComparator>::SkipList(leveldb::MemTable::KeyComparator, leveldb::Arena*) third_party/leveldatabase/src/db/skiplist.h:325
    #5 0x7e2a76e in leveldb::MemTable::MemTable(leveldb::InternalKeyComparator const&) third_party/leveldatabase/src/db/memtable.cc:24
    #6 0x7e084ce in leveldb::DBImpl::DBImpl(leveldb::Options const&, std::string const&) third_party/leveldatabase/src/db/db_impl.cc:120
    #7 0x7e1bfb0 in leveldb::DB::Open(leveldb::Options const&, std::string const&, leveldb::DB**) third_party/leveldatabase/src/db/db_impl.cc:1449
    #8 0x61ef0a2 in LevelDBPrefStore::OpenDB(base::FilePath const&, LevelDBPrefStore::ReadingResults*) chrome/browser/prefs/leveldb_pref_store.cc:113
    #9 0x61efcae in LevelDBPrefStore::DoReading(base::FilePath const&) chrome/browser/prefs/leveldb_pref_store.cc:158
    #10 0x61f2dc0 in LevelDBPrefStore::ReadPrefs() chrome/browser/prefs/leveldb_pref_store.cc:325
...

> Implementation of leveldb-backed PrefStore.
> 
> This is not hooked up yet, migration code from Json-backed stores is needed, among other things.
> 
> BUG=362814
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271602
> 
> Review URL: https://codereview.chromium.org/169323003

TBR=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/298043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272700 0039d316-1c4b-4281-b951-d872f2087c98

Instead, each HttpNetworkSession is given its own immutable copies on
construction.  Other than spdy_enabled, none of the globals were
changed before this CL, anyways.

Also, setting spdy_enabled back to true after setting it to false no
longer clears the NPN list.

spdy_enabled is still a global because group policy can set it to
false at runtime.

BUG=372533
R=joaodasilva@chromium.org, rch@chromium.org, sergeyu@chromium.org, sgurun@chromium.org, sky@chromium.org, ttuttle@chromium.org

Review URL: https://codereview.chromium.org/284423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272698 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a crash in ungraceful sync backend shutdown.  The problem was that
the sync backend host core might try to unregister itself as a listener
of some information generated in the ModelTypeRegistry, but the
ModelTypeRegistry did not exist if backend initialization failed.

The fix used here is to track whether or not we were registered for
these notifications in the first place, and only unregister if we
had previously registered successfully.  In the failure shutdown
case, the flag is unset, so we will not attempt to unregister.

BUG=376863

Review URL: https://codereview.chromium.org/294023017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368334

Review URL: https://codereview.chromium.org/296133011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272696 0039d316-1c4b-4281-b951-d872f2087c98

Previously immediate reconnection was triggered by the video channel
becoming inactive. That can cause spurious reconnects on flaky networks.
Now the webapp will always wait for 10 seconds before trying to reconnect.

BUG=375568

Review URL: https://codereview.chromium.org/297963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272695 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346399
TEST=none

Review URL: https://codereview.chromium.org/260903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272687 0039d316-1c4b-4281-b951-d872f2087c98

- "cd" under some bash settings can print the current directory
- adb_gdb variable use is missing undescore

BUG=

Review URL: https://codereview.chromium.org/292983014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272686 0039d316-1c4b-4281-b951-d872f2087c98

I got this by change when I ran:
$ gn gen out/Debug_gn --args='os="linux" cpu_arch="arm"'
ERROR at //content/common/BUILD.gn:151:31: Undefined identifier
    if (cpu_arch != "arm" || !is_chromos) {
                             ^---------

BUG=None
TEST=above
TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/302443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272685 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/297113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272684 0039d316-1c4b-4281-b951-d872f2087c98

sanjeevr@ hasn't been active on the project for long time.

Review URL: https://codereview.chromium.org/299923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272683 0039d316-1c4b-4281-b951-d872f2087c98

TBR for analyzer changes, which are just fixes to the analyzer unit tests.

R=dsinclair
CC=epenner
TBR=willchan

Review URL: https://codereview.chromium.org/277883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362288

Review URL: https://codereview.chromium.org/287253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272681 0039d316-1c4b-4281-b951-d872f2087c98

Previously it would not set the return address properly, hopefully it will work now.

Review URL: https://codereview.chromium.org/282333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272680 0039d316-1c4b-4281-b951-d872f2087c98

Also moves the prefs registration to the stability provider.

BUG=374206

Review URL: https://codereview.chromium.org/299153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272679 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272678 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174693:174715&mode=html
TBR=kbr@chromium.org,alph@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/297063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272677 0039d316-1c4b-4281-b951-d872f2087c98

This patch continues the work of issue 170733004(https://codereview.chromium.org/170733004).

Two things are done in this patch:
1) Update the patch to compile again.
2) Move IPC handler to chrome_render_message_filter, and update content_settings_observer.cc.

BUG=343382

Review URL: https://codereview.chromium.org/273513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272676 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to remove dependency on GCMStatsRecorder from GCMClient.

BUG=356716
TEST=existing tests
TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/294053017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272675 0039d316-1c4b-4281-b951-d872f2087c98

The #ifdefs in badge_util.cc had the chromeos code behind OS_LINUX &&
TOOLKIT_VIEWS, which is no longer just chromeos. Switch that block to
OS_CHROMEOS and use the old GTK+ hard coded settings in the Linux aura
build.

BUG=376335

Review URL: https://codereview.chromium.org/295263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272674 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272673 0039d316-1c4b-4281-b951-d872f2087c98

- Uploading from pure-svn and intending to commit manually to properly remove the directory from svn.
- Includes deps_whitelist change for new Skia DEP
- Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123

R=mkosiba@chromium.org

Review URL: https://codereview.chromium.org/296903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272672 0039d316-1c4b-4281-b951-d872f2087c98

This is not hooked up yet, migration code from Json-backed stores is needed, among other things.

BUG=362814

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271602

Review URL: https://codereview.chromium.org/169323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272671 0039d316-1c4b-4281-b951-d872f2087c98