- 17 Jul, 2017 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ceb5bb0..c6e2620a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I180c4329127f835e6e95d5d1fa8e48bd45f8afa8 Reviewed-on: https://chromium-review.googlesource.com/574567Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487085}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3a4ebcc7c490..f768baf129fc $ git log 3a4ebcc7c..f768baf12 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Let CPDF_MeshStream::ReadVertexRow return a vector Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ibfec7eb954dbb3874c58fdee951e4dc54432dd65 Reviewed-on: https://chromium-review.googlesource.com/574459 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487084}
-
Yipeng Wang authored
Bug: 674250 Change-Id: I2c8c38e680da2357abe39146571937fc369c4778 Reviewed-on: https://chromium-review.googlesource.com/558206 Commit-Queue: Yipeng Wang <yipengw@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487083}
-
David Bokan authored
This reverts commit 8448024f. Reason for revert: This likely introduced a container-overflow: crbug.com/742520 Original change's description: > Unregister cc scrollbar when registering new one > > We previously DCHECKed that we could never register a new scrollbar > against a scroll layer that already has a scrollbar. i.e. We expected > that the old scrollbar would be unregistered prior to registering the > new one. > > RootScroller can break this assumption on Android. On Android, the > global rootScroller (i.e. OuterViewport) is prevented from creating > its own scrollbars, instead inheriting the VisualViewport-created > scrollbars. In other words, the VisualViewport creates a pair of > scrollbars and they get re-assigned to whatever the current outer > viewport is. > > This means that when we change the global rootScroller (for context see > core/page/scrolling/README.md), the previous rootScroller now creates > its own scrollbars and the VisualViewport scrollbars get registered to > the new rootScroller. This then creates a race between moving the > VisualViewport scrollbar registration and new scrollbar registration on > the old rootScroller. > > Long-term, the outer viewport shouldn't own the scrollbars but for now > it doesn't hurt to just unregister the scrollbar if we notice the > scroller already has scrollbars registered. > > Bug: 739738 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I99e8a95881e7dad19c0318a661da80f441b97b19 > Reviewed-on: https://chromium-review.googlesource.com/562018 > Reviewed-by: Weiliang Chen <weiliangc@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486086} TBR=bokan@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739738, 742520, 742678 Change-Id: I1134e17dcb04a3a2cc50f07ecbc0fc79cc74f344 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/574547 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487082}
-
Mikhail Pozdnyakov authored
This patch introduces the Sensor.ConfigureReadingChangeNotifications() method to substitute SensorConfiguration.suppress_on_change_events. Rationals 1. This functionality is not a part of sensor configuration (like sampling rate or accuracy) so better to be decoupled from SensorConfiguration. 2. Code simplification: no need to increment/decrement suppress_on_change_events_count_ at every start()/stop() call. Bug: Change-Id: I55ee9250d6810f36fb6586be1b10923e36b71075 Reviewed-on: https://chromium-review.googlesource.com/536937Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#487081}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d4b678751117..e3e9628ecf86 $ git log d4b678751..e3e9628ec --date=short --no-merges --format='%ad %ae %s' 2017-07-16 bsalomon Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I373bbd72f3353b03a14c481467a041a8f48dfb3d Reviewed-on: https://chromium-review.googlesource.com/574458Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487080}
-
Ned Nguyen authored
This CL also update tools/perf/page_sets/data/.gitignore to make sure the file would not be checked in by mistake again. Bug: 744545 Change-Id: I63ca35ea2f3ba4e5c8a51f0f58a66eecad0710a4 Reviewed-on: https://chromium-review.googlesource.com/574455Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#487079}
-
Han Leon authored
Using wpt-import in Chromium d3ae6e94. TBR=qyearsley@chromium.org No-Export: true Change-Id: I51eb23df0d6b06bfc0facb34e1f3605089d79c35 Reviewed-on: https://chromium-review.googlesource.com/574249Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#487078}
-
Anthony Vallee-Dubois authored
Bug: 742329 Change-Id: I73b2043c63f814d0394ed745eb6b1e55814db339 Reviewed-on: https://chromium-review.googlesource.com/570982 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#487077}
-
Daniel Bratell authored
"using namespace" in global scope introduces a lot of symbols into the current scope and does not work well with jumbo. In case of WTF you can also equally well just write a WTF:: prefix. Bug: Change-Id: Id615f60151e0bc46cfe2a5e9a6a9313c412f1344 Reviewed-on: https://chromium-review.googlesource.com/570446 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487076}
-
Mythri Alle authored
We plan to merge v8.browse and v8.runtimestats benchmarks into a single benchmark. So, enable the memory metric on the v8.runtimestats benchmark. Though the expectedQueueingTimeMetric is alredy enabled on v8.runtimestats* it requires v8.compile trace events to work correctly. Also enable v8.compile category for the expectedQueueingTimeMetric. The only other metric tracked by v8.browsing and not by v8.runtimestats.browsing is the v8 executionMetric. This is not required since the runtimeStatsMetric is a super set of the executionMetric. Bug: chromium:690921 Change-Id: I574c8c27515d3a62dc6d94c759be0eed32543f20 Reviewed-on: https://chromium-review.googlesource.com/574171Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#487075}
-
Yipeng Wang authored
This CL deletes all JNI registration calls under chrome/browser/ui since the JNI registration is automatic now. Change-Id: Id3a0bf6fe0d3bdc413e878324b732979ce0536fc Reviewed-on: https://chromium-review.googlesource.com/572189Reviewed-by:
-
Duc Bui authored
The header file was added when adding signals that mark the start/end of session restore (https://codereview.chromium.org/2935183002). Bug: 661774 Change-Id: I4cfa262281ceb880e76cf99a84b319119e7261e1 Reviewed-on: https://chromium-review.googlesource.com/573488 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487073}
-
Daniel Bratell authored
ng_block_layout_algorithm_test and ng_constraint_space both use a local function ConstructConstraintSpace for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the functions will collide. This patch gives the functions unique names. R=fs@opera.com Change-Id: I3941094aad201b7ec6796d63664da8cfba8056c3 Reviewed-on: https://chromium-review.googlesource.com/574237Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487072}
-
Daniel Bratell authored
There are several classes in frame which have use of for instance EXPECT_POINT_EQ and EXPECT_SIZE_EQ. The problem (beyond duplicating code) is that in jumbo builds those defines collide. This patch moves the shared macros to core/frame/FrameTestHelpers.h. There are also equally named macros in cc/test/geometry_test_utils.h but those work on gfx::Rect/gfx::RectF which is not quite API compatible (different character case). R=fs@opera.com Change-Id: I60cb7eff533e4dccc796937a027ec090071cd5c2 Reviewed-on: https://chromium-review.googlesource.com/574179 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Daniel Bratell authored
There is a gtest namespace ::testing and a helper namespace in blink called ::blink::testing. If both are visible to the compiler, ::blink::testing will be used first and classes in ::testing will not be found. This happens in jumbo builds so we better be more specific. R=fs@opera.com Change-Id: I4da27383432226191b0fcb72f3c54784698f0262 Reviewed-on: https://chromium-review.googlesource.com/574488Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/42102420c02a..d4b678751117 $ git log 42102420c..d4b678751 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 ccameron Make SkImage_Lazy cache its result from onMakeColorSpace Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4829ae1403c2cb91fb0f738ee66fdf117fe1ff9d Reviewed-on: https://chromium-review.googlesource.com/574208Reviewed-by:
-
Daniel Bratell authored
Normal jumbo_target has the wrong default configs for components so this adds a new jumbo_component that has the right default configs. Bug: 713137 Change-Id: I32fd2d015162d85b7ff07d5515489b9e33cfb987 Reviewed-on: https://chromium-review.googlesource.com/571790Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487068}
-
Daniel Bratell authored
Both InterpolableValueTest and InterpolationEffectTest use an identical class for value testing. These classes collided in jumbo builds where they were compiled in the same translation unit. This patch moves the class to AnimationTestHelper.h and changes its name to be more descriptive now when it isn't as close to where it is used anymore. Also changing the name of the kDuration constant that interfered with blink::kDuration. R=fs@opera.com Change-Id: Ic90cec2972f5464d7932b2ba91994273968e87c4 Reviewed-on: https://chromium-review.googlesource.com/574489Reviewed-by:
-
Daniel Bratell authored
IdleDeadlineTest and ScriptedIdleTaskControllerTest both use similarly names mock classes, MockScheduler, MockThread and MockPlatform which collide in jumbo builds where they are merged into the same translation unit. This patch gives the classes unique names. R=fs@opera.com Change-Id: I305cb3fbdfbd3b3b6fc7c18e8c3ceccf89da863e Reviewed-on: https://chromium-review.googlesource.com/574487Reviewed-by:
-
Daniel Bratell authored
PageOverlayTest and PrintContextTest both use a local mock test class named MockCanvas for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique names. R=fs@opera.com Change-Id: Icfcb2b4b553e50e08cb6ac56712e4e9aa5f2b69e Reviewed-on: https://chromium-review.googlesource.com/574349Reviewed-by:
-
Daniel Bratell authored
There is blink enum class LineBreakType used to correctly layout text. That makes it unsuitable to use the same name in a unit_test since they may collide, and actually will collide in jumbo builds. This patch changes LineBreakType to NewlineType R=fs@opera.com Change-Id: I3c5ae6ea5b6e199990c8b51c3a55eb1d17a8f19e Reviewed-on: https://chromium-review.googlesource.com/574238Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86deba2a..0ceb5bb0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib74be404e4cf7d34cf13eb8aa1ab5f8056d0ec79 Reviewed-on: https://chromium-review.googlesource.com/574408Reviewed-by:
-
Pavol Marko authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/137ec42a355f..69b19fbcbec5 $ git log 137ec42a3..69b19fbcb --date=short --no-merges --format='%ad %ae %s' 2017-06-30 pmarko system_api: Support for temporary policy read Created with: roll-dep src/third_party/cros_system_api This will be used by CL:564609. BUG=722371 Change-Id: Ieadd125ff2aa83a3ca69c3611d2c60aae3c1e2d6 Reviewed-on: https://chromium-review.googlesource.com/574347Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487062}
-
Jérôme Lebel authored
On iPad, the user can show the bookmarks with the sign-in promo and open the settings. If they sign in with the settings, then the sign-in promo will be removed from the bookmarks. The mediator from the bookmarks should not send the dismiss histogram. To avoid this problem, the sign-in promo view mediator needs to check if the user is logged in before sending the dismiss histogram. Bug: 742514 Change-Id: Id5c189e68a06e82874ef487155831593911a9ef4 Reviewed-on: https://chromium-review.googlesource.com/567508 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487061}
-
Eddy Mead authored
[CSS Typed OM] Correctly use const on the CSSStyleValue subclass typed members of CSSTransformComponents - Members shouldn't be const (they need to be able to be modified after being returned to JS) - Match the style guide for pointer getters: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Use-const-correctly) - The DOMMatrix function being changed was added for Typed OM in https://codereview.chromium.org/2907973002/ Bug: 545318 Change-Id: Id4399ceaf9290f4f52847696c57a37f8022894fb Reviewed-on: https://chromium-review.googlesource.com/544576 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#487060}
-
Jérôme Lebel authored
Adding an explicit method to send histograms when the sign-in promo view is removed. Bug: 709286 Change-Id: I32c4091e9db05edeb497ab1583fe9b6e3017f5f6 Reviewed-on: https://chromium-review.googlesource.com/567923 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
-
Daniel Bratell authored
CSSTokenizerTest already uses functions named Ident and Dimension so to avoid special casing in jumbo builds where the tests are compiled together, rename them here. R=fs@opera.com Change-Id: I6b600c269463d897b6d56287e450e37d027b2911 Reviewed-on: https://chromium-review.googlesource.com/574173Reviewed-by:
-
Daniel Bratell authored
HTMLMediaElementTest and MediaCustomControlsFullscreenDetectorTest both use a local TestParam struct/enum for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: I17a4d3a25e38bc0789071fcec31b066a385d34a0 Reviewed-on: https://chromium-review.googlesource.com/574178Reviewed-by:
-
Daniel Bratell authored
There is a shared RegisterMockedURLLoad in URLTestHelpers and a couple of local ones imported with "using" or locally declared. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the functions will collide. This patch removes a "using" and renames a function to make the names more unique. R=fs@opera.com Change-Id: I6866f13bd1903e42269b7286645a9f07396b68a8 Reviewed-on: https://chromium-review.googlesource.com/574180Reviewed-by:
-
Suchit Agrawal authored
Create new BUILD.gn file for media/video and moved respective media component changes from media/filters/BUILD.gn file to new BUILD.gn file. BUG=613033 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Change-Id: Iaa2ff8c16d697ede5e8e249fbc01c058eaef6d78 Reviewed-on: https://chromium-review.googlesource.com/569528Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#487055}
-
David Roger authored
Dice signout did not cancel the token exchange request, which could lead to a situation where the token is eventually added to Chrome and propagated back to the web by the account reconcilor. Change-Id: I1c1a2b218694e3de5783e6a29dbcec29a6e0aa0d Reviewed-on: https://chromium-review.googlesource.com/570423Reviewed-by:
-
Daniel Bratell authored
HTMLResourcePreloaderTest and HTMLPreloadScannerTest both use a local PreconnectTestCase struct for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: I99f315843fd6908ba94595e852e6c1fac6acdedb Reviewed-on: https://chromium-review.googlesource.com/574177Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487053}
-
Hector Dearman authored
This use after free crash was caused when a client with a pending response unregisters (via UnregisterClientProcess) and that pending response is the last pending response for the current request. UnregisterClientProcess iterates over request->pending_responses calling OnProcessMemoryDumpResponse or OnOSMemoryDumpResponse when it finds a pending response which matches the client. OnOSMemoryDumpResponse/OnProcessMemoryDumpResponse removes the pending response and calls FinalizeGlobalMemoryDumpIfAllManagersReplied which (if there are no more pending responses) destroys the request we're iterating over. We had a test which attempted to test this but for subtle reasons it didn't actually cover this case. This CL fixes the bug by not-calling OnOSMemoryDumpResponse/OnProcessMemoryDumpResponse from UnregisterClientProcess and adds a test to cover this case. Bug: 742265 Change-Id: I96504edf98ea1b0e530e0daf3f4adbfaa509bc15 Reviewed-on: https://chromium-review.googlesource.com/570247Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#487052}
-
Dan Elphick authored
This reverts commit 67fac36a. Reason for revert: Causes several CPU load, time and memory regressions. Fixes crbug/740469 Original change's description: > Increase priority of compositor TQ in NONE Usecase > > This allows animated GIFs to keep updating even in the presence of timer > storms. > > Reland change partially reverted in > WebRtc and CrSettings tests have been landed. > > https: //chromium-review.googlesource.com/c/508792/ now that fixes to > Bug: 703608 > Change-Id: Id014fda26b7168658c679a7bf74359485c5262e5 > Reviewed-on: https://chromium-review.googlesource.com/559345 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#484863} TBR=skyostil@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 703608, 740469 Change-Id: I172f61626446462bb5582c942ae58d09a13dad71 Reviewed-on: https://chromium-review.googlesource.com/573902 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487051}
-
Daniel Bratell authored
There is a ::Function template in wtf/Functional.h and if someone else defines a function with the same name that template will be harder to use. This is more of a problem in jumbo builds where more code is visible so that both the definitions becomes visible at the same time. R=fs@opera.com Change-Id: I0be2f2e2441f3e5db0049f65e1b4c0be8997d586 Reviewed-on: https://chromium-review.googlesource.com/574028Reviewed-by:
-
Daniel Bratell authored
There is a gtest namespace ::testing and a helper namespace in blink called ::blink::testing. If both are visible to the compiler, ::blink::testing will be used first and classes in ::testing will not be found. This happens in jumbo builds so we better be more specific. R=fs@opera.com Bug: Change-Id: I912ed721a0ccae7b8e8b622020f87f15204362cf Reviewed-on: https://chromium-review.googlesource.com/574027Reviewed-by:
-
hans authored
It was previous calling the out-of-line method WeakReference::is_valid(). That means that code like if (my_weak_ptr) my_weak_ptr->foo(); would do two calls to is_valid(), plus tests and branching. The is_valid() method showed up as one of the most frequently called non-inline functions during browser start-up on Windows (about 1M calls). is_valid() was also inefficient in itself, because it had to do a null-check flag_, as well as checking if the flag was marked valid. This patch removes the null-pointer check by using a sentinel Flag object instead of a nullptr. And instead of storing a bool in the Flag, it stores a pointer-sized bitmask 0 or ~0, so it can be AND'ed with the pointer value and conveniently setting EFLAGS so that the code above just becomes a few loads, AND, branch, and call. (The size of Flag is unchanged; it grows into the padding only.) This is expected to reduce the binary size by ~48KB on Android, and increase it by 79KB on x64 Linux -- something that's paid for by the split-out refactorings to WeakPtr and WeakPtrFactory. Exposing the SequenceChecker calls in inline functions caused the MessageLoopTestType*.Nesting test to overflow on Win64 dcheck release builds, which is why this patch also lowers the recursion depth there. BUG=728324,738183,738193 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2963623002 Cr-Commit-Position: refs/heads/master@{#487048} -
stkhapugin@chromium.org authored
Automatically generated ARCMigrate commit Notable issues: - added bridged casts where necessary - replaced retain-autorelease with NS_VALID_UNTIL_END_OF_SCOPE BUG=624363 TEST=None Change-Id: Ibd7f03942d784bdcf2b95a30f693cfd736ef13c9 Reviewed-on: https://chromium-review.googlesource.com/570031 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#487047}
-
jdoerrie authored
This change removes GetHumanReadableOrigin and GetHumanReadableOriginForAndroidUri. These methods are now dead code following http://crrev.com/c/571227. Bug: 628988 Change-Id: I24cc948a29f709cd3e8280698616114d05d4c87c Reviewed-on: https://chromium-review.googlesource.com/574169Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#487046}
-
