GitLab

These tests are timing out.

TBR=oshima@chromium.org
BUG=487501

Review URL: https://codereview.chromium.org/1134043006

Cr-Commit-Position: refs/heads/master@{#329595}

Revert of Use cert config options in SSLServerSocketOpenSSL. (patchset #4 id:80001 of https://codereview.chromium.org/1138813003/)

Reason for revert:
It seems like this change has caused new leaks on Linux and ChromeOS.

First build it appeared: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/41241

Log output:
Memcheck:Leak
fun:calloc
fun:PORT_ZAlloc_Util
fun:ConvertToSID
fun:ServerSessionIDLookup
fun:ssl3_HandleClientHello
fun:ssl3_HandleHandshakeMessage
fun:ssl3_HandleHandshake
fun:ssl3_HandleRecord
fun:ssl3_GatherCompleteHandshake
fun:SSL_ForceHandshake
fun:_ZN3net18SSLServerSocketNSS11DoHandshakeEv
fun:_ZN3net18SSLServerSocketNSS15DoHandshakeLoopEi
fun:_ZN3net18SSLServerSocketNSS21OnHandshakeIOCompleteEi
fun:_ZN3net18SSLServerSocketNSS14OnRecvCompleteEi
fun:_ZN3net18SSLServerSocketNSS18BufferRecvCompleteEi

This might be tickling some bug in underlying libraries, or it might be a problem with the change itself.

You can reproduce the leak by running valgrind and running all the SSLServerSocket tests. I didn't narrow down which test.

See https://www.chromium.org/developers/how-tos/using-valgrind for more details on using valgrind.

Original issue's description:
> Use cipher suite config options in SSLServerSocketOpenSSL.
>
> Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
> list and require_forward_secrecy flag from SSLConfig. Fixed
> SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.
>
> BUG=481163
>
> Committed: https://crrev.com/d0eae58087e6f45088d6ef349d9ebaa2da450ea1
> Cr-Commit-Position: refs/heads/master@{#329528}

TBR=davidben@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481163

Review URL: https://codereview.chromium.org/1131573005

Cr-Commit-Position: refs/heads/master@{#329594}

BUG=483283

Review URL: https://codereview.chromium.org/1113683003

Cr-Commit-Position: refs/heads/master@{#329593}

BUG=457697

Review URL: https://codereview.chromium.org/1138163002

Cr-Commit-Position: refs/heads/master@{#329592}

This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel|
enum into a class of their own: |ConnectionSecurityHelper| in
//chrome/browser/ssl (since it is applying Chrome-specific security
policy to determine the security level of a page).

Later, we will use the new |ConnectionSecurityHelper| class to compute a
security level for a page to send to the DevTools Security
panel. Specifically, we need to be able to calculate the security level
for a given page, not just the WebContents for the active tab.

BUG=484392

Review URL: https://codereview.chromium.org/1123943002

Cr-Commit-Position: refs/heads/master@{#329591}

Removed the concept of max_results == 0 meaning "unlimited" in mixer
groups. Now, the omnibox group is specifically considered unlimited (and
all other groups have a defined maximum).

BUG=487494

Review URL: https://codereview.chromium.org/1139493004

Cr-Commit-Position: refs/heads/master@{#329590}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/69b829f..9fa4ee7

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1133663005

Cr-Commit-Position: refs/heads/master@{#329589}

Allow an Intent navigation even when a user types if a URL is server redirect and has an external protocol

BUG=487282

Review URL: https://codereview.chromium.org/1136443004

Cr-Commit-Position: refs/heads/master@{#329588}

TBR=oshima@chromium.org
BUG=487500

Review URL: https://codereview.chromium.org/1141693002

Cr-Commit-Position: refs/heads/master@{#329587}

These tests are consistently failing and have been for some time.

TBR=oshima@chromium.org
BUG=484910

Review URL: https://codereview.chromium.org/1138383002

Cr-Commit-Position: refs/heads/master@{#329586}

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1136363002

Cr-Commit-Position: refs/heads/master@{#329585}

TBR=oshima@chromium.org
BUG=487492

Review URL: https://codereview.chromium.org/1140593004

Cr-Commit-Position: refs/heads/master@{#329584}

Review URL: https://codereview.chromium.org/1128313004

Cr-Commit-Position: refs/heads/master@{#329583}

TEST=Checked manually with a test server.
BUG=None

Review URL: https://codereview.chromium.org/1127273004

Cr-Commit-Position: refs/heads/master@{#329582}

This is for making type of file_to_install and file_display_name_ consistent.

BUG=486616

Review URL: https://codereview.chromium.org/1129103006

Cr-Commit-Position: refs/heads/master@{#329581}

This is necessary because it is one of the dependencies of the
'blink_tests' group that should be built.

BUG=483171
R=avi@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1131773004

Cr-Commit-Position: refs/heads/master@{#329580}

Previously this was called --linux-only which was a little
misleading since this flag is really used to detect when
it running via the hooks.

Review URL: https://codereview.chromium.org/1099003002

Cr-Commit-Position: refs/heads/master@{#329579}

BUG=449816

Review URL: https://codereview.chromium.org/1128683003

Cr-Commit-Position: refs/heads/master@{#329578}

BUG=485381

Review URL: https://codereview.chromium.org/1130113005

Cr-Commit-Position: refs/heads/master@{#329577}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/76a74c1..69b829f

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1138373003

Cr-Commit-Position: refs/heads/master@{#329576}

Cr-Commit-Position: refs/heads/master@{#329575}

This is used to rank apps and webstore results. This should not (really)
affect the relative ranking of any results, only the absolute scores
that they are assigned internally. However, this will be relevant in the
future when we start comparing scores of different types of results
against each other.

The algorithm (used to score app and webstore results) now has a
different tapering formula, designed to reach a higher score with fewer
keystrokes. Previously, it was based on the percentage of the full title
you had typed (which unfairly de-prioritized apps with long titles, such
as "Google Keep - notes and lists"). Now, it has an exponential curve,
so you get a reasonably high score with just a few letters matched, and
then it tapers off, approaching 1.0 as you type more letters.

BUG=422610

Review URL: https://codereview.chromium.org/1138193002

Cr-Commit-Position: refs/heads/master@{#329574}

BUG=486236
TEST=manually tested.

Review URL: https://codereview.chromium.org/1141563002

Cr-Commit-Position: refs/heads/master@{#329573}

There was no icon specified for the <paper-icon-button> for closing the WebUI. This adds the "close" icon for this <paper-icon-button>.

Review URL: https://codereview.chromium.org/1139663003

Cr-Commit-Position: refs/heads/master@{#329572}

The first is 1be16298:
"Clear the onMessage and onDisconnect listeners when their Extension Port is destroyed."
which was a fix to the original patch.

The second, original patch is 32b3a84b:
"Move the Extension Port implementation out of messaging.js into its own file port.js."

This is the key patch, which has caused no end of trouble. The goal was noble:
to fix the myriad of bugs which messaging has due to being written in JS not
C++. It appears that the moral of the story is: this is impossible, and the
hole we've dug in over the last 5 years cannot be recovered from (without a
complete rewrite, I suppose).

The last .5 of a patch was one of the tests added in
b9dca054 which will no longer pass.

BUG=486715,477323,475536
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1131043003

Cr-Commit-Position: refs/heads/master@{#329571}

BUG=485381
NOTRY=true

Review URL: https://codereview.chromium.org/1134553006

Cr-Commit-Position: refs/heads/master@{#329570}

BUG=485381

Review URL: https://codereview.chromium.org/1137103002

Cr-Commit-Position: refs/heads/master@{#329569}

BUG=485381

Review URL: https://codereview.chromium.org/1125343005

Cr-Commit-Position: refs/heads/master@{#329568}

This is a regression in https://codereview.chromium.org/1114633002c

BUG=485832
TEST=covered by unittests

Review URL: https://codereview.chromium.org/1132303005

Cr-Commit-Position: refs/heads/master@{#329567}

Quoting raymes: "What is happening is that while the
plugin is initializing it sends a sync IPC which results in re-entrancy.
ExecuteScript is being run during re-entrancy which runs a script on the page
which can result in layout changing and so reportGeometry can be called."

BUG=486674

Review URL: https://codereview.chromium.org/1137433004

Cr-Commit-Position: refs/heads/master@{#329566}

This matches the GYP build.

Review URL: https://codereview.chromium.org/1134833003

Cr-Commit-Position: refs/heads/master@{#329565}

There are more errors coming up after the latest libvpx roll.

TBR=oshima@chromium.org
BUG=468169

Review URL: https://codereview.chromium.org/1137993006

Cr-Commit-Position: refs/heads/master@{#329564}

Blink maintains state for popups whether they are hidden shown etc. So when a popup is shown and
an action causes the popup to be hidden then blink changes the state to hidden. If an action causes
the popup to be closed on the browser without notifying blink that the popup is going away due to focus
being lost on the parent view, then blink assumes that the popup is still visible.

As a result clicking again on a select box would just hide the popup as blink thinks the popup is visible.

This bug is only triggered in corner cases like ASH where you have one root window parenting everything else.
On regular desktop environments clicking outside the browser window while the popup is open would cause activation
changes to occur which would ensure that the Blur notification goes through to the browser.

The other change is a simple fix in delegate_execute which caused it to crash in debug mode on a multi dll build.
Crash occurred because we were looking for version information in base.dll while launching the crash server.

BUG=482937

Review URL: https://codereview.chromium.org/1136143005

Cr-Commit-Position: refs/heads/master@{#329563}

BUG=485381

Review URL: https://codereview.chromium.org/1132793005

Cr-Commit-Position: refs/heads/master@{#329562}

Sync changes could trigger UpdateDriveApps before DriveAppRegistry is
populated with data. An empty list from DriveAppRegistry causes all
Drive apps be uninstalled. And some Drive apps would cause Gaia cookies
to be lost.

BUG=449816
TEST=DriveAppProviderTest.UpdateAfterDriveAppRegistryUpdate

Review URL: https://codereview.chromium.org/1130903006

Cr-Commit-Position: refs/heads/master@{#329561}

BUG=485381

Review URL: https://codereview.chromium.org/1135733005

Cr-Commit-Position: refs/heads/master@{#329560}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6394784..76a74c1

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1128993006

Cr-Commit-Position: refs/heads/master@{#329559}

The "configurable" and "multipleMounts" should be optional and default to
false.

TEST=browser_tests: *FileSystemProvider*Configure*, *FileSystemProvider*Mount*
BUG=474146

Review URL: https://codereview.chromium.org/1127283003

Cr-Commit-Position: refs/heads/master@{#329558}

When one of the streams is much shorter than other(s), the
shorter stream reaches EOS first and then its media time
stops increasing, which blocks other streams due to using
BalancedMediaTaskRunner. Resetting the media task runner
will ensure other streams are not blocked by the shortest
one.

BUG=internal b/19560149

Review URL: https://codereview.chromium.org/1140003002

Cr-Commit-Position: refs/heads/master@{#329557}

This moves more of the transitive state of the tile to PrioritizedTile
which has a shorter lifetime, avoiding us to update properties on the
tile.

BUG=

Review URL: https://codereview.chromium.org/1132443003

Cr-Commit-Position: refs/heads/master@{#329556}