GitLab

Password setting page should show android URLs (e.g.
android://hash@com.example.android/path) in human readable form (android://com.example.android/path) for both saved passwords and exceptions.

BUG=486736

Review URL: https://codereview.chromium.org/1140943002

Cr-Commit-Position: refs/heads/master@{#329633}

The scroll restoration type is added to page state and serialized. It is used
by blink to control the scroll/scale restoration behaviour for history
entries. Its value may be provided by user via web-exposed API.

Blink side CL: http://crrev.com/927213004

BUG=444094

Review URL: https://codereview.chromium.org/959783003

Cr-Commit-Position: refs/heads/master@{#329632}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aeab899..09c7804

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/1138633003

Cr-Commit-Position: refs/heads/master@{#329631}

BUG=455847

Review URL: https://codereview.chromium.org/1111133002

Cr-Commit-Position: refs/heads/master@{#329630}

Update the V8 version to the one used for the upcoming Chromium branch M44.
If this CL results in failed tests please contact the test owners.
They most likely need to make changes to deal with the roll-back.

Original roll: https://crrev.com/1224d1ad48f94177798158fdc0e3e7faed8635ab

When in doubt please try to contact the committer.

TBR=machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,danno@chromium.org

Review URL: https://codereview.chromium.org/1136893003

Cr-Commit-Position: refs/heads/master@{#329629}

BUG=429756

Review URL: https://codereview.chromium.org/1131303003

Cr-Commit-Position: refs/heads/master@{#329628}

ShowSigninCommand is a command to perform a sign in operation.

Modernize other commands to use "instancetype", "NS_DESIGNATED_INITIALIZER",
"NS_UNAVAILABLE" for the initializers and "@synthetize" for the properties.

Remove unused ShowAccountsSettingsCommand.

BUG=429756

Review URL: https://codereview.chromium.org/1124173004

Cr-Commit-Position: refs/heads/master@{#329627}

BUG=486397
TEST=manually tested; Right click a folder on MTP volume, and confirmed that zip selection is disabled.

Review URL: https://codereview.chromium.org/1138973002

Cr-Commit-Position: refs/heads/master@{#329626}

BUG=484306

Review URL: https://codereview.chromium.org/1131943005

Cr-Commit-Position: refs/heads/master@{#329625}

BUG=487587

Review URL: https://codereview.chromium.org/1140923002

Cr-Commit-Position: refs/heads/master@{#329624}

Use the same logic as for normal Android app credentials to avoid displaying the lengthy hash part of android:// URIs.

BUG=486736

Review URL: https://codereview.chromium.org/1137283002

Cr-Commit-Position: refs/heads/master@{#329623}

Revert of Enable extension browser tests on debug windows. (patchset #1 id:1 of https://codereview.chromium.org/1128253005/)

Reason for revert:
 GcdPrivateAPITest.WifiPasswords fails after this patch.

Failure example:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37938

Original issue's description:
> Enable extension browser tests on debug windows.
>
> BUG=177163
>
> Committed: https://crrev.com/121cbb5f7fce9719ab6152cb2e059575df8139d6
> Cr-Commit-Position: refs/heads/master@{#329495}

TBR=asargent@chromium.org,hubbe@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=177163

Review URL: https://codereview.chromium.org/1134333003

Cr-Commit-Position: refs/heads/master@{#329622}

Application has this capability, kif tests should mirror it.

BUG=421798

Review URL: https://codereview.chromium.org/1135813006

Cr-Commit-Position: refs/heads/master@{#329621}

Revert of Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg (patchset #1 id:1 of https://codereview.chromium.org/1128913003/)

Reason for revert:
Doesnt fix GcdPrivateAPITest.WifiPasswords on win dbg:

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37945

Original issue's description:
> Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg
> TBR=vitalybuka
> BUG=177163
>
> Committed: https://crrev.com/81834cca312ad12091b40ebdab5ec9ca6db1c418
> Cr-Commit-Position: refs/heads/master@{#329615}

TBR=asargent@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=177163

Review URL: https://codereview.chromium.org/1125413007

Cr-Commit-Position: refs/heads/master@{#329620}

BUG=457697

Review URL: https://codereview.chromium.org/1132343003

Cr-Commit-Position: refs/heads/master@{#329619}

Use the same sourceid (chrome-mobile) for search on Google on Android and iOS.

BUG=None

Review URL: https://codereview.chromium.org/1134213002

Cr-Commit-Position: refs/heads/master@{#329618}

The AppCompat RadioButton has a bug that is being fixed.

BUG=474695

Review URL: https://codereview.chromium.org/1138183003

Cr-Commit-Position: refs/heads/master@{#329617}

The test appears to get stuck on waiting for black frames. This patch
adds some logging so we perhaps can learn more where in the image we
find the nonblack pixels. Also trying to increase tolerance for
rounding errors somewhat to see if that helps.

BUG=477498

Review URL: https://codereview.chromium.org/1108803002

Cr-Commit-Position: refs/heads/master@{#329616}

TBR=vitalybuka
BUG=177163

Review URL: https://codereview.chromium.org/1128913003

Cr-Commit-Position: refs/heads/master@{#329615}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e886fb..aeab899

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/1126313007

Cr-Commit-Position: refs/heads/master@{#329614}

Revert of Revert of Drive: Let DriveUploader use batch request API. (patchset #1 id:1 of https://codereview.chromium.org/1135353004/)

Reason for revert:
The failure is not caused by the patch. MigrationSingleClientTest.AllTypesIndividually looks flaky.

Original issue's description:
> Revert of Drive: Let DriveUploader use batch request API. (patchset #7 id:120001 of https://codereview.chromium.org/1134633003/)
>
> Reason for revert:
> MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN:
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327
>
> Original issue's description:
> > Drive: Let DriveUploader use batch request API.
> >
> > The CL lets DriveUploader use batch request API. DriveUploader does asynchronous
> > preparation before calling API on service interface. To hold batch request
> > during the asynchronous preparation, the CL introduce refcounted hepler class,
> > which manages life time of batch request configurator.
> >
> > BUG=451917
> > TEST=DriveUploaderTest
> >
> > Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0
> > Cr-Commit-Position: refs/heads/master@{#329599}
>
> TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=451917
>
> Committed: https://crrev.com/e244812ae9a09d001f24f9aaaf780c80f976d790
> Cr-Commit-Position: refs/heads/master@{#329610}

TBR=kinaba@chromium.org,tzik@chromium.org,sergeyv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451917

Review URL: https://codereview.chromium.org/1138883004

Cr-Commit-Position: refs/heads/master@{#329613}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/75d0e9b..4e886fb

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/1136713004

Cr-Commit-Position: refs/heads/master@{#329612}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eaa355a9..15c8b709

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1124053004

Cr-Commit-Position: refs/heads/master@{#329611}

Revert of Drive: Let DriveUploader use batch request API. (patchset #7 id:120001 of https://codereview.chromium.org/1134633003/)

Reason for revert:
MigrationSingleClientTest.AllTypesIndividually is broken by this change on Linux GN:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28327

Original issue's description:
> Drive: Let DriveUploader use batch request API.
>
> The CL lets DriveUploader use batch request API. DriveUploader does asynchronous
> preparation before calling API on service interface. To hold batch request
> during the asynchronous preparation, the CL introduce refcounted hepler class,
> which manages life time of batch request configurator.
>
> BUG=451917
> TEST=DriveUploaderTest
>
> Committed: https://crrev.com/9cf453b74c8790f6d7a91f958ec998a9fa5a1fa0
> Cr-Commit-Position: refs/heads/master@{#329599}

TBR=kinaba@chromium.org,tzik@chromium.org,hirono@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451917

Review URL: https://codereview.chromium.org/1135353004

Cr-Commit-Position: refs/heads/master@{#329610}

To avoid wide image becomes blurry thumbnail, crop image at image_loader.
Currently it is used only for thumbnails, we only support to crop an image into square.

BUG=480679
TEST=ImageLoaderJsTest.ImageLoaderTest

Review URL: https://codereview.chromium.org/1137993007

Cr-Commit-Position: refs/heads/master@{#329609}

As a side effect, this _immediately_ updates the last used profile to a new
path if necessary, so synchronous profile loading will create a new profile there instead of
opening the old profile while it is in the process of being deleted.

BUG=479309,425785,483528

Review URL: https://codereview.chromium.org/1113333003

Cr-Commit-Position: refs/heads/master@{#329608}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/be87f1c..75d0e9b

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/1137693005

Cr-Commit-Position: refs/heads/master@{#329607}

- ContinueSessionRestore() should ensure SESSION_RESTORE_PREPARING state.
  Otherwise, /MergeSession is not called after /ListAccount because it would
  not be considered as is_pre_merge;
- Cover SESSION_RESTORE_PREPARING state in connection change event;

BUG=487476

Review URL: https://codereview.chromium.org/1137253003

Cr-Commit-Position: refs/heads/master@{#329606}

This runs the full suite of tests with the AppListMixer field trial set
to both "default" and "Blended", for full coverage of both code paths.

Also, MixerTest.Basic now has different expectations in the "Blended"
case, because the mixing behaviour has (deliberately) changed.

BUG=487494

Review URL: https://codereview.chromium.org/1128683005

Cr-Commit-Position: refs/heads/master@{#329605}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/24dae38..be87f1c

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1126333004

Cr-Commit-Position: refs/heads/master@{#329604}

BUG=485955
NOTRY=true
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1137763003

Cr-Commit-Position: refs/heads/master@{#329603}

The goal is to remove all dependencies from test_runner on content

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1140863002

Cr-Commit-Position: refs/heads/master@{#329602}

Adds the "AppListMixer" Finch experiment, affecting the search result
ranking and mixing in the App Launcher. By default, the mixer behaves
exactly as before. With the "Blended" option, results are selected and
ordered more naturally according to their relevance to the query, rather
than in arbitrary groups ("apps, then omnibox, then webstore, then
people").

Specific changes under the "Blended" option:

- Replaced the per-group "boost" with a per-group "multiplier". Now,
  instead of stratifying results from each group, they are mixed
  together according to the relevance score assigned by the provider.
  Some groups have a multiplier to de-prioritize them (people results
  x0.85, webstore results x0.4). This means that relevance scores now
  need to be comparable between groups!

- Removed the 6-result limit from the mixer. It can now return an
  arbitrary number of results, which will later be truncated by the
  view. (This is necessary because the view now supports more than 6
  results, since all app results take up a single row.)

- The per-group limit is now a "soft" limit. If there aren't enough
  total results to fill a minimum quota of 6, we go back and get as many
  results as we can from each group.

- The omnibox group is no longer special. Previously, it had no limit,
  but would only provide more than 1 result if there was room. Now, it
  has a soft limit of 4, and behaves the same as other groups (can
  provide more results if necessary).

Can be enabled with --force-fieldtrials=AppListMixer/Blended.

BUG=487494,460451,422610,338418

Review URL: https://codereview.chromium.org/1113483002

Cr-Commit-Position: refs/heads/master@{#329601}

Cr-Commit-Position: refs/heads/master@{#329600}

The CL lets DriveUploader use batch request API. DriveUploader does asynchronous
preparation before calling API on service interface. To hold batch request
during the asynchronous preparation, the CL introduce refcounted hepler class,
which manages life time of batch request configurator.

BUG=451917
TEST=DriveUploaderTest

Review URL: https://codereview.chromium.org/1134633003

Cr-Commit-Position: refs/heads/master@{#329599}

BUG=378127
R=kalman@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1137783005

Cr-Commit-Position: refs/heads/master@{#329598}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9fa4ee7..24dae38

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1130653005

Cr-Commit-Position: refs/heads/master@{#329597}

BUG=

Review URL: https://codereview.chromium.org/1134013004

Cr-Commit-Position: refs/heads/master@{#329596}

These tests are timing out.

TBR=oshima@chromium.org
BUG=487501

Review URL: https://codereview.chromium.org/1134043006

Cr-Commit-Position: refs/heads/master@{#329595}

Revert of Use cert config options in SSLServerSocketOpenSSL. (patchset #4 id:80001 of https://codereview.chromium.org/1138813003/)

Reason for revert:
It seems like this change has caused new leaks on Linux and ChromeOS.

First build it appeared: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/41241

Log output:
Memcheck:Leak
fun:calloc
fun:PORT_ZAlloc_Util
fun:ConvertToSID
fun:ServerSessionIDLookup
fun:ssl3_HandleClientHello
fun:ssl3_HandleHandshakeMessage
fun:ssl3_HandleHandshake
fun:ssl3_HandleRecord
fun:ssl3_GatherCompleteHandshake
fun:SSL_ForceHandshake
fun:_ZN3net18SSLServerSocketNSS11DoHandshakeEv
fun:_ZN3net18SSLServerSocketNSS15DoHandshakeLoopEi
fun:_ZN3net18SSLServerSocketNSS21OnHandshakeIOCompleteEi
fun:_ZN3net18SSLServerSocketNSS14OnRecvCompleteEi
fun:_ZN3net18SSLServerSocketNSS18BufferRecvCompleteEi

This might be tickling some bug in underlying libraries, or it might be a problem with the change itself.

You can reproduce the leak by running valgrind and running all the SSLServerSocket tests. I didn't narrow down which test.

See https://www.chromium.org/developers/how-tos/using-valgrind for more details on using valgrind.

Original issue's description:
> Use cipher suite config options in SSLServerSocketOpenSSL.
>
> Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
> list and require_forward_secrecy flag from SSLConfig. Fixed
> SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.
>
> BUG=481163
>
> Committed: https://crrev.com/d0eae58087e6f45088d6ef349d9ebaa2da450ea1
> Cr-Commit-Position: refs/heads/master@{#329528}

TBR=davidben@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481163

Review URL: https://codereview.chromium.org/1131573005

Cr-Commit-Position: refs/heads/master@{#329594}