- 27 Aug, 2014 40 commits
-
-
rdevlin.cronin authored
Since we've consolidated most of the extension action execution code, this object is rather unneeded. Remove it. BUG=407665 Review URL: https://codereview.chromium.org/508563003 Cr-Commit-Position: refs/heads/master@{#292177}
-
xians authored
Revert of Used native deinterleaved and float point format for the input streams. (patchset #5 of https://codereview.chromium.org/501823002/) Reason for revert: It broke the mac asan bot, http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/1976 Original issue's description: > Used native deinterleaved and float point format for the input streams. > > If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output. > > This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac. > > > BUG=404884 > TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html > > Committed: https://chromium.googlesource.com/chromium/src/+/1a9ce977642c7f2cc2e30d83757c42264f052f0b TBR=dalecurtis@chromium.org,eroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=404884 Review URL: https://codereview.chromium.org/514773002 Cr-Commit-Position: refs/heads/master@{#292176}
-
dongseong.hwang authored
Mesa GL driver supports GL_ARB_texture_storage extensions, not GL_EXT_texture_storage. GLES3 supports glTexStroage2D by default. GLES3 doesn't support BGRA format for immutable texture without GL_APPLE_texture_format_bgra8888 extension. We prefer BGRA support to immutable texture support, so GLES3 enables immutable texture only if it supports GL_APPLE_texture_format_bgra8888. In addition, currently the compositor blindly uses BGRA on glTexStorage2D. It can cause a potential bug so this CL checks BGRA format support to use BGRA on glTexStorage2D. This CL makes Intel GPU (e.g. Intel Chromebook) and GLES3 devices with GL_APPLE_texture_format_bgra8888 extension take advantage of immutable texture. BUG=407034 Review URL: https://codereview.chromium.org/499283002 Cr-Commit-Position: refs/heads/master@{#292175}
-
horo authored
BUG=402387 Review URL: https://codereview.chromium.org/492603002 Cr-Commit-Position: refs/heads/master@{#292174}
-
davidben authored
The 'ssl_lib_error' value reported is rather uninteresting. OpenSSL is has two levels of errors. The one we were logging is almost always 1. Make the error callback SSL-implementation-specific and include the library code, reason code, file name, and line number, all of which OpenSSL already tracks. BUG=286480 Review URL: https://codereview.chromium.org/494913002 Cr-Commit-Position: refs/heads/master@{#292173}
-
vmpstr authored
R=nduca Review URL: https://codereview.chromium.org/507103002 Cr-Commit-Position: refs/heads/master@{#292172}
-
mlamouri authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180956%3A180973&mode=html TBR=gavinp@chromium.org BUG=None Review URL: https://codereview.chromium.org/508153002 Cr-Commit-Position: refs/heads/master@{#292171}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/506163002 Cr-Commit-Position: refs/heads/master@{#292170}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/506883003 Cr-Commit-Position: refs/heads/master@{#292169}
-
starodub authored
Re-recording other tests may be required. BUG=370977 Review URL: https://codereview.chromium.org/491863003 Cr-Commit-Position: refs/heads/master@{#292168}
-
yhirano authored
blink::WebSocket assumes that any APIs won't be called once disconnect is called, but PepperWebSocketHost didn't keep the contract. Note that PepperWebSocketHost can receive SEND* / CLOSE messages even if it sends a CLOSED message to the ppapi process, because these IPCs are asynchronous. BUG=407885 R=ricea@chromium.org Review URL: https://codereview.chromium.org/510663002 Cr-Commit-Position: refs/heads/master@{#292167}
-
machenbach authored
TBR=vogelheim@chromium.org Review URL: https://codereview.chromium.org/510653003 Cr-Commit-Position: refs/heads/master@{#292166}
-
igsolla authored
exitFullScreen() might be call without a prior call to enterFullScreen() if a "misbehave" app overrides onShowCustomView but does not add the custom view to the window. This fixes a crash by returning early from exitFullScreen in that case. BUG=408133 Review URL: https://codereview.chromium.org/501093007 Cr-Commit-Position: refs/heads/master@{#292165}
-
Steven Bennetts authored
BUG=none R=xiyuan@chromium.org Review URL: https://codereview.chromium.org/506313003 Cr-Commit-Position: refs/heads/master@{#292164}
-
skare authored
BUG=407860 NOTRY=True Review URL: https://codereview.chromium.org/480563003 Cr-Commit-Position: refs/heads/master@{#292163}
-
Robert Sesek authored
In the near future, Crashpad (the new Mac crash reporter) will be integrated, and it should be integrated/exposed transparently to the users of this component. BUG=406410 R=blundell@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/485893007 Cr-Commit-Position: refs/heads/master@{#292162}
-
mcasas authored
BUG=408089 Review URL: https://codereview.chromium.org/511863002 Cr-Commit-Position: refs/heads/master@{#292161}
-
marja authored
It's trying to use a member variable which doesn't exist, and thus throwing an exception every time it's used. The brokenness was introduced by r290923 ( https://codereview.chromium.org/404803003/ ). BUG= Review URL: https://codereview.chromium.org/508923002 Cr-Commit-Position: refs/heads/master@{#292160}
-
jiangj authored
Missing GL_TEXTURE_RECTANGLE_ARB definition if gl.h or glext.h is not included. Review URL: https://codereview.chromium.org/511793002 Cr-Commit-Position: refs/heads/master@{#292159}
-
rdevlin.cronin authored
It looks like a SetBorder(NULL) crept into https://codereview.chromium.org/324393002, and the result is that the chevron hover effect (i.e., draw a border) is overridden. Remove the call to SetBorder(). BUG=407518 Review URL: https://codereview.chromium.org/492373004 Cr-Commit-Position: refs/heads/master@{#292158}
-
mtklein authored
This is our first attempt, mostly to feel this out. Performance and correctness problems are both possible. Please revert this if a benchmark even smells funny. That said, we've been working on this a while, are pretty confident it's good stuff, and have had Skia's internal testing entirely switched over for a week. Parts of Chromium that serialize and deserialize SkPictures are already switched over. This CL finishes things off by switching the default recorded-from-scratch SkPicture to use SkRecord too. BUG= Review URL: https://codereview.chromium.org/504823003 Cr-Commit-Position: refs/heads/master@{#292157}
-
nasko authored
This CL adds support for collecting tracing data during the execution of browser tests. It is currently not possible to do so, yet it is very useful to be able to collect this data and analyze it without having to step through with debugger. BUG= Review URL: https://codereview.chromium.org/506113002 Cr-Commit-Position: refs/heads/master@{#292156}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/5e8dbd31de0dff44aff83295bdfe518477a5a088..4473be874f70d4a8833180a7aebcc9d8a0b1de9e CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel TBR=djsollen@google.com Review URL: https://codereview.chromium.org/508113002 Cr-Commit-Position: refs/heads/master@{#292155}
-
qsr authored
This CL allows to generate Stub and Proxy of mojo service in java. This allows to call interfaces method through message pipes. Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57 Review URL: https://codereview.chromium.org/411913002 Cr-Commit-Position: refs/heads/master@{#292154}
-
dconnelly authored
It turns out specifying a "when" option is required, or it throws an exception :( BUG= Review URL: https://codereview.chromium.org/512683002 Cr-Commit-Position: refs/heads/master@{#292153}
-
https://codereview.chromium.org/498123002/dmichael authored
Reason for revert: I should've checked sooner; this is apparently still used by Flash. (See go/UMA, histograms, Pepper.InterfaceUsed) Original issue's description: > Remove unused PPB_View_Dev > > TBR=binji@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/2210d5fb49cd4b75972f2e304b29637c050de4f1 TBR=binji@chromium.org,raymes@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/512703003 Cr-Commit-Position: refs/heads/master@{#292152}
-
xians authored
If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output. This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac. BUG=404884 TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html Review URL: https://codereview.chromium.org/501823002 Cr-Commit-Position: refs/heads/master@{#292151}
-
noyau authored
BUG=None Review URL: https://codereview.chromium.org/456793002 Cr-Commit-Position: refs/heads/master@{#292150}
-
torne authored
Update to a recent version of AOSP master. The primary effect on Chromium is that the android_aosp bot will now use a recent version of clang when building chromium targets for host and thus we no longer need to support using gcc 4.2 or 4.6 to compile host code here. BUG=377684 NOTRY=true Review URL: https://codereview.chromium.org/514653002 Cr-Commit-Position: refs/heads/master@{#292149}
-
petarj authored
Add missing variables (android_ndk_*) for building Chromium for MIPS64. In addition to this, set default mips_arch_variant-s for different MIPS platforms. BUG=400684 Review URL: https://codereview.chromium.org/494713002 Cr-Commit-Position: refs/heads/master@{#292148}
-
wjmaclean authored
HostZoomMap will be moving from BrowserContext to StoragePartition soon as part of fixing this bug. Many sites will still want to access the default HostZoomMap for a BrowserContext, so we will rename this function in order to be clear about that. BUG=335317 Review URL: https://codereview.chromium.org/506073002 Cr-Commit-Position: refs/heads/master@{#292147}
-
tfarina authored
ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern). ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi ui_unittests.isolate -> ui_base_tests.isolate Add a TODO assigned to me to rename ui_unittests target to ui_base_unittests when buildbot is updated. BUG=331829,373148,299841,103304 TEST=ui_unittests R=sky@chromium.org Review URL: https://codereview.chromium.org/506483002 Cr-Commit-Position: refs/heads/master@{#292146}
-
bruthig authored
BUG=395622 TEST=automated Review URL: https://codereview.chromium.org/454173002 Cr-Commit-Position: refs/heads/master@{#292145}
-
mcasas authored
BUG= Review URL: https://codereview.chromium.org/512713002 Cr-Commit-Position: refs/heads/master@{#292144}
-
mlamouri authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180903:180956&mode=html TBR=gavinp@chromium.org BUG=None Review URL: https://codereview.chromium.org/513753002 Cr-Commit-Position: refs/heads/master@{#292143}
-
perkj authored
Reland WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo originally landed in https://codereview.chromium.org/442313002/ The only difference is that the test has been disabled on DrMemory since it times out. Notice that many WebRtcBrowsertests are disabled due to the same reason. BUG= 403070, 398844 Review URL: https://codereview.chromium.org/478543004 Cr-Commit-Position: refs/heads/master@{#292142}
-
mtklein authored
We're getting away without checking bounds today because we're building and checking a bounding-box hierarchy at record time; draws outside the picture bounds happen to never be recorded. This isn't a guarantee of the recording API, and indeed doesn't happen if you record without a bounding-box hierarchy. We want to lean on this lack of guarantee a bit more. To cut down on time spent recording, we may move around when we build a bounding box hierarchy. The upshot is that the SkPicture may contain commands that won't draw anything, and AnalysisCanvas might receive them. In short, the safe thing to do is quickReject just like SkCanvas does. tested: cc_unittests, unit_tests (Background: found this when debugging PicturePileImplTest.AnalyzeIsSolid* failures from http://crrev.com/504823003) BUG= Review URL: https://codereview.chromium.org/505263002 Cr-Commit-Position: refs/heads/master@{#292141}
-
tdresser authored
BUG=None Review URL: https://codereview.chromium.org/504183005 Cr-Commit-Position: refs/heads/master@{#292140}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#292139}
-
bartfab authored
This CL switches CryptohomeAuthenticator's mount code from the old MountAsync() method that takes a password to a MountEx() that takes a Key for authentication. BUG=367847 TEST=Updated unit tests Review URL: https://codereview.chromium.org/488633003 Cr-Commit-Position: refs/heads/master@{#292138}
-