GitLab

This still leaves memory_instrumentation in the RC service, hosted
by content and the relevant dependencies. All dependencies to the
RC coordination unit graph are however scrubbed.

Bug: 910288
Change-Id: I6744d2f8d42ad8c88458b531057ada0c4c2ba01a
Reviewed-on: https://chromium-review.googlesource.com/c/1425042
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626180}

Previously introduced WebNavigationBodyLoader is now used for
loading the navigation request body, instead of faking the
WebURLRequest.

Brief list of changes in this patch:
- WebNavigationParams take a bunch of request- and response-related
  fields instead of WebURLRequest.
- RenderFrameImpl fills the params instead of constructing a fake
  WebURLRequest, and constructs NavigationBodyLoader.
- DocumentLoader synchronously processes params, and then starts
  body loader to receive the main resource data. Multiple places
  in Blink are interested in main resource loading process, so
  DocumentLoader notifies them by calling DispatchXXX methods
  on FrameFetchContext. We should be able to clean this up later
  if needed.
- webkit_unit_tests mimic production and create a body loader
  of their own.
- Some unrelevant test cases are removed (e.g. checking main
  resource request priority).

With this patch we are just two steps away from committing
navigation synchronously:
- Preload mhtml archives in advance to retrieve the mime type of
  the main document.
- Move commit from "received first byte" to "handle response" step.

Things which could be cleaned up:
- Elegantly notify interested parties about main resource load.
- Simplify the loading flow in DocumentLoader, making it linear.
  Currently, we keep the flow similar to original one, where we
  call StopLoading() from various places to minimize the CL and
  potential risk.

This patch corresponds to step 6.g of the doc linked in the bug.

TBR=mmenke@chromium.org

Bug: 855189
Change-Id: I379172a94d2d59f694d0cbb99f22b147339a5090
Reviewed-on: https://chromium-review.googlesource.com/c/1401238
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626179}

BUG=804637
R=thestig

Change-Id: Ia478f17bdc0ab07243a94fca6092b63d3cbaabfd
Reviewed-on: https://chromium-review.googlesource.com/c/1437479
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626178}

The cpu_profiler category is disabled by default.
This entry is not useful and is adding confusion
to users when reporting traces on bugs.

R=oysteine@chromium.org

Change-Id: I8d272dccf9307739d8cb5d95aa830357219ae31f
Reviewed-on: https://chromium-review.googlesource.com/c/1435747Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626177}

Bug: 924785
Change-Id: Ia077d4d43baf974df46baa64632254e95a9ec6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1432883
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626176}

The //fuchsia:webrunner_pkg was moved to
//fuchsia/runners:web_runner_pkg but a reference to the old target was
still present in //fuchsia:action. This fixes the issue.

Bug: 922635
Change-Id: I29733695ef4dcbe1e84ae1b3be51754ed69b5297
Reviewed-on: https://chromium-review.googlesource.com/c/1435700
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626175}

The mojom category is needed to debug what is happening on the IO/Thread.
We are seeing janks related to communications between renderers, browser
and GPU. We believe the mojom categoy will help us doing investigation.

R=oysteine@chromium.org

Bug: 867931
Change-Id: Ic01d67ca82cf60e949793eaf5ac1a09486452519
Reviewed-on: https://chromium-review.googlesource.com/c/1437065Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626174}

According to the new RobolectricTestRunner(haven't updated yet): https://github.com/robolectric/robolectric/blob/robolectric-4.1/robolectric/src/main/java/org/robolectric/RobolectricTestRunner.java#L98
seems getJarResolver() called in the constructor which will check system property "robolectric.offline" for DependencyResolver.

Bug: 900746
Change-Id: Ia05f0028330b8633a9fe329824d1a97e18f37e50
Reviewed-on: https://chromium-review.googlesource.com/c/1436557Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#626173}

JSON manifests are deprecated.

Bug: 895616
Change-Id: If5306731b0bae4cb12dba636e8a70aef87766514
TBR: halliwell@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1436734
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626172}

There are lots of unused includes. Also modernize the code slightly.

Change-Id: I55fea71019682e39a018f211c33f71db3543901a
Reviewed-on: https://chromium-review.googlesource.com/c/1435722Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626171}

The web view load scheduled by WKBasedNavigationManager::Restore() is
deferred when used in CWVWebView's |resetWebStateWithSessionStorage|
because the |_containerView| is not created until later. This CL calls
LoadIfNecessary() explicitly after the view is created to trigger the
session restoration.

This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
enabled. A better approach would be to turn this test into a
programmatic test so both navigation managers implementations are
tested, but web::features symbols are not exposed in ios/web_view.

Bug: 862714
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet
Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111
Reviewed-on: https://chromium-review.googlesource.com/c/1135435
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626170}

When connecting touch devices via a USB-C cable, the touch-display
pairing may fail. This happens specifically when multiple external
displays are connected. The only way to resolve this is by performing
a manual calibration.

The default heuristic that pairs touch controllers and displays
connected via the USB fails since the display is actually connected
via the display link interface rather than the USB. The display is
thus listed as an evdi device when the pairing happens.

This patch changes the way we identify USB devices and lists evdi
displays as USB displays instead.

Bug: 925211
Change-Id: I2568d41360f6f23465fd28314d5602f29f562204
Component: Touch device manager, evdi, usb, pairing
Reviewed-on: https://chromium-review.googlesource.com/c/1435758
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626169}

Using wpt-import in Chromium 8427edc8.
With Chromium commits locally applied on WPT:
f643497e "[resource-timing] Modify is_secure_context_ based on resource"
20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix"
40748e1e "Upstream fast/workers to external/wpt/workers: first batch."
6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
andruud@chromium.org:
  external/wpt/css/css-properties-values-api
bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org:
  external/wpt/css/css-conditional
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I1578fb80b8b4d56d239c08fdcc5cf60173cbc359
Reviewed-on: https://chromium-review.googlesource.com/c/1437066Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626168}

Flushing after every sequence of command, which is sufficient to work
around this crash without OOP-R, did not work around this crash.
Now flush at every command.

The flowchart for interpreting these results is
- If this does not fix the issue: Add crash instrumentation to see what
  command is causing the crash.
- If this fixes the issue: See if we can "bisect" which commands need
  to be flushed in order for this to be fixed.

Bug: 906453
Change-Id: Ic60833d4c4e15f7c9eed18ca5b6267e275ae6dec
Reviewed-on: https://chromium-review.googlesource.com/c/1436591Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626167}

This is intended as a decent introduction for folks who have to work on
AppCache.

Change-Id: I153251d0128f58261fa9e3c66339982b0bf4493d
Reviewed-on: https://chromium-review.googlesource.com/c/1424220
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626166}

TBR=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I0ec929c7bac23f8a5f5bf3e53d2f4aa38bb35db8
Reviewed-on: https://chromium-review.googlesource.com/c/1361336
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626165}

No behavior change expected.

compile_resources.py takes almost exclusively build intermediates as
inputs (all except for link config, which rarely changes), and so
md5_check was just adding complexity & overhead.

Adding AtomicOutput should improve robustness & reduce overbuilds in a
more effective way, as well as protect against Ctrl-C at unfortunate
times.

Change-Id: Iee179fb3b693e8f2b98399b365537ff7aec27b13
Reviewed-on: https://chromium-review.googlesource.com/c/1436736
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626164}

Bug: 916726
Change-Id: I2b09a0d9c7b3f6b716bb250a68b2cbada1d472d3
Reviewed-on: https://chromium-review.googlesource.com/c/1427463
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626163}

This CL effectively reverts the refactoring in
https://chromium-review.googlesource.com/c/chromium/src/+/1185218/. It
extracts the lower level decode code so that it can be used (later) to
implement a gpu::ImageDecodeAcceleratorWorker that decodes JPEGs using
the VAAPI.

A VaapiJpegDecoder class is created to contain this lower level code. In
a follow-up CL, this class is expanded to be responsible for dealing
with the VaapiWrapper and surface creation.

This opportunity is used to fix some includes and build dependencies.
Additionally, some code health fixes are done, the most significant
being getting rid of memset in the Fill*() methods.

Bug: 924310
Test: the VaapiJpegDecoderTest unit tests pass on a nocturne.
Change-Id: Idf207e9f81385611e84069e229a0e59eec2479ec
Reviewed-on: https://chromium-review.googlesource.com/c/1424401Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626162}

https://pdfium.googlesource.com/pdfium.git/+log/e24ead1a8947..f0898a22bff3


git log e24ead1a8947..f0898a22bff3 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 tsepez@chromium.org Remove CJX_ classes that do not meaningfully extend CJX_Container.


Created with:
  gclient setdep -r src/third_party/pdfium@f0898a22bff3

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib2fbeadb148daafaa61d8411e3f6ab9650dece65
Reviewed-on: https://chromium-review.googlesource.com/c/1437008Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626161}

SVG elements don't participate in the normal layout algorithms and are
more likely to be used for animations.

Bug: 581518
Change-Id: I66c811d32fabff6c181629b82a9798a9e9d60995
Reviewed-on: https://chromium-review.googlesource.com/c/1437104
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626160}

This CL merges the SOCKSClientSocketPool with the
TransportClientSocketPool it used to sit above. In doing this, the
SOCKSClientSocketPool class is removed, in favor of a
TransportClientSocketPool. SOCKSConnectJobs now directly create
TransportConnectJobs, instead of going through a socket pool.

This doesn't affect any other socket pools - there's still an SSL socket
pool on top of the socket pool for a SOCKS proxy, for instance.

This is part of an effort to flatten the socket pools.
https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit

Bug: 472729
Change-Id: I22f808bb67372d0f9dd843bae9c70006f553b04b
Reviewed-on: https://chromium-review.googlesource.com/c/1417719
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626159}

Change-Id: I94a3e7c5f8e89e2d2080024755cdc4a5f87ad92f
Reviewed-on: https://chromium-review.googlesource.com/c/1437396Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626158}

Bug: 921548
Change-Id: I1406ddf0284dac2d007d71f4b7acac23d72c6a63
Reviewed-on: https://chromium-review.googlesource.com/c/1436203
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626157}

This deadlock situation is not reproducable and we don't have any
understanding of how perfetto would add a task to the scheduler's
sequence manager rather then the task manager. We suspect that this is
no longer an issue.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=839073
Change-Id: Id56e2f3bed30e29abb0c05e668ef9abbafda909f
Reviewed-on: https://chromium-review.googlesource.com/c/1433771
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626156}

Rather than blindly assigning "nested-document", we ought to examine the
state of the frame's owner to determine whether it might potentially end
up executing as a plugin, and report the value in the header accordingly.

Bug: 860510
Change-Id: I78291d8209382fbd325f4d8e72b24c6444fe25b6
Reviewed-on: https://chromium-review.googlesource.com/c/1432955
Auto-Submit: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626155}

https://chromium.googlesource.com/angle/angle.git/+log/59b1ed4a60fc..59d756e530c5


git log 59b1ed4a60fc..59d756e530c5 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 geofflang@chromium.org Vulkan: Add a test for scissored depth and stencil clears.


Created with:
  gclient setdep -r src/third_party/angle@59d756e530c5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I6f0124bb79e82c6fd08aa392b903462c0bccf28e
Reviewed-on: https://chromium-review.googlesource.com/c/1437005Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626154}

This also adds it to the whitelist used in
third_party/blink/renderer/DEPS

Gab/Francois, I've used your refactoring script for this, the rule is:
  matches = re.compile(r'(\n *[^/\n][^/\n]*(base::DoNothing|base::NullCallback)\b[^*])', re.DOTALL).findall(content)

  if not matches:
    return False

  updated_content = refactor_lib.AddInclude(file_path, content, "base/bind_helpers.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

TBR=gab@chromium.org

Change-Id: I33e347d3000efd43d567ecf0cc025614ff9cfeed
Reviewed-on: https://chromium-review.googlesource.com/c/1437335
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626153}

It is unknown when, but an update to Windows 10 changed the name
of Windows Defender to Windows Defender Antivirus.

Bug: 682286
Change-Id: I3202896859fd3018d276dc1f30f1704e67c6d6d5
Reviewed-on: https://chromium-review.googlesource.com/c/1432092Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626152}

This is to address the comment
https://chromium-review.googlesource.com/c/aosp/platform/external/libchrome/+/1387893/2/components/timers/alarm_timer_chromeos.h#45

Instead of just upstreaming it, which exposes a method unused in Chromium,
this CL introduces Create() factory method and drops the code to
fallback in case of timerfd_create failure.

Now, a caller should check whether Create() returns null or not.
In case of null, to keep the previous behavior, the caller can
create an instance of the parent class.

Along with the change, in order to run unittest for the class
without capability CAP_WAKE_ALARM, this CL also introduces CreateForTesting().
We used to test just fall-back code paths.

In addition, this CL fixes the FD leak on destruction.

BUG=None
TEST=Build and run components_unittests --gtest_filter=AlarmTimerTest*. Run try.

Change-Id: Ieb9660335120565ccff7f192d7a8192ca1e59ebc
Reviewed-on: https://chromium-review.googlesource.com/c/1411356Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626151}

The Fuchsia platform now properly sets errno EOPNOTSUPP when invoking
setsockopt with IP_MULTICAST_IF. This ignores the error to unblock the
Fuchsia SDK roll.

Bug: 924792
Change-Id: Icf6b430d5c22f9c5b7302f74b662592db65f13b7
Reviewed-on: https://chromium-review.googlesource.com/c/1435978Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626150}

Record counts for number of ad frames that have a display:none style
set. Record the pixel dimensions of the ad frames. These numbers will
be useful to identify cutoff points for visible advertisements.

Most AdsPageLoadObserver metrics are skewed low. With some
UKM and manual verification, it was seen this is at least in part due
to counting very  small frames (e.g. 1 pixel by 1 pixel) and counting
frames which are not displayed to users. These metrics are necessary
to filter out these frames in the future.

Because display: none is tied to frame elements not having content views,
and all frame views are removed in a same process navigation, we also
need to plumb ReadyToCommitNavigation to the PLM observers so we are
not reporting frames that were visible during the page's lifetime
as display: none.

Bug: 924357
Change-Id: I2fa4126e5d7b26459d8250399980736441ffee37
Reviewed-on: https://chromium-review.googlesource.com/c/1431713
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626149}

Native pages do not have a URL in the omnibox by default. In these
cases we shouldn't show the edit-url suggestion. The side effect of
this is text in the omnibox being erased while typing a url.

Bug: 925350
Change-Id: I3783ca598aa289a0ece268b54cd21c52036b7de7
Reviewed-on: https://chromium-review.googlesource.com/c/1437177Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626148}

Uses ThumbnailCache's DecompressThumbnailFromFile to read, decompress
and return tab thumbnails on the Java side.

Change-Id: Ia3905cf2f3aa859318897db0fcb2d1b489a7827a
Reviewed-on: https://chromium-review.googlesource.com/c/1423702Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626147}

This reverts commit 5fe5e428.

Reason for revert: CL that broke the tests was reverted.

Original change's description:
> Disable two flaky NetworkContextConfiguration browser tests
> 
> TBR: mmenke@chromium.org
> Bug: 922876
> Change-Id: I7aa180a67d2d8cae122b4472df80659914912b81
> Reviewed-on: https://chromium-review.googlesource.com/c/1417756
> Commit-Queue: Ian Clelland <iclelland@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Auto-Submit: Ian Clelland <iclelland@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623727}

TBR=rockot@google.com,mmenke@chromium.org,iclelland@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 922876
Change-Id: Ic436c92a89e6ed8bb7f25d7f9e80ed4a31c2d5b8
Reviewed-on: https://chromium-review.googlesource.com/c/1437256Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626146}

I added the tests to understand WeakIdentifieryMap behavior, e.g.
whether the map entry will be automatically removed when the object is
garbage collected, etc. The tests look also helpful for others.

Also simplify WeakIdentifierMap by removing the non-garbage-collecting
version which didn't look working. I tried that in test and the compiler
reported error requiring the type to be garbage collected.

Change-Id: Ic3f8d99d19d526d1a7a8e3940cf2e117323b9c20
Reviewed-on: https://chromium-review.googlesource.com/c/1435536
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626145}

Instantiate these instances when needed since the flow can be short,
especially when the intent is from Chrome, like abort on onboard screen
or failed to get scripts or do not accept the script.

Bug: 806868
Change-Id: Ib72e90a72bd8539376e54ec0a6615a14bade0568
Reviewed-on: https://chromium-review.googlesource.com/c/1430520
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626144}

Bug: 924877
Change-Id: Iacc7dbca1c2166cc9219ebaa4153ab0e52546053
Reviewed-on: https://chromium-review.googlesource.com/c/1435494Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626143}

These methods are only implemented and used by OmniboxViewViews, so
they are removed from the base class.

Bug: 329527
Change-Id: I47bb17b9f51bc623383525181128c7ec5c3e8c40
Reviewed-on: https://chromium-review.googlesource.com/c/1429986
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626142}

It is possible for the presentation-feedback for a frame to arrive in
the display compositor after the client has stopped requesting
begin-frames. In such cases, the CompositorFrameSinkSupport turns on the
needs-begin-frames flag, so that it can send a begin-frame to the client
carrying the presentation-feedback for the last frame. After this
begin-frame is sent, the needs-begin-frame flag needs to be reset in the
client's CompositorFrameSinkSupport.

BUG=916572

Change-Id: Ic935521c364c98dad6d4f9523de71647ed72a71f
Reviewed-on: https://chromium-review.googlesource.com/c/1433554Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626141}