- 01 Oct, 2018 40 commits
-
-
Koji Ishii authored
Following bot results are included. 10090 10094 10097 10100 10108 10114 10119 10133 10135 10146 10156 10170 10178 10184 10188 10201 2 lines were removed and 6 lines were deflaked by consecutive results since 10108. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibce2757c1abe3ef73fec672756278d870abca479 Reviewed-on: https://chromium-review.googlesource.com/1248882 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595491}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8e2bb1384ad..3ad86d0c8bc4 git log e8e2bb1384ad..3ad86d0c8bc4 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 michaelludwig@google.com Accept processor test seed from command line Created with: gclient setdep -r src/third_party/skia@3ad86d0c8bc4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Id435576cae77f5cb11641d30a3ccac03cd22a064 Reviewed-on: https://chromium-review.googlesource.com/1253825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595490}
-
Vaclav Brozek authored
This CL does the following changes to the code used by ChromePasswordManagerClient: (1) Extracts its platform-independent part into the core component. This will be useful when adding these metrics to iOS. (2) Adds tests for that code. (3) Replaces an obsolete guard against race-conditions with a thread-safe singleton pattern making use of modern C++. Bug: 887409 Change-Id: Ie9ad57d75df3bcebf491aa3f32c5f4919ca93f5b Reviewed-on: https://chromium-review.googlesource.com/1251543 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595489}
-
Devlin Cronin authored
api_test_utils::CreateExtension() variants are no longer really useful with the new-and-improved ExtensionBuilder class. Remove them to reduce code and have one fewer ways of constructing test extension objects. While we're at it, const-ify the creation sites. TBR=atwilson@chromium.org (just updating background_mode_manager_unittest to use a builder) Bug: 889925 Change-Id: I99087834e6b4c30a43c0badb0245295e0e1de525 Reviewed-on: https://chromium-review.googlesource.com/1252766 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595488}
-
Stephen McGruer authored
This CL changes the currentTime algorithm to respect the start and end scroll offset specified for the ScrollTimeline. It does not change the compositor logic - that is left for a followup. https://wicg.github.io/scroll-animations/#dom-scrolltimeline-startscrolloffset Bug: 885196 Change-Id: I732a39659f1f354a8dec982bf75e14f11c0f2134 Reviewed-on: https://chromium-review.googlesource.com/1238376 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#595487}
-
Ben Pastene authored
This reverts commit 49993008. Reason for revert: maintenance over, reenabling CQ Original change's description: > Drain the CQ starting at 11AM PST for emergency lab network maintenance. > > Maintenance will last about an hour. Drain the CQ for the duration of > this. > > NOTRY=true > TBR=jbudorick, tandrii > > Change-Id: Ic5114c910c431ddd92cacfc323d7cd420cc9657a > Reviewed-on: https://chromium-review.googlesource.com/1255222 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595479} TBR=tandrii@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Ia66d9c492cca5001bfffbbc40992f49cd5b108aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1255582Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595486}
-
manuk authored
On the about:omnibox page, the transition table-header is a hyperlink to the relevant code segment explaining page transitions. This cl fixes that link. Previous broken link: http://code.google.com/codesearch#OAMlx_jo-ck/src/content/public/common/page_transition_types.h&exact_package=chromium&l=24 New link: https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h?q=page_transition_types.h&sq=package:chromium&dr=CSs&l=14 Change-Id: I75512d5d6b5420396f8ee22271798c365e4c6c90 Reviewed-on: https://chromium-review.googlesource.com/1252010Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595485}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ddc705933d3f..fe90a1d2dcbe git log ddc705933d3f..fe90a1d2dcbe --date=short --no-merges --format='%ad %ae %s' 2018-10-01 jbolz@nvidia.com Enable /MP4 (parallel build across 4 cores for MSVC) for SPIRV-Tools/source[/opt] (#1930) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fe90a1d2dcbe The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3bb22dffe11913d8fce558b19f164570bc313854 Reviewed-on: https://chromium-review.googlesource.com/1254522Reviewed-by:
-
Eugene But authored
This adds a new value to Download.IOSDownloadMimeType histogram. From graphics.pixar.com: USD is the core of Pixar's 3D graphics pipeline, used in every 3D authoring and rendering application, including Pixar's proprietary Presto animation system. USD previews are supported by Safari and logging the usage will help to decide the priority of supporting USD previews in Chrome. Bug: 883399 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40ceac24f21316f2e5681f1f8af9ea538ac7509e Reviewed-on: https://chromium-review.googlesource.com/1252363Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#595483}
-
phweiss authored
This new policy maps to the CloudDpc policy vpnConfigDisabled, which turns off the user's ability to modify their VPN configuration by disabling the settings UI. In the future, we also want to apply this policy to Chrome settings. BUG=b:72861260 BUG=873123 TEST=unit test Change-Id: I7c4046f95790350f9a44c311972afc3a3ad68d84 Reviewed-on: https://chromium-review.googlesource.com/1251586Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Philipp Weiß <phweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#595482}
-
Keiichi Watanabe authored
Instead of using a fixed frame size 320x240, use a size that is supported by the device. BUG=chromium:881300 TEST=run capture_unittests on kevin TEST=run capture_unittests with another fix in chromium:881300 on amd64-generic VM Change-Id: I3a9ec8b781675b05f6a98d0221ae9dbb0a9c4694 Reviewed-on: https://chromium-review.googlesource.com/1249469Reviewed-by:Christian Fremerey <chfremer@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595481}
-
Findit authored
This reverts commit e195437f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595445 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UxOTU0MzdmMzBiZjMzZWI0OWIyZTM4MzhmZjFhYmI1ZjUyY2ZkZGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/3124 Sample Failed Step: compile Original change's description: > [Autofill Assistant] Add StopCurrentScript() in ActionDelegate. > > Bug: 806868 > Change-Id: Ic3deb3353377e950fadc0d011c75f7ed91ca5366 > Reviewed-on: https://chromium-review.googlesource.com/1250923 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595445} Change-Id: Iefb7112349dd74ca20ff2190ed661f3c6098f89b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1255502 Cr-Commit-Position: refs/heads/master@{#595480}
-
Ben Pastene authored
Maintenance will last about an hour. Drain the CQ for the duration of this. NOTRY=true TBR=jbudorick, tandrii Change-Id: Ic5114c910c431ddd92cacfc323d7cd420cc9657a Reviewed-on: https://chromium-review.googlesource.com/1255222Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595479}
-
Francois Doray authored
This will help investigate issues such as https://crbug.com/890841 in the future. It is usually helpful to have a lot of logging in test-only code. TBR=rsleevi@chromium.org Bug: 890841 Change-Id: I7ed1e06cf578277ffd4f7976cc70b46209998f38 Reviewed-on: https://chromium-review.googlesource.com/1254742 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595478}
-
John Chen authored
Fix a stack overflow that can be caused by receiving a large amount of data from Chrome. Also increase the maximum buffer size for communication between app and ChromeDriver. Bug: chromium:877105, chromedriver:2587, b/112588554 Change-Id: Ie98544237472da629c01b9422b2e01a4716e8b88 Reviewed-on: https://chromium-review.googlesource.com/1233177 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595477}
-
Nico Weber authored
Bug: 832676 Change-Id: If5abb30902fdde9ec391c3a6fc8ed5808cf36476 Reviewed-on: https://chromium-review.googlesource.com/1253089Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595476}
-
Marina Ciocea authored
This reverts commit 9a13eecb. Reason for revert: Enable sandbox only for Windows and Mac. Leave sandbox disabled on Linux until I fix #890850. Original change's description: > Revert "Enable AudioServiceSandbox flag in audio service field trial testing." > > This reverts commit 6caca443. > > Reason for revert: I suspect that this CL is causing https://crbug.com/890850 > > Original change's description: > > Enable AudioServiceSandbox flag in audio service field trial testing. > > > > Bug: 832666 > > Change-Id: I3ec5dbea8e34f3a9295723def845e49b2bb59af3 > > Reviewed-on: https://chromium-review.googlesource.com/1240280 > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#595397} > > TBR=holte@chromium.org,marinaciocea@chromium.org > > Change-Id: I5e6d1a9e153003c086ce8c2f247230d4832ce99b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 832666, 890850 > Reviewed-on: https://chromium-review.googlesource.com/1254746 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595464} TBR=fdoray@chromium.org,holte@chromium.org,marinaciocea@chromium.org Change-Id: I5176102960a7450de1b44612b85c7098d0df9c8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832666, 890850 Reviewed-on: https://chromium-review.googlesource.com/1255063 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#595475}
-
Micah Morton authored
This reverts commit e034d163. Reason for revert: We want to change shill sandboxing back to default-disabled rather than default-enabled. We will still roll out sandboxing to 50% of users in M70. Original change's description: > Wire up ShillSandboxing flag to be enabled by default > > In a previous CL:1173260 I meant to wire up this feature flag to be > enabled by default. Somehow I mistakenly landed the code with the > FEATURE_DISABLED_BY_DEFAULT flag instead. > > Bug: 649417 > Test: Same as CL:1173260 > Change-Id: I2154749addb0539be9a2ef53c368d80dc10bee41 > Reviewed-on: https://chromium-review.googlesource.com/1190644 > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Micah Morton <mortonm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586444} TBR=stevenjb@chromium.org,mnissler@chromium.org,mortonm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 649417 Change-Id: Ice783f6bced9828e1ae8fb966f00f5dc32aff3f2 Reviewed-on: https://chromium-review.googlesource.com/1251326Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595474}
-
Byoungkown authored
The code in components/metrics takes about >3CPU minutes to build. Building effort will fall to about 1 CPU minutes using jumbo builds[1]. When building using jumbo, files gets merged. It means that you cannot duplicate symbol names within the component, not even in anonymous namespaces. [1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md Bug: 869381 Change-Id: I5287f8366ea78b6e97c51d04489ec3c2ed28fab6 Reviewed-on: https://chromium-review.googlesource.com/1239133 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#595473}
-
Artur Khachatryan authored
Tests which were temporary grouped under the bug 2480 have been investigated and put under the corresponding bugs. 'test_expectations' is updated according to those changes. Change-Id: I360e3310edc7d3698ddf939449d1387f0b50a32f Reviewed-on: https://chromium-review.googlesource.com/1252916Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595472}
-
jdoerrie authored
This change adds a warning to the clang-tidy docs that using a Jumbo build for Chrome is not supported. Bug: NONE Change-Id: I2d714c81689493c35e5e6b4de8d45948f94d8cda Reviewed-on: https://chromium-review.googlesource.com/1254149Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#595471}
-
Tetsui Ohkubo authored
The user avatar did not have proper tooltip when it's guest session. TEST=manual BUG=889831 Change-Id: I620704000b2d01b83406eeebc301c54a4138bac1 Reviewed-on: https://chromium-review.googlesource.com/1250383Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595470}
-
Leonard Grey authored
We managed to miss the fact that ShareMenuController's transition animation data was dependent on Cocoa browser windows. This change uses Views APIs to get the content area's rect and screengrab instead. Bug: 890355 Change-Id: Ifa86782902e24985228a423510b65b5a58ef37b5 Reviewed-on: https://chromium-review.googlesource.com/1252245Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#595469}
-
Tetsui Ohkubo authored
According to the spec, new shelf should have 8dip padding between the top of the shelf and the bottom of the popup notifications. TEST=manual BUG=883640 Change-Id: I6186379d221624b76984af69b922f85e36556401 Reviewed-on: https://chromium-review.googlesource.com/1250344Reviewed-by:
-
Christian Biesinger authored
Just move the shelf variable up a few lines. operator[] is not trivial because it does bounds checking; this allows us to avoid some of that overhead. R=ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1ff6c9788a39710728faa032e45ca490bfd7b247 Reviewed-on: https://chromium-review.googlesource.com/1253702Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595467}
-
Jeremy Klein authored
Avoid installing the Android Messages PWA if prohibited by policy or if either the phone or Chromebook does not support it. Also listen for changes in feature state to install the app if something changes. Bug: 884290 Change-Id: I527828e68c3578e54a1ce15cace64e4ed2c81745 Reviewed-on: https://chromium-review.googlesource.com/1250209 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595466}
-
Mohsen Izadi authored
In HeadlessContentMainDelegate::RunProcess(), if the headless browser instance is destroyed before browser runner is shut down, GPU clients might end up accessing the destroyed object in the meantime. An example is when a client tries to establish a GPU channel ending up accessing destroyed HeadlessBrowserImpl::options in order to instantiate viz::GpuHostImpl. This CL changes the ordering to fix the race condition. BUG=881211 TEST=headless_browsertests --gtest_filter=HeadlessBrowserTest.* Change-Id: I2518eeefcc1e446a59d680fa78eab88e26765404 Reviewed-on: https://chromium-review.googlesource.com/1251331Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595465}
-
François Doray authored
This reverts commit 6caca443. Reason for revert: I suspect that this CL is causing https://crbug.com/890850 Original change's description: > Enable AudioServiceSandbox flag in audio service field trial testing. > > Bug: 832666 > Change-Id: I3ec5dbea8e34f3a9295723def845e49b2bb59af3 > Reviewed-on: https://chromium-review.googlesource.com/1240280 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595397} TBR=holte@chromium.org,marinaciocea@chromium.org Change-Id: I5e6d1a9e153003c086ce8c2f247230d4832ce99b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832666, 890850 Reviewed-on: https://chromium-review.googlesource.com/1254746Reviewed-by:
-
Francois Doray authored
Multiple recent failures: Win7 Tests (1) - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84175 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84165 See failure log on the bug. TBR=droger@chromium.org Bug: 879443 Change-Id: Id3300df55adc2336c338cfeb0a3fd8c8e75d51b9 Reviewed-on: https://chromium-review.googlesource.com/1254562Reviewed-by:
-
Mario Sanchez Prada authored
There are no references to either ProfileOAuth2TokenServiceFactory or ProfileOAuth2TokenService, so these includes can be safely removed. Bug: 890237 Change-Id: If484fd41a20ef88b59a91777d741c368fc36ba17 Reviewed-on: https://chromium-review.googlesource.com/1251045Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595462}
-
Weidong Guo authored
This is a reland of e39c47e5 Original change's description: > Install app to first available position in app list > > Changes: > 1. Calculate the first available position in AppListModelUpdater for > newly added item. > 2. Add test coverage. > > Bug: 883939 > Test: AppListSyncableServiceTest.FirstAvailablePosition > Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319 > Reviewed-on: https://chromium-review.googlesource.com/1231193 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592539} Bug: 883939,887636 Change-Id: Id630fd99023a670ddcec52c977f20f3e1092f8b6 Reviewed-on: https://chromium-review.googlesource.com/1237256Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595461}
-
Eric Stevenson authored
The android-binary-size bot blocks CLs that do one of the following: * Increase normalized_apk_size > 16 kb * Add more than 50 Java methods * Add/increase the size of an uncompressed pak > 1 kb The trybot emits useful debugging information as bot steps and includes a link to an interactive Supersize HTML report. These checks are skipped for autorollers and for CLs with "Binary-Size:" in the commit message. Bug: 702625 Change-Id: I3e9dee26e96fd0d1cfe5f86ec1b8c717fa1abf2f Reviewed-on: https://chromium-review.googlesource.com/1254502Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
The separation of the sync layer from the core has been a failed experiment. There has not been an embedder of the core which did not use sync, and in fact the core itself depends on a lot of sync-related code. Having the separate sync layer is now just confusing. Bug: 515108 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I65cc70b6a5e1ea1332ac9ae22de704cf757dc25e Reviewed-on: https://chromium-review.googlesource.com/1252583Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595459}
-
Chris Lu authored
AtrributesProvider was used in legacy reading list logic. FaviconLoader is now the preferred method. Bug: 878796 Change-Id: I009c762dfe7053e149c6b94b2145c4f68008a304 Reviewed-on: https://chromium-review.googlesource.com/1252523 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595458}
-
Robert Ma authored
This change appends the pinned depot_tools in Chromium checkout (at //src/third_party/depot_tools) to PATH so that the wpt_{import,export} scripts always work as long as we have a `gclient sync`ed checkout. The main reason for the change is to fix the scripts on LUCI, where depot_tools is no longer in PATH by default. Bug: 803111 Change-Id: I9242befa3dbc9e735ae3a618dcd5b8f5eff5579d Reviewed-on: https://chromium-review.googlesource.com/1252532Reviewed-by:Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#595457}
-
James Cook authored
The assertions were unclear because the test window was being created partially outside the display work area, resulting in it being moved from its initial coordinates. Make the simulated display bigger so the window isn't moved. Clarify and document the expectations. Bug: 890633 Test: ash_unittests Change-Id: Ie0ba065bc4d8f46a2cfd6ad24250d808845e8cd5 Reviewed-on: https://chromium-review.googlesource.com/1252384 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#595456}
-
Charlie Harrison authored
Web Speech API is not implemented on WebView. Bug: 890499 Change-Id: I0f8e94c5662f7213ff1d5ce5e13dbcab515bed66 Reviewed-on: https://chromium-review.googlesource.com/1254466Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#595455}
-
erikchen authored
The original CL didn't allow negative time skew from the time server. While this is likely correct, this caused unit tests to fail as they relied on negative time skew. This CL allows negative time skew, and also removes another source of non-determinism from the tests. Original change's description: > Use accurate X11 event timestamp computation. > > X events have a timestamp which is only well defined relative to the X11 Server > time. The previous computation for timestamp for X11 events was making the > assumption that Server time and Chrome time were the same. This assumption is > not always true -- this is likely the root cause of "bad" timestamps observed in > https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 > > This CL changes event timestamp computation to make a roundtrip to the X11 > Server to get an accurate base::TimeTicks. This logic was lifted out of the > responsiveness calculator, which was already doing this computation. The latter > will subsequently be changed to use the computation in this CL. > > Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 > Bug: 859155 > Reviewed-on: https://chromium-review.googlesource.com/1249383 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594844} Change-Id: I6595f6aa163a18c9724c50546ac8c84bc5c84a03 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1252685Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
erikchen authored
The logic in NSMenuItem(ChromeAdditions) attempts to mimic Cocoa's logic for determining whether a NSMenuItem will fire for a given NSEvent. In keyboard layouts that produce non-ascii characters, Cocoa uses the event's "characters" property to process keyEquivalents, and will manually apply the shift modifier if necessary. Our logic was failing to do so. This meant that key combinations such as [cmd + shift + t] on 2-Set Korean would attempt to match a NSMenuItem with keyEquivalent "t" rather than a NSMenuItem with keyEquivalent "T". Bug: 889970 Change-Id: I81fdf11c4ffa6322d78e981cdbff6956cd8f4b79 Reviewed-on: https://chromium-review.googlesource.com/1254462Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595453}
-
Nicolas Ouellet-Payeur authored
This new method can be used to set a second source of rules for BrowserSwitcherSitelist, in addition to the 'url_list' and 'url_greylist' prefs. Once the IEEM sitelist download code is ready, we can use this method to apply the downloaded rules. Bug: 884837 Change-Id: I0e6d20a03fb27425dd3e9d7b9fd9b2b9fa19d163 Reviewed-on: https://chromium-review.googlesource.com/1249524Reviewed-by:
-
