GitLab

NOTRY=true
TBR=benm@chromium.org

BUG=

Review URL: https://codereview.chromium.org/12210130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181853 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181852 0039d316-1c4b-4281-b951-d872f2087c98

- Deprecate is_fetching_changes_ flag
- Add a new flag: may_have_unfetched_changes_ which is turned on
  at the beginning and when an event is fired
- Call StartBatchSyncForOrigin() and FetchChangesForIncrementalSync()
  only from MaybeStartFetchTask() with more strict conditions.

Partialy integrating the change proposal made by tzik:
https://codereview.chromium.org/12221088/

* It ALWAYS sets may_have_unfetched_changes_ true and call MaybeStartFetchTask()
in XMPP/Timer/Auth/Network event handlers, so it has to be able to kick
StartBatchSyncForOrigin() or FetchChangesForIncrementalSync() whenever an
event happens even if the service state is in TEMPORARY_UNAVAILABLE.

* It ALWAYS sets may_have_unfetched_changes_ false in StartBatchSyncForOrigin()
and FetchChangesForIncrementalSync(), so that it won't get stuck in an infinite
loop calling one of the methods again and again when the service state is
TEMPORARY_UNAVAILABLE (e.g. network is offline).

* It does NOT queue fetch tasks to the pending_tasks_ when another task is
running, so the service has not to be overloaded by unifinished pending fetch
tasks.

* NotifyTaskDone() ALWAYS calls SchedulePolling() (which starts the timer
if it hasn't been started) so it should not miss the tminigs where one of
fetch-change methods have to be called.

== State transition map:

{ OK, !batch.empty(), _ }
  -> NotifyTaskDone() calls StartBatchSyncForOrigin() until batch.empty() becomes true

{ TEMPORARY_UNAVAILABLE, !batch.empty(), _ }
  -> NotifyTaskDone() calls nothing
  -> XMPP/Timer/Auth/Network event handler calls StartBatchSyncForOrigin() if no task is running, otherwise let NotifyTaskDone() call it at most once

{ !DISABLED, batch.empty(), !incremental.empty() }
  -> NotifyTaskDone() calls nothing
  -> XMPP/Timer/Auth/Network event handler calls FetchChangesForIncrementalSync() if no task is running, otherwise let NotifyTaskDone() call it at most once

BUG=175047
TEST=manual

Review URL: https://codereview.chromium.org/12210109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181851 0039d316-1c4b-4281-b951-d872f2087c98

Also roll CDM DEPS to r181763.

TEST=Test page plays; content_browsertests pass.

Review URL: https://codereview.chromium.org/12212079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181850 0039d316-1c4b-4281-b951-d872f2087c98

classes to extensions/common/

TBR=ben@chromium.org
BUG=162530

Review URL: https://chromiumcodereview.appspot.com/12208078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172050


Review URL: https://chromiumcodereview.appspot.com/12181005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172705
TEST=on device, login, and press Shift-Alt-n. Also make sure NOT toggling when login/lock-screens.


Review URL: https://chromiumcodereview.appspot.com/12096027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181847 0039d316-1c4b-4281-b951-d872f2087c98

The "code" holds the identification of physical key.
Unlike to "key" value, this value is not affected on current keyboard layout or modifier state.

BUG=169993

Review URL: https://codereview.chromium.org/12224031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181846 0039d316-1c4b-4281-b951-d872f2087c98

Add url prefix to AutofillQuery requests when autocheckout enabled, and set accepts="a" (autocheckout) rather than "e" (experiment)

BUG=172143,172186


Review URL: https://chromiumcodereview.appspot.com/11953100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181845 0039d316-1c4b-4281-b951-d872f2087c98

New icons are smaller and do not look good with vertical centering. This patch aligns them to the label's baseline and also adds small margin between icons and labels.

TEST=Enter Files.app and check icons in the left nav.
BUG=None

Review URL: https://codereview.chromium.org/12208122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181844 0039d316-1c4b-4281-b951-d872f2087c98

Allow downloading of metadata even if drive is disabled on LTE

BUG=175068

Review URL: https://codereview.chromium.org/12220073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181843 0039d316-1c4b-4281-b951-d872f2087c98

Before, only Drive had a gear menu. This menu contains remaining space and help item. For consistency, the same button should appear on any other volume, but without Drive related items. As a result, the help menu item as well as the remaining size are in one place for each volume.

TEST=Check the gear button in Downloads, Drive and some removeable media. It should contain only 2 items for non-Drive volumes: space and help. Check if space is correct.
BUG=172813

Review URL: https://codereview.chromium.org/12221082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181841 0039d316-1c4b-4281-b951-d872f2087c98

These flags aren't supported on 64-bit and can throw an error on Win8 process creation.

BUG=147752

Review URL: https://chromiumcodereview.appspot.com/12207106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181840 0039d316-1c4b-4281-b951-d872f2087c98

The capture video frames are obtained by using camera's PreviewCallbackWithBuffer.
Most of VideoCaptureDevice unit tests are disabled on Android due to different data flow and threading.

BUG=161417
Review URL: https://codereview.chromium.org/11860002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181839 0039d316-1c4b-4281-b951-d872f2087c98

- Send multiple requests per discovery cycle using a timer object.
- Refactor to make it possible to test code with timers.
- Add unit tests for multiple discovery.

BUG=166650,170250


Review URL: https://chromiumcodereview.appspot.com/12150002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181838 0039d316-1c4b-4281-b951-d872f2087c98

This change allows apps to declare a page_launcher key in the
manifest to add themselves to the action box. When the
corresponding action is clicked, the app will receive a
pageLauncher.onClicked event.

ActionBox design document: https://docs.google.com/a/google.com/document/d/1Qxiey4vnbX0YwCRi5BGQbeCuH3DxHGMOtYnQOjBpcCI/edit

BUG=125307


Review URL: https://chromiumcodereview.appspot.com/12095023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181837 0039d316-1c4b-4281-b951-d872f2087c98

Some older drivers should support Stage3D constrained mode, not baseline mode, so add blacklist entries for that.


BUG=172771


Review URL: https://chromiumcodereview.appspot.com/12079111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181836 0039d316-1c4b-4281-b951-d872f2087c98

> Suppress TabbedPaneTest and FocusManagerTest leaks.
> 
> My http://crrev.com/181798 introduced Valgrind leaks:
> http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339
> I'll suppress the leaks temporarily while I'm fixing them.
> 
> BUG=138059,175644
> TEST=No Valgrind leaks reported from these tests.
> TBR=zhaoqin@chromium.org
> 
> Review URL: https://codereview.chromium.org/12226104

TBR=msw@google.com
Review URL: https://codereview.chromium.org/12248013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181832 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heapcheck/builds/14990
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339

> Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.
> 
> Remove NativeTabbedPaneWin and NativeTabbedPaneWrapper.
> ( its last use was eliminated in http://crrev.com/180924 )
> Write a TabbedPane based on NativeTabbedPaneViews.
> Update unit tests; cleanup; etc.
> 
> BUG=138059
> TEST=No observable tabbed pane appearance/behavior changes (see the WebsiteSettingsPopupView and CollectedCookiesView); unit tests.
> R=markusheintz@chromium.org,sky@chromium.org,ben@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/12225042

TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/12221130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181831 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181830 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181829 0039d316-1c4b-4281-b951-d872f2087c98

My http://crrev.com/181798 introduced Valgrind leaks:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339
I'll suppress the leaks temporarily while I'm fixing them.

BUG=138059,175644
TEST=No Valgrind leaks reported from these tests.
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/12226104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152854
TBR=thakis@chromium.org for stub method in cocoa

Review URL: https://chromiumcodereview.appspot.com/12207105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159265


Review URL: https://chromiumcodereview.appspot.com/11968032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181826 0039d316-1c4b-4281-b951-d872f2087c98

This change is the first of several to process changes from sync of the "Synced Notifications" data type.  It defines the SyncedNotification type more fully in synced_notification_specifics.proto, and implements the incoming interfaces needed to handle the data.

This change handles notifications coming in from the sync channel.  These notifications will eventually call into the C++ backend supporting the Desktop Notification API (doc here: https://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/proposed-changes/apis-under-development/desktop-notification-api )

It is based closely on the change list for history delete directives: https://chromiumcodereview.appspot.com/10855037

BUG=168212

Review URL: https://chromiumcodereview.appspot.com/11745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181825 0039d316-1c4b-4281-b951-d872f2087c98

We pass the selection bounds as anchor/focus. Sometimes,
we need the start and end instead, and the is_anchor_first
flag allows us to derive start/end from anchor/focus.

On Android, use this flag to set the correct selection handle
positions.

BUG=162468


Review URL: https://chromiumcodereview.appspot.com/12228005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181824 0039d316-1c4b-4281-b951-d872f2087c98

Adding support for processing java side tasks while in nested mode. We process messages from the java messagequeue
using reflection, till the queue is idle.
TBR=jochen@chromium.org
TBRing for content_shell.gypi
BUG=138275


Review URL: https://chromiumcodereview.appspot.com/12213021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181823 0039d316-1c4b-4281-b951-d872f2087c98

Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.

BUG=115047

Review URL: https://chromiumcodereview.appspot.com/12210030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172015
TBR=vangelis

Review URL: https://codereview.chromium.org/12223055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181821 0039d316-1c4b-4281-b951-d872f2087c98

D3D11 seems to crash when the device is created if dlumd32.dll is loaded.

BUG=175525
Review URL: https://codereview.chromium.org/12218101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181820 0039d316-1c4b-4281-b951-d872f2087c98

The only way to keep image_preserved disabled was to use a
glFinish after EGL image creation. This is fine if we only
create EGL images on the upload thread, but we might start
doing this on either thread.

This alternative work around just doesn't use image-
preserve. The performance benefit wasn't large on Qualcomm
anyway.

No-try for Android only change.

NOTRY=true
BUG=175272

Review URL: https://chromiumcodereview.appspot.com/12218088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181819 0039d316-1c4b-4281-b951-d872f2087c98

The delegate can go away while we asynchronously load images.
To handle this case, ExtensionInfobarGtk should register itself as
DelegateObserver with the ExtensionInfoBarDelegate and
handle the Delegate Deletion case.

BUG=162662


Review URL: https://chromiumcodereview.appspot.com/12208091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181818 0039d316-1c4b-4281-b951-d872f2087c98

This provides an implementation WebKit::WebUnitTestSupport::createLayerTreeViewForTesting()
for webkit_unit_tests that want to instantiate compositing support and need initialization
to succeed but do not need to actually render anything. Critically, this sort of
view does not depend on any particular client or settings.

This appears to be a lot of code, but it's actually a bit of movement and very
little new code.  The primary movement is extracting most of the test class
cc/test/fake_web_graphics_context3d.h into cc/fake_web_graphics_context3d.h so
that it can be exported to other modules as a regular class. This is necessary
since webkit_unit_tests are in a different component and must use only the
normally exported parts of the cc library.  cc/test/test_web_graphics_context3d.h
has all of the extra bells and whistles and assertions for cc_unittests.

WebLayerTreeViewImplForTesting uses a very simple context and does not depend
on an external client at all.  This results in two subtle but very significant
properties (which are the point of this whole exercise) - the unit tests no longer
depend on WebLayerTreeViewClient or WebGraphicsContext3D at all.  The entire
notion of what the context type is now entirely hidden in the chromium side of
the codebase and can be swapped out for something else (like gpu::GLES2Interface)
without any further changes on the WebKit side.

After this patch, the only remaining caller of WebCompositorSupport::createLayerTreeView
in the WebKit tree is WebViewHost, which needs to instantiate a view that can
render pixels (using mesa) for DumpRenderTree.  I'll address that separately.

BUG=175383

Review URL: https://codereview.chromium.org/12211110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181817 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181816 0039d316-1c4b-4281-b951-d872f2087c98

This is useful for running telemetry under simulated bandwidth conditions. For
example, to run with DSL speed, pass:
--extra-wpr-args="--shaping_type=proxy --net=dsl"

BUG=None
TEST=tools/perf/run_multipage_benchmarks --extra-wpr-args="--shaping_type=proxy --net=dsl" --browser=system loading_benchmark tools/perf/page_sets/top_25.json
NOTRY=True

Review URL: https://codereview.chromium.org/12224111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172371
TEST=PanelLayoutManager.SplitViewOverlapWhenLarge


Review URL: https://chromiumcodereview.appspot.com/12213111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181814 0039d316-1c4b-4281-b951-d872f2087c98

To include the temporary fix of systrace.

BUG=169592


Review URL: https://chromiumcodereview.appspot.com/12212119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181813 0039d316-1c4b-4281-b951-d872f2087c98

Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
A screenshot of the set passphrase page is available here:
https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing

BUG=171370
TEST=browser_tests, unit_tests

Review URL: https://chromiumcodereview.appspot.com/12208068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=74138
TBR=apatrick@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12225128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181811 0039d316-1c4b-4281-b951-d872f2087c98

closed. Previously we were sending this out twice on aura, which was
causing the task manager to CHECK.

BUG=174512
TEST=covered by unit test
R=ben@chromium.org,erg@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12225122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181810 0039d316-1c4b-4281-b951-d872f2087c98