- 23 Jun, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8c86588d1bcc..a46969229d6b $ git log 8c86588d1..a46969229 --date=short --no-merges --format='%ad %ae %s' 2017-06-16 halcanary SkPDF: implement SkPDFArray::reserve. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I6b99cb172f2b11a394d62bca37ea09958f563cfb Reviewed-on: https://chromium-review.googlesource.com/545976Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481933}
-
guidou authored
Use array elements instead of pointer values in comparisons involving pointers to member functions. One of these comparisons failed on Windows Debug and others are suspect of failing on WinClang DLL builds. BUG=736309 Review-Url: https://codereview.chromium.org/2958543002 Cr-Commit-Position: refs/heads/master@{#481932}
-
Jinsuk Kim authored
Native interface ContentViewCore is going away. This CL replaces it usage in embedders with WebContents/ViewAndroid in preparation of the deletion. This CL make changes to media-related part. BUG=626764 Change-Id: I4afee7e603d8ea9d801f09e7f2a5ef27faf2dd68 Reviewed-on: https://chromium-review.googlesource.com/543081Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#481931}
-
Emircan Uysaler authored
This reverts commit 44820576. Reason for revert: This seems to break WebRtcApprtcBrowserTest.MANUAL_WorksOnApprtc test. The failure is consistent on Win bots and very likely on Mac bots: https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/35214 https://build.chromium.org/p/chromium.webrtc/waterfall?builder=Mac%20Tester Original change's description: > [Mojo Video Capture] Enable service in default testing config > > This CL is part of the Mojo Video Capture work. > Design doc for dev work [1]. > Design doc for launch [2]. > > BUG:584797,721812 > > [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing > [2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing > > Change-Id: I38b83efdf1e8619e3edba95df70a6b5fdae30a3f > Reviewed-on: https://chromium-review.googlesource.com/524298 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481767} TBR=jwd@chromium.org,chfremer@chromium.org Change-Id: Ife2bf7fc75a09528de04e08b5f8e4d4e7f94660c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/546276Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481930}
-
David Benjamin authored
This avoids a blocker on removing HASH_VALUE_SHA1 and was unnecessary. The |key_hash| field can just as easily be a der::Input and BoringSSL already has abstractions for computing a digest. It also allows us to fill in missing hash functions. Bug: 564281 Change-Id: Ib044df61bb7bdfc4c5b021861c8f0561635dc6a8 Reviewed-on: https://chromium-review.googlesource.com/545017Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#481929}
-
Robert Flack authored
To help debug the Scheduling.Browser.MainAndImplFrameTimeDelta2 metric, this adds a trace of the times used to compute the impl and main frame delta. We should be able to use this to identify which frames were identified as slipping and when those times were recorded. BUG=719667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ab1d6ca72f0c3ec186740d33014e8d39cfe8404 Reviewed-on: https://chromium-review.googlesource.com/535658Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481928}
-
https://chromium-review.googlesource.com/544720rdsmith authored
NOTRY=true TBR=kinuko@chromium.org BUG=736362 Review-Url: https://codereview.chromium.org/2954143002 Cr-Commit-Position: refs/heads/master@{#481927}
-
Jorge Lucangeli Obes authored
BUG=706832 TEST=Remove -Wno-shift-negative-values from Chrome OS build. TEST=Build Chrome for Chrome OS, no warnings/errors. TEST=Build Chrome with chromeos=1, no warnings/errors. Change-Id: I71936ec6d3a41c787febe1b83f865fed2cd322fa Reviewed-on: https://chromium-review.googlesource.com/546035Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#481926}
-
Sorin Jianu authored
This is a mechanical change. At high level: * Not posting to the FILE thread. * Posting to a task runner obtained by calling GetTaskRunnerForThread. Bug: 735695 Change-Id: I273289deeb1af44868970d561717fa03615a932c Reviewed-on: https://chromium-review.googlesource.com/544444Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#481925}
-
Miguel Casas-Sanchez authored
This CL adds a feature flag for image capture to ease debugging of issues in the wild (e.g. https://crbug.com/722038 and https://crbug.com/709819). The flag is enabled by default: chrome://flags/#enable-image-capture-api Bug: 735661 Change-Id: Iab06dbc9e6d4a5ecbbf85f70ad7221770915b464 Reviewed-on: https://chromium-review.googlesource.com/544185Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#481924}
-
Boris Sazonov authored
ProfileDownloaderDelegate implementation may delete ProfileDownloader inside OnProfileDownloadSuccess or OnProfileDownloadFailure, so profile_image_fetcher_ has to be reset before calling these methods. Bug: 736358 Change-Id: I5f16bd1c3b54f7f317957cf916ef1b9d93b30494 Reviewed-on: https://chromium-review.googlesource.com/546055Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#481923}
-
Yuke Liao authored
https://chromium-review.googlesource.com/c/542962/ was reverted due to a bug, however, part of the changes are still useful, so restore them in this CL. And specifically, this CL refactors CRWWebController and web view creation utils to use UserAgentType. Bug: Change-Id: Iafaca12bd30d1b84b315295ee090e7ee68161bfe Reviewed-on: https://chromium-review.googlesource.com/545112 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#481922}
-
James Cook authored
* Add workarounds for YCM build failures * Fix recommended vscode settings to match recommended YCM path Bug: none Change-Id: I906ce3ede9d58ff2974de1c0d094eefd00b9f589 Reviewed-on: https://chromium-review.googlesource.com/546155Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#481921}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/753d46ee..5844b475 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2954133003 Cr-Commit-Position: refs/heads/master@{#481920}
-
lanwei authored
We send a fake mousemove event to check if there is any change of the element underneath the mouse cursor, but we should not send the mousemove event to the DOM, because the mouse does not move. Bug: 333623 Change-Id: I037ce8f56605afc4b21031095425bdeee8b0aa0c Reviewed-on: https://chromium-review.googlesource.com/537514Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#481919}
-
stkhapugin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2886043003 Cr-Commit-Position: refs/heads/master@{#481918}
-
kojii authored
The function name follows the WTF Vector convention. Needed in LayoutNG. BUG=636993 Review-Url: https://codereview.chromium.org/2956603002 Cr-Commit-Position: refs/heads/master@{#481917}
-
braveyao authored
The problem only happens when an external monitor is connected to a MBP and works together with the built-in screen. If the desktop capture is started from the external monitor, e.g. window picker locates on the external monitor, there is no notification bar on any screen. There is no such problem when desktop capture is started from built-in screen. The problem is because chrome aligns the notificaiton bar to the cooridnates of the external monitor, but still draw it to the built-in screen. The fix is to draw the notification bar to the screen from which the desktop capture is started, by adding the offset of x coordinat of the curren |mainScreen|. Bug: 671427 Change-Id: Ida11c91cc0525dc14110f42662c9f3269bf09234 Reviewed-on: https://chromium-review.googlesource.com/545115Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#481916}
-
Chris Kuiper authored
This removes the call to start() at the end of init(), and instead waits until data is fed in. At that time, it writes as much data as the AudioTrack instance takes, then calls start(), then feeds in any additional data not taken on the first call. Bug: internal b/62923451 Test: run on IMX7, observe logs for playback of TTS and Media streams, notice no underruns reported Change-Id: I89b272655176d22e0cb17e896fe6b9c1daa3e717 Reviewed-on: https://chromium-review.googlesource.com/545262Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#481915}
-
erikchen authored
The end-point now supports passing memory dump configs. Add tests. BUG=chromium:735124 Review-Url: https://codereview.chromium.org/2954603002 Cr-Commit-Position: refs/heads/master@{#481914}
-
Chris Kuiper authored
This tweaks/removes/reduces/throttles logging during audio playback in CMA backend for Android. In addition, it added a couple of missing initializers in AudioSinkAudioTrackImpl. Bug: None Test: run on IMX7, observe fewer/better logs... Change-Id: I3ca294abe50a3e2a62c95c6b0feaff5bde485cdb Reviewed-on: https://chromium-review.googlesource.com/545261Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#481913}
-
sczs authored
- Creates TransitionController objects so Coordinators don't have to conform to the UIViewControllerTransitioningDelegate protocol. This will make it easy to switch out to different transitions or make AB experiments. - Moves the presentationFrame calculation into the MenuPresentationController, which also reduces code duplication. In order to make this possible the MenuPresentationDelegate has changed. BUG=682880 Review-Url: https://codereview.chromium.org/2952213003 Cr-Commit-Position: refs/heads/master@{#481912}
-
Takayoshi Kochi authored
When CSSParserContext is created, it determines whether the context is in quirks mode or not, by looking at master document's quirks mode flag instead of context object's document. This worked for stylesheets in <style> element in an import, because the style rules defined there actually applies to the master document. This caused problem for querySelector/querySelectorAll because the query mode mismatches when the master document is in quirks mode. HTML Imports are always in no quirks mode without DOCTYPE declaration[1][2]. As we optimize ID match for quirks mode by lowercasing IDs in HTML and ID selectors in CSS, but when the master document is in quirks mode, querySelector in import ran in quirks mode (thus selector was lowercased) while IDs in import are preserving case, and never matched. The fix for this is to check if it is in querySelector (i.e. not using dynamic profile), use the document's mode, rather than its master document's mode. [1] http://w3c.github.io/webcomponents/spec/imports/#additions-to-tree-construction-algorithm [2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=24349 Bug: 621172 Change-Id: I110bd62df962009ee015239fbc0e5fe24a1e6893 Reviewed-on: https://chromium-review.googlesource.com/544732 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#481911}
-
Dominic Battre authored
Bug: 732846 Change-Id: I12291bfc4484a11cd068a50fd3603525d6577c18 Reviewed-on: https://chromium-review.googlesource.com/533217 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#481910}
-
Xianzhu Wang authored
BUG=727173 Change-Id: Idb20e6d81192865d125c802e40ef58ab1960ffbd Reviewed-on: https://chromium-review.googlesource.com/545136 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481909}
-
Robert Liao authored
BrowserProcessSubThread initializes COM, so TestBrowserThread and TestBrowserThreadBundle should too. BUG=734135 Change-Id: I8cd0f1422bd4e680372c542f79dc9763879433ec Reviewed-on: https://chromium-review.googlesource.com/540100Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#481908}
-
tmartino authored
order summary screen. Specifically: - Does not read the "preview" text (e.g., "123 Fake St. and 1 other...") as it is confusingly similar to the selected state. - Adds accessible content when a payment method has been selected. BUG=733684 Review-Url: https://codereview.chromium.org/2956473002 Cr-Commit-Position: refs/heads/master@{#481907}
-
droger authored
BUG=730589 Review-Url: https://codereview.chromium.org/2951263002 Cr-Commit-Position: refs/heads/master@{#481906}
-
jialiul authored
BUG=736324 Review-Url: https://codereview.chromium.org/2959443003 Cr-Commit-Position: refs/heads/master@{#481905}
-
Bryan McQuade authored
Unit test infrastructure doesn't consistently provide a GlobalRequestID for NavigationHandles. NavigationSimulator provides support for generating GlobalRequestIDs, but WebContentsTester does not. As a result, page load metrics production code contains a workaround for missing GlobalRequestIDs. This change removes that workaround. This change does the following: * require a GlobalRequestID for simulated main frame resource loads. * add support in NavigationSimulator to get the GlobalRequestID for the navigation, after nav commit. * add support for specifying a GlobalRequestID in SimulateLoadedResource. * add tests to verify correct behavior * switch most observers to using non-main frame resources, since most observers do not have any resource type specific logic Going forward, any tests that want to simulate the load of a main frame resource must use NavigationSimulator in order to get a valid GlobalRequestID. Bug: 711352 Change-Id: I01aded2cbdc36cb627235d0ce0126045ed441c0a Reviewed-on: https://chromium-review.googlesource.com/541516 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#481904}
-
Xiyuan Xia authored
This reverts commit d9339152. Reason for revert: Breaks win compile. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/19349 Original change's description: > Replace GetBlockingPool and FILE thread with post_task API > > BUG=689520,667892 > > Change-Id: I1143fbc8c5f7c12dfdd8e5764d58c9b372d3cb16 > Reviewed-on: https://chromium-review.googlesource.com/544782 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481889} TBR=xiyuan@chromium.org,grt@chromium.org Change-Id: Ib5ca5c591792f0909188ebe6db2c4c9d25a4cba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 689520, 667892 Reviewed-on: https://chromium-review.googlesource.com/545856Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481903}
-
Xida Chen authored
This reverts commit d9339152. Reason for revert: <INSERT REASONING HERE> Causing compile error here: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/19349 Original change's description: > Replace GetBlockingPool and FILE thread with post_task API > > BUG=689520,667892 > > Change-Id: I1143fbc8c5f7c12dfdd8e5764d58c9b372d3cb16 > Reviewed-on: https://chromium-review.googlesource.com/544782 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481889} TBR=xiyuan@chromium.org,grt@chromium.org Change-Id: I4fbdb87edffff078ca60bb16c10628b5b13da00a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 689520, 667892 Reviewed-on: https://chromium-review.googlesource.com/546115Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481902}
-
parastoog authored
because otherwise some names would not be parsed correctly. BUG=687727 Review-Url: https://codereview.chromium.org/2956513002 Cr-Commit-Position: refs/heads/master@{#481901}
-
Alex Clarke authored
This makes it easier to evaluate script in the newly created isolated world. Bug: Change-Id: I4ff82f79333f2e4ef69790c1cbb1da280ecc78cb Reviewed-on: https://chromium-review.googlesource.com/541336Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481900}
-
dfalcantara authored
Needs some up top to match the side. BUG=730227 Review-Url: https://codereview.chromium.org/2952333002 Cr-Commit-Position: refs/heads/master@{#481899}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f3b9d4b033a6..8c86588d1bcc $ git log f3b9d4b03..8c86588d1 --date=short --no-merges --format='%ad %ae %s' 2017-06-22 bsalomon Add correctness testing for ANGLE D3D11 ES3 2017-06-15 bungeman Clip FreeType glyph bitmap to mask. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Id6b906ba010b8b2ca6374c6b79b674f591a53585 Reviewed-on: https://chromium-review.googlesource.com/545695Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#481898}
-
Anita Woodruff authored
- Should have been using matchesChannelStatus in all cases where channel statuses are checked, for better error messaging on fail. Bug: Change-Id: If36da189c1707e3e788bbe48cfc9ccf8eccbe71e Reviewed-on: https://chromium-review.googlesource.com/545716Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#481897}
-
robertphillips authored
BUG=733428 Review-Url: https://codereview.chromium.org/2954013003 Cr-Commit-Position: refs/heads/master@{#481896}
-
Quinten Yearsley authored
Bug: 733696 Change-Id: Ifedf5c2d8a1e505240feeddfcda8c270fb6b4b7f Reviewed-on: https://chromium-review.googlesource.com/540267 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#481895}
-
Xida Chen authored
TBR=msramek@chromium.org NOTRY=true Bug: 736333 Change-Id: Ibc07aa373a6dd7c779705d10dec8efc26ebd8a15 Reviewed-on: https://chromium-review.googlesource.com/545995Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481894}
-