- 14 May, 2020 40 commits
-
-
Tobias Sargeant authored
This also adds an allow list of crash keys, derived from the WebView set. Bug: 1064594 Change-Id: I8e476444a8b2bb7a3e9301598fbed719809c6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202996 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#768980}
-
Nate Fischer authored
No change to logic. This logs the length of the crash UI's user-facing list to UMA. Fixed: 1082468 Test: None Change-Id: Iff1436454c3e3f5aa7d5950414e6ab246f4d61f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199872 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768979}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2b7d96959916..37120ab59d1f git log 2b7d96959916..37120ab59d1f --date=short --first-parent --format='%ad %ae %s' 2020-05-14 danilchap@webrtc.org in RtpSenderVideo propagate chain_diffs into dependency descriptor Created with: gclient setdep -r src/third_party/webrtc@37120ab59d1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id00984b6f7247d1517015b6f16b66b0330a59ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768978}
-
Maksim Moskvitin authored
This CL adds new histogram to record whether sync error is shown to the user because user action is required to fetch keys. Bug: 1032526 Change-Id: I623576edc369f7355eed9f7ec5827df668670eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172685 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768977}
-
Tomasz Wiszkowski authored
This addresses the setTextApearance version limitations. Unclear how this passed presubmit. Related change: https://crrev.com/c/2191195 Bug: 1082222 Change-Id: Ida9588ecdac4324c0cd54aac19b00614b9826b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202957 Commit-Queue: Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#768976}
-
danakj authored
And stop using the FocusedFrame() in them, instead use the current frame. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: If43e1a38c9ebb6acd682ba7abd5c3abdde550814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202158 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768975}
-
Yue Zhang authored
Bug: 1076295 Change-Id: I85a9e2af5517cdcb42a667de28fbbc5ae7b1ffdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200376 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768974}
-
Nate Fischer authored
No change to logic. This adds a histogram to track which menu items the user interacts with. This includes the "refresh" button in the crash UI. Fixed: 1079073 Test: None Change-Id: Icaf80a7e895ccf8815e7be7c3d559fa30f41873d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186754 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Scott Little authored
Previously, Feed articles would always open the offline version of a page if it exists, which isn't ideal for users who are online. This CL changes this behavior to open the article normally, which leaves it up to Offline Pages to decide whether or not to open the offline version of the page (e.g. when offline). TBR=twellington@chromium.org,wychen@chromium.org Bug: 1069906 Change-Id: I5723e418747867411511ede72f43c323b493b154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151175Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#768972}
-
David Van Cleve authored
Trust Tokens (https://github.com/wicg/trust-token-api) is a new feature allowing callers to specify cryptographic operations to execute alongside certain requests. It currently provides an iframe interface executing these operations alongside subframe navigations, and fetch and XHR interfaces allowing executing the operations alongside subresource requests. Two of the three Trust Tokens operations ("redemption" and "signing," in contrast to "issuance") require that the trust-token-redemption Feature Policy feature be present in the executing context. This is the second of a series of two CLs enforcing this Feature Policy requirement in the browser. It binds a frame's trust-token-redemption feature policy value to its subresource loaders, so that the network service can verify that subresource requests bearing redemption or signing operations originated from frames with the necessary policy. to the network service; adds NetworkContext unit tests confirming that the checks work as intended given a value of the policy. Test: Adds content browser tests confirming that the feature policy gets passed Bug: 1071272 Change-Id: I2bfeff20ec44459f408b67cd48965757a6b987c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165645 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#768971}
-
Avi Drissman authored
interstitial_page_impl.* was removed in d51e7703 so remove a reference to it in DEPS. Bug: 1077074 Change-Id: I885f45f483175ec7bba627df10091aa8a3d0586f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202500 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768970}
-
David Van Cleve authored
There was a dangling clause left over from an earlier iteration of TrustTokenRequestSigningHelper::Begin's method comment. Change-Id: I011d9600200a063e00ae1b6d11a187c0cf4b5c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202499 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#768969}
-
Danan S authored
Bug: 1067979 Change-Id: Id9269a510d3e60aa9ae806f375d39df5c8a6ea41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202668Reviewed-by:
-
Toni Barzic authored
Swipe from shelf generally means go to home, which would imply going back if the home screen is showing search, or non-initial apps page. BUG=1064739, 1057317 Change-Id: If9bb00a4879d4ec4c9605ac2d472912095ca1091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#768967}
-
Varun Khaneja authored
Instead of excluding countries using Finch params, add that list in client code. See the associated bug for more context. R=xinghuilu Fixed: 1064457 Change-Id: Ic4a8d7be4c66ad2b6e3de71186906e48d2ec3462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195647 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#768966}
-
Wan-Teh Chang authored
Multiply R, G, B samples by alpha if alpha_option is kAlphaPremultiplied. If the frame has an alpha plane, call media::PaintCanvasVideoRenderer only if the pixel format is I420 (8bpc) and alpha_option is kAlphaPremultiplied, because that is the only YUV pixel format that libyuv supports with an alpha plane and media::PaintCanvasVideoRenderer enables RGB premultiplication by alpha when calling libyuv::I420AlphaToARGB(). This allows us to enable the AVIF image tests guarded by FIXME_SUPPORT_10BIT_IMAGE_WITH_ALPHA and FIXME_SUPPORT_12BIT_IMAGE_WITH_ALPHA. Bug: 1072134 Change-Id: I47fffcdf2a7421578a02e92c44e40696c5884afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200436Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#768965}
-
dpapad authored
Also adding placeholder js_type_check() targets for the remaining cr_elements/ Mocha test files. This is done to facilitate the parallelization of the effort to add JS type checking for WebUI tests. It makes it easier to see which parts of the code are not type checked yet. Bug: 1000989 Change-Id: I5bd77fe43ef43b574d6631633800b25c7cfe0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199181Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#768964}
-
Lukasz Anforowicz authored
A tag (struct, class, union or enum) is free-standing if its declaration is not immediately used as part of a type of a field or variable. See also clang::TagDecl::isFreeStanding method. Example of a non-free-standing struct: struct NonFreeStandingStructCanHaveAName { int some_field; }* ptr_to_the_non_free_standing_struct; After this CL, the rewriter will avoid rewriting pointers to non-free-standing structs, because 1) such structs are relatively rare and 2) such structs are difficult to rewrite correctly (essentially the definition of the struct has to be used as a template argument of CheckedPtr). Bug: 1069567 Change-Id: Ib571344594795334be90bef5350a467d5841d96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173575 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768963}
-
Christopher Cameron authored
The Metal test shaders are compiled in a function that comes from a PostTask. There is currently no path through which a PostTask will end up running on a ThreadPriority::DISPLAY thread. Change the Metal test code to create a ThreadPriority::DISPLAY thread and do its work there. A separate change is making that correspond to a pthread priority of 50. Of note is that Metal's callback to Chrome comes from a Metal-created thread which has priority 31. Also change the default test shader to be a Compile instead of a Link (the Link tests have not been completed). Bug: 974219 Change-Id: Ieb5ab0748b3aa255ee7dd3348870ddf812caa682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200357Reviewed-by:
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/a810d82575ecbde26406fa583371f807f8721ed7..78b3337a10a7f7b3495b6cb8140a74e265290898 Bug: none Change-Id: Ib9538ea7ab2b4660f19f751da1598f01699ccd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202385 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#768961}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09d3485a9556..70e7f5841429 git log 09d3485a9556..70e7f5841429 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 primiano@google.com Merge "UI: Fix time bounds capping of updateLocalTime()" Created with: gclient setdep -r src/third_party/perfetto@70e7f5841429 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ieba765d975da900bc3cf85ced958478ac809fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202480Reviewed-by:
-
Khushal Sagar authored
DisplayDamageTracker waits for all clients to respond if BeginFrame was dispatched to them in a vsync. If we're throttling the BeginFrame for any reason, ensure we also don't expect damage from the client for that vsync. R=sadrul@chromium.org Change-Id: I3419abbfd2fd99ef113c03c5ad6cd75ee887ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200083 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#768959}
-
Yue Zhang authored
Bug: 1082886 Change-Id: Ic40a94010622efa41a04a9a2524cdd5106945220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202427 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#768958}
-
Matthias Körber authored
With this change, the value of a specific field type can only be filled a limited number of times into a specific form. Bug: 1075734 Change-Id: I7af1535d4877a4847ab84a5c11c70a1be35647a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172299 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#768957}
-
yilkal authored
In chrome new tab landing page, there are some iframes which navigate to useful urls. These urls are prevented from loading which causes a mismatch between expectation. This cl solves the problem by avoiding throttling blocking subframes in per app time limits. Bug: 1076194 Change-Id: I236fc914adca2709312978dac3c3be743b61909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200377 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#768956}
-
Nate Fischer authored
No change to production logic. This simplifies Service-related tests by adding ServiceConnectionHelper. This can be used in a try-with-resources pattern to temporarily bind to a Service, and automatically unbind when you're done. The main benefit is this moves assertions out of the onServiceConnected() callback, putting them back on the test thread (see http://go/no-asserts-on-main-thread). This also simplifies test logic by removing the need for helper methods and coordinating binding/unbinding across different helper method calls. Fixed: 1082017 Test: run_webview_instrumentation_test_apk -f MetricsBridgeServiceTest.* Test: run_webview_instrumentation_test_apk -f VariationsSeedServerTest.* Change-Id: I6b87206c17fbbf1da845f3bb5dbec495e15eabf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197201Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Aran Gilman authored
This reverts commit eb95adf5. Reason for revert: Flaky test fixed. Original change's description: > Revert "Reland "Persist Reader Mode theme and font family settings on desktop."" > > This reverts commit d1173dbd. > > Reason for revert: DomDistillerViewerSourceBrowserTest.UISetsPrefs flaky > > Original change's description: > > Reland "Persist Reader Mode theme and font family settings on desktop." > > > > This reverts commit 23979013, which > > reverted an earlier implementation of this CL in commit > > a18fd063 due to > > https://crbug.com/1065341. > > > > The main functional difference between this and the original version is > > where the JavaScript code calls the pref-storing functions. They were > > previously called inside useTheme() and useFontFamily() instead of the > > UI callbacks. Changes to the synced prefs result in a series of > > observers being notified, which ultimately led to the useTheme() and > > useFontFamily() methods being called again, potentially leading to an > > infinite loop and the behavior seen in the bug. > > > > The updateThemeSelection() method from the original CL was excluded in > > this reimplementation because it was unintentionally never called in the > > original CL. Omitting it helps reduce the scope of the CL and highlight > > the important changes. > > > > Bug: 1016615, 1065341 > > Change-Id: Ifd0e71027afd196267419ed81f7bdc0d78978a98 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152901 > > Reviewed-by: Emily Stark <estark@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Commit-Queue: Aran Gilman <gilmanmh@google.com> > > Cr-Commit-Position: refs/heads/master@{#762524} > > TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,gilmanmh@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1016615, 1065341, 1075439 > Change-Id: I222e95940848b68fa8158fd64aaca76048ed96db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167751 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762756} TBR=dmazzoni@chromium.org,estark@chromium.org,wychen@chromium.org,hendrich@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016615, 1065341, 1075439 Change-Id: Id1033620710d17d45c2df85a126b44a1f226e8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170422Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#768954}
-
Chris Harrelson authored
1. Mismatch between computed and used style of transform-style CSS. 2. Additional grouping (flattening) properties. Bug: 1008483 Change-Id: I06d8940bca56a4843b2389dece057095565d68ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202379Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#768953}
-
Koji Ishii authored
This flag was added to keep the line cache code until we refactor to share more logic with simplified layout. The new line cache landed at r768067 <crrev.com/c/2185249>. Existing tests for old line cache were ported to the new line cache in <crrev.com/c/2198867> and <crrev.com/c/2198704>. Bug: 982194 Change-Id: I2de77a91f77b063a5c3cff7bb44d5904dd2b4685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198852 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#768952}
-
Mike Wittman authored
Android needs to pass its native unwinder into StackSamplingProfiler since it is provided out of band, wihin a dynamic feature module, and not built into the profiler. Bug: 1004855 Change-Id: I9a1471d0deb09a8555ce641fdcef743aa2c56373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202319Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#768951}
-
Jae Hoon Kim authored
Platform side dlcservice daemon will be up prior to Chrome's initialization of DBus clients. Registering the signal exposed by dlcservice should happen immediately on Chrome side's initialization of dlcservice client. BUG=chromium:1071656 TEST=./unit_tests Change-Id: If2aa6dbececf155f91aa0014a904aef21ea6acba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199923 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#768950}
-
Yi Xu authored
In the next cls, I added a new story tag SimpleCanvas and I moved tests from blink/perf_tests/canvas to perf/page_set/rendering. So that canvas perf tests can be ran with rendering benchmark. Bug: 1077148 Change-Id: I55372610a2816a554946ecc77d530b1a5981d787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175497 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#768949}
-
Jimmy Gong authored
- Launching the app is behind a feature flag. Screenshot of changes: https://screenshot.googleplex.com/oaYDOJUKfNt Bug: 1053704 Change-Id: I54e764e846e0fda7671908f24f732e83de14cfea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194855 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#768948}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If5f9943bf33226dec8429d559c2d62375fe8c41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202483Reviewed-by:
-
Sean Gilhuly authored
Bug: 1021566 Change-Id: If73c54ea7a480c5c83566c5b1290b04c6ecce0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190836Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#768946}
-
Yuly Novikov authored
We want to measure performance of production build, not DCHECKs. TBR=jmadill Bug: angleproject:4637 Change-Id: I259af0944bbaf21b1a26b976865bce09397176d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202676Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#768945}
-
Ian Kilpatrick authored
If we had an empty linebox with a float inside it (and the float was shifted due to other floats) it was possible for that linebox to fail the DCHECK in: ng_block_layout_algorithm.cc:1584 DCHECK(!normal_child_had_clearance || !is_self_collapsing); Both of these conditions were true. This patch changes the normal_child_had_clearance variable to only be true if it was a *block* child (not inline), pushed by floats. Bug: 1064987 Change-Id: Ie326437a637cc57d1b17f91ac5e49847fd13c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137377 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#768944}
-
Clark DuVall authored
This delays creation of the WebLayer class loader until it is actually needed, which saves a couple MB of memory until WebLayer is used. Bug: 1061512 Change-Id: I2e0d3fb47ce79be0d7d4eac2421a5c7dc3487a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202660Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768943}
-
Elly Fong-Jones authored
This change was generated with: find . -type f | xargs sed -i -e 's/\bDialogDelegate:://g' followed by some manual cleanup. Bug: None Change-Id: I042650c53bfd7e1d7fbab4cd963dced5a7a7aaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202141 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd950196d58a..2c3d0672ade4 Created with: gclient setdep -r src-internal@2c3d0672ade4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,dfried@google.com Change-Id: Iecb0ca2b8891f02eac27f308c1e0845501b50eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768941}
-
