- 28 Jan, 2015 29 commits
-
-
primiano authored
This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/872363004 Cr-Commit-Position: refs/heads/master@{#313437}
-
sammc authored
Review URL: https://codereview.chromium.org/878773002 Cr-Commit-Position: refs/heads/master@{#313436}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/12a5230..7f3bd0d TBR=timloh@chromium.org,leviw@chromium.org Review URL: https://codereview.chromium.org/882883002 Cr-Commit-Position: refs/heads/master@{#313435}
-
meacer authored
BUG=451272 Review URL: https://codereview.chromium.org/872993003 Cr-Commit-Position: refs/heads/master@{#313434}
-
cpu authored
found by the vc /analyze bot BUG=440500 Review URL: https://codereview.chromium.org/876343004 Cr-Commit-Position: refs/heads/master@{#313433}
-
eseidel authored
My understanding is that by-default javac pulls encoding from the user's environment http://stackoverflow.com/questions/9661935/how-to-change-the-defaults-system-java-encode-form-in-windows http://stackoverflow.com/questions/11343828/file-encoding-has-no-effect-lc-all-environment-variable-does-it which is wrong for Chromium where all of our source files are known to be UTF-8, regardless of what the user has set in their environment. In my case I was using Chrome Remote Desktop to connect to my linux machine and for whatever reason LANG was missing from the resulting environment. After this patch mojo_shell builds correctly for Android again. BUG=419378 Review URL: https://codereview.chromium.org/869673002 Cr-Commit-Position: refs/heads/master@{#313432}
-
bokan authored
This patch prevents the overlay scrollbars from showing up when we're near the minimum scale. The threshold can be set per-platform; by default it's 0 so the scrollbars will be visible regardless of the scale. On Windows/Linux/CrOS we'd like to prevent the scrollbars from overlaying over the window scrollbars so we set a small non-0 threshold. BUG=446411 Review URL: https://codereview.chromium.org/877863002 Cr-Commit-Position: refs/heads/master@{#313431}
-
satorux authored
The class derives from WAPI, which is no longer used. BUG=357038 TEST=syncfs unit tests pass TBR=rogerta@chromium.org # for google_apis/{BUILD.gn,google_apis.gyp) Review URL: https://codereview.chromium.org/881723002 Cr-Commit-Position: refs/heads/master@{#313430}
-
cpu authored
VS /analyze complains about this. BUG=427616 Review URL: https://codereview.chromium.org/878333002 Cr-Commit-Position: refs/heads/master@{#313429}
-
vmpstr authored
Sometimes we get into situations where we get frequent UpdateTiles, but no AppendQuads. As a result we can start accumulating tilings (during pinch zoom for example), but we never free any of them, since the code to free tilings happens only during AppendQuads. This patch remedies this by ensuring that if AppendQuads doesn't clean up the tilings, and we've added some since last time we ran UpdateTiles, we clean them up. R=danakj BUG=452304 Review URL: https://codereview.chromium.org/881083002 Cr-Commit-Position: refs/heads/master@{#313428}
-
vadimt authored
We suspect that this method may be causing jankiness of QuicClientSession constructor BUG=422516 Review URL: https://codereview.chromium.org/879943003 Cr-Commit-Position: refs/heads/master@{#313427}
-
smckay authored
This is the first of several steps in bringing a material design friendly cloud import feature. BUG=420680 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/883973002 Cr-Commit-Position: refs/heads/master@{#313426}
-
spang authored
This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. The mouse button map is a UI thread object, so move all of the mouse processing that needs button map information outside of the device-specific object. Devices no longer get a MouseButtonMapEvdev* since they will execute on a different thread. BUG=449710 TEST=boot link_freon & click mouse Review URL: https://codereview.chromium.org/872683006 Cr-Commit-Position: refs/heads/master@{#313425}
-
gunsch authored
R=lcwu@chromium.org,dougsteed@chromium.org BUG=336640 Review URL: https://codereview.chromium.org/876373004 Cr-Commit-Position: refs/heads/master@{#313424}
-
wfh authored
OOP PDF is now enabled by default, so remove the check in ChromeBrowserMainPartsWin::PreCreateThreads BUG=442157 TEST=launch with --enable-win32k-renderer-lockdown or --force-fieldtrials=Win32kLockdown/Enabled/ check chrome://histograms that Win32k lockdown is enabled. Check OOP PDF still works both with and without --disable-direct-write switch. Review URL: https://codereview.chromium.org/872673002 Cr-Commit-Position: refs/heads/master@{#313423}
-
samueltan authored
Rename termination, suspend, and dark resume action time histograms. This is to accomodate to the change in the max value of these non-enumerated histograms introduced in Chrome OS CL:238890. BUG=chromium:443458 TEST=none. Review URL: https://codereview.chromium.org/819713007 Cr-Commit-Position: refs/heads/master@{#313422}
-
ssid authored
This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/866803003 Cr-Commit-Position: refs/heads/master@{#313421}
-
schenney authored
The rasterize_and_record benchmark was not using data from the DisplayItemList. Now it does. R=ajuma@chromium.org,vmpstr@chromium.org BUG=451448 Review URL: https://codereview.chromium.org/867803003 Cr-Commit-Position: refs/heads/master@{#313420}
-
dyen authored
Metrics have been added for the GPU using the GPU Tracer. Currently we record the average, max, and stddev ms for each category per frame for the following categories: render_compositor: Both CPU/GPU side spent on the render compositor. browser_compositor: Both CPU/GPU spent on browser compositor. total: Both CPU/GPU and total frame time spent in renderer. swap: Time between swaps, total FPS. R=vmiura@chromium.org BUG=None Review URL: https://codereview.chromium.org/854833003 Cr-Commit-Position: refs/heads/master@{#313419}
-
raymes authored
Currently if the RenderFrame is destroyed prior to the MimeHandlerViewContainer then we will look for the wrong entry in the map. This fixes that issue by removing the entry when the RenderFrame is destroyed. Review URL: https://codereview.chromium.org/874293004 Cr-Commit-Position: refs/heads/master@{#313418}
-
eroman authored
Review URL: https://codereview.chromium.org/839653002 Cr-Commit-Position: refs/heads/master@{#313417}
-
kjoswiak authored
AudioDecoderJob maintains an object audio_timestamp_helper_ for use with AV sync. Previously, this object was configured with demuxer value for sample rate, whereas it should instead be synced with the decoder's reported sample rate. This CL enables AudioDecoderJob to track decoder output rate, and ensures change in output format is propagated to this object. BUG=internal b/18873488 Review URL: https://codereview.chromium.org/805273007 Cr-Commit-Position: refs/heads/master@{#313416}
-
qyearsley authored
Changes in this CL: - In request_build.py, add a URL for linux try bot. - Add sample config for functional bisect. - Make perf-related config parameters optional. - Use builder type when starting build try jobs, and when fetching builds. A few other changes: - Update bisect_perf_regression.py file docstring. - Rename _BuilderTryjob to _StartBuilderTryJob and refactor. - Remove unused code in request_build.py. Proposed follow-up: - Move functions related to builder to be methods of one class, so that the builder-specific info/logic (e.g. builder bot and archive location) is in one place. BUG= Review URL: https://codereview.chromium.org/806943007 Cr-Commit-Position: refs/heads/master@{#313415}
-
zhenw authored
BUG=452266 Review URL: https://codereview.chromium.org/858093003 Cr-Commit-Position: refs/heads/master@{#313414}
-
nednguyen authored
BUG=418375 Review URL: https://codereview.chromium.org/883853004 Cr-Commit-Position: refs/heads/master@{#313413}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/8ece6eb..6dbfb21 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/871193004 Cr-Commit-Position: refs/heads/master@{#313412}
-
andresantoso authored
Refactor into a virtual method on TabDialogs, with overrides for Views and Cocoa. ValidationMessageBubble is moved out of chrome namespace to be more consistent with other dialogs. BUG=425229 Review URL: https://codereview.chromium.org/867323005 Cr-Commit-Position: refs/heads/master@{#313411}
-
scottmg authored
d:\src\cr3\src\net\cert\crl_set.cc(53): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\net\cert\crl_set.cc(53): warning C4456: declaration of 'i' hides previous local declaration d:\src\cr3\src\net\cert\crl_set.cc(47): note: see declaration of 'i' R=mattm@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/882833002 Cr-Commit-Position: refs/heads/master@{#313410}
-
tengs authored
The only preference right now is proximityRequired, which is now returned through the chrome.easyUnlockPrivate.getUserInfo API. BUG=403419 Review URL: https://codereview.chromium.org/880603003 Cr-Commit-Position: refs/heads/master@{#313409}
-
- 27 Jan, 2015 11 commits
-
-
isherman authored
BUG=406439 TEST=none R=tengs@chromium.org Review URL: https://codereview.chromium.org/843023002 Cr-Commit-Position: refs/heads/master@{#313408}
-
william.xie authored
Define kInvalidMediaPlayerID to replace "-1" for BrowserMediaPlayerManager BUG= Review URL: https://codereview.chromium.org/883653002 Cr-Commit-Position: refs/heads/master@{#313407}
-
naiem.shaik authored
Add the method OnURLsDeleted() to History{Backend,Service}Observer and change History{Backend,Service} to call this method instead of sending the notification. Port client code to implement the History{Backend,Service}Observer interface instead of using chrome::NOTIFICATION_HISTORY_URLS_DELETED. Remove obsolete code for broadcasting notification from history code and HistoryDetails type. BUG=373326 Review URL: https://codereview.chromium.org/773103004 Cr-Commit-Position: refs/heads/master@{#313406}
-
leviw authored
Failing on chromium.webkit/ChromiumOS BUG=452666 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/881073003 Cr-Commit-Position: refs/heads/master@{#313405}
-
asargent authored
This is a mostly mechanical change to move these files over, and make corresponding changes to strings, build files, and include paths. BUG=447014 Review URL: https://codereview.chromium.org/864093002 Cr-Commit-Position: refs/heads/master@{#313404}
-
kmarshall authored
Add unit tests for requireAsync. R=mfoltz@chromium.org,sammc@chromium.org CC=wez@chromium.org,haibinlu@chromium.org BUG= Review URL: https://codereview.chromium.org/862793003 Cr-Commit-Position: refs/heads/master@{#313403}
-
hanxi authored
The major refactor includes: - Introduce HostID (a pair of |id, type|) to replace extension_id in browser side. - Abstract UserScriptLoader to be a base class, and introduces a derived class ExtensionUserScriptLoader which is responsible for loading user scripts for extensions. - In DeclarativeUserScriptManager, a master is created per extension/webUI. - DeclarativeUserScriptManager becomes an ExtensionRegistryObserver and is responsible for clearing scripts for master objects when receive OnExensionUnloaded event. BUG=437566 Review URL: https://codereview.chromium.org/822453002 Cr-Commit-Position: refs/heads/master@{#313402}
-
erikchen authored
Revert of Reland "mac: Layer back the root view of the browser window on OSX 10.9+." (patchset #1 id:1 of https://codereview.chromium.org/878673006/) Reason for revert: Chrome Mac lost its rounded bottom corners https://code.google.com/p/chromium/issues/detail?id=452707 Original issue's description: > Reland "mac: Layer back the root view of the browser window on OSX 10.9+." > > The original CL was reverted because it caused non-deterministic failures in > browser tests that used the file tab-restore-visibility.html. The test file had > an edge case that caused thrashing and prevented the page from loading. This > has since been fixed. > > > BrowserWindowController always layer-backs the contentView of the window. If > > Chrome were linked against OSX 10.9, this would also cause the root view to be > > layer backed. Since Chrome is linked against OSX 10.6, the root view by default > > is not layer backed. > > > > BrowserWindowController is going to have a custom AppKit fullscreen animation, > > which requires that the root view is layer backed. While it is possible to > > implement a custom AppKit fullscreen animation as early as OSX 10.7, the > > effects of layer backing the root view on OSX 10.7 are murky. It seems much > > safer to just layer back the root view on OSX 10.9+, and only enable the custom > > AppKit fullscreen animation on OSX 10.9+. > > > > As far as I know, this change has no detrimental side effects. There is no > > spike in memory usage > > (https://code.google.com/p/chromium/issues/detail?id=396264#c11), presumably > > because NSThemeFrame implements -wantsUpdateLayer on OSX 10.9+. > > > > BUG=413009, 414527 > > Committed: https://crrev.com/8dec34f8f3504352e4eef95b2aaa36c561aea930 > > Cr-Commit-Position: refs/heads/master@{#311191} > > BUG=413009, 414527 > TBR=rsesek@chromium.org > > Committed: https://crrev.com/4713180802457f8c6854c10db4689ab4fab98155 > Cr-Commit-Position: refs/heads/master@{#313207} TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=413009, 414527 Review URL: https://codereview.chromium.org/881133002 Cr-Commit-Position: refs/heads/master@{#313401}
-
danakj authored
This test has been flaky (see bug), but I am not able to recreate the flake locally. However, this test does PostSetNeedsCommit() from the impl thread while also causing commits from the main thread in DidCommit which could cause an extra commit to happen in theory. This changes the test to stop using PostSetNeedsCommit() and always cause commits from DidCommit on the main thread, to help make the test more deterministic. R=ajuma, enne@chromium.org, vmpstr BUG=451988 Review URL: https://codereview.chromium.org/877213002 Cr-Commit-Position: refs/heads/master@{#313400}
-
scottmg authored
Warns on VS2015. I'm not sure why this is new, I guess something become move-able (or not-move-able). d:\src\cr3\src\net\base\sdch_manager.cc(459): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>' with [ T=net::SdchManager::DictionarySet ] d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr' with [ T=net::SdchManager::DictionarySet ] d:\src\cr3\src\net\base\sdch_manager.cc(463): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>' with [ T=net::SdchManager::DictionarySet ] d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr' with [ T=net::SdchManager::DictionarySet ] d:\src\cr3\src\net\base\sdch_manager.cc(467): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>' with [ T=net::SdchManager::DictionarySet ] d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr' with [ T=net::SdchManager::DictionarySet ] R=rsleevi@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/883753004 Cr-Commit-Position: refs/heads/master@{#313399}
-
tommi authored
WebRTC 8141:8176 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/67d96fc..9fbfe8f Libjingle 8141:8174 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/419aa31..6660ffc TBR=kjellander@chromium.org Review URL: https://codereview.chromium.org/882813003 Cr-Commit-Position: refs/heads/master@{#313398}
-