- 24 Sep, 2019 40 commits
-
-
Min Qin authored
BUG=1004212 Change-Id: I68c74718c037d05833174bb73813217d9fa2b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810004Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699542}
-
Kristi Park authored
M78 builders require include for base::ASCIIToUTF16. Bug: 1007538 Change-Id: I2715b0a25d680e1ed17aa01c15dfa8228442a04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824181 Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699541}
-
Sam Goto authored
The rollout of SmsReceiver is controlled via the origin trials mechanism [1], so, to enable it on stable, the flag isn't necessary anymore to gate the deployment. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/runtime_enabled_features.json5?type=cs&q=SmsReceiver+feature&sq=package:chromium&g=0&l=1563 Bug: 1007212 Change-Id: I581b5ba13c281c334a9961caf21bda5608064365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823698Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699540}
-
Marijn Kruisselbrink authored
Also changes the sandboxed file system version of these tests to run in both windows and workers. The native file system version of these tests are currently manual tests. In the future we can automate them. Also currently some of the writer tests don't pass in the native file system version, because of things like bug 998913. Bug: 998917 Change-Id: I4aefee6e35008afd73c2cf316d16ea189717bd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787869Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#699539}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/645a8dea641a..10cf66556532 git log 645a8dea641a..10cf66556532 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 capn@google.com Fix WSI present on MacOS Created with: gclient setdep -r src/third_party/swiftshader@10cf66556532 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137673628 Change-Id: Ib9b822956c96248260b9777e8943ab502c8d87f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823497Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699538}
-
Sammie Quon authored
Test: manual Bug: 1005354 Change-Id: I5674ed65831e640ddb17012ac41eb7e694f975f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818716 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#699537}
-
Joe DeBlasio authored
This CL adds ы and ԍ to the set of Cyrillic characters that look like Latin characters, as well as a test case to verify. Bug: 884693 Change-Id: I0329b1c2bce2b733463346d69a2bae5d65234085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823320Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#699536}
-
Bo Liu authored
Changing rendering mode is not synchronous, so provide a callback for when an animation can start safely. Add a callback aidl that that just passes an ObjectWrapper, which provides no type safety. Add Callback and ListenableResult generic types in the client lib. Update the animation demo to use new API. Note now there is flickers since mode switching is not visually seamless yet. Add a few tests. Change-Id: I903f0b5805aee03bbf15e67bc6314b1e6f0fdc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814758Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL adds fieldtrial configuration json entry for gesture navigation in preparation of beta experiment. Bug: 1006111 Change-Id: I304e60985362cc74d9215cd2d84cfb796e92c517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815965Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#699534}
-
Tiansong Cui authored
Bug: internal b/140961065 Test: build and run, check HCI logs Change-Id: I1fe5abbd21168b864b7d82e632a5c55f5927802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815724Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Auto-Submit: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#699533}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61918356b65e..0b27dd1ff740 git log 61918356b65e..0b27dd1ff740 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 fmayer@google.com Merge "Use trace processor to convert to pprof." Created with: gclient setdep -r src/third_party/perfetto@0b27dd1ff740 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib6b57704f204f48e676c9c0587078cc977ed964c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823038Reviewed-by:
-
Yue Li authored
Currently opening android app does not clear the Assistant UI state, which is not ideal. Following the OpenUrl path through ash controllers instead of directly call DeviceActions could solve the issue. Bug: b/130315570 Test: Manual Test Change-Id: Id456aa1b821d7e024ebcf9edc3b8e39ff548662f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809068 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#699531}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c171a2106b2b..693460a3a7b7 git log c171a2106b2b..693460a3a7b7 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 thestig@chromium.org Use STL functions in a couple places. 2019-09-24 thestig@chromium.org Add a pixel test for pattern rendering. 2019-09-24 thestig@chromium.org Simplify access to |CPDF_CharPosList::m_CharPos|. 2019-09-24 thestig@chromium.org Add a pixel test for a bad line rendering. Created with: gclient setdep -r src/third_party/pdfium@693460a3a7b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:984811,chromium:451366 Change-Id: I04908ef3ca04ebc237e2804b9eb53d955bf94746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823578Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b95534d333c..4c707a2c53fd git log 8b95534d333c..4c707a2c53fd --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ehmaldonado@chromium.org git-cl: Re-write some tests to use mock. Created with: gclient setdep -r src/third_party/depot_tools@4c707a2c53fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I3cbdc0d2ebd37ad34de69e58488b6457b1bfa042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823717Reviewed-by:
-
Lijin Shen authored
This CL adds the missing field trial testing config for the feature TabSwitcherLongpressMenu. Bug: 998848 Change-Id: I7d4ae7a78631cafe3dbe44d708c42f645bc00d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822660Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#699528}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b87974eebeaa..4fc8f1f8fe0e git log b87974eebeaa..4fc8f1f8fe0e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 yueherngl@google.com auron: remove jecht branch builders 2019-09-24 vapier@chromium.org goma: force running with python2 2019-09-24 lamontjones@chromium.org config: add cr50_firmware signing to cr50 builders. Created with: gclient setdep -r src/third_party/chromite@4fc8f1f8fe0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibba45c749ed4522bf8270e44dca5ef30c31e24fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823577Reviewed-by:
-
Matt Jones authored
This patch moves the snackbar manager out of the BottomSheetController and removes the controller's dependency on Activity. The controller did little more than hold a reference to the snackbar manager, this is more along the lines of "feature interaction". As a result the code has been moved to "glue code" in the activity (soon to be RootUiCoordinator). Bug: 986310, 1002277 Change-Id: Ibdbd2ad5a65e9721aecce20a54d7eb632814455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822027Reviewed-by:
-
Dmitry Gozman authored
This refactoring stops plumbing things through content, and just handles it locally in FrameLoader. No behavior changes. Bug: none Change-Id: I6c38f060b4976c6e62f063238bb0145a8163fe18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818600 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#699525}
-
Sergey Ulanov authored
libvk_swiftsahder.so was pulled on web_engine package after swiftshader was enabled in Angle. We don't need it so it can be excluded. Bug: fuchsia:37278 Change-Id: I459385e5c61a2a5eb510aeeecf0f5c7c7d038a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823040 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699524}
-
Eric Stevenson authored
Current can result in unused GN variables if set. Bug: 1005836 Change-Id: I56eef0b9e2c94ee44071c373cc71c0fa4409ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822323 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699523}
-
Robert Ogden authored
"Lite page" is an overloaded term so this moves everything related to the lite page redirect preview into a better named file/class (generally, *lite_page* => *lite_page_redirect*). Note: The LitePageInfobar was not renamed because it is used for all HTTPS-based previews, although it was originally for the redirect previews. Note 2: TRhere are no behavioral changes except for removing an unused mojo datapipe in previews_lite_page_redirect_serving_url_loader.cc, since that was generating warnings. Bug: 1005295 Change-Id: I75ac37ec7555e098a211be35336ab7f0f042b091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819522Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#699522}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the blink.mojom.DisplayCutoutClient interface, and adapt tests. Bug: 955171, 978694 Change-Id: I48cc1a9129b3796a60ff510d18d36a0ad37bd28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817883Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#699521}
-
Sadrul Habib Chowdhury authored
INPUT_EVENT_LATENCY_FORWARD_SCROLL_UPDATE_TO_MAIN_COMPONENT and LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT components were only being set on ui::LatencyInfo objects, but were never being used for anything (especially after the 'main_thread_scroll_latency' metric was removed from telemetry). So remove these components. BUG=849719, 1000697 Change-Id: Ia264d06598970fb32a0f21cbb7b2d15f25ffc28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800727 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699520}
-
Sammie Quon authored
It wasn't working as expected, if the screenshot was kept alive, you can still see the top window. A patch [1] was added to make this not the case, but the compositor still draws the frame where the top window was hidden (seen as a flash) even with compositing locks applied. This is OK for enter tablet animation as the entire animation will cover the top window anyways. I will look into a way that works for exit tablet animation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1797482 Test: manual Bug: 948706 Change-Id: Ic3b7843c70a5f71ac5c5ad0c2e7290af81d01551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804523 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#699519}
-
Jesse McKenna authored
This relands crrev.com/c/1810242, reverted by crrev.com/c/1815802. Unit test ShellUtilRegistryTest.AddFileAssociations was failing on Windows 7 bots when checking for registry key HKCU\Software\Classes\<progID>\Application, because this key is only created by ShellUtil::AddFileAssociations() on Windows 8 and later. I changed this CHECK() to only take place when on Windows 8 or later. Original change description: When an application is registered as a handler for a file type, the name that is displayed in the "Open With..." menu for that file type is controlled by registry value HKCR/<application ProgID>/Application::ApplicationName. This change extends ShellUtil::AddFileAssociations(), which will soon be used to register Progressive Web Apps (PWAs) as file handlers on Windows, to set ApplicationName. This enables PWAs registered as file handlers to appear in the "Open With..." menu with a readable display name such as "My PWA". Bug: 960245 Change-Id: I0790faa2b3eedec82ace2c324ff582515af048aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818429 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699518}
-
Joel Hockey authored
Change install-linux-package control to use the same FileTasks FileHandler filtering as import-crostini-image. Replaces some of the code from CL:1712667 CL:1730907 CL:1752825 Bug: 1006112 Change-Id: Iba1a6e7bf99f19bad1cd1adb1c858c0c5d1751cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820400 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699517}
-
liberato@chromium.org authored
Send in MediaLog to MCVD, and use it to log errors during init and decoding. Change-Id: Ia4e0b4689475e5b7fc0cb3bdc1a0ff3a25f6dcf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816133 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699516}
-
Michael Thiessen authored
No functional changes intended - please revert if something breaks. There were many differing callsites of PackageManager#resolveActivity and queryIntentActivities, some of which handled possible Exceptions, some of which handled StrictMode violations, and none of which handled all of these. A followup change will attempt to introduce a presubmit check so that new direct usages of these functions aren't added. Various packages that can't depend on base were not changed. Change-Id: Ibbf7eb4e4aa0b6a80974df898f5418b94e2d1426 Bug: 1006819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816978 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699515}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c2146f2ca2a..b5037ca88923 git log 4c2146f2ca2a..b5037ca88923 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nihohit@gmail.com Add comment explaining that using mirrors might break git cl. 2019-09-24 fmalita@chromium.org [skottie] Tweak skottie_tool --threads meaning 2019-09-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-24 fmalita@chromium.org [skottie] Multi-threaded skottie_tool 2019-09-24 brianosman@google.com GrGLProgramBuilder cleanup 2019-09-24 robertphillips@google.com Remove compressed format support from the GrGpu::createBackendTexture code path 2019-09-24 bsalomon@google.com Remove workarounds for osmesa 2019-09-24 ethannicholas@google.com Fixed integer divide / remainder in sksl interpreter 2019-09-24 robertphillips@google.com Fix accessing off end of pixmap for R16G16_float in SSE2/SSE4.1 mode 2019-09-24 scroggo@google.com Move is_orientation_marker into its own file 2019-09-24 robertphillips@google.com Clean up cruft left over from addition GrGpu::createBackendTexture chokepoint 2019-09-24 jvanverth@google.com Remove MoltenVK configs from the bots. 2019-09-24 nigeltao@google.com Enable Codec_GifInterlacedTruncated test for Wuffs 2019-09-24 reed@google.com support gpu for skottie2movie Created with: gclient setdep -r src/third_party/skia@b5037ca88923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:1005615 Change-Id: If0b7c0e8d3ca34dac3cc2f655c01e28f7163e986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822663Reviewed-by:
-
Anushruth authored
Without this flag, VM image for betty-pi-arc is not downloaded when gclient runhooks is run. This is reland of crrev.com/c/1815882 as it was reverted in crrev.com/c/1819056. Added parentheses for 'OR' and this should hopefully fix the issue R=bpastene@chromium.org Bug: 1000513 Change-Id: I92792f0ca2b470edb34e8eb5d399afa2dfba5df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820020Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#699513}
-
Akihiro Ota authored
This change adds metadata for the battery and rich text hotkeys so that they appear in the ChromeVox menu, where the user can find details on how to activate them. It also renames the commands so the internal and external naming is consistent. Change-Id: I3e5f53a40660eb7bd83b55c0e180457b3be69f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817154Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#699512}
-
Rouslan Solomakhin authored
Bug: 952283 Change-Id: I462775028293c384f4e87a1a3afe88c844e792b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822720 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699511}
-
Sky Malice authored
Bug: 1003608, 986836 Change-Id: I7412fed30fbe5d294534d648a82816689e45a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802518Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The tests were refactored manually to use JniMocker. This allows us to get rid of ContextualSearchContextForTest. Bug: 929661 Change-Id: I5dcfc91df003d26cefad9aaa2bb2bf0b2afcabf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817117 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699509}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb4818bc4652..30eeb0c5bf9c Created with: gclient setdep -r src-internal@30eeb0c5bf9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I5f1add89dc782195c50a6a871567287aa6564052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699508}
-
Shimi Zhang authored
Previously setWebMessageListener(jsObjectName, allowedOriginRules, listener) configured |jsObjectName| and |allowedOriginRules| have a different life cycle than the |listener|. This caused a lot confusion. This CL introduces addWebMessageListener() to replace setWebMessageListener() to allow multiple JavaScript objects to be injected for each call of it. It also resolves an ugly unsetWebMessageListener() API, now removeWebMessageListener() has a clearer syntax. Design: - We will give each frame a JsToJavaMessaging mojo interface per each listener, which is still associated to legacy IPC as the PendingAssociatedRemote is passed through another associated remote. - JS object will use JsToJavaMessaging AssociatedRemote to communicate back to the browser process. - Introducing a WebMessageListenerHolder to hold a listener. Bug: 918065 Change-Id: I5a8e4cc2ff05f2475de92fdbaa7c2579caf08b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770504Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#699507}
-
Elly Fong-Jones authored
We are still using these to tell whether usage of specific a11y features is rising or falling as new OS releases roll out, so let's hang onto them for now :) Bug: None Change-Id: I59aea7044e0443eae7ab4a3620ef89c40c71beac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821977 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#699506}
-
Matthew Mourgos authored
Allow app_list_view and other code within app_list to access the current shelf size where needed. This has become necessary because, when the hotseat flag is enabled, shelf size can change during runtime. Bug: 973483 Change-Id: I90b52cae00ccb90d9d151283804444226fd4a097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815601 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699505}
-
Gabriel Charette authored
One such problematic pref at the moment is kHintsFetcherHostsSuccessfullyFetched found while diagnosing unexpected failures in https://chromium-review.googlesource.com/c/chromium/src/+/1818219 which makes microseconds-since-epoch a realistic (very large) number in unit tests. R=miu@chromium.org Bug: 1004987, 1007427, 634507 Change-Id: I5ebf6a0ef46e2aea704ab5c54372ae77cbe64afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822840 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699504}
-
Miguel Casas authored
This CL makes chromeos_with_codecs* compile without VA-API hardware acceleration (used for video and image dec/encoding), which is a legitimate target (at least to compile) that in the past has been inadvertently broken. Note that the cros_chrome_sdk* bots (e.g. chromeos-amd64-generic-rel, based on simplechrome checkouts) still compile with the official respective chromeos args.gn, that includes use_vaapi (or use_v4l2_codec). Bug: 1006266 Change-Id: I322fe10cac403fbee0e2ef17732fe38e88c2b564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815846Reviewed-by:
-
