GitLab

The CL:
https://codereview.chromium.org/2718583002
adds code that sends an event on the readValue callback. So if subscribes
to notifications and then calls readValue, will get notified twice. This
CL fixes this issue.

BUG=697702

Review-Url: https://codereview.chromium.org/2728623004
Cr-Commit-Position: refs/heads/master@{#455652}

BUG=699791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2731333003
Cr-Commit-Position: refs/heads/master@{#455651}

Remove FrameHost::browserControls(), and redirect all calls to
Page::browserControls().

BUG=691794

Review-Url: https://codereview.chromium.org/2737703002
Cr-Commit-Position: refs/heads/master@{#455650}

BUG=697580
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2739043002
Cr-Commit-Position: refs/heads/master@{#455649}

Revert of Buffer 2 seconds of data in the ffmpeg demuxer. (patchset #3 id:40001 of https://codereview.chromium.org/2737653002/ )

Reason for revert:
Broke layout test compositing/video/video-poster.html on Mac, Linux ASAN:
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.9/43534
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.10/31122
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/1414

Original issue's description:
> Buffer 2 seconds of data in the ffmpeg demuxer.
>
> This has been shown to reduce jank in badly muxed mp4 files.
>
> BUG=540898
>
> Review-Url: https://codereview.chromium.org/2737653002
> Cr-Commit-Position: refs/heads/master@{#455551}
> Committed: https://chromium.googlesource.com/chromium/src/+/e23907eaba82f5595b74fb0094968481d6e00514

TBR=dalecurtis@chromium.org,dalecurtis@google.com,hubbe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=540898

Review-Url: https://codereview.chromium.org/2740863002
Cr-Commit-Position: refs/heads/master@{#455648}

In this patch, we remove ReadOnly flag when mouseleave with touch in
EventHandler::handleMouseMoveOrLeaveEvent since we want to
updateHoverActiveState without hit test for this case.

BUG=678363

Review-Url: https://codereview.chromium.org/2734153003
Cr-Commit-Position: refs/heads/master@{#455647}

Apparently after we switched to CompositorFrameSinkSupport in
DelegatedFrameHost, we started using more memory in some performance tests.
We hypothesized that this could be because we send an ack back to the
client before returning the resources and therefore the client cannot reuse
the old resources and has to allocate new ones. I ran the performance tests
that regressed on this CL and I can see clear improvements in memory usage.

Examples of improved metrics (from win_x64_perf_bisect Build #1626):
vm_working_set_delta_size.smpte_3840x2160_60fps_vp9.webm_total from 297.5 MiB to 258.6 MiB
vm_working_set_delta_size.crowd2160.webm_total from 301.1 MiB to 261.3 MiB

BUG=696850
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2734783006
Cr-Commit-Position: refs/heads/master@{#455646}

EditingAppleTabSpan class is non-standard CSS class name
that is produced while creating a span element with tab
in editing, but the usage is low(<=0.0001%).

This CL removes the code that handles EditingAppleTabSpan class
from Blink.

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/OlgmGUvnMU4/9HMNXMjGCQAJ

BUG=383677

Review-Url: https://codereview.chromium.org/2718543003
Cr-Commit-Position: refs/heads/master@{#455645}

For instance, INPUT type="search" elements allow styling of the cancel button,
via a ::-webkit-search-cancel-button pseudo element selector. We don't want authors
to be able to escape the containing INPUT element by styling the cancel button as
position:absolute, etc.

Force INPUT and other text control elements to be in the containing block chain of
all its descendants. This should be a good idea in general (and at least harmless),
and there's also C++ code [1] that essentially assumes that it is so.

Since this change makes canContainFixedPositionObjects() in LayoutObject and
ComputedStyle even more different than they used to be, we need to change some
code from using the one in ComputedStyle to the one in LayoutObject.

Two existing tests in fast/forms/ had to be updated, since they were adding together
offsetLeft of an INPUT element and offsetLeft of something inside the INPUT element
in a way that used to work by accident. Use getBoundingClientRect() instead, since
the test ultimately wants absolute coordinates anyway.

[1] See ThemePainterDefault::paintSearchFieldCancelButton()

BUG=685527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733593002
Cr-Commit-Position: refs/heads/master@{#455644}

fetchStart() was making such an assumption and dereferencing null causing crashes in prod.

BUG=560564

Review-Url: https://codereview.chromium.org/2741563002
Cr-Commit-Position: refs/heads/master@{#455643}

This fixes a chicken-and-egg problem introduced by http://crrev.com/455325.
WebPagePopupImpl sets m_isAcceleratedCompositingActive during the first
compositing update, which scheduleAnimation wouldn't schedule without the bit.

WebPagePopupImpl now eagerly initializes m_layerTreeView, which matches what
WebViewImpl does for non-popup content.

BUG=699412,698464

Review-Url: https://codereview.chromium.org/2737193002
Cr-Commit-Position: refs/heads/master@{#455642}

This CL moves the spacing around a controlled-by indicator to the
indictor itself, so that the width of the dropdown menu no longer
changes.

BUG=699486
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2732213007
Cr-Commit-Position: refs/heads/master@{#455641}

BUG=686608

Review-Url: https://codereview.chromium.org/2624343002
Cr-Commit-Position: refs/heads/master@{#455640}

Revert of Add failure screenshots and render test images to results detail. (patchset #8 id:130001 of https://codereview.chromium.org/2701473003/ )

Reason for revert:
Reverting :( this since using find_depot_tools doesnt work on some bots. Will have to find alternative and reland.

Original issue's description:
> Add failure screenshots and render test images to results detail.
>
> Review-Url: https://codereview.chromium.org/2701473003
> Cr-Commit-Position: refs/heads/master@{#453039}
> Committed: https://chromium.googlesource.com/chromium/src/+/191a06d04a38e8b322c326d42433cbb1f5575025

TBR=yolandyan@chromium.org,hzl@chromium.org,hzl@google.com,jbudorick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2737223002
Cr-Commit-Position: refs/heads/master@{#455639}

This is split from fady's cl:
https://codereview.chromium.org/2688593002/

BUG=686861, 664547

Review-Url: https://codereview.chromium.org/2737653005
Cr-Commit-Position: refs/heads/master@{#455638}

Remove the VisualViewport::frameHost() method, and replace it with
Remove Remove VisualViewport::page() and update callsites.

This is pre-work to remove FrameHost from VisualViewport, which is part
of the work to remove FrameHost.

BUG=691794

Review-Url: https://codereview.chromium.org/2728873002
Cr-Commit-Position: refs/heads/master@{#455637}

When updating a certified WebAPK whose Clank-fetched content no longer
matches its Harpoon-fetched content on the server, server will return
a certified WebAPK with resources from the Harpoon-fetched content, and
set the filed "infrequent_updates" field in the Response proto as true
to direct Clank to check for updates less frequently for this WebAPK.

On the Clank, once we see such a flag during updates, we will cache it
in the WebAppDataStorage to avoid frequently request updates, since
Clank will always think the WebAPK's resources don't match its Web
Manifest.

BUG=680128

Review-Url: https://codereview.chromium.org/2641973003
Cr-Commit-Position: refs/heads/master@{#455636}

This patch adds a Java wrapper for RenderFrameHost. It also adds a
getMainFrame method to WebContents.

This will be useful for Payment Request which needs to know
the exact (sub)frame issued the payment request.

BUG=620173
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2681933002
Cr-Commit-Position: refs/heads/master@{#455635}

To OSX older than 10.12.4.

BUG=640506
TEST=
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2733953007
Cr-Commit-Position: refs/heads/master@{#455634}

Changes characteristic.readValue/writeValue/getDescriptor(s) and
descriptor.readValue/writeValue to return a more actionable error.

BUG=684445

Review-Url: https://codereview.chromium.org/2729433002
Cr-Commit-Position: refs/heads/master@{#455633}

This fixes an issue where a popup opened by clicking a notification doesn't
activate Chrome (and appears behind the active app) on Mac.

BUG=661250

Review-Url: https://codereview.chromium.org/2729613006
Cr-Commit-Position: refs/heads/master@{#455632}

This will fix the regression where opening a ZIP file in the Guest mode
gives no feedback.

BUG=694419
TEST=Manually tested by opening a zip file in Guest mode.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2740713002
Cr-Commit-Position: refs/heads/master@{#455631}

The VS 2017 vcvarsall.bat file is quite fragile. It fails if
vcvarsall.bat from a previous release has been run in the same command
prompt, and this failure is not detected by setup_toolchain.py. The
problem occurs because the new vcvarsall.bat won't overwrite an
existing VSINSTALLDIR. The fix is to clear it from the environment if it
is set.

The main test was to try to build with VS 2017 after running the VS 2015
vcvarsall.bat. Trimmed output is shown here:

> where cl
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64_x86\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\cl.exe

> set gyp
GYP_MSVS_VERSION=2017

> gn clean out\release & gn gen out\release & ninja -v -C out\release ..\..\build\precompile.cc^^
Done. Made 5496 targets from 1254 files in 4078ms
ninja: Entering directory `out\release'
...
[15/15 0.439s] ... \Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64/cl.exe ...

I also verified that I can switch between 2015 and 2017 builds with just
a "gn gen" to reset the toolchain.

> set GYP_MSVS_VERSION=2015
> gn gen out\release

> ninja -v -C out\release ..\..\build\precompile.cc^^
ninja: Entering directory `out\release'
[1/1 0.140s ] ... "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64/cl.exe" ...

> set GYP_MSVS_VERSION=2017
> gn gen out\release
Done. Made 5496 targets from 1254 files in 3768ms

> ninja -v -C out\release ..\..\build\precompile.cc^^
ninja: Entering directory `out\release'
[1/1 0.131s ] ... \Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64/cl.exe ...

R=scottmg@chromium.org
BUG=683729

Review-Url: https://codereview.chromium.org/2738993003
Cr-Commit-Position: refs/heads/master@{#455630}

BUG=676012

Review-Url: https://codereview.chromium.org/2742453003
Cr-Commit-Position: refs/heads/master@{#455629}

Revert of wire PasswordProtectionService into PasswordReuseDetectionManager (patchset #4 id:110001 of https://codereview.chromium.org/2734863004/ )

Reason for revert:
This CL causes crashes crbug.com/699551

Original issue's description:
> wire PasswordProtectionService into PasswordReuseDetectionManager
>
> Wire PasswordProtectionService into PasswordReuseDetectionManager to
> help log non-whitelisted password-reuses to UMA
>
> BUG=691103
>
> Review-Url: https://codereview.chromium.org/2734863004
> Cr-Commit-Position: refs/heads/master@{#455250}
> Committed: https://chromium.googlesource.com/chromium/src/+/3b7571b5b5900a3d4582d62abe23b1a193bbee83

TBR=dvadym@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=691103

Review-Url: https://codereview.chromium.org/2738073002
Cr-Commit-Position: refs/heads/master@{#455628}

Currently the logic to check whether devices are available for a WebRTC request
is nested between various permissions checks. This CL hoists that logic out
such that it occurs before any other permission checks occur.

BUG=596786

Review-Url: https://codereview.chromium.org/2728573002
Cr-Commit-Position: refs/heads/master@{#455627}

BUG=699767,697971

Review-Url: https://codereview.chromium.org/2738053002
Cr-Commit-Position: refs/heads/master@{#455626}

Chromedriver/Selenium expects to be able to set the log file using the CHROME_LOG_FILE environment variable.

BUG=698095

Review-Url: https://codereview.chromium.org/2736883002
Cr-Commit-Position: refs/heads/master@{#455625}

We are adding COMPONENT/TEAM information into OWNERS file
(error_page, captive_portal, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2737253002
Cr-Commit-Position: refs/heads/master@{#455624}

https://codereview.chromium.org/2466413009 covered some cases, but the
case of creating a new tab via ctrl-+ is covered by this CL.

BUG=470669

Review-Url: https://codereview.chromium.org/2737553004
Cr-Commit-Position: refs/heads/master@{#455623}

When there is enough space we can move popover so that
arrow points to the middle of anchor box (as opposite to the side).

BUG=699489

Review-Url: https://codereview.chromium.org/2742503002
Cr-Commit-Position: refs/heads/master@{#455622}

This adds a function to PermissionManager which allows checking the
permission for a particular RenderFrameHost. Some permission checks
depend on the exact context of the requesting frame. For example:
-For permission delegation we need to know the FeaturePolicy associated
with the frame, which is attached to the RenderFrameHost
-Some ChromeOS media-related permission checks require the
RenderFrameHost. These currently live in media_permissions.cc but it
would be good to move them into the PermissionContext subclass.
-Android permission checks currently require the WebContents in order to
determine their state.

A frame isn't always available when we want to determine the status of a
permission, so when it's not available the old version of the function
which takes in origins can be used. GetPermissionStatusForFrame should
always perform more checks than GetPermissionStatus and tend to be used
wherever possible.

The RenderFrameHost is passed down to the
PermissionContextBase::GetPermissionStatus. At this internal level of
the code, its value may be nullptr if the call does not originate from a
frame context. Subclasses should always check the RenderFrameHost before
using it.

TBR=peter@chromium.org,tommycli@chromium.org,xhwang@chromium.org,michaeln@chromium.org
BUG=596786

Review-Url: https://codereview.chromium.org/2723983004
Cr-Commit-Position: refs/heads/master@{#455621}

The name doesn't need "Base" in it, and it should be "WebShell"
to differentiate from "WebViewShell".

BUG=

Review-Url: https://codereview.chromium.org/2740783002
Cr-Commit-Position: refs/heads/master@{#455620}

According to latest WebVR Spec, there are several changes. Remove VRFrameData#timestamp is one of them.

BUG=697167

Review-Url: https://codereview.chromium.org/2736593002
Cr-Commit-Position: refs/heads/master@{#455619}

BUG=698657

Review-Url: https://codereview.chromium.org/2736243003
Cr-Commit-Position: refs/heads/master@{#455618}

Revert of Move chrome/common/safe_browsing/csd.proto to components/safe_browsing (patchset #2 id:20001 of https://codereview.chromium.org/2733343002/ )

Reason for revert:
revert this CL since it broke linux bots.

Original issue's description:
> Move chrome/common/safe_browsing/csd.proto to components/safe_browsing
>
> Move csd.proto to components/safe_browsing.
> This CL serves 2 purpose:
> (1) moving csd.proto to component enables further componentization of
> safe browsing reporting functionality, that will be used by WebView
> (2) It also allows PasswordProtectionService, and PasswordManager code
> to use these proto directly.
>
> BUG=698899,688629
>
> Review-Url: https://codereview.chromium.org/2733343002
> Cr-Commit-Position: refs/heads/master@{#455609}
> Committed: https://chromium.googlesource.com/chromium/src/+/f3aafdc5ac1a6caf52c6c41615118e381ad9e549

TBR=nparker@chromium.org,vakh@chromium.org,sky@chromium.org,pkasting@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698899,688629

Review-Url: https://codereview.chromium.org/2743483002
Cr-Commit-Position: refs/heads/master@{#455617}

This updates third_party/woff2 from a15a8ab (7 May 2016) to
cbea7b9 (7 Mar 2017).

This version uses the latest Brotli API, so local modification of
woff2_dec.cc is no longer needed.

Review-Url: https://codereview.chromium.org/2736873002
Cr-Commit-Position: refs/heads/master@{#455616}

BUG=454984, 684098

Review-Url: https://codereview.chromium.org/2705673003
Cr-Commit-Position: refs/heads/master@{#455615}

https://skia.googlesource.com/skia.git/+log/f141fff87abd..28b1252bab29

$ git log f141fff87..28b1252ba --date=short --no-merges --format='%ad %ae %s'
2017-03-08 brianosman Added MSAA selection to viewer GUI
2017-03-08 robertphillips Switch GrYUVProvider over to GrTextureProxies

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Ice4263929a2c55f408b6c34b432184886d17e4ac
Reviewed-on: https://chromium-review.googlesource.com/451823Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455614}

BUG=695625

Review-Url: https://codereview.chromium.org/2737863002
Cr-Commit-Position: refs/heads/master@{#455613}